Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Laurent Pinchart
Hi Andy, Thank you for the patches. I've slightly modified 1/5 and 3/5 (the first one returned -1 from media_enum_entities(), which made media-ctl stop with a failure message) and pushed the result to the repository. I've also added another patch to fix autoconf malloc/realloc tests when

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Andy Shevchenko
On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: I've slightly modified 1/5 and 3/5 (the first one returned -1 from media_enum_entities(), which made media-ctl stop with a failure message) and pushed the result to the repository. Okay. I looked at them. One minor comment:

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Andy Shevchenko
On Tue, 2011-09-06 at 13:46 +0300, Andy Shevchenko wrote: On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: I've slightly modified 1/5 and 3/5 (the first one returned -1 from media_enum_entities(), which made media-ctl stop with a failure message) and pushed the result to

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Laurent Pinchart
Hi Andy, On Tuesday 06 September 2011 12:50:25 Andy Shevchenko wrote: On Tue, 2011-09-06 at 13:46 +0300, Andy Shevchenko wrote: On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: I've slightly modified 1/5 and 3/5 (the first one returned -1 from media_enum_entities(), which made

[media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-05 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/media.c b/src/media.c index e3cab86..050289e 100644 --- a/src/media.c +++ b/src/media.c @@ -255,7 +255,7 @@ static int