Re: [patch] [media] gspca: passing wrong length parameter to reg_w()

2012-05-02 Thread Jean-Francois Moine 
On Wed, 2 May 2012 09:15:25 +0300
Dan Carpenter dan.carpen...@oracle.com wrote:

 This looks like a cut an paste error.  This is a two byte array but we
 use 8 as a length parameter.
 
 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
 ---
 This is a static checker fix.  I don't own the hardware.
 
 diff --git a/drivers/media/video/gspca/conex.c 
 b/drivers/media/video/gspca/conex.c
 index ea17b5d..f39fee0 100644
 --- a/drivers/media/video/gspca/conex.c
 +++ b/drivers/media/video/gspca/conex.c
 @@ -306,7 +306,7 @@ static void cx_sensor(struct gspca_dev*gspca_dev)
  
   reg_w(gspca_dev, 0x0020, reg20, 8);
   reg_w(gspca_dev, 0x0028, reg28, 8);
 - reg_w(gspca_dev, 0x0010, reg10, 8);
 + reg_w(gspca_dev, 0x0010, reg10, 2);
   reg_w_val(gspca_dev, 0x0092, 0x03);
  
   switch (gspca_dev-cam.cam_mode[(int) gspca_dev-curr_mode].priv) {
 @@ -326,7 +326,7 @@ static void cx_sensor(struct gspca_dev*gspca_dev)
   }
   reg_w(gspca_dev, 0x007b, reg7b, 6);
   reg_w_val(gspca_dev, 0x00f8, 0x00);
 - reg_w(gspca_dev, 0x0010, reg10, 8);
 + reg_w(gspca_dev, 0x0010, reg10, 2);
   reg_w_val(gspca_dev, 0x0098, 0x41);
   for (i = 0; i  11; i++) {
   if (i == 3 || i == 5 || i == 8)

Hi Dan,

Thanks for the patch. The bug is very very old (6 years, at least -
neither have I such a webcam).

Maybe the fix could have been

reg_w(gspca_dev, 0x0010, reg10, sizeof reg10);

but it is OK for me.

Acked-by: Jean-Francois Moine http://moinejf.free.fr

-- 
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] [media] gspca: passing wrong length parameter to reg_w()

2012-05-02 Thread Dan Carpenter 
On Wed, May 02, 2012 at 08:47:58AM +0200, Jean-Francois Moine wrote:
 Thanks for the patch. The bug is very very old (6 years, at least -
 neither have I such a webcam).
 

My guess is that it's harmless to write a few extra garbage bits,
but it's still worth fixing as a cleanup.

 Maybe the fix could have been
 
   reg_w(gspca_dev, 0x0010, reg10, sizeof reg10);
 
 but it is OK for me.
 
 Acked-by: Jean-Francois Moine http://moinejf.free.fr

Thanks.

regards,
dan carpenter

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html