Re: [patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll()

2010-11-17 Thread Jarod Wilson
On Wed, Nov 17, 2010 at 08:12:23AM +0300, Dan Carpenter wrote:
 We shouldn't unlock here.  I think this was a cut and paste error.

Yeah, looks like it.

Acked-by: Jarod Wilson ja...@redhat.com

-- 
Jarod Wilson
ja...@redhat.com

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll()

2010-11-16 Thread Dan Carpenter
We shouldn't unlock here.  I think this was a cut and paste error.

Signed-off-by: Dan Carpenter erro...@gmail.com

diff --git a/drivers/media/IR/lirc_dev.c b/drivers/media/IR/lirc_dev.c
index 8418b14..8ab9d87 100644
--- a/drivers/media/IR/lirc_dev.c
+++ b/drivers/media/IR/lirc_dev.c
@@ -522,10 +522,8 @@ unsigned int lirc_dev_fop_poll(struct file *file, 
poll_table *wait)
 
dev_dbg(ir-d.dev, LOGHEAD poll called\n, ir-d.name, ir-d.minor);
 
-   if (!ir-attached) {
-   mutex_unlock(ir-irctl_lock);
+   if (!ir-attached)
return POLLERR;
-   }
 
poll_wait(file, ir-buf-wait_poll, wait);
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html