From: Dan Carpenter <erro...@gmail.com>
Return -EINVAL if we don't find the control id.
Signed-off-by: Dan Carpenter <erro...@gmail.com>
Cc: Mauro Carvalho Chehab <mche...@infradead.org>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Trent Piepho <xy...@speakeasy.org>
Cc: Douglas Schilling Landgraf <dougsl...@redhat.com>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
---
drivers/media/video/cx231xx/cx231xx-video.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff -puN
drivers/media/video/cx231xx/cx231xx-video.c~cx231xx-improve-error-handling
drivers/media/video/cx231xx/cx231xx-video.c
--- a/drivers/media/video/cx231xx/cx231xx-video.c~cx231xx-improve-error-handling
+++ a/drivers/media/video/cx231xx/cx231xx-video.c
@@ -1902,9 +1902,12 @@ static int radio_queryctrl(struct file *
if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)
return -EINVAL;
if (c->id == V4L2_CID_AUDIO_MUTE) {
- for (i = 0; i < CX231XX_CTLS; i++)
+ for (i = 0; i < CX231XX_CTLS; i++) {
if (cx231xx_ctls[i].v.id == c->id)
break;
+ }
+ if (i == CX231XX_CTLS)
+ return -EINVAL;
*c = cx231xx_ctls[i].v;
} else
*c = no_ctl;
_
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
