Re: [patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed bitfields

2010-10-22 Thread Dan Carpenter
Pawel Osciak; Marek Szyprowski; > > linux-media@vger.kernel.org; kernel-janit...@vger.kernel.org > > Subject: [patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed > > bitfields > > > > These are signed so instead of being 1 and 0 as intended they are -1 > >

RE: [patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed bitfields

2010-10-22 Thread Sylwester Nawrocki
rnel.org > Subject: [patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed > bitfields > > These are signed so instead of being 1 and 0 as intended they are -1 > and > 0. It doesn't cause a bug in the current code but Sparse warns about > it: > > drivers/media/video/s

[patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed bitfields

2010-10-21 Thread Dan Carpenter
These are signed so instead of being 1 and 0 as intended they are -1 and 0. It doesn't cause a bug in the current code but Sparse warns about it: drivers/media/video/s5p-fimc/fimc-core.h:226:28: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter diff --git a/drivers/me