MEDIA: lirc, improper locking

2010-07-07 Thread Jiri Slaby
Hi, stanse found a locking error in lirc_dev_fop_read: if (mutex_lock_interruptible(ir-irctl_lock)) return -ERESTARTSYS; ... while (written length ret == 0) { if (mutex_lock_interruptible(ir-irctl_lock)) {#1 ret = -ERESTARTSYS; break; } ... }

Re: MEDIA: lirc, improper locking

2010-07-07 Thread Jarod Wilson
On Wed, Jul 07, 2010 at 02:52:58PM +0200, Jiri Slaby wrote: Hi, stanse found a locking error in lirc_dev_fop_read: if (mutex_lock_interruptible(ir-irctl_lock)) return -ERESTARTSYS; ... while (written length ret == 0) { if (mutex_lock_interruptible(ir-irctl_lock)) {#1 ret =