Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-21 Thread Fabio Porcedda
On Wed, Mar 20, 2013 at 12:46 PM, Arnd Bergmann wrote: > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> >> On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: >> > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> >> I think we can check inside the deferred_probe_work_func() >> >> if

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Arnd Bergmann
On Wednesday 20 March 2013, Fabio Porcedda wrote: > > On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: > > On Wednesday 20 March 2013, Fabio Porcedda wrote: > >> I think we can check inside the deferred_probe_work_func() > >> if the dev->probe function pointer is equal to platform_drv_prob

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Fabio Porcedda
On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> I think we can check inside the deferred_probe_work_func() >> if the dev->probe function pointer is equal to platform_drv_probe_fail(). > > I think it's too late by then, because that wou

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Arnd Bergmann
On Wednesday 20 March 2013, Fabio Porcedda wrote: > I think we can check inside the deferred_probe_work_func() > if the dev->probe function pointer is equal to platform_drv_probe_fail(). I think it's too late by then, because that would only warn if we try to probe it again, but when platform_dri

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Fabio Porcedda
On Tue, Mar 19, 2013 at 6:59 PM, Arnd Bergmann wrote: > On Tuesday 19 March 2013, Fabio Porcedda wrote: >> On Tue, Mar 19, 2013 at 5:48 PM, Arnd Bergmann wrote: >> > On Tuesday 19 March 2013, Geert Uytterhoeven wrote: >> >> Hmm, so we may have drivers that (now) work perfectly fine with >> >> mod

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-19 Thread Arnd Bergmann
On Tuesday 19 March 2013, Fabio Porcedda wrote: > On Tue, Mar 19, 2013 at 5:48 PM, Arnd Bergmann wrote: > > On Tuesday 19 March 2013, Geert Uytterhoeven wrote: > >> Hmm, so we may have drivers that (now) work perfectly fine with > >> module_platform_driver_probe()/platform_driver_probe(), but will

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-19 Thread Fabio Porcedda
On Tue, Mar 19, 2013 at 5:48 PM, Arnd Bergmann wrote: > On Tuesday 19 March 2013, Geert Uytterhoeven wrote: >> Hmm, so we may have drivers that (now) work perfectly fine with >> module_platform_driver_probe()/platform_driver_probe(), but will start >> failing suddenly in the future? > > They will

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-19 Thread Arnd Bergmann
On Tuesday 19 March 2013, Geert Uytterhoeven wrote: > Hmm, so we may have drivers that (now) work perfectly fine with > module_platform_driver_probe()/platform_driver_probe(), but will start > failing suddenly in the future? They will fail if someone changes the initialization order. That would al

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-19 Thread Geert Uytterhoeven
On Tue, Mar 19, 2013 at 9:55 AM, Fabio Porcedda wrote: > On Mon, Mar 18, 2013 at 12:28 PM, Arnd Bergmann wrote: >> On Monday 18 March 2013, Fabio Porcedda wrote: >>> On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann wrote: >>> > On Monday 18 March 2013, Fabio Porcedda wrote: >>> >> Since by using

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-19 Thread Fabio Porcedda
On Mon, Mar 18, 2013 at 12:28 PM, Arnd Bergmann wrote: > On Monday 18 March 2013, Fabio Porcedda wrote: >> >> On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann wrote: >> > On Monday 18 March 2013, Fabio Porcedda wrote: >> >> Since by using platform_driver_probe() the function >> >> ep93xx_pwm_prob

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Arnd Bergmann
On Monday 18 March 2013, Fabio Porcedda wrote: > > On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann wrote: > > On Monday 18 March 2013, Fabio Porcedda wrote: > >> Since by using platform_driver_probe() the function > >> ep93xx_pwm_probe() is freed after initialization, > >> is better to use modul

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Fabio Porcedda
On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann wrote: > On Monday 18 March 2013, Fabio Porcedda wrote: >> Since by using platform_driver_probe() the function >> ep93xx_pwm_probe() is freed after initialization, >> is better to use module_platform_drive_probe(). >> IMHO i don't see any good reaso

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Arnd Bergmann
On Monday 18 March 2013, Fabio Porcedda wrote: > Since by using platform_driver_probe() the function > ep93xx_pwm_probe() is freed after initialization, > is better to use module_platform_drive_probe(). > IMHO i don't see any good reason to use module_platform_driver() for > this driver. As I com

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Fabio Porcedda
On Fri, Mar 15, 2013 at 9:18 PM, Arnd Bergmann wrote: > On Friday 15 March 2013, H Hartley Sweeten wrote: >> Arnd, >> >> Ill look at converting the ep93xx pwm driver to the PWM subsystem. The only >> issue is >> the current driver exposes a sysfs interface that I think is not available >> in tha

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, H Hartley Sweeten wrote: > Arnd, > > Ill look at converting the ep93xx pwm driver to the PWM subsystem. The only > issue is > the current driver exposes a sysfs interface that I think is not available in > that subsystem. You can probably keep providing that interface i

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Fabio Porcedda
On Fri, Mar 15, 2013 at 12:28 PM, Arnd Bergmann wrote: > On Friday 15 March 2013, Fabio Porcedda wrote: >> >> * Regarding the use of module_platform_driver_probe, I'm a little worried >> >> about >> >> the interactions with deferred probing. I don't think there are any >> >> regressions, >> >>

RE: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread H Hartley Sweeten
On Thursday, March 14, 2013 6:58 AM, Arnd Bergmann wrote: > On Thursday 14 March 2013, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Signed-off-by: Fabio Porcedda >> Cc: Greg Kro

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Fabio Porcedda wrote: > >> * Regarding the use of module_platform_driver_probe, I'm a little worried > >> about > >> the interactions with deferred probing. I don't think there are any > >> regressions, > >> but we should probably make people aware that one cannot ret

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Fabio Porcedda
On Thu, Mar 14, 2013 at 3:06 PM, Sascha Hauer wrote: > On Thu, Mar 14, 2013 at 01:58:05PM +, Arnd Bergmann wrote: >> On Thursday 14 March 2013, Fabio Porcedda wrote: >> > This patch converts the drivers to use the >> > module_platform_driver_probe() macro which makes the code smaller and >> >

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-14 Thread Sascha Hauer
On Thu, Mar 14, 2013 at 01:58:05PM +, Arnd Bergmann wrote: > On Thursday 14 March 2013, Fabio Porcedda wrote: > > This patch converts the drivers to use the > > module_platform_driver_probe() macro which makes the code smaller and > > a bit simpler. > > > > Signed-off-by: Fabio Porcedda > > C

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-14 Thread Arnd Bergmann
On Thursday 14 March 2013, Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. > > Signed-off-by: Fabio Porcedda > Cc: Greg Kroah-Hartman > Cc: Arnd Bergmann > --- > drivers/misc/atmel_pwm.c