Re: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-11-10 Thread Guennadi Liakhovetski
On Tue, 10 Nov 2009, Laurent Pinchart wrote: > Hi Guennadi, > > On Friday 30 October 2009 15:01:06 Guennadi Liakhovetski wrote: > > Introduce new v4l2-subdev sensor operations, move .enum_framesizes() and > > .enum_frameintervals() methods to it, > > I understand that we need sensor-specific ope

Re: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-11-10 Thread Laurent Pinchart
Hi Guennadi, On Friday 30 October 2009 15:01:06 Guennadi Liakhovetski wrote: > Introduce new v4l2-subdev sensor operations, move .enum_framesizes() and > .enum_frameintervals() methods to it, I understand that we need sensor-specific operations, but I'm not sure if those two are really unneeded

RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-11-04 Thread Guennadi Liakhovetski
On Mon, 2 Nov 2009, Karicheri, Muralidharan wrote: > >> >@@ -301,9 +301,9 @@ static int mt9t031_set_params(struct > >soc_camera_device > >> >*icd, > >> > ret = reg_write(client, MT9T031_WINDOW_WIDTH, rect->width - 1); > >> > if (ret >= 0) > >> > ret = reg_write(client, MT9T031_W

RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-11-02 Thread Karicheri, Muralidharan
khovetski >Sent: Friday, October 30, 2009 4:32 PM >To: Karicheri, Muralidharan >Cc: Linux Media Mailing List; Hans Verkuil; Laurent Pinchart; Sakari Ailus >Subject: RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use >g_skip_top_lines in soc-camera > >On Fri, 30 Oct 2009,

RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-10-30 Thread Guennadi Liakhovetski
On Fri, 30 Oct 2009, Karicheri, Muralidharan wrote: > Guennadi, > > > > mt9m111->rect.left = MT9M111_MIN_DARK_COLS; > > mt9m111->rect.top = MT9M111_MIN_DARK_ROWS; > >diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c > >index 6966f64..57e04e9 100644 > >

RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-10-30 Thread Karicheri, Muralidharan
Guennadi, > mt9m111->rect.left = MT9M111_MIN_DARK_COLS; > mt9m111->rect.top = MT9M111_MIN_DARK_ROWS; >diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c >index 6966f64..57e04e9 100644 >--- a/drivers/media/video/mt9t031.c >+++ b/drivers/media/video/mt