RE: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

2009-06-22 Thread Karicheri, Muralidharan
>> >> >> > +static int dm355_ccdc_init(void) >> > +{ >> > +       printk(KERN_NOTICE "dm355_ccdc_init\n"); >> > +       if (vpfe_register_ccdc_device(&ccdc_hw_dev) < 0) >> > +               return -1; >> >> Don't you want to rewrite this to return good error code? >> int ret; >> printk(); >> ret =

Re: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

2009-06-19 Thread Hans Verkuil
On Wednesday 17 June 2009 23:51:43 Alexey Klimov wrote: > Hello, > one more small comment > > On Thu, Jun 18, 2009 at 12:11 AM, wrote: > > From: Muralidharan Karicheri > > > > DM355 CCDC hw module > > > > Adds ccdc hw module for DM355 CCDC. This registers with the bridge > > driver a set of hw_op

Re: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

2009-06-17 Thread Alexey Klimov
Hello, one more small comment On Thu, Jun 18, 2009 at 12:11 AM, wrote: > From: Muralidharan Karicheri > > DM355 CCDC hw module > > Adds ccdc hw module for DM355 CCDC. This registers with the bridge > driver a set of hw_ops for configuring the CCDC for a specific > decoder device connected to vpf