RE: [PATCH v1] s5p-mfc: update MFC v4l2 driver to support MFC6.x
Hi Arun, First of all - your patch is incomplete. I cannot find a modified videodev2.h file. Compilation fails with a lot of undefined symbols - attached below. Please supply this file, then I will be able to provide you with more comments and a proper review. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center --- Errors In file included from drivers/media/video/s5p-mfc/s5p_mfc.c:25: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type make[4]: *** [drivers/media/video/s5p-mfc/s5p_mfc.o] Error 1 make[4]: *** Waiting for unfinished jobs In file included from drivers/media/video/s5p-mfc/s5p_mfc_intr.c:21: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type make[4]: *** [drivers/media/video/s5p-mfc/s5p_mfc_intr.o] Error 1 In file included from drivers/media/video/s5p-mfc/s5p_mfc_dec.c:27: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_dec.c:38: error: 'V4L2_PIX_FMT_NV12MT_16X16' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c:59: error: 'V4L2_PIX_FMT_NV21M' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c:73: error: 'V4L2_PIX_FMT_H264_MVC' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c:129: error: 'V4L2_PIX_FMT_VP8' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c: In function 'vidioc_try_fmt': drivers/media/video/s5p-mfc/s5p_mfc_dec.c:377: warning: comparison between pointer and integer drivers/media/video/s5p-mfc/s5p_mfc_dec.c: In function 'vidioc_s_fmt': drivers/media/video/s5p-mfc/s5p_mfc_dec.c:450: warning: comparison between pointer and integer make[4]: *** [drivers/media/video/s5p-mfc/s5p_mfc_dec.o] Error 1 In file included from drivers/media/video/s5p-mfc/s5p_mfc_enc.c:28: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_enc.c:38: error: 'V4L2_PIX_FMT_NV12MT_16X16' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:59: error: 'V4L2_PIX_FMT_NV21M' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:113: error: 'V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BITS' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:113: error: initializer element is not constant drivers/media/video/s5p-mfc/s5p_mfc_enc.c:113: error: (near initialization for 'controls[1].maximum') drivers/media/video/s5p-mfc/s5p_mfc_enc.c:126: error: 'V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BITS' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:126: error: initializer element is not constant drivers/media/video/s5p-mfc/s5p_mfc_enc.c:126: error: (near initialization for 'controls[3].id') drivers/media/video/s5p-mfc/s5p_mfc_enc.c:202: error: 'V4L2_CID_MPEG_VIDEO_VBV_DELAY' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:202: error: initializer element is not constant drivers/media/video/s5p-mfc/s5p_mfc_enc.c:202: error: (near initialization for 'controls[12].id') drivers/media/video/s5p-mfc/s5p_mfc_enc.c:572: error: 'V4L2_CID_MPEG_VIDEO_H264_SEI_FRAME_PACKING' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:572: error: initializer element is not constant drivers/media/video/s5p-mfc/s5p_mfc_enc.c:572: error: (near initialization for 'controls[55].id') drivers/media/video/s5p-mfc/s5p_mfc_enc.c:580: error: 'V4L2_CID_MPEG_VIDEO_H264_SEI_FP_CURRENT_FRAME_0' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:580: error: initializer element is
Re: RE: [PATCH v1] s5p-mfc: update MFC v4l2 driver to support MFC6.x
Hi Kamil, The patch for videodev2.h is already posted by Jeongtae Park and is under review. [1] Now as suggested by you, I will send that patch again and also by incorporating the review comments given there. [1] http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/45190 Regards Arun --- Original Message --- Sender : Kamil Debskik.deb...@samsung.com Software Engineer/Poland RD Center-Linux Platform (SSD)/Samsung Electronics Date : Jul 05, 2012 20:45 (GMT+05:30) Title : RE: [PATCH v1] s5p-mfc: update MFC v4l2 driver to support MFC6.x Hi Arun, First of all - your patch is incomplete. I cannot find a modified videodev2.h file. Compilation fails with a lot of undefined symbols - attached below. Please supply this file, then I will be able to provide you with more comments and a proper review. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center --- Errors In file included from drivers/media/video/s5p-mfc/s5p_mfc.c:25: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type make[4]: *** [drivers/media/video/s5p-mfc/s5p_mfc.o] Error 1 make[4]: *** Waiting for unfinished jobs In file included from drivers/media/video/s5p-mfc/s5p_mfc_intr.c:21: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type make[4]: *** [drivers/media/video/s5p-mfc/s5p_mfc_intr.o] Error 1 In file included from drivers/media/video/s5p-mfc/s5p_mfc_dec.c:27: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_dec.c:38: error: 'V4L2_PIX_FMT_NV12MT_16X16' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c:59: error: 'V4L2_PIX_FMT_NV21M' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c:73: error: 'V4L2_PIX_FMT_H264_MVC' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c:129: error: 'V4L2_PIX_FMT_VP8' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_dec.c: In function 'vidioc_try_fmt': drivers/media/video/s5p-mfc/s5p_mfc_dec.c:377: warning: comparison between pointer and integer drivers/media/video/s5p-mfc/s5p_mfc_dec.c: In function 'vidioc_s_fmt': drivers/media/video/s5p-mfc/s5p_mfc_dec.c:450: warning: comparison between pointer and integer make[4]: *** [drivers/media/video/s5p-mfc/s5p_mfc_dec.o] Error 1 In file included from drivers/media/video/s5p-mfc/s5p_mfc_enc.c:28: drivers/media/video/s5p-mfc/s5p_mfc_common.h:330: error: field 'hier_qp_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:335: error: field 'sei_fp_arrangement_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:338: error: field 'fmo_map_type' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_common.h:340: error: field 'fmo_chg_dir' has incomplete type drivers/media/video/s5p-mfc/s5p_mfc_enc.c:38: error: 'V4L2_PIX_FMT_NV12MT_16X16' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:59: error: 'V4L2_PIX_FMT_NV21M' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:113: error: 'V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BITS' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:113: error: initializer element is not constant drivers/media/video/s5p-mfc/s5p_mfc_enc.c:113: error: (near initialization for 'controls[1].maximum') drivers/media/video/s5p-mfc/s5p_mfc_enc.c:126: error: 'V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BITS' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:126: error: initializer element is not constant drivers/media/video/s5p-mfc/s5p_mfc_enc.c:126: error: (near initialization for 'controls[3].id') drivers/media/video/s5p-mfc/s5p_mfc_enc.c:202: error: 'V4L2_CID_MPEG_VIDEO_VBV_DELAY' undeclared here (not in a function) drivers/media/video/s5p-mfc/s5p_mfc_enc.c:202: error: initializer element is not constant drivers/media/video/s5p-mfc/s5p_mfc_enc.c:202: error: (near
