RE: [PATCH v1 - 4/5] V4L : vpif updates for DM6467 vpif capture driver

2009-08-17 Thread Karicheri, Muralidharan
Vaibhav, I don't see any serious issues raised here. I can send another patch to fix this if needed. Regards, Murali +#include linux/spinlock.h #include linux/kernel.h +#include linux/io.h [Hiremath, Vaibhav] You may want to put one line gap here. Ok. Just editorial. +#include

RE: [PATCH v1 - 4/5] V4L : vpif updates for DM6467 vpif capture driver

2009-08-17 Thread Karicheri, Muralidharan
, Vaibhav Sent: Monday, August 17, 2009 12:35 PM To: Karicheri, Muralidharan; linux-media@vger.kernel.org Cc: davinci-linux-open-sou...@linux.davincidsp.com; hverk...@xs4all.nl Subject: RE: [PATCH v1 - 4/5] V4L : vpif updates for DM6467 vpif capture driver H Murali, -Original Message- From

RE: [PATCH v1 - 4/5] V4L : vpif updates for DM6467 vpif capture driver

2009-08-16 Thread Hiremath, Vaibhav
Quick review comments below - -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Karicheri, Muralidharan Sent: Saturday, August 15, 2009 2:32 AM To: linux-media@vger.kernel.org Cc: