RE: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

tel.com>; Vijaykumar, Ramya > <ramya.vijayku...@intel.com> > Subject: Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver > > Hi Yong, > > Thanks for the update! This looks pretty good in general, still some more > comments below. > > Do you happen

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Tomasz, On Thu, Jul 13, 2017 at 05:31:33PM +0900, Tomasz Figa wrote: > On Thu, Jul 13, 2017 at 5:21 PM, Sakari Ailus wrote: > >> >> + ret = v4l2_async_notifier_register(>v4l2_dev, > >> >> >notifier); > >> >> + if (ret) { > >> >> +

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

On Thu, Jul 13, 2017 at 5:21 PM, Sakari Ailus wrote: >> >> + ret = v4l2_async_notifier_register(>v4l2_dev, >> >> >notifier); >> >> + if (ret) { >> >> + cio2->notifier.num_subdevs = 0; >> > >> > No need to assign num_subdevs as 0. >> > >> > [YZ]

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Tomasz and Yong, On Thu, Jul 13, 2017 at 01:51:18PM +0900, Tomasz Figa wrote: > Hi Yong, > > On Thu, Jul 13, 2017 at 8:20 AM, Zhi, Yong wrote: > > Hi, Sakari, > > > > Thanks for the time spent on code review, acks to all the comments, except > > two places: > > > >> +/*

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, On Thu, Jul 13, 2017 at 8:20 AM, Zhi, Yong wrote: > Hi, Sakari, > > Thanks for the time spent on code review, acks to all the comments, except > two places: > >> +/* .complete() is called after all subdevices have been located */ >> +static int

RE: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

kari Ailus [sakari.ai...@iki.fi] Sent: Tuesday, July 11, 2017 3:33 AM To: Zhi, Yong Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; hans.verk...@cisco.com; Zheng, Jian Xu; tf...@chromium.org; Mani, Rajmohan; Toivonen, Tuukka; Yang, Hyungwoo; Vijaykumar, Ramya Subject: Re: [PATCH v4

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, Thanks for the update! This looks pretty good in general, still some more comments below. Do you happen to have a todo list for the changes that are still planned? AFAIR we should have two items in the list at least --- 1. Extend the format example to include the DMA word boundary and