Re: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

2018-02-05 Thread Maxime Ripard
On Mon, Feb 05, 2018 at 11:42:11AM +, Fabrizio Castro wrote: > Hello Maxime, > > thank you for your feedback. > > > > > +/* > > > > + * configure parallel port control lines polarity > > > > + * > > > > + * POLARITY CTRL0 > > > > + * - [5]:PCLK polarity (0: active low, 1: active high) > > >

RE: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

2018-02-05 Thread Fabrizio Castro
Hello Maxime, thank you for your feedback. > > > +/* > > > + * configure parallel port control lines polarity > > > + * > > > + * POLARITY CTRL0 > > > + * - [5]:PCLK polarity (0: active low, 1: active high) > > > + * - [1]:HREF polarity (0: active low, 1: active high) > > > + * - [0]:VSYNC

Re: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

2018-02-02 Thread Maxime Ripard
Hi Fabrizio, On Thu, Feb 01, 2018 at 05:53:18PM +, Fabrizio Castro wrote: > > Subject: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface > > > > Add support of DVP parallel mode in addition of > > existing MIPI CSI mode. The choice between two modes > > and configuration is

RE: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

2018-02-01 Thread Fabrizio Castro
Hello Hugues, > Subject: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface > > Add support of DVP parallel mode in addition of > existing MIPI CSI mode. The choice between two modes > and configuration is made through device tree. > > Signed-off-by: Hugues Fruchet