RE: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-11 Thread Yeh, Andy
gt; Cc: Linux Media Mailing List <linux-media@vger.kernel.org>; Sakari Ailus <sakari.ai...@linux.intel.com>; Chen, JasonX Z <jasonx.z.c...@intel.com>; Chiang, AlanX <alanx.chi...@intel.com> Subject: Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver Hi Andy, Tha

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
On Tue, Mar 06, 2018 at 06:52:16PM +0900, Tomasz Figa wrote: > On Tue, Mar 6, 2018 at 6:46 PM, Sakari Ailus > wrote: > > On Tue, Mar 06, 2018 at 06:28:43PM +0900, Tomasz Figa wrote: > >> On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus > >>

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Tomasz Figa
On Tue, Mar 6, 2018 at 6:46 PM, Sakari Ailus wrote: > On Tue, Mar 06, 2018 at 06:28:43PM +0900, Tomasz Figa wrote: >> On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus >> wrote: >> > On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
On Tue, Mar 06, 2018 at 06:28:43PM +0900, Tomasz Figa wrote: > On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus > wrote: > > On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa wrote: > >> On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus > >>

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Tomasz Figa
On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus wrote: > On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa wrote: >> On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus >> wrote: >> > Hi Tomasz and Andy, >> > >> > On Sat, Mar 03, 2018 at

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa wrote: > On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus > wrote: > > Hi Tomasz and Andy, > > > > On Sat, Mar 03, 2018 at 12:43:59AM +0900, Tomasz Figa wrote: > > ... > >> > +static int imx258_set_ctrl(struct

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Tomasz Figa
On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus wrote: > Hi Tomasz and Andy, > > On Sat, Mar 03, 2018 at 12:43:59AM +0900, Tomasz Figa wrote: > ... >> > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) >> > +{ >> > + struct imx258 *imx258 = >> > +

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
Hi Tomasz and Andy, On Sat, Mar 03, 2018 at 12:43:59AM +0900, Tomasz Figa wrote: ... > > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) > > +{ > > + struct imx258 *imx258 = > > + container_of(ctrl->handler, struct imx258, ctrl_handler); > > + struct i2c_client

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-02 Thread Tomasz Figa
Hi Andy, Thanks for the patch. Let me post some comments inline. On Fri, Mar 2, 2018 at 11:55 PM, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > >