RE: [RFC/PATCH v2 7/7] v4l: subdev: Generic ioctl support

2010-07-12 Thread Pawel Osciak
Laurent Pinchart wrote: Sent: Friday, July 09, 2010 5:32 PM To: linux-media@vger.kernel.org Cc: sakari.ai...@maxwell.research.nokia.com Subject: [RFC/PATCH v2 7/7] v4l: subdev: Generic ioctl support Instead of returning an error when receiving an ioctl call with an unsupported command, forward

Re: [RFC/PATCH v2 7/7] v4l: subdev: Generic ioctl support

2010-07-12 Thread Laurent Pinchart
Hi Pawel, On Monday 12 July 2010 11:33:52 Pawel Osciak wrote: On Friday 9 July 2010 17:32:00 Laurent Pinchart wrote: [snip] diff --git a/drivers/media/video/v4l2-subdev.c b/drivers/media/video/v4l2- subdev.c index 31bec67..ce47772 100644 --- a/drivers/media/video/v4l2-subdev.c +++

Re: [RFC/PATCH v2 7/7] v4l: subdev: Generic ioctl support

2010-07-10 Thread Mauro Carvalho Chehab
Em 09-07-2010 12:31, Laurent Pinchart escreveu: Instead of returning an error when receiving an ioctl call with an unsupported command, forward the call to the subdev core::ioctl handler. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

Re: [RFC/PATCH v2 7/7] v4l: subdev: Generic ioctl support

2010-07-10 Thread Hans Verkuil
On Saturday 10 July 2010 16:08:46 Mauro Carvalho Chehab wrote: Em 09-07-2010 12:31, Laurent Pinchart escreveu: Instead of returning an error when receiving an ioctl call with an unsupported command, forward the call to the subdev core::ioctl handler. Signed-off-by: Laurent Pinchart

Re: [RFC/PATCH v2 7/7] v4l: subdev: Generic ioctl support

2010-07-10 Thread Mauro Carvalho Chehab
Em 10-07-2010 13:31, Hans Verkuil escreveu: On Saturday 10 July 2010 16:08:46 Mauro Carvalho Chehab wrote: Em 09-07-2010 12:31, Laurent Pinchart escreveu: Hmm... private ioctls at subdev... I'm not sure if I like this idea. I prefer to merge this patch only after having a driver actually