Re: Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l
Sorry, SOB On Thu, Oct 14, 2010 at 12:36 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Hi Steven, I'm still missing your SOB for the three patches from Gavin. Please reply to this thread publicly with your SOB, and I'll add both SOB's on my tree. Thanks, Mauro Sorry, a mix of travel and time away from email. For all three patches by Gavin: Signed-off-by: Steven Toth st...@kernellabs.com Regards, - Steve -- Steven Toth - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l
Hi stoth,
Em 31-07-2010 17:42, Steven Toth escreveu:
Mauro,
Analog Encoder and VBI support in the SAA7164 tree, for the HVR2200
and HVR2250 cards.
Please pull from http://www.kernellabs.com/hg/~stoth/saa7164-v4l
As requested on irc, I've pulled from your tree again, and fixed a few things
on your patch series (a warning and _lots_ of checkpatch issues).
There are still some compilation breakages in the middle of your patch series.
So, I'll fold some patches, in order to avoid the issues.
There are still a few checkpatch issues (I removed all 80-columns warning
noise).
Could you please double check them?
To make life easier for you, I've created a temp git tree at:
http://git.linuxtv.org/mchehab/stoth.git
The checkpatch.pl errors/warnings are enclosed bellow.
Thanks,
Mauro
---
WARNING: braces {} are not necessary for single statement blocks
#47: FILE: drivers/media/video/saa7164/saa7164-api.c:43:
+ if (ret != SAA_OK) {
+ printk(KERN_ERR %s() error, ret = 0x%x\n, __func__, ret);
+ }
WARNING: braces {} are not necessary for single statement blocks
#70: FILE: drivers/media/video/saa7164/saa7164-api.c:66:
+ if (ret != SAA_OK) {
+ printk(KERN_ERR %s() error, ret = 0x%x\n, __func__,
ret);
+ }
WARNING: braces {} are not necessary for single statement blocks
#93: FILE: drivers/media/video/saa7164/saa7164-api.c:89:
+ if (ret != SAA_OK) {
+ printk(KERN_ERR %s() error, ret = 0x%x\n, __func__, ret);
+ }
WARNING: braces {} are not necessary for single statement blocks
#103: FILE: drivers/media/video/saa7164/saa7164-api.c:99:
+ if (ret != SAA_OK) {
+ printk(KERN_ERR %s() error, ret = 0x%x\n, __func__, ret);
+ }
ERROR: do not use C99 // comments
#654: FILE: drivers/media/video/saa7164/saa7164-api.c:650:
+ //saa7164_dumphex16(dev, buf, 16);
WARNING: kfree(NULL) is safe this check is probably not required
#1381: FILE: drivers/media/video/saa7164/saa7164-buffer.c:317:
+ if (buf-data) {
+ kfree(buf-data);
WARNING: kfree(NULL) is safe this check is probably not required
#1386: FILE: drivers/media/video/saa7164/saa7164-buffer.c:322:
+ if (buf)
+ kfree(buf);
ERROR: do not use C99 // comments
#1962: FILE: drivers/media/video/saa7164/saa7164-core.c:126:
+// saa7164_dumphex16FF(buf-port-dev, (p + i), 32);
WARNING: braces {} are not necessary for single statement blocks
#2038: FILE: drivers/media/video/saa7164/saa7164-core.c:202:
+ for (i = 0; i 30; i++) {
+ hg-counter1[0 + i].val = i;
+ }
WARNING: braces {} are not necessary for single statement blocks
#2043: FILE: drivers/media/video/saa7164/saa7164-core.c:207:
+ for (i = 0; i 18; i++) {
+ hg-counter1[30 + i].val = 30 + (i * 10);
+ }
WARNING: braces {} are not necessary for single statement blocks
#2048: FILE: drivers/media/video/saa7164/saa7164-core.c:212:
+ for (i = 0; i 15; i++) {
+ hg-counter1[48 + i].val = 200 + (i * 200);
+ }
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2103: FILE: drivers/media/video/saa7164/saa7164-core.c:267:
+ printk(KERN_ERR %4d %12d %Ld\n,
ERROR: do not use C99 // comments
#2154: FILE: drivers/media/video/saa7164/saa7164-core.c:318:
+// saa7164_dumphex16FF(dev, (p +
buf-actual_size) - 32 , 64);
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2239: FILE: drivers/media/video/saa7164/saa7164-core.c:403:
+ %s() %Ldms elapsed irq-deferred %Ldms wp: %d rp: %d\n,
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2315: FILE: drivers/media/video/saa7164/saa7164-core.c:479:
+ %s() %Ldms elapsed irq-deferred %Ldms wp: %d rp: %d\n,
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2402: FILE: drivers/media/video/saa7164/saa7164-core.c:567:
+ dprintk(DBGLVL_IRQ, %s() %Ldms elapsed\n, __func__,
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2427: FILE: drivers/media/video/saa7164/saa7164-core.c:592:
+ dprintk(DBGLVL_IRQ, %s() %Ldms elapsed\n, __func__,
ERROR: else should follow close brace '}'
#2606: FILE: drivers/media/video/saa7164/saa7164-core.c:965:
+ }
+ else
WARNING: struct file_operations should normally be const
#2747: FILE: drivers/media/video/saa7164/saa7164-core.c:1172:
+static struct file_operations saa7164_proc_fops = {
WARNING: braces {} are not necessary for single statement blocks
#4427: FILE: drivers/media/video/saa7164/saa7164-encoder.c:1236:
+ if (ubuf-pos ubuf-actual_size) {
+ printk(KERN_ERR read() pos actual, huh?\n);
+ }
WARNING: braces {} are not necessary for single statement blocks
#4453: FILE: drivers/media/video/saa7164/saa7164-encoder.c:1262:
+ if (!ret !ubuf) {
+ ret = -EAGAIN;
+ }
WARNING: braces {} are not
Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l
Em 11-10-2010 18:03, Mauro Carvalho Chehab escreveu:
Hi stoth,
Em 31-07-2010 17:42, Steven Toth escreveu:
Mauro,
Analog Encoder and VBI support in the SAA7164 tree, for the HVR2200
and HVR2250 cards.
Please pull from http://www.kernellabs.com/hg/~stoth/saa7164-v4l
As requested on irc, I've pulled from your tree again, and fixed a few things
on your patch series (a warning and _lots_ of checkpatch issues).
There are still some compilation breakages in the middle of your patch series.
So, I'll fold some patches, in order to avoid the issues.
There are still a few checkpatch issues (I removed all 80-columns warning
noise).
Could you please double check them?
To make life easier for you, I've created a temp git tree at:
http://git.linuxtv.org/mchehab/stoth.git
Stoth,
I realized that I missed a few patches on my queue. I've applied them also at
the
git tree. There are a few issues on some of them:
commit a5209649cb5aa8a706e6ed5ab74378f2f95c64bf
Author: Steven Toth st...@kernellabs.com
Date: Wed Oct 6 21:52:22 2010 -0300
V4L/DVB: saa7164: Removed use of the BKL
Remove usage of the BKL and instead used video_set_drvdata() during
open fops.
Signed-off-by: Steven Toth st...@kernellabs.com
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
There were some conflicts on this patch. Please verify that the conflict solve
went ok.
commit 86ae40b5f3da13c5fd0c70731aac6447c6af4cd8
Author: Gavin Hurlbut gjhur...@gmail.com
Date: Thu Sep 30 18:21:20 2010 -0300
V4L/DVB: Fix the -E{*} returns in the VBI device as well
commit f92f45822ce73cfc4bde8d61a75598fb9db35d6b
Author: Gavin Hurlbut gjhur...@gmail.com
Date: Wed Sep 29 15:18:20 2010 -0300
V4L/DVB: Fix the negative -E{BLAH} returns from fops_read
commit 25b5ab78a5240c82baa78167e55c8d74a6e0a276
Author: Gavin Hurlbut gjhur...@gmail.com
Date: Mon Sep 27 23:50:43 2010 -0300
V4L/DVB: Change the second input names to include 2 to distinguish them
Those three patches are missing your Signed-off-by: and Gavin's Signed-off-by:
Could you please provide it?
Thanks,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l
I replied earlier, but due to gmail wanting to send HTML mail by
default (grr), it bounced when sending to the list Original
reply (slightly reformatted) follows:
commit 86ae40b5f3da13c5fd0c70731aac6447c6af4cd8
Author: Gavin Hurlbut gjhur...@gmail.com
Date: Thu Sep 30 18:21:20 2010 -0300
V4L/DVB: Fix the -E{*} returns in the VBI device as well
commit f92f45822ce73cfc4bde8d61a75598fb9db35d6b
Author: Gavin Hurlbut gjhur...@gmail.com
Date: Wed Sep 29 15:18:20 2010 -0300
V4L/DVB: Fix the negative -E{BLAH} returns from fops_read
commit 25b5ab78a5240c82baa78167e55c8d74a6e0a276
Author: Gavin Hurlbut gjhur...@gmail.com
Date: Mon Sep 27 23:50:43 2010 -0300
V4L/DVB: Change the second input names to include 2 to distinguish them
Those three patches are missing your Signed-off-by: and Gavin's Signed-off-by:
Could you please provide it?
Chock those up to me missing putting the Signed-off-by: lines in the
patches I sent to Steven due to me being new to mercurial. Is there a
way for me to add it posthumously, as it were? I'll be sure to add
that in any future patches, and I apologize for the oversight. It
would be (for all three patches):
Signed-off-by: Gavin Hurlbut gjhur...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
