Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-17 Thread Andrey Gusakov
Hi. Just have time to test. I apologize for delay. I'd like to squash all the s3c-camif patches before sending upstream, if you don't mind. And to add your Signed-off at the final patch. Ok. Squash. I might have introduced bugs in the image effects handling, hopefully there is none. I

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-17 Thread Sylwester Nawrocki
Hi, On 11/17/2012 01:07 PM, Andrey Gusakov wrote: Hi. Just have time to test. I apologize for delay. No problem, thanks for the feedback. I'd like to squash all the s3c-camif patches before sending upstream, if you don't mind. And to add your Signed-off at the final patch. Ok. Squash. I

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-13 Thread Sylwester Nawrocki
Hi Andrey, On 11/11/2012 02:26 PM, Andrey Gusakov wrote: Hi. Patch v2 attached. Comments taken into account. Thanks, I had to rework the S3C-CAMIF subdev controls handling to avoid races when the control's value is modified in the control framwework and accessed from interrupt context in the

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-11 Thread Andrey Gusakov
Hi. Patch v2 attached. Comments taken into account. I often get VIDIOC_QUERYCAP: failed: Inappropriate ioctl for device This is an issue in the v4l2-ctl, it is going to be fixed by adding VIDIOC_SUBDEV_QUERYCAP ioctl for subdevs. It has been just discussed today. I guess you get it when

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-09 Thread Sylwester Nawrocki
Hi, On 11/08/2012 07:47 PM, Andrey Gusakov wrote: Ok, thanks. I will add the missing CONFIG_PM_RUNTIME dependency in Kconfig. The driver has to have PM_RUNTIME enabled since on s3c64xx SoCs there are power domains and the camera power domain needs to be enabled for the CAMIF operation. The

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-08 Thread Andrey Gusakov
Hi. On Thu, Nov 8, 2012 at 1:57 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 11/06/2012 10:34 PM, Andrey Gusakov wrote: Hi. Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Work! I'm looking at drivers/media/usb/gspca/m5602/m5602_ov9650.h It use

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-07 Thread Sylwester Nawrocki
On 11/06/2012 10:34 PM, Andrey Gusakov wrote: Hi. Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Work! I'm looking at drivers/media/usb/gspca/m5602/m5602_ov9650.h It use significantly different init sequence. Some of settings described in Application note for ov9650,

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-06 Thread Andrey Gusakov
Hi. Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Work! I'm looking at drivers/media/usb/gspca/m5602/m5602_ov9650.h It use significantly different init sequence. Some of settings described in Application note for ov9650, some look like magic. Do you have

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-05 Thread Andrey Gusakov
Hi. But documentation on ov9650 is too conflicting and did not cover all registers used in driver. Do you mean the OV9650 datasheet, version 1.3, from September 24, 2004 ? Yes. Also I have datasheet version 1.91 from January 28, 2005 and Application note 1.1 from 7 December 2004 All can be

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-05 Thread Sylwester Nawrocki
Hi, On 11/05/2012 10:44 AM, Andrey Gusakov wrote: But documentation on ov9650 is too conflicting and did not cover all registers used in driver. Do you mean the OV9650 datasheet, version 1.3, from September 24, 2004 ? Yes. Also I have datasheet version 1.91 from January 28, 2005 and

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-05 Thread Andrey Gusakov
Hi. Thanks all! I make it work! Have to comment out write { REG_GRCOM, 0x3f }, /* Analog BLC regulator */ and have to enable gate clock for fimc at probe. Hmm, in my case VER was 0x50. PID, VER = 0x96, 0x50. And this a default value after reset according to the datasheet, ver. 1.3. For ver.

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-05 Thread Sylwester Nawrocki
Hi Andrey, On 11/05/2012 12:11 PM, Andrey Gusakov wrote: Hi. Thanks all! I make it work! Have to comment out write { REG_GRCOM, 0x3f }, /* Great news! Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Analog BLC regulator */ and have to enable gate clock for fimc

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-04 Thread Sylwester Nawrocki
Hi Andrey, Cc: LMML On 11/04/2012 09:43 PM, Andrey Gusakov wrote: Hi all. I'm testing your FIMC driver on S3C6410 hardware with OV9650 (in plans OV2640). I fixed some register definition, gpio init, fixed IRQ handling for S3C6410. So now i can get test frames from internal pattern generator.

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-04 Thread Tomasz Figa
Hi Andrey, On Sunday 04 of November 2012 23:14:47 Sylwester Nawrocki wrote: Are you using this version of patches: http://git.linuxtv.org/snawrocki/media.git/shortlog/refs/heads/s3c-cam if ? I'm using patches from https://github.com/snawrocki/linux/commits/s3c-camif-v3.5 wich was in