Am 13.10.2013 16:00, schrieb Frank Schäfer:
> [snip]
>
> Am 12.10.2013 05:45, schrieb Mauro Carvalho Chehab:
>> Changing the input will likely power on the device. The design of the
>> old suspend callback were to call it when the device is not being used.
>> Any try to use the device makes it to w
On Tue, 15 Oct 2013, Guennadi Liakhovetski wrote:
> Well, yes, the idea is not bad, FWIW I could live with it. Doing this
> wouldn't be very simple though, I guess. E.g. em28xx would have to do both
> - call balanced .s_power() for camera sensors etc. and call .suspend() for
> tuners or whateve
Why do we call these functions only in case of V4L2_BUF_TYPE_VIDEO_CAPTURE ?
> > Isn't it needed for VBI capturing, too ?
> > em28xx_wake_i2c() is probably also needed for radio mode..."
> >
> > Right, my patch doesn't change this, so, this is unrelated.
> &
[snip]
Am 12.10.2013 05:45, schrieb Mauro Carvalho Chehab:
>
> Changing the input will likely power on the device. The design of the
> old suspend callback were to call it when the device is not being used.
> Any try to use the device makes it to wake up, as it makes no sense to
> use a device in
?
> em28xx_wake_i2c() is probably also needed for radio mode..."
>
> Right, my patch doesn't change this, so, this is unrelated.
>
> Have I missed anything?
>
> > > Could you test, please?
> >
> > Yes, this patch will make the warnings disa
Am 10.10.2013 20:38, schrieb Frank Schäfer:
[...]
"Hmm... your patch didn't change this, but:
Why do we call these functions only in case of V4L2_BUF_TYPE_VIDEO_CAPTURE
?
Isn't it needed for VBI capturing, too ?
em28xx_wake_i2c() is probably also needed for radio mode..."
me reviewing them and
> replying immediately. We all have other things to do too.
True. It would be nice to get further feedback and clear decisions from
the maintainer.
Anyway, if a regression can't be fixed in a reasonable time (at least
provisional), the commit that introduced this regress
ver I cannot force people to spend time reviewing them and
replying immediately. We all have other things to do too.
> > http://www.mail-archive.com/linux-media@vger.kernel.org/msg66566.html
> >
> >> And what about the em28xx v4l2-clk patches ?
> > Their acceptance is relat
is still under discussion:
How long are you going to discuss this ?
We are not talking about a new feature or improvement/extension.
This is about fixing a regression, which should always have highest
priority.
8 weeks IMHO should be more than enough.
> http://www.mail-archive.com/linux-media@vger
Yes, this patch will make the warnings disappear and works at least for
> my em28xx+ov2640 device.
Good, thanks for testing!
> What about Mauros an my concerns with regards to all other em28xx devices ?
This is still under discussion:
http://www.mail-archive.com/linux-media@v
cide
which way to go.
Either accept and apply the existing patches or request new ones with
changes.
But IMHO doing nothing for 2 months isn't the right way to handle
regressions.
Regards,
Frank
> In the meantime I'm still waiting for more comments to my "[RFD]
> use-counting
on has still not been
> fixed.
> Does anybody care about it ? WONTFIX ?
You replied to my patch "em28xx: balance subdevice power-off calls" with a
few non-essential IMHO comments but you didn't test it. Could you test,
please? In the meantime I'm still wai
till not been
fixed.
Does anybody care about it ? WONTFIX ?
Regards,
Frank
>> Regards,
>> Frank
>>> Thanks
>>> Guennadi
>>>
>>>
>>> -Original Message-
>>> From: "Frank Schäfer"
>>> To: Guennadi Liakhovetski
Hi Frank,
On Monday 02 September 2013 20:30:42 Frank Schäfer wrote:
> Sorry for the delayed reply.
> A few remarks:
>
> Am 27.08.2013 14:52, schrieb Laurent Pinchart:
> > ...
> >
> > Even if the bridge doesn't control the clock, it provides a clock to the
> > sensor. As such, it's the responsibi
On 09/02/2013 08:30 PM, Frank Schäfer wrote:
Sorry for the delayed reply.
A few remarks:
Am 27.08.2013 14:52, schrieb Laurent Pinchart:
...
Even if the bridge doesn't control the clock, it provides a clock to the
sensor. As such, it's the responsibility of the bridge driver to provide the
cloc
Sorry for the delayed reply.
A few remarks:
Am 27.08.2013 14:52, schrieb Laurent Pinchart:
> ...
>
> Even if the bridge doesn't control the clock, it provides a clock to the
> sensor. As such, it's the responsibility of the bridge driver to provide the
> clock to the sensor driver. The sensor d
Hi Guennadi,
Am 30.08.2013 12:30, schrieb Guennadi Liakhovetski:
> Hi Frank,
>
> On Fri, 23 Aug 2013, Frank Schäfer wrote:
>
>> Hi Sylwester,
>>
>> Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
>>> Hi Frank,
>>>
>>> On 08/21/2013 10:39 PM, Frank Schäfer wrote:
Am 20.08.2013 18:34, schrieb
Hi Frank,
On Fri, 23 Aug 2013, Frank Schäfer wrote:
> Hi Sylwester,
>
> Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
> > Hi Frank,
> >
> > On 08/21/2013 10:39 PM, Frank Schäfer wrote:
> >> Am 20.08.2013 18:34, schrieb Frank Schäfer:
> >>> Am 20.08.2013 15:38, schrieb Laurent Pinchart:
>
Hi Mauro,
On Wednesday 28 August 2013 06:27:52 Mauro Carvalho Chehab wrote:
> Sylwester Nawrocki escreveu:
> > On 08/27/2013 06:00 PM, Mauro Carvalho Chehab wrote:
> > >>> > > The thing is that you're wanting to use the clock register as a
> > >>> > > way to detect that the device got initialized
Em Wed, 28 Aug 2013 11:00:42 +0200
Sylwester Nawrocki escreveu:
> On 08/27/2013 06:00 PM, Mauro Carvalho Chehab wrote:
> >>> > > The thing is that you're wanting to use the clock register as a way to
> >>> > > detect that the device got initialized.
> >> >
> >> > I'm not sure to follow you there
On 08/27/2013 06:00 PM, Mauro Carvalho Chehab wrote:
>>> > > The thing is that you're wanting to use the clock register as a way to
>>> > > detect that the device got initialized.
>> >
>> > I'm not sure to follow you there, I don't think that's how I want to use
>> > the
>> > clock. Could you pl
Em Tue, 27 Aug 2013 17:27:52 +0200
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Tuesday 27 August 2013 11:08:58 Mauro Carvalho Chehab wrote:
> > Laurent Pinchart escreveu:
> > > On Monday 26 August 2013 11:09:33 Mauro Carvalho Chehab wrote:
> > > > Guennadi Liakhovetski escreveu:
>
> > Ok,
Hi Mauro,
On Tuesday 27 August 2013 11:08:58 Mauro Carvalho Chehab wrote:
> Laurent Pinchart escreveu:
> > On Monday 26 August 2013 11:09:33 Mauro Carvalho Chehab wrote:
> > > Guennadi Liakhovetski escreveu:
[snip]
> > > > Ok, let's try to summerise:
> > > >
> > > > * background: many camera
Em Tue, 27 Aug 2013 14:52:19 +0200
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Monday 26 August 2013 11:09:33 Mauro Carvalho Chehab wrote:
> > Guennadi Liakhovetski escreveu:
> > > On Sat, 24 Aug 2013, Mauro Carvalho Chehab wrote:
> > > > Em Fri, 23 Aug 2013 00:15:52 +0200
> > > > Frank Schäf
Hi Mauro,
On Monday 26 August 2013 11:09:33 Mauro Carvalho Chehab wrote:
> Guennadi Liakhovetski escreveu:
> > On Sat, 24 Aug 2013, Mauro Carvalho Chehab wrote:
> > > Em Fri, 23 Aug 2013 00:15:52 +0200
> > > Frank Schäfer escreveu:
> > > > Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
> > > >
Em Mon, 26 Aug 2013 15:54:16 +0200 (CEST)
Guennadi Liakhovetski escreveu:
> On Sat, 24 Aug 2013, Mauro Carvalho Chehab wrote:
>
> > Em Fri, 23 Aug 2013 00:15:52 +0200
> > Frank Schäfer escreveu:
> >
> > > Hi Sylwester,
> > >
> > > Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
> > > > Hi Fr
On Sat, 24 Aug 2013, Mauro Carvalho Chehab wrote:
> Em Fri, 23 Aug 2013 00:15:52 +0200
> Frank Schäfer escreveu:
>
> > Hi Sylwester,
> >
> > Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
> > > Hi Frank,
> > >
> > > On 08/21/2013 10:39 PM, Frank Schäfer wrote:
> > >> Am 20.08.2013 18:34, schr
On 08/24/2013 09:03 PM, Mauro Carvalho Chehab wrote:
Em Fri, 23 Aug 2013 00:15:52 +0200
Frank Schäfer escreveu:
Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
On 08/21/2013 10:39 PM, Frank Schäfer wrote:
Am 20.08.2013 18:34, schrieb Frank Schäfer:
Am 20.08.2013 15:38, schrieb Laurent Pinch
Em Fri, 23 Aug 2013 00:15:52 +0200
Frank Schäfer escreveu:
> Hi Sylwester,
>
> Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
> > Hi Frank,
> >
> > On 08/21/2013 10:39 PM, Frank Schäfer wrote:
> >> Am 20.08.2013 18:34, schrieb Frank Schäfer:
> >>> Am 20.08.2013 15:38, schrieb Laurent Pinchart:
Em Tue, 20 Aug 2013 18:39:33 +0200
Frank Schäfer escreveu:
> Am 20.08.2013 17:31, schrieb Mauro Carvalho Chehab:
> > Em Tue, 20 Aug 2013 15:38:57 +0200
> > Laurent Pinchart escreveu:
> >
> >> Hi Mauro,
> >>
> >> On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
> >>> Em Sun, 18 Aug
Hi Sylwester,
Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
> Hi Frank,
>
> On 08/21/2013 10:39 PM, Frank Schäfer wrote:
>> Am 20.08.2013 18:34, schrieb Frank Schäfer:
>>> Am 20.08.2013 15:38, schrieb Laurent Pinchart:
Hi Mauro,
On Sunday 18 August 2013 12:20:08 Mauro Carvalho Ch
Hi Frank,
On 08/21/2013 10:39 PM, Frank Schäfer wrote:
Am 20.08.2013 18:34, schrieb Frank Schäfer:
Am 20.08.2013 15:38, schrieb Laurent Pinchart:
Hi Mauro,
On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
Am 17.08.2013
Am 20.08.2013 18:34, schrieb Frank Schäfer:
> Am 20.08.2013 15:38, schrieb Laurent Pinchart:
>> Hi Mauro,
>>
>> On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
>>> Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski:
Am 20.08.2013 17:31, schrieb Mauro Carvalho Chehab:
> Em Tue, 20 Aug 2013 15:38:57 +0200
> Laurent Pinchart escreveu:
>
>> Hi Mauro,
>>
>> On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
>>> Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
Am 17.08.2013 12:51, schrieb
Am 20.08.2013 15:38, schrieb Laurent Pinchart:
> Hi Mauro,
>
> On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
>> Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
>>> Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski:
Hi Frank,
As I mentioned on the list, I'm cur
Em Tue, 20 Aug 2013 15:38:57 +0200
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
> > Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
> > > Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski:
> > > > Hi Frank,
> > > > As I men
Hi Mauro,
On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
> Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
> > Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski:
> > > Hi Frank,
> > > As I mentioned on the list, I'm currently on a holiday, so, replying
> > > briefly.
>
t; Frank
> > Thanks
> > Guennadi
> >
> >
> > -Original Message-
> > From: "Frank Schäfer"
> > To: Guennadi Liakhovetski , Linux Media Mailing List
> >
> > Sent: Fr., 16 Aug 2013 21:03
> > Subject: em28xx + ov2640 and
> Thanks
> Guennadi
>
>
> -Original Message-
> From: "Frank Schäfer"
> To: Guennadi Liakhovetski , Linux Media Mailing List
>
> Sent: Fr., 16 Aug 2013 21:03
> Subject: em28xx + ov2640 and v4l2-clk
>
> Hi Guennadi,
>
> since commit 9aea470b
--Original Message-
From: "Frank Schäfer"
To: Guennadi Liakhovetski , Linux Media Mailing List
Sent: Fr., 16 Aug 2013 21:03
Subject: em28xx + ov2640 and v4l2-clk
Hi Guennadi,
since commit 9aea470b399d797e88be08985c489855759c6c60 "soc-camera:
switch I2C subdevice drivers to use v4l
Hi Guennadi,
since commit 9aea470b399d797e88be08985c489855759c6c60 "soc-camera:
switch I2C subdevice drivers to use v4l2-clk", the em28xx driver fails
to register the ov2640 subdevice (if needed).
The reason is that v4l2_clk_get() fails in ov2640_probe().
Does the em28xx driver have to register a
41 matches
Mail list logo
