Re: fix PCTV 461e tuner I2C binding

2014-07-08 Thread Shuah Khan
Moikka Antti, On 07/07/2014 09:45 PM, Antti Palosaari wrote: Moikka Shuah Why are we unregistering i2c devices and dvb in this resume path? Looks incorrect to me. I don't know. Original patch I send was a bit different and tuner was removed only during em28xx_dvb_fini()

Re: fix PCTV 461e tuner I2C binding

2014-07-08 Thread Antti Palosaari
On 07/08/2014 04:55 PM, Shuah Khan wrote: Moikka Antti, On 07/07/2014 09:45 PM, Antti Palosaari wrote: Moikka Shuah Why are we unregistering i2c devices and dvb in this resume path? Looks incorrect to me. I don't know. Original patch I send was a bit different and tuner was removed only

Re: fix PCTV 461e tuner I2C binding

2014-07-08 Thread Shuah Khan
On 07/08/2014 12:51 PM, Antti Palosaari wrote: On 07/08/2014 04:55 PM, Shuah Khan wrote: Moikka Antti, On 07/07/2014 09:45 PM, Antti Palosaari wrote: Moikka Shuah Why are we unregistering i2c devices and dvb in this resume path? Looks incorrect to me. I don't know. Original patch I send

fix PCTV 461e tuner I2C binding

2014-07-07 Thread Shuah Khan
Mauro/Antti, I have been looking at the following commit to drivers/media/usb/em28xx/em28xx-dvb.c a83b93a7480441a47856dc9104bea970e84cda87 +++ b/drivers/media/usb/em28xx/em28xx-dvb.c @@ -1630,6 +1630,7 @@ static int em28xx_dvb_resume(struct em28xx *dev) em28xx_info(Resuming DVB

Re: fix PCTV 461e tuner I2C binding

2014-07-07 Thread Antti Palosaari
Moikka Shuah On 07/08/2014 02:34 AM, Shuah Khan wrote: Mauro/Antti, I have been looking at the following commit to drivers/media/usb/em28xx/em28xx-dvb.c a83b93a7480441a47856dc9104bea970e84cda87 +++ b/drivers/media/usb/em28xx/em28xx-dvb.c @@ -1630,6 +1630,7 @@ static int

[PATCH FOR 3.14] em28xx-dvb: fix PCTV 461e tuner I2C binding

2014-02-12 Thread Antti Palosaari
Add missing m88ts2022 module reference counts as removing that module is not allowed when it is used by em28xx-dvb module. That same module was not unregistered correctly, fix it too. Error cases validated by returning errors from m88ds3103, m88ts2022 and a8293 probe(). Signed-off-by: Antti