Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
which determined message size using sizeof rather than hardcoded constants.
Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
message too so the sizeof was bogus in this case.
All other uses of siz
On Saturday 30 January 2010 17:26:51 Martin Fuzzey wrote:
> Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
> which determined message size using sizeof rather than hardcoded constants.
>
> Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
> mess
Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
which determined message size using sizeof rather than hardcoded constants.
Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
message too so the sizeof was bogus in this case.
All other uses of siz
On Sat, Jan 30, 2010 at 04:43:19PM +0100, Martin Fuzzey wrote:
> Greg KH wrote:
> > Video developers, any comments?
> >
> > Jef, were you able to narrow it down to the actual patch that caused the
> > problem.
> >
> >
> Indeed it was my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
>
> I some
Greg KH wrote:
> Video developers, any comments?
>
> Jef, were you able to narrow it down to the actual patch that caused the
> problem.
>
>
Indeed it was my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
I somehow missed the email from Laurent back in August about this.
Am checking the rest
On Sat, Jan 30, 2010 at 12:03:09AM +, Jef Treece wrote:
> Here's a link to the previous message:
> http://www.mail-archive.com/linux-media@vger.kernel.org/msg14330.html
Great.
Video developers, any comments?
Jef, were you able to narrow it down to the actual patch that caused the
problem.
On Fri, Jan 29, 2010 at 12:45:37AM +, Jef Treece wrote:
> I reported a regression and provided a fix a few months ago for a
> regression in pwc_set_shutter_speed that was introduced in approx
> April 2009. Is that regression going to get fixed? It's really causing
> a lot of pain because it mea