Re: macbook webcam no longer works on .35-rc
On Mon, 2010-07-05 at 10:23 +0200, Laurent Pinchart wrote:
Could you please test the following patch when you will have time ?
That fixes it, thank you.
johannes
diff --git a/drivers/media/video/uvc/uvc_ctrl.c
b/drivers/media/video/uvc/uvc_ctrl.c
index 9af4d47..a350fad 100644
--- a/drivers/media/video/uvc/uvc_ctrl.c
+++ b/drivers/media/video/uvc/uvc_ctrl.c
@@ -122,8 +122,8 @@ static struct uvc_control_info uvc_ctrls[] = {
.selector = UVC_PU_POWER_LINE_FREQUENCY_CONTROL,
.index = 10,
.size = 1,
- .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_RANGE
- | UVC_CONTROL_RESTORE,
+ .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_CUR
+ | UVC_CONTROL_GET_DEF | UVC_CONTROL_RESTORE,
},
{
.entity = UVC_GUID_UVC_PROCESSING,
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macbook webcam no longer works on .35-rc
Hi Johannes, On Monday 12 July 2010 14:36:26 Johannes Berg wrote: On Mon, 2010-07-05 at 10:23 +0200, Laurent Pinchart wrote: Could you please test the following patch when you will have time ? That fixes it, thank you. The fix has been applied to http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-next.git;a=shortlog and should end up in the next 2.6.35-rc. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macbook webcam no longer works on .35-rc
Hi Johannes, On Friday 02 July 2010 09:26:15 Johannes Berg wrote: On Wed, 2010-06-30 at 23:11 +0200, Johannes Berg wrote: I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). Does it prevent your camera from working, or does it just print annoying messages to the kernel log ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macbook webcam no longer works on .35-rc
Hi Johannes, On Friday 02 July 2010 09:26:15 Johannes Berg wrote: On Wed, 2010-06-30 at 23:11 +0200, Johannes Berg wrote: I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). Is that the only error messages printed by the driver to the kernel log, or do you get other similar ones ? If you get others, please report them. Could you please send me the output of lsusb -v for your camera ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macbook webcam no longer works on .35-rc
On Mon, 2010-07-05 at 09:28 +0200, Laurent Pinchart wrote: Hi Johannes, On Friday 02 July 2010 09:26:15 Johannes Berg wrote: On Wed, 2010-06-30 at 23:11 +0200, Johannes Berg wrote: I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). Does it prevent your camera from working, or does it just print annoying messages to the kernel log ? It prevents it from working, and it's the only error message since the tool/driver/libv4l/whatever just gives up after getting -EIO. lsusb -v is: Bus 001 Device 002: ID 05ac:8507 Apple, Inc. Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize064 idVendor 0x05ac Apple, Inc. idProduct 0x8507 bcdDevice4.18 iManufacturer 1 Apple Inc. iProduct2 Built-in iSight iSerial 3 8J8B41B6T40U3A00 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 642 bNumInterfaces 3 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 500mA Interface Association: bLength 8 bDescriptorType11 bFirstInterface 0 bInterfaceCount 2 bFunctionClass 14 Video bFunctionSubClass 3 Video Interface Collection bFunctionProtocol 0 iFunction 2 Built-in iSight Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber0 bAlternateSetting 0 bNumEndpoints 1 bInterfaceClass14 Video bInterfaceSubClass 1 Video Control bInterfaceProtocol 0 iInterface 2 Built-in iSight VideoControl Interface Descriptor: bLength13 bDescriptorType36 bDescriptorSubtype 1 (HEADER) bcdUVC 1.00 wTotalLength 51 dwClockFrequency4.00MHz bInCollection 1 baInterfaceNr( 0) 1 VideoControl Interface Descriptor: bLength18 bDescriptorType36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 1 wTerminalType 0x0201 Camera Sensor bAssocTerminal 0 iTerminal 0 wObjectiveFocalLengthMin 0 wObjectiveFocalLengthMax 0 wOcularFocalLength0 bControlSize 3 bmControls 0x000a Auto-Exposure Mode Exposure Time (Absolute) VideoControl Interface Descriptor: bLength 9 bDescriptorType36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 2 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bSourceID 3 iTerminal 0 VideoControl Interface Descriptor: bLength11 bDescriptorType36 bDescriptorSubtype 5 (PROCESSING_UNIT) Warning: Descriptor too short bUnitID 3 bSourceID 1 wMaxMultiplier 0 bControlSize2 bmControls 0x157f Brightness Contrast Hue Saturation Sharpness Gamma White Balance Temperature Backlight Compensation Power Line Frequency White Balance Temperature, Auto iProcessing 0 bmVideoStandards 0x 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes3 Transfer TypeInterrupt Synch Type None Usage Type Data wMaxPacketSize 0x0008 1x 8 bytes bInterval 6 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 VideoStreaming Interface Descriptor: bLength14
Re: macbook webcam no longer works on .35-rc
Hi Johannes,
On Monday 05 July 2010 10:15:53 Johannes Berg wrote:
On Mon, 2010-07-05 at 09:28 +0200, Laurent Pinchart wrote:
Hi Johannes,
On Friday 02 July 2010 09:26:15 Johannes Berg wrote:
On Wed, 2010-06-30 at 23:11 +0200, Johannes Berg wrote:
I'm pretty sure this was a regression in .34, but haven't checked
right now, can bisect when I find time but wanted to inquire first
if somebody had ideas. All I get is:
[57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3)
: -32 (exp. 1).
Does it prevent your camera from working, or does it just print
annoying messages to the kernel log ?
It prevents it from working, and it's the only error message since the
tool/driver/libv4l/whatever just gives up after getting -EIO.
lsusb -v is:
[snip]
Thanks.
PS: I'll be on vacation until Saturday starting right now.
Could you please test the following patch when you will have time ?
diff --git a/drivers/media/video/uvc/uvc_ctrl.c
b/drivers/media/video/uvc/uvc_ctrl.c
index 9af4d47..a350fad 100644
--- a/drivers/media/video/uvc/uvc_ctrl.c
+++ b/drivers/media/video/uvc/uvc_ctrl.c
@@ -122,8 +122,8 @@ static struct uvc_control_info uvc_ctrls[] = {
.selector = UVC_PU_POWER_LINE_FREQUENCY_CONTROL,
.index = 10,
.size = 1,
- .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_RANGE
- | UVC_CONTROL_RESTORE,
+ .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_CUR
+ | UVC_CONTROL_GET_DEF | UVC_CONTROL_RESTORE,
},
{
.entity = UVC_GUID_UVC_PROCESSING,
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macbook webcam no longer works on .35-rc
On Wed, 2010-06-30 at 23:11 +0200, Johannes Berg wrote: I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). Didn't have to bisect it. The problem is caused by commit 59529081e092506edb81a42d914e2d0522f65ca7 Author: Laurent Pinchart laurent.pinch...@ideasonboard.com Date: Sat Jan 23 06:30:20 2010 -0300 V4L/DVB: uvcvideo: Cache control min, max, res and def query results which reverts cleanly, but then the driver doesn't compile and one also needs to revert commit cf7a50eeb6f462a0b7d1619fcb27a727a2981769 Author: Laurent Pinchart laurent.pinch...@ideasonboard.com Date: Sun Apr 25 16:27:14 2010 -0300 V4L/DVB: uvcvideo: Prevent division by 0 when control step value is 0 and commit e54532e591cd5b9ce77dbc8d9786ae9f600f101a Author: Laurent Pinchart laurent.pinch...@ideasonboard.com Date: Sat Jan 23 07:07:53 2010 -0300 V4L/DVB: uvcvideo: Clamp control values to the minimum and maximum values in that order. These are commits introduced in the .34/.35 cycles. Please fix. Can we revert things that are regressions pre-dating the current kernel version? johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
macbook webcam no longer works on .35-rc
I'm pretty sure this was a regression in .34, but haven't checked right now, can bisect when I find time but wanted to inquire first if somebody had ideas. All I get is: [57372.078968] uvcvideo: Failed to query (130) UVC control 5 (unit 3) : -32 (exp. 1). johannes -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
