Hello Mauro Carvalho Chehab,
The patch 269d91f53fe3: "[media] vp702x: comment dead code" from Apr
29, 2015, leads to the following static checker warning:
drivers/media/usb/dvb-usb/dvb-usb-remote.c:128
legacy_dvb_usb_read_remote_control()
error: uninitialized sym
Since the first version of this driver, the remote controller
code is disabled, adding an early return inside vp702x_rc_query().
Let's disable the code with #if 0, to remove this warning:
drivers/media/usb/dvb-usb/vp702x.c:268 vp702x_rc_query() info: ignoring
unreachable code.
Signed-off-by:
drivers/media/usb/dvb-usb/vp702x.c:70:5: warning: no previous prototype for
'vp702x_usb_out_op_unlocked' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb/vp702x.c:89:5: warning: no previous prototype for
'vp702x_usb_out_op' [-Wmissing-prototypes]
Signed-off-by: Mauro Carvalho Chehab
-usb/vp702x-fe.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x-fe.c
b/drivers/media/dvb/dvb-usb/vp702x-fe.c
index 8ff5aab..fa0b811 100644
--- a/drivers/media/dvb/dvb-usb/vp702x-fe.c
+++ b/drivers/media/dvb/dvb-usb/vp702x-fe.c
-usb/vp702x-fe.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x-fe.c
b/drivers/media/dvb/dvb-usb/vp702x-fe.c
index 8ff5aab..fa0b811 100644
--- a/drivers/media/dvb/dvb-usb/vp702x-fe.c
+++ b/drivers/media/dvb/dvb-usb/vp702x-fe.c
On Fri, 26 Aug 2011 00:11:15 +0200
Florian Mickler flor...@mickler.org wrote:
In my previous change to this driver, I was not aware, that
dvb_usb_device_init
calls the frontend_attach routine which needs a transfer
buffer. So we can not setup anything private in the probe routine beforehand
/media/dvb/dvb-usb/vp702x-fe.c | 92 +++
drivers/media/dvb/dvb-usb/vp702x.c| 211 ++---
drivers/media/dvb/dvb-usb/vp702x.h| 13 ++-
3 files changed, 193 insertions(+), 123 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x-fe.c
b/drivers
Hi,
On Wed, 3 Aug 2011 09:39:46 +0200 (CEST)
Patrick Boettcher pboettc...@kernellabs.com wrote:
Hi Florian,
I'm not sure whether I still have exactly this box. There were two
versions and I got rid of at least one of them.
I moved recently into a new house and right now a lot of
On Thu, Aug 04, 2011 at 12:21:29PM +0200, Florian Mickler wrote:
Mauro, what to do?
Apply the fix which Tino tested, perhaps? :P (obviously).
The bug is present in 3.0 so it should be tagged for stable as well.
regards,
dan carpenter
--
To unsubscribe from this list: send the line
Hi Florian,
On Tue, 2 Aug 2011, Florian Mickler wrote:
Hi Mauro! Hi Patrick!
I realized this morning, that I broke vp702x (if it was working before)
with my last patchseries. Sorry. :(
I'm gonna follow up on this mail with a patch to hopefully fix it, but
if nobody can test it, I'd say
Hi Mauro! Hi Patrick!
I realized this morning, that I broke vp702x (if it was working before)
with my last patchseries. Sorry. :(
I'm gonna follow up on this mail with a patch to hopefully fix it, but
if nobody can test it, I'd say to rather revert my patchseries
for v3.1 . It will then still
mutex to serialize that buffer but instead need to use the
dvb_usb_device's usb_mutex.
Note: Compile tested only!
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x-fe.c | 30 -
drivers/media/dvb/dvb-usb/vp702x.c| 220
Hi!
This is a patchset modifying the vp702x to get rid of on-stack dma buffers
and additionally preallocating the used buffers on device probe.
I can not test these patches, as I don't have the hardware.
They compile though...
I made it a bit more finegrained for easier review.
If someone
This sets up a buffer and a mutex protecting that buffer in
the struct vp702x_device_state.
The definition of struct vp702x_device_state is moved into the header
in order to use the buffer also in the frontend.
Signed-off-by: Florian Mickler flor...@mickler.org
---
Some whitespace, one linebreak and one unneded variable
initialization...
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x.c | 23 ---
1 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x.c
We need a state struct for the dvb_usb_device.
In order to reduce confusion we rename the vp702x_state struct.
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git
Otherwise it is not obvious that vp702x_usb_in_op or vp702x_usb_out_op
will not interfere with any vp702x_usb_inout_op.
Note: This change is tested to compile only, as I don't have the
hardware.
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x.c | 37
Note: This change is tested to compile only as I don't have the
hardware.
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x-fe.c | 69 +
1 files changed, 35 insertions(+), 34 deletions(-)
diff --git a/drivers/media/dvb/dvb
: This change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x-fe.c | 89 +++--
drivers/media/dvb/dvb-usb/vp702x.c| 78 ++--
2 files changed, 124
struct vp702x_device_state.power_state is nowhere referenced.
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x.h
Note: This change is tested to compile only as I don't have the
hardware.
Signed-off-by: Florian Mickler flor...@mickler.org
---
drivers/media/dvb/dvb-usb/vp702x.c | 59 +--
1 files changed, 35 insertions(+), 24 deletions(-)
diff --git
21 matches
Mail list logo
