Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Hans Verkuil
On Monday 16 March 2009 00:25:44 Trent Piepho wrote: On Sun, 15 Mar 2009, Andy Walls wrote: On Sun, 2009-03-15 at 10:28 -0700, Trent Piepho wrote: Why are the i2c addresses from various i2c chips moved into the bttv driver? Doesn't it make more sense that the addresses for chip X

Re: RFC: ov7670 soc-camera driver

2009-03-16 Thread Hans Verkuil
On Sunday 15 March 2009 23:23:38 Jonathan Corbet wrote: On Sun, 15 Mar 2009 17:10:01 + Jonathan Cameron ji...@cam.ac.uk wrote: The primary control on this chip related to shutter rate is actualy the frame rate. There are rather complex (and largerly undocumented) interactions between

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Jean Delvare
Hi Trent, On Sun, 15 Mar 2009 16:46:36 -0700 (PDT), Trent Piepho wrote: On Sun, 15 Mar 2009, Andy Walls wrote: But the specific problem that Hans' brings up is precisely a Linux kernel I2C subsystem *software* prohibition on two i2c_clients binding to the same address on the same adapter.

Re: [PATCH] add new frequency table for Strasbourg, France

2009-03-16 Thread BOUWSMA Barry
On Sat, 14 Mar 2009, Benjamin Zores wrote: Attached patch updates the current dvb-t/fr-Strasbourg file with relevant transponders frequency values. Hi, I have a problem with some of these values. Well, to be truthful, all of these values. I don't have a good 'net connection to be able to

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Mauro Carvalho Chehab
On Sun, 15 Mar 2009 18:53:13 +0100 Jean Delvare kh...@linux-fr.org wrote: On Sun, 15 Mar 2009 10:42:41 -0700 (PDT), Trent Piepho wrote: On Sun, 15 Mar 2009, Jean Delvare wrote: On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote: This is the typical multifunction device problem. It

Re: [PATCH v2 1/4] pxa_camera: Enforce YUV422P frame sizes to be 16 multiples

2009-03-16 Thread Guennadi Liakhovetski
On Sat, 14 Mar 2009, Robert Jarzmik wrote: Due to DMA constraints, the DMA chain always transfers bytes from the QIF fifos to memory in 8 bytes units. In planar formats, that could mean 0 padding between Y and U plane (and between U and V plane), which is against YUV422P standard.

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Mauro Carvalho Chehab
On Sun, 15 Mar 2009 18:53:13 +0100 Jean Delvare kh...@linux-fr.org wrote: On Sun, 15 Mar 2009 10:42:41 -0700 (PDT), Trent Piepho wrote: On Sun, 15 Mar 2009, Jean Delvare wrote: On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote: This is the typical multifunction device problem. It

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Mauro Carvalho Chehab
On Sun, 15 Mar 2009 13:24:00 +0100 Hans Verkuil hverk...@xs4all.nl wrote: Hi Mauro, Can you review my ~hverkuil/v4l-dvb-bttv2 tree? It converts this driver to v4l2_subdev, and as far as I can see it works and should probe all the different audio devices in the correct and safe order.

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Hans Verkuil
Hi Hans, On Sun, 15 Mar 2009 19:53:06 +0100 Hans Verkuil hverk...@xs4all.nl wrote: On Sunday 15 March 2009 18:28:42 Trent Piepho wrote: On Sun, 15 Mar 2009, Hans Verkuil wrote: On Sunday 15 March 2009 17:04:43 Trent Piepho wrote: On Sun, 15 Mar 2009, Hans Verkuil wrote: Hi

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Hans Verkuil
On Sun, 15 Mar 2009 13:24:00 +0100 Hans Verkuil hverk...@xs4all.nl wrote: Hi Mauro, Can you review my ~hverkuil/v4l-dvb-bttv2 tree? It converts this driver to v4l2_subdev, and as far as I can see it works and should probe all the different audio devices in the correct and safe order.

Re: [PATCH v2 2/4] pxa_camera: remove YUV planar formats hole

2009-03-16 Thread Guennadi Liakhovetski
On Sat, 14 Mar 2009, Robert Jarzmik wrote: All planes were PAGE aligned (ie. 4096 bytes aligned). This is not consistent with YUV422 format, which requires Y, U and V planes glued together. The new implementation forces the alignement on 8 bytes (DMA requirement), which is almost always the

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Mauro Carvalho Chehab
On Mon, 16 Mar 2009 11:44:12 +0100 (CET) Hans Verkuil hverk...@xs4all.nl wrote: What new module parameters did you add? tvaudio to override the 'needs_tvaudio' from the card definition. At least on the first kernel with the new driver, IMO, the default should for this option should

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Jean Delvare
Hi Mauro, On Mon, 16 Mar 2009 06:34:02 -0300, Mauro Carvalho Chehab wrote: On Sun, 15 Mar 2009 18:53:13 +0100 Jean Delvare kh...@linux-fr.org wrote: On Sun, 15 Mar 2009 10:42:41 -0700 (PDT), Trent Piepho wrote: You can also split the device into multiple devices. Most SoCs have one

Re: [PATCH v2 3/4] pxa_camera: Redesign DMA handling

2009-03-16 Thread Guennadi Liakhovetski
On Sat, 14 Mar 2009, Robert Jarzmik wrote: The DMA transfers in pxa_camera showed some weaknesses in multiple queued buffers context : - poll/select problem The bug shows up with capture_example tool from v4l2 hg tree. The process just stalls on a select timeout. - multiple

Re: [PATCH v2 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-16 Thread Guennadi Liakhovetski
On Sat, 14 Mar 2009, Robert Jarzmik wrote: The last buffer queued will often overrun, as the DMA chain is finished, and the time the dma irq handler is activated, the QIF fifos are filled by the sensor. The fix is to ignore the overrun condition on the last queued buffer, and restart the

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Andy Walls
On Sun, 2009-03-15 at 13:44 +0100, Hans Verkuil wrote: Hi Mauro, Jean, When converting the bttv driver to v4l2_subdev I found one probing conflict between tvaudio and ir-kbd-i2c: address 0x96 (or 0x4b in 7-bit notation). It turns out that this is one and the same PIC16C54 device used on

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Mauro Carvalho Chehab
On Mon, 16 Mar 2009 08:09:44 -0300 Mauro Carvalho Chehab mche...@infradead.org wrote: Can you review my ~hverkuil/v4l-dvb-bttv2 tree? Ok, it was not that hard. It follows my comments. --- a/linux/drivers/media/video/bt8xx/bttv-cards.cSun Mar 15 10:53:32 2009 +0100 +++

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Hans Verkuil
On Sun, 2009-03-15 at 13:44 +0100, Hans Verkuil wrote: Hi Mauro, Jean, When converting the bttv driver to v4l2_subdev I found one probing conflict between tvaudio and ir-kbd-i2c: address 0x96 (or 0x4b in 7-bit notation). It turns out that this is one and the same PIC16C54 device used on

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Hans Verkuil
On Mon, 16 Mar 2009 08:09:44 -0300 Mauro Carvalho Chehab mche...@infradead.org wrote: Can you review my ~hverkuil/v4l-dvb-bttv2 tree? Ok, it was not that hard. It follows my comments. --- a/linux/drivers/media/video/bt8xx/bttv-cards.c Sun Mar 15 10:53:32 2009 +0100 +++

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Mauro Carvalho Chehab
On Mon, 16 Mar 2009 12:18:01 +0100 Jean Delvare kh...@linux-fr.org wrote: With the current approach, we need to bind two completely different things inside the same i2c module, which may result in a very poor design. I really don't see any problem there. There are many drivers (i2c or

Re: [linux-dvb] EC168 and MT2060

2009-03-16 Thread t.Hgch
Hi, I opened de device and it is definitely an EC168 and a MXL5003s, also to my surprise on the chipset it is written DUTV007 instead of DUTV002, which was the model number that was written in the package. However when scanning I get errors and only finds about a third of available services at

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Hans Verkuil
Based on this principle, IMO, the probing function should, by default, probe for tvaudio, if it doesn't find another audio device. You may eventually ask for people to report, to warn us that the board entry is broken, but we shouln't intentionally break a device that we're almost

Re: [linux-dvb] FusionHDTV7 and v4l causes kernel panic

2009-03-16 Thread Steven Toth
Timothy D. Lenz wrote: Using kernel 2.6.26.8 and v4l from a few days ago. When I modprobe cx23885 to load the drivers, I get kernel panic We'll need the oops. - Steve -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Mauro Carvalho Chehab
On Mon, 16 Mar 2009 14:04:19 +0100 (CET) Hans Verkuil hverk...@xs4all.nl wrote: Based on this principle, IMO, the probing function should, by default, probe for tvaudio, if it doesn't find another audio device. You may eventually ask for people to report, to warn us that the

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Jean Delvare
Hi Mauro, On Mon, 16 Mar 2009 09:52:37 -0300, Mauro Carvalho Chehab wrote: On Mon, 16 Mar 2009 12:18:01 +0100 Jean Delvare kh...@linux-fr.org wrote: I really don't see any problem there. There are many drivers (i2c or not) in the kernel which do exactly this and this works just fine. We

Re: [PULL] http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2/

2009-03-16 Thread Devin Heitmueller
On Mon, Mar 16, 2009 at 3:58 AM, Hans Verkuil hverk...@xs4all.nl wrote: Looks great! I have one small final note (doesn't prevent this from going in): In au8522_decoder.c you can remove the 'normal_i2c[]' array and the I2C_CLIENT_INSMOD macro. It's only relevant for kernels 2.6.22. Note

Re: RFC: ov7670 soc-camera driver

2009-03-16 Thread Jonathan Cameron
Guennadi Liakhovetski wrote: On Sun, 15 Mar 2009, Hans Verkuil wrote: On Sunday 15 March 2009 19:50:39 Guennadi Liakhovetski wrote: On Sun, 15 Mar 2009, Jonathan Cameron wrote: From: Jonathan Cameron ji...@cam.ac.uk OV7670 driver for soc-camera interfaces. Much appreciated, thanks! ---

Re: RFC: ov7670 soc-camera driver

2009-03-16 Thread Jonathan Cameron
Jonathan Corbet wrote: On Sun, 15 Mar 2009 17:10:01 + Jonathan Cameron ji...@cam.ac.uk wrote: The primary control on this chip related to shutter rate is actualy the frame rate. There are rather complex (and largerly undocumented) interactions between this setting and the auto

Re: [linux-dvb] EC168 and MT2060

2009-03-16 Thread Antti Palosaari
Tanguy PRUVOT wrote: There is a Linux EC168 (with MxL) driver available Where can i find it ? http://linuxtv.org/hg/~anttip/ec168/ Antti -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Mauro Carvalho Chehab
I need to be short, since I'm about to travel. On Mon, 16 Mar 2009 15:28:02 +0100 Jean Delvare kh...@linux-fr.org wrote: Ah yeah, now I remember. You're the one who considers 2.6.18 a bleeding edge kernel suitable for upstream development. This explains a lot. I have 3 separated

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Hans Verkuil
On Mon, 16 Mar 2009 14:04:19 +0100 (CET) Hans Verkuil hverk...@xs4all.nl wrote: Based on this principle, IMO, the probing function should, by default, probe for tvaudio, if it doesn't find another audio device. You may eventually ask for people to report, to warn us that the

Re: S4 hang with uvcvideo causing Unlink after no-IRQ? Controller is probably using the wrong IRQ.

2009-03-16 Thread Brandon Philips
On 16:50 Fri 13 Mar 2009, Alan Stern wrote: On Fri, 13 Mar 2009, Brandon Philips wrote: On 14:03 Fri 13 Mar 2009, Alan Stern wrote: On Fri, 13 Mar 2009, Brandon Philips wrote: Okay, not much information there but it's a start. Here's a more informative patch to try instead.

Re: [PULL] http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2/

2009-03-16 Thread Trent Piepho
On Sun, 15 Mar 2009, Devin Heitmueller wrote: au0828: remove memset calls in v4l2 routines. The userland callers are responsible for clearing the output buffers, so remove the unneeded memset calls. A driver should not assume that _userspace_ has cleared the buffers. In some cases userspace is

Problems with Hauppauge HVR 1600 and cx18 driver

2009-03-16 Thread Corey Taylor
Hi, I just recently bought a Hauppauge Win TV HVR-1600 card and am using it with MythTV running on Ubuntu Intrepid 8.10 64-bit edition. My hardware is an Asus A8N VM-CSM Motherboard with an Athlon 64 single core CPU. I'm using the cx18 driver compiled from Mercurial (as of last weekend) and

Re: [PULL] http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2/

2009-03-16 Thread Devin Heitmueller
On Mon, Mar 16, 2009 at 2:05 PM, Trent Piepho xy...@speakeasy.org wrote: On Sun, 15 Mar 2009, Devin Heitmueller wrote: au0828: remove memset calls in v4l2 routines. The userland callers are responsible for clearing the output buffers, so remove the unneeded memset calls. A driver should not

Re: Problems with Hauppauge HVR 1600 and cx18 driver

2009-03-16 Thread Devin Heitmueller
On Mon, Mar 16, 2009 at 2:10 PM, Corey Taylor johnfiveal...@yahoo.com wrote: Hi, I just recently bought a Hauppauge Win TV HVR-1600 card and am using it with MythTV running on Ubuntu Intrepid 8.10 64-bit edition. My hardware is an Asus A8N VM-CSM Motherboard with an Athlon 64 single core

Re: [PATCH] add new frequency table for Strasbourg, France

2009-03-16 Thread Benjamin Zores
BOUWSMA Barry wrote: First, every frequency is given an offset from the nominal centre frequency of the 8MHz envelope. I am aware this is common in the UK where the switchover is happening gradually so as not to interfere with adjacent analogue services, and I also know that last I checked,

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Hans Verkuil wrote: +++ b/linux/drivers/media/video/bt8xx/bttvp.h Sun Mar 15 13:07:15 2009 +0100 @@ -331,6 +331,7 @@ struct bttv { unsigned int tuner_type; /* tuner chip type */ unsigned int tda9887_conf; unsigned int svhs, dig; + int has_saa6588;

[cron job] v4l-dvb daily build 2.6.22 and up: WARNINGS, 2.6.16-2.6.21: ERRORS

2009-03-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Mon Mar 16 19:00:03 CET 2009 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 11038:626c136ec221 gcc version: gcc

Re: [PATCH v2 3/4] pxa_camera: Redesign DMA handling

2009-03-16 Thread Robert Jarzmik
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: What is QIF? Do you mean Quick Capture Interface - QCI? I also see CIF used in the datasheet, probably, for Capture InterFace, but I don't see QIF anywhere. Also, please explain the first time you use the abbreviation. Also fix it in the

Re: [PATCH] add new frequency table for Strasbourg, France

2009-03-16 Thread wk
Benjamin Zores wrote: BOUWSMA Barry wrote: First, every frequency is given an offset from the nominal centre frequency of the 8MHz envelope. I am aware this is common in the UK where the switchover is happening gradually so as not to interfere with adjacent analogue services, and I also know

Re: [PATCH v2 3/4] pxa_camera: Redesign DMA handling

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Robert Jarzmik wrote: Guennadi Liakhovetski g.liakhovet...@gmx.de writes: What is QIF? Do you mean Quick Capture Interface - QCI? I also see CIF used in the datasheet, probably, for Capture InterFace, but I don't see QIF anywhere. Also, please explain the first time you

no /dev/dvb

2009-03-16 Thread Rolf Schumacher
Hi, dvb professionals, I followed the advices on http://www.linuxtv.org/wiki/index.php/How_to_Obtain%2C_Build_and_Install_V4L-DVB_Device_Drivers#Optional_Pre-Compilation_Steps Build and Installation Instructions downloaded the v4l sources via mercurial, make and sudo make install finished

no /dev/dvb

2009-03-16 Thread Rolf Schumacher
Hi, dvb professionals, I followed the advices on http://www.linuxtv.org/wiki/index.php/How_to_Obtain%2C_Build_and_Install_V4L-DVB_Device_Drivers#Optional_Pre-Compilation_Steps Build and Installation Instructions downloaded the v4l sources via mercurial, make and sudo make install finished

Re: [linux-dvb] Patch for DigitalNow TinyTwin remote.

2009-03-16 Thread Antti Palosaari
hei Stuart, Stuart wrote: First of all, thanks to those involved in getting the TinyTwin working! I haven't found any support for the remote control yet so I would like to offer what I've managed to do so far (in case I've done something wrong as this is the first time I've tried to submit a

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Hans Verkuil
On Monday 16 March 2009 22:40:40 Jean Delvare wrote: On Mon, 16 Mar 2009 12:43:33 -0700 (PDT), Trent Piepho wrote: On Mon, 16 Mar 2009, Jean Delvare wrote: Come on, just look at ir-kbd-i2c and tvaudio again, see how great are these drivers which have been designed on top of the legacy i2c

[PATCH v3 1/4] pxa_camera: Enforce YUV422P frame sizes to be 16 multiples

2009-03-16 Thread Robert Jarzmik
Due to DMA constraints, the DMA chain always transfers bytes from the QCI fifos to memory in 8 bytes units. In planar formats, that could mean 0 padding between Y and U plane (and between U and V plane), which is against YUV422P standard. Therefore, a frame size is required to be a multiple of 16

[PATCH v3 2/4] pxa_camera: Remove YUV planar formats hole

2009-03-16 Thread Robert Jarzmik
All planes were PAGE aligned (ie. 4096 bytes aligned). This is not consistent with YUV422 format, which requires Y, U and V planes glued together. The new implementation forces the alignement on 8 bytes (DMA requirement), which is almost always the case (granted by width x height being a multiple

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Jean Delvare wrote: On Mon, 16 Mar 2009 12:43:33 -0700 (PDT), Trent Piepho wrote: On Mon, 16 Mar 2009, Jean Delvare wrote: Come on, just look at ir-kbd-i2c and tvaudio again, see how great are these drivers which have been designed on top of the legacy i2c binding

Re: Embedded Linux Conference

2009-03-16 Thread Kevin Hilman
Hans Verkuil hverk...@xs4all.nl writes: Just FYI: I'll be attending the Embedded Linux Conference in San Francisco, April 6th-8th (http://www.embeddedlinuxconference.com/elc_2009). This might be a good opportunity to discuss omap and davinci V4L2 issues face-to-face. Let me know if you

Re: Embedded Linux Conference

2009-03-16 Thread Kyungmin Park
Hi, On Tue, Mar 17, 2009 at 7:56 AM, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@deeprootsystems.com [090316 15:52]: Hans Verkuil hverk...@xs4all.nl writes: Just FYI: I'll be attending the Embedded Linux Conference in San Francisco, April 6th-8th

Re: [RFC][PATCH 0/2] Sensor orientation reporting

2009-03-16 Thread Adam Baker
On Monday 16 March 2009, Hans de Goede wrote: Both patches look good to me. A complaint about lack of documentation wouldn't have gone amiss. Unfortunately having just remembered that I should have done that I'm struggling to get the current docbook to compile (So far I've suffered Ubuntu not

Re: Embedded Linux Conference

2009-03-16 Thread Steve Sakoman
On Mon, Mar 16, 2009 at 3:56 PM, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@deeprootsystems.com [090316 15:52]: Hans Verkuil hverk...@xs4all.nl writes: Just FYI: I'll be attending the Embedded Linux Conference in San Francisco, April 6th-8th

Re: [linux-dvb] EC168 and MT2060

2009-03-16 Thread t.Hgch
Hi, I found that my card isn't locking on certain frequencies,Could it be a problem of signal strength? In widows it gets all channels though. Here is the log: [41630.298168] ec100_init [41630.299611] 40 21 ff 00 c6 01 01 00 00 [41630.301225] 40 21 09 00 c6 01 02 00 b1 fe [41630.302605] 40

Re: [linux-dvb] FusionHDTV7 and v4l causes kernel panic

2009-03-16 Thread Timothy D. Lenz
When it panics, there is no log, just a bunch of stuff that that scrolls fast on the main monitor then cold lock. No way to scroll back. I looked at the logs and the ones that are text had nothing about it. - Original Message - From: Steven Toth st...@linuxtv.org To:

Re: Problems with Hauppauge HVR 1600 and cx18 driver

2009-03-16 Thread Andy Walls
On Mon, 2009-03-16 at 15:53 -0700, Corey Taylor wrote: Corey, As far as I know, with ATSC/QAM you typically won't see the same sort of tearing artifacts with a digital source, as those sorts of distortions are usually a product of analog transmission. When you encounter these issues with

Re: [linux-dvb] FusionHDTV7 and v4l causes kernel panic

2009-03-16 Thread Andy Walls
On Mon, 2009-03-16 at 17:46 -0700, Timothy D. Lenz wrote: When it panics, there is no log, just a bunch of stuff that that scrolls fast on the main monitor then cold lock. No way to scroll back. Not even Shift+PageUp ? I looked at the logs and the ones that are text had nothing about

Strange card

2009-03-16 Thread Eduardo Kaftanski
I bought today a card that was packaged as a PICO2000-compatible but I can't get it to work... I read all the archives and wikis I could find but the only one thread with the same card description but the recipe won't work for me. Here is the lspci... is this card supported? 01:0a.0 Multimedia

Re: [PATCH] add new frequency table for Strasbourg, France

2009-03-16 Thread BOUWSMA Barry
On Mon, 16 Mar 2009, wk wrote: Benjamin Zores wrote: BOUWSMA Barry wrote: First, every frequency is given an offset from the nominal centre frequency of the 8MHz envelope. I am aware this is common in the UK where the switchover is happening gradually so as not to interfere

RE: [RFC 3/7] ARM: DaVinci: DM646x Video: THS7303 video amplifier driver

2009-03-16 Thread Subrahmanya, Chaithrika
Hans, Thank you for the comments. Please see my response inline. I have agreed to most of your comments and will do the changes accordingly. Hi Chaithrika, This is the first pass of this i2c driver. Note that several of the comments here also apply to adv7343. OK, will do the

RE: [RFC 2/7] ARM: DaVinci: DM646x Video: ADV7343 video encoder driver

2009-03-16 Thread Subrahmanya, Chaithrika
Hans, Please see my response inline. For the comments common to THS7303 and ADV7343 driver, I will do the changes to both the drivers. Hi Chaithrika, Here is the review of this driver. On Friday 13 March 2009 10:08:39 chaithr...@ti.com wrote: From: Chaithrika U S chaithr...@ti.com