Re: [PATCH 5/9] V4L2: Added Timberdale Logiwin driver

2009-06-06 Thread Alexey Klimov
Hello, Richard i have only two small suggestions. On Fri, Jun 5, 2009 at 5:40 PM, Richard Röjforsrichard.rojfors@mocean-labs.com wrote: V4L2 video capture driver for the logiwin IP on the Timberdale FPGA. The driver uses the Timberdale DMA engine Signed-off-by: Richard Röjfors

Re: [linux-dvb] SDMC DM1105N not being detected

2009-06-06 Thread Igor M. Liplianin
On 5 June 2009 21:41:46 Simon Kenyon wrote: Simon Kenyon wrote: Simon Kenyon wrote: the picture seems to be breaking up badly will revert to my version and see if that fixes it [sorry for the delay. i was away on business] i've checked and your original code, modified to compile and

[PATCH] zr364xx.c: vfree does its own NULL check

2009-06-06 Thread Figo.zhang
vfree() does it's own NULL checking, no need for explicit check before calling it. Signed-off-by: Figo.zhang figo1...@gmail.com --- drivers/media/video/zr364xx.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/zr364xx.c

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: # HG changeset patch # User Eduardo Valentin eduardo.valen...@nokia.com # Date 1243414605 -10800 # Branch export # Node ID 4fb354645426f8b187c2c90cd8528b2518461005 # Parent 142fd6020df3b4d543068155e49a2618140efa49 Device drivers of

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: # HG changeset patch # User Eduardo Valentin eduardo.valen...@nokia.com # Date 1243414605 -10800 # Branch export # Node ID 4fb354645426f8b187c2c90cd8528b2518461005 # Parent

RFC: proposal for new i2c.h macro to initialize i2c address lists on the fly

2009-06-06 Thread Hans Verkuil
Hi all, For video4linux we sometimes need to probe for a single i2c address. Normally you would do it like this: static const unsigned short addrs[] = { addr, I2C_CLIENT_END }; client = i2c_new_probed_device(adapter, info, addrs); This is a bit awkward and I came up with this macro:

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Andy Walls
On Sat, 2009-06-06 at 14:49 +0200, Hans Verkuil wrote: I propose to change the API as follows: #define V4L2_I2C_ADDRS(addr, addrs...) \ ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) Comments? If we decide to go this way, then I need to know soon so that I can make

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Saturday 06 June 2009 17:19:08 Andy Walls wrote: On Sat, 2009-06-06 at 14:49 +0200, Hans Verkuil wrote: I propose to change the API as follows: #define V4L2_I2C_ADDRS(addr, addrs...) \ ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) Comments? If we decide to

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Saturday 06 June 2009 14:49:46 Hans Verkuil wrote: On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: # HG changeset patch # User Eduardo Valentin eduardo.valen...@nokia.com # Date 1243414605 -10800 # Branch export #

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Hans Verkuil wrote: On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: I propose to change the API as follows: #define V4L2_I2C_ADDRS(addr, addrs...) \ ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) struct v4l2_subdev

Re: RFC: proposal for new i2c.h macro to initialize i2c address lists on the fly

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Hans Verkuil wrote: For video4linux we sometimes need to probe for a single i2c address. Normally you would do it like this: static const unsigned short addrs[] = { addr, I2C_CLIENT_END }; client = i2c_new_probed_device(adapter, info, addrs); This is a bit

Re: [PATCH v2] tuner-simple, tveeprom: Add support for the FQ1216LME MK3

2009-06-06 Thread Martin Dauskardt
Am Samstag, 6. Juni 2009 03:59:41 schrieb Andy Walls: Hi, This is version 2 of the patch that: 1. adds explicit support for the FQ1216LME MK3 2. points the tveeprom module to the FQ1216LME MK3 entry for EEPROMs claiming FQ1216LME MK3 and MK5. 3. refactors some code in

[PULL] http://linuxtv.org/hg/~dougsland/em28xx/

2009-06-06 Thread Douglas Schilling Landgraf
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/em28xx for the following: - em28xx: Add Kworld 315 entry - em28xx: set up tda9887_conf in em28xx_card_setup() Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a

Re: [linux-dvb] SDMC DM1105N not being detected

2009-06-06 Thread Simon Kenyon
Igor M. Liplianin wrote: On 5 June 2009 21:41:46 Simon Kenyon wrote: Simon Kenyon wrote: Simon Kenyon wrote: the picture seems to be breaking up badly will revert to my version and see if that fixes it [sorry for the delay. i was away on business] i've checked and your original code,

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Eduardo Valentin
Hi Hans, On Sat, Jun 6, 2009 at 8:09 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Saturday 06 June 2009 14:49:46 Hans Verkuil wrote: On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: # HG changeset patch # User Eduardo

Re: Probably strange bug with usb radio-mr800

2009-06-06 Thread Oliver Neukum
Am Freitag, 5. Juni 2009 00:43:04 schrieb Alexey Klimov: Is there any ideas about different behaviour of device on 32- and 64-bit platforms with the same usb bulk messages? Any input is welcome. Are you running a 32 bit userland? If so, ioctls could be critical. If not, the driver may not be

Re: RFC: proposal for new i2c.h macro to initialize i2c address lists on the fly

2009-06-06 Thread Mauro Carvalho Chehab
Em Sat, 6 Jun 2009 15:00:48 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi all, For video4linux we sometimes need to probe for a single i2c address. Normally you would do it like this: static const unsigned short addrs[] = { addr, I2C_CLIENT_END }; client =

Re: RFC: proposal for new i2c.h macro to initialize i2c address lists on the fly

2009-06-06 Thread Jon Smirl
On Sat, Jun 6, 2009 at 9:00 AM, Hans Verkuilhverk...@xs4all.nl wrote: Hi all, For video4linux we sometimes need to probe for a single i2c address. Normally you would do it like this: Why does video4linux need to probe to find i2c devices? Can't the address be determined by knowing the PCI ID

Re: RFC: proposal for new i2c.h macro to initialize i2c address lists on the fly

2009-06-06 Thread hermann pitton
Hi, Am Samstag, den 06.06.2009, 18:20 -0400 schrieb Jon Smirl: On Sat, Jun 6, 2009 at 9:00 AM, Hans Verkuilhverk...@xs4all.nl wrote: Hi all, For video4linux we sometimes need to probe for a single i2c address. Normally you would do it like this: Why does video4linux need to probe to

Re: [PATCH]videobuf-core.c: add pointer check

2009-06-06 Thread Figo.zhang
On Sun, 2009-06-07 at 09:16 +0800, Figo.zhang wrote: On Wed, 2009-06-03 at 10:01 +0800, Figo.zhang wrote: add poiter check for videobuf_queue_core_init(). any guys who write a v4l driver, pass a NULL pointer or a non-inintial pointer to the first parameter such as