Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

2010-07-31 Thread Christoph Bartelmus
Hi Maxim, on 31 Jul 10 at 01:01, Maxim Levitsky wrote: On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: [...] +#define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x0023, __u32) If you really want this new ioctl, then it should be clarified how it behaves in relation to

Handling of large keycodes

2010-07-31 Thread Dmitry Torokhov
Hi Mauro, I finally got a chance to review the patches adding handling of large scancodes to input core and there are a few things with this approach that I do not like. First of all I do not think that we should be working with scancode via a pointer as it requires additional compat handling

Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 10:10 +0200, Christoph Bartelmus wrote: Hi Maxim, on 31 Jul 10 at 01:01, Maxim Levitsky wrote: On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: [...] +#define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x0023, __u32) If you really want this new

Re: Handling of large keycodes

2010-07-31 Thread Mauro Carvalho Chehab
Hi Dmitry, Em 31-07-2010 06:19, Dmitry Torokhov escreveu: Hi Mauro, I finally got a chance to review the patches adding handling of large scancodes to input core and there are a few things with this approach that I do not like. Thanks for the review! First of all I do not think that we

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Andy Walls
On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl jonsm...@gmail.com wrote: On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky maximlevit...@gmail.com wrote: + pll_freq =

Re: [PULL] soc-camera, sh-vou, v4l2 for 2.6.36

2010-07-31 Thread Guennadi Liakhovetski
Hi Mauro On Fri, 30 Jul 2010, Mauro Carvalho Chehab wrote: Em 29-07-2010 06:31, Guennadi Liakhovetski escreveu: Hi Mauro The following changes since commit c57fd88318988f17731e446fe1d8498f506fdd44: V4L/DVB: uvcvideo: Add support for Manta MM-353 Plako (2010-07-05 19:47:16

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl jonsm...@gmail.com wrote: On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 10:28 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 10:37 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 10:28 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl

[PATCH 0/9 v4] IR: few fixes, additions and ENE driver

2010-07-31 Thread Maxim Levitsky
Hi, 4th revision of my patches below: Changes: * more carefull repeat support in NECX protocol * added documentation for wide band mode ioctl * fix for 64 bit divide * updated summary of patches, and preserved few * Acked/Reviewed by tags you gave me. Best regards, Maxim Levitsky --

[PATCH 01/13] IR: Kconfig fixes

2010-07-31 Thread Maxim Levitsky
Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig

[PATCH 05/13] IR: JVC: make repeat work

2010-07-31 Thread Maxim Levitsky
Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-)

[PATCH 06/13] IR: nec decoder: fix repeat.

2010-07-31 Thread Maxim Levitsky
Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com Reviewed-by: Andy Walls awa...@md.metrocast.net --- drivers/media/IR/ir-nec-decoder.c |

[PATCH 07/13] IR: NECX: support repeat

2010-07-31 Thread Maxim Levitsky
This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |2 ++ drivers/media/IR/ir-nec-decoder.c | 23 +-- 2 files changed, 23 insertions(+), 2

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

2010-07-31 Thread Maxim Levitsky
This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c

[PATCH 10/13] IR: extend interfaces to support more device settings

2010-07-31 Thread Maxim Levitsky
LIRC: add new IOCTL that enables learning mode (wide band receiver) Still missing features: carrier report timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- .../DocBook/v4l/lirc_device_interface.xml | 16 +++

[PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- MAINTAINERS |6 + drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 595 + drivers/media/IR/ene_ir.h | 51 ++--- 5 files

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

2010-07-31 Thread Maxim Levitsky
Some ir input devices have small buffer, and interrupt the host each time it is full (or half full) Add a helper that automaticly handles timeouts, and also automaticly merges samples of same time (space-space) Such samples might be placed by hardware because size of sample in the buffer is small

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls awa...@md.metrocast.net wrote: I think you won't be able to fix the problem conclusively either way.  A lot of how the chip's clocks should be programmed depends on how the GPIOs are used and what crystal is used. I suspect many designers will use

[PULL] http://www.kernellabs.com/hg/~stoth/cx23885-mpx

2010-07-31 Thread Steven Toth
Mauro, Please pull from http://www.kernellabs.com/hg/~stoth/cx23885-mpx - cx23885: prepare the cx23885 makefile for alsa support - cx23885: merge mijhail's header changes for alsa - cx23885: ALSA support - cx23885: core changes requireed for ALSA - cx23885: add definitions

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 12:25 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls awa...@md.metrocast.net wrote: I think you won't be able to fix the problem conclusively either way. A lot of how the chip's clocks should be programmed depends on how the GPIOs are used and

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 12:25 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls awa...@md.metrocast.net wrote: I think you won't be able to fix the problem conclusively either way. A lot of how the chip's clocks should be programmed depends on how the GPIOs are used and

[PATCH] IR keymap: Add print button for HP OEM version of MCE remote

2010-07-31 Thread Andy Walls
This patch adds a defintion for the Print button found on HP OEM versions of the MCE remote. All of the other keys found on the HP OEM version of the remote match the other keys as already defined. Because, who doesn't need remote printing, while one is sitting on the couch across from one's PC?

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Christoph Bartelmus
Hi Jon, on 31 Jul 10 at 12:25, Jon Smirl wrote: On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls awa...@md.metrocast.net wrote: I think you won't be able to fix the problem conclusively either way.  A lot of how the chip's clocks should be programmed depends on how the GPIOs are used and what

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus l...@bartelmus.de wrote: Hi Jon, on 31 Jul 10 at 12:25, Jon Smirl wrote: On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls awa...@md.metrocast.net wrote: I think you won't be able to fix the problem conclusively either way.  A lot of how the

Re: [PULL] http://www.kernellabs.com/hg/~stoth/cx23885-mpx

2010-07-31 Thread Andy Walls
On Sat, 2010-07-31 at 12:31 -0400, Steven Toth wrote: Mauro, Please pull from http://www.kernellabs.com/hg/~stoth/cx23885-mpx - cx23885: prepare the cx23885 makefile for alsa support - cx23885: merge mijhail's header changes for alsa - cx23885: ALSA support - cx23885:

Re: [PATCH 01/20] mt9m111: Added indication that MT9M131 is supported by this driver

2010-07-31 Thread Guennadi Liakhovetski
On Fri, 30 Jul 2010, Michael Grzeschik wrote: From: Philipp Wiesner p.wies...@phytec.de Added this info to Kconfig and mt9m111.c, some comment cleanup, replaced 'mt9m11x'-statements by clarifications or driver name. Driver is fully compatible to mt9m131 which has only additional functions

Re: [PATCH 02/20] mt9m111: init chip after read CHIP_VERSION

2010-07-31 Thread Guennadi Liakhovetski
On Fri, 30 Jul 2010, Michael Grzeschik wrote: Moved mt9m111_init after the chip version detection passage: I don't like the idea of writing on a device we haven't identified yet. In principle it's correct, but what do you do, if a chip cannot be probed, before it is initialised / enabled?

Re: [PATCH 01/20] mt9m111: Added indication that MT9M131 is supported by this driver

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik m.grzesc...@pengutronix.de writes: From: Philipp Wiesner p.wies...@phytec.de Added this info to Kconfig and mt9m111.c, some comment cleanup, replaced 'mt9m11x'-statements by clarifications or driver name. Driver is fully compatible to mt9m131 which has only additional

Re: [PATCH 05/20] mt9m111: added default row/col/width/height values

2010-07-31 Thread Guennadi Liakhovetski
On Fri, 30 Jul 2010, Michael Grzeschik wrote: Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 03/20] mt9m111: register cleanup hex to dec bitoffset

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik m.grzesc...@pengutronix.de writes: Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de OK for me (the formal ack will be once we finish the review). Cheers. -- Robert -- To unsubscribe from this list: send the line

[PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

2010-07-31 Thread Steven Toth
Mauro, Analog Encoder and VBI support in the SAA7164 tree, for the HVR2200 and HVR2250 cards. Please pull from http://www.kernellabs.com/hg/~stoth/saa7164-v4l - saa7164: basic definitions for -encoder.c - saa7164: Add some encoder firmwares message types and structs - saa7164:

Re: [PATCH 04/20] mt9m111: added new bit offset defines

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik m.grzesc...@pengutronix.de writes: Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de OK for me. Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [PATCH 06/20] mt9m111: changed MAX_{HEIGHT,WIDTH} values to silicon pixelcount

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik m.grzesc...@pengutronix.de writes: Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 17:53 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 2:51 PM, Andy Walls awa...@md.metrocast.net wrote: On Sat, 2010-07-31 at 14:14 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus l...@bartelmus.de wrote: Hi Jon, on 31 Jul 10 at

[PATCH 1/7] V4L/DVB: Partially revert commit da7251dd0bca6c17571be2bd4434b9779dea72d8

2010-07-31 Thread Mauro Carvalho Chehab
By mistake, changeset da7251dd0bca6c17571be2bd4434b9779dea72d8 reverted the following commits: commit 6795f9a1ac9e85deb96a49e46b29c809214bf5ea commit d69861a25a54ef1cd6ee92f5ceb6ff2c01d84803 commit 1ba30538e2d125ce821622ac1f5e7ef31d856077 This patch partially reverts the

[PATCH 2/7] V4L/DVB: dvb-usb: get rid of struct dvb_usb_rc_key

2010-07-31 Thread Mauro Carvalho Chehab
dvb-usb has its own IR handle code. Now that we have a Remote Controller subsystem, we should start using it. So, remove this struct, in favor of the similar struct defined at the RC subsystem. This is a big, but trivial patch. It is a 3 line delect, plus lots of rename on several dvb-usb files.

[PATCH 3/7] V4L/DVB: dvb-usb: prepare drivers for using rc-core

2010-07-31 Thread Mauro Carvalho Chehab
This is a big patch, yet trivial. It just move the RC properties to a separate struct, in order to prepare the dvb-usb drivers to use rc-core. There's no change on the behavior of the drivers. With this change, it is possible to have both legacy and rc-core based code inside the dvb-usb-remote,

[PATCH 4/7] V4L/DVB: dvb-usb: add support for rc-core mode

2010-07-31 Thread Mauro Carvalho Chehab
Allows dvb-usb drivers to use rc-core, instead of the legacy implementation. No driver were ported yet to rc-core, so, some small adjustments may be needed, when starting to migrate the drivers. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git

[PATCH 5/7] V4L/DVB: Add a keymap file with dib0700 table

2010-07-31 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com create mode 100644 drivers/media/IR/keymaps/rc-dib0700-big.c diff --git a/drivers/media/IR/keymaps/Makefile b/drivers/media/IR/keymaps/Makefile index 86d3d1f..85330d1 100644 --- a/drivers/media/IR/keymaps/Makefile +++