Re: Remote that breaks current system

2010-08-12 Thread Christoph Bartelmus
Hi Jarod, on 11 Aug 10 at 10:38, Jarod Wilson wrote: On Mon, Aug 2, 2010 at 4:42 PM, Jon Smirl jonsm...@gmail.com wrote: On Mon, Aug 2, 2010 at 2:09 PM, Jarod Wilson ja...@redhat.com wrote: On Mon, Aug 02, 2010 at 01:13:22PM -0400, Jon Smirl wrote: On Mon, Aug 2, 2010 at 12:42 PM, Christoph

[patch] V4L/DVB: unlock on error path

2010-08-12 Thread Dan Carpenter
If we return directly here then we miss out on some mutex_unlock()s Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/s5p-fimc/fimc-core.c b/drivers/media/video/s5p-fimc/fimc-core.c index b151c7b..1beb226 100644 --- a/drivers/media/video/s5p-fimc/fimc-core.c +++

[patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Dan Carpenter
There were a couple issues here. If the allocation failed for dev then it would lead to a NULL dereference. If request_irq() or request_region() failed it would release the irq and the region even though they were not successfully aquired. Signed-off-by: Dan Carpenter erro...@gmail.com diff

[patch] IR: ir-raw-event: null pointer dereference

2010-08-12 Thread Dan Carpenter
The original code dereferenced ir-raw after freeing it and setting it to NULL. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/IR/ir-raw-event.c b/drivers/media/IR/ir-raw-event.c index 43094e7..8e0e1b1 100644 --- a/drivers/media/IR/ir-raw-event.c +++

dvb_net.c:1237: error: ‘struct net_device’ has no member

2010-08-12 Thread Goga777
hi with 2.6.35 kernel and current v4l-dvb I have other errors as described here is http://www.kernellabs.com/blog/?p=1397 CC [M] /home/fabio/src/v4l-dvb-drxd/v4l/dvb_filter.o CC [M] /home/fabio/src/v4l-dvb-drxd/v4l/dvb_ca_en50221.o CC [M] /home/fabio/src/v4l-dvb-drxd/v4l/dvb_frontend.o CC [M]

Re: A problem with http://git.linuxtv.org/media_tree.git

2010-08-12 Thread Matti J. Aaltonen
On Wed, 2010-08-11 at 15:16 +0200, ext Mauro Carvalho Chehab wrote: Em 11-08-2010 08:44, Matti J. Aaltonen escreveu: Hi again. On Wed, 2010-08-11 at 14:34 +0300, Matti J. Aaltonen wrote: Hello. On Wed, 2010-08-11 at 12:56 +0200, ext Hans Verkuil wrote: Hi. I cloned your tree at

Re: A problem with http://git.linuxtv.org/media_tree.git

2010-08-12 Thread Hans Verkuil
On Wed, 2010-08-11 at 15:16 +0200, ext Mauro Carvalho Chehab wrote: Em 11-08-2010 08:44, Matti J. Aaltonen escreveu: Hi again. On Wed, 2010-08-11 at 14:34 +0300, Matti J. Aaltonen wrote: Hello. On Wed, 2010-08-11 at 12:56 +0200, ext Hans Verkuil wrote: Hi. I cloned your tree

Re: A problem with http://git.linuxtv.org/media_tree.git

2010-08-12 Thread Matti J. Aaltonen
On Thu, 2010-08-12 at 12:29 +0200, ext Hans Verkuil wrote: On Wed, 2010-08-11 at 15:16 +0200, ext Mauro Carvalho Chehab wrote: Em 11-08-2010 08:44, Matti J. Aaltonen escreveu: Hi again. On Wed, 2010-08-11 at 14:34 +0300, Matti J. Aaltonen wrote: Hello. On Wed, 2010-08-11 at

Re: [PATCH v7 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-12 Thread Matti J. Aaltonen
Hello Alexey On Wed, 2010-08-11 at 10:06 +0200, ext Alexey Klimov wrote: + + radio = kzalloc(sizeof(*radio), GFP_KERNEL); + if (!radio) + return -ENOMEM; + + radio-write_buf = kmalloc(256, GFP_KERNEL); + if (!radio-write_buf) +

Re: [PATCH v7 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-12 Thread pramodh ag
Matti, +/** + * wl1273_fm_set_tx_power() -    Set the transmission power value. + * @core:            A pointer to the device struct. + * @power:            The new power value. + */ +static int wl1273_fm_set_tx_power(struct wl1273_core *core, u16 power) +{ +    int r; + +    if

Re: [PATCH v7 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-12 Thread Matti J. Aaltonen
Hello. On Thu, 2010-08-12 at 14:10 +0200, ext pramodh ag wrote: Matti, +/** + * wl1273_fm_set_tx_power() -Set the transmission power value. + * @core:A pointer to the device struct. + * @power:The new power value. + */ +static int

Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Maxim Levitsky
On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: There were a couple issues here. If the allocation failed for dev then it would lead to a NULL dereference. If request_irq() or request_region() failed it would release the irq and the region even though they were not successfully

Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Dan Carpenter
On Thu, Aug 12, 2010 at 05:35:04PM +0300, Maxim Levitsky wrote: On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: There were a couple issues here. If the allocation failed for dev then it would lead to a NULL dereference. If request_irq() or request_region() failed it would release

Re: libdvbsec - trying to control DiSEqC positioner

2010-08-12 Thread Matthias Weber
Hi. We are trying to use the libdvbsec-api from the dvb-apps package (/dvb_apps/lib/libdvbsec) to build our own DiSEqC positioner control. It's going to implement a kind of USALS/GotoX/GotoXX/DiSEqC1.3, whatever you want to call it (there's no hardware receiver provided atm). But at the moment

Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Maxim Levitsky
On Thu, 2010-08-12 at 18:19 +0200, Dan Carpenter wrote: On Thu, Aug 12, 2010 at 05:35:04PM +0300, Maxim Levitsky wrote: On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: There were a couple issues here. If the allocation failed for dev then it would lead to a NULL dereference.

[PATCH] fix v4l2-ctrls compilation

2010-08-12 Thread Meelis Roos
Current git has broken v4l2-ctrls compilation - kzalloc et al are missing prototypes. Fix it by including linux/slab.h that contains the definitions. Signed-off-by: Meelis Roos mr...@linux.ee diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c index

[GIT PULL for 2.6.36] V4L/DVB fixes

2010-08-12 Thread Mauro Carvalho Chehab
Linus, Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus For 3 build fixes. Cheers, Mauro. The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris

Re: [patch] IR: ir-raw-event: null pointer dereference

2010-08-12 Thread Jarod Wilson
- Dan Carpenter erro...@gmail.com wrote: The original code dereferenced ir-raw after freeing it and setting it to NULL. Signed-off-by: Dan Carpenter erro...@gmail.com Acked-by: Jarod Wilson ja...@redhat.com -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the

[PATCH v2] V4L2: avoid name conflicts in macros

2010-08-12 Thread Guennadi Liakhovetski
sd and err are too common names to be used in macros for local variables. Prefix them with an underscore to avoid name clashing. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: as suggested by Mauro, also patched v4l2_device_call_all and v4l2_device_call_until_err, as well

Re: [PATCH] v4l2-ctrls.c was missing slab.h

2010-08-12 Thread Guennadi Liakhovetski
On Thu, 12 Aug 2010, Christopher Friedt wrote: Fixed broken compile of drivers/media/video/v4l2-ctrls.c. It failed due to missing #include linux/slab.h, and errored-out with implicit declaration of function kzalloc, kmalloc, ... Signed-off-by: Christopher Friedt chrisfri...@gmail.com ---

[PATCH] soc-camera: initialise videobuf immediately before allocating them

2010-08-12 Thread Guennadi Liakhovetski
Only the streamer process has to initialise videobufs. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Janusz, this and the following patch can be useful, if we decide to implement dynamic switching between videobuf implementations. Only compile-tested...

[PATCH] soc-camera: allow only one video queue per device

2010-08-12 Thread Guennadi Liakhovetski
Multiple user-space application instances can open the same video device, but it only makes sense for one of them to manage the videobuffer queue and set video format of the device. Restrict soc-camera respectively. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Also compile

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-12 Thread Guennadi Liakhovetski
On Sun, 1 Aug 2010, Janusz Krzysztofik wrote: Friday 30 July 2010 20:49:05 Janusz Krzysztofik napisał(a): Friday 30 July 2010 13:07:42 Guennadi Liakhovetski napisał(a): On Sun, 18 Jul 2010, Janusz Krzysztofik wrote: This is a V4L2 driver for TI OMAP1 SoC camera interface. Two

Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free'

2010-08-12 Thread Douglas Schilling Landgraf
Hello, 2010/8/11 Goga777 goga...@bk.ru: Hi I can't compile current v4l-dvb with new 2.6.35 kernel arvdr:/usr/src/v4l-dvb# make make -C /usr/src/v4l-dvb/v4l make[1]: Entering directory `/usr/src/v4l-dvb/v4l' creating symbolic links... make -C firmware prep make[2]: Entering directory