Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Clemens Ladisch
Laurent Pinchart wrote: +struct media_device { ... + u8 model[32]; + u8 serial[40]; + u8 bus_info[32]; All drivers and userspace applications have to treat this as char[], so why u8[]? Regards, Clemens -- To unsubscribe from this list: send the line unsubscribe linux-media in

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-25 Thread Clemens Ladisch
Laurent Pinchart wrote: A link is a point-to-point oriented connection between two pads, either on the same entity or on different entities. Data flows from a source pad to a sink pad. Links are stored in the source entity. In the descriptors of USB Audio and HDAudio devices, the links are

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-25 Thread Marek Szyprowski
Hello, On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: From: Pawel Osciak p.osc...@samsung.com Videobuf2 is a Video for Linux 2 API-compatible driver framework for multimedia devices. It acts as an intermediate

Re: [PATCH 3/7] v4l: videobuf2: add vmalloc allocator

2010-11-25 Thread Hans Verkuil
On Friday, November 19, 2010 16:55:40 Marek Szyprowski wrote: From: Pawel Osciak p.osc...@samsung.com Add an implementation of contiguous virtual memory allocator and handling routines for videobuf2, implemented on top of vmalloc()/vfree() calls. Signed-off-by: Pawel Osciak

Re: [PATCH 5/7] v4l: videobuf2: add read() and write() emulator

2010-11-25 Thread Hans Verkuil
On Friday, November 19, 2010 16:55:42 Marek Szyprowski wrote: Add a generic file io (read and write) emulator for videobuf2. It uses MMAP memory type buffers and generic vb2 calls: req_bufs, qbuf and dqbuf. Video date is being copied from mmap buffers to userspace with standard copy_to_user()

RE: [PATCH 3/7] v4l: videobuf2: add vmalloc allocator

2010-11-25 Thread Marek Szyprowski
Hello, On Thursday, November 25, 2010 11:07 AM Hans Verkuil wrote: On Friday, November 19, 2010 16:55:40 Marek Szyprowski wrote: From: Pawel Osciak p.osc...@samsung.com Add an implementation of contiguous virtual memory allocator and handling routines for videobuf2, implemented on top

Re: [PATCH 6/7] v4l: vivi: port to videobuf2

2010-11-25 Thread Hans Verkuil
On Friday, November 19, 2010 16:55:43 Marek Szyprowski wrote: Make vivi use videobuf2 in place of videobuf. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Pawel Osciak

Re: [PATCH 3/7] v4l: videobuf2: add vmalloc allocator

2010-11-25 Thread Hans Verkuil
On Thursday, November 25, 2010 11:26:56 Marek Szyprowski wrote: Hello, On Thursday, November 25, 2010 11:07 AM Hans Verkuil wrote: On Friday, November 19, 2010 16:55:40 Marek Szyprowski wrote: From: Pawel Osciak p.osc...@samsung.com Add an implementation of contiguous virtual

Re: [RFC/PATCH v3 6/7] omap3: Export omap3isp platform device structure

2010-11-25 Thread Laurent Pinchart
Hi Felipe, On Thursday 25 November 2010 08:02:41 Felipe Balbi wrote: On Thu, Nov 25, 2010 at 03:54:37AM +0100, Laurent Pinchart wrote: From: Stanimir Varbanov svarba...@mm-sol.com The omap3isp platform device requires platform data. As the data can be provided by a kernel module, the device

RE: [PATCH 10/10] ux500: MCDE: Add platform specific data

2010-11-25 Thread Jimmy RUBIN
Hi, + + if (ddev-id == PRIMARY_DISPLAY_ID rotate_main) { + swap(width, height); +#ifdef CONFIG_DISPLAY_GENERIC_DSI_PRIMARY_ROTATE_180_DEGREES + rotate = FB_ROTATE_CCW; +#else + rotate = FB_ROTATE_CW; +#endif + } + + virtual_width =

Re: [RFC/PATCH v3 6/7] omap3: Export omap3isp platform device structure

2010-11-25 Thread Felipe Balbi
Hi, On Thu, Nov 25, 2010 at 12:17:59PM +0100, Laurent Pinchart wrote: pass platform_data as an argument to this call ? Then remove the static inline and export this one ? Yes indeed, why ? :-) I guess things like that are difficult to spot when you've had your nose on the code for too long.

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-25 Thread Hans Verkuil
On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote: Hello, On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: From: Pawel Osciak p.osc...@samsung.com Videobuf2 is a Video for Linux 2 API-compatible

RE: [PATCH 02/10] MCDE: Add configuration registers

2010-11-25 Thread Jimmy RUBIN
Hi, This patch adds the configuration registers found in MCDE. + +#define MCDE_VAL2REG(__reg, __fld, __val) \ + (((__val) __reg##_##__fld##_SHIFT) __reg##_##__fld##_MASK) +#define MCDE_REG2VAL(__reg, __fld, __val) \ + (((__val) __reg##_##__fld##_MASK)

Re: [RFC/PATCH v6 11/12] v4l: Make video_device inherit from media_entity

2010-11-25 Thread Hans Verkuil
On Thursday, November 25, 2010 03:28:18 Laurent Pinchart wrote: V4L2 devices are media entities. As such they need to inherit from (include) the media_entity structure. When registering/unregistering the device, the media entity is automatically registered/unregistered. The entity is

RE: [PATCH 08/10] MCDE: Add frame buffer device

2010-11-25 Thread Jimmy RUBIN
Hi, On Wednesday 10 November 2010, Jimmy Rubin wrote: + +static struct platform_device mcde_fb_device = { + .name = mcde_fb, + .id = -1, +}; Do not introduce new static devices. We are trying to remove them and they will stop working. Why do you even need a device here if

RE: [PATCH 09/10] MCDE: Add build files and bus

2010-11-25 Thread Marcus LORENTZON
Hi Arnd, Comments inline. -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: den 12 november 2010 17:23 To: linux-arm-ker...@lists.infradead.org Cc: Jimmy RUBIN; linux-fb...@vger.kernel.org; linux- me...@vger.kernel.org; Dan JOHANSSON; Linus WALLEIJ Subject: Re:

[PATCH] [media] msp3400: fix mute audio regression

2010-11-25 Thread Hans Verkuil
This patch applies 2.6.37 commit 0310871d8f71da4ad8643687fbc40f219a0dac4d to the 2.6.36 stable series. It was just too late to be included in 2.6.36 at the time, but it should be added to 2.6.36 since it fixes broken audio on this fairly popular audio receiver chip. Regards, Hans

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 03:28:10AM +0100, Laurent Pinchart wrote: +Links have flags that describe the link capabilities and state. + MEDIA_LINK_FLAG_ACTIVE indicates that the link is active and can be + used to transfer media data. When two or more links target a sink pad, + only

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 10:38:05AM +0100, Clemens Ladisch wrote: In USB and HD audio devices, all links are immutable, and the routing is controlled by 'selector' entities that activate exactly one of their input pads. In userspace, this entity shows up as a mixer control. I guess it would

Re: [RFC/PATCH v6 05/12] media: Reference count and power handling

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 03:28:12AM +0100, Laurent Pinchart wrote: If the entity is of node type, the power change is distributed to all connected entities. For non-nodes it only affects that very node. A mutex is used to serialise access to the entity graph. ASoC has its own

Re: [RFC/PATCH v6 09/12] media: Entity locking and pipeline management

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 03:28:16AM +0100, Laurent Pinchart wrote: Link states must not be modified while streaming is in progress on a graph they belong or connect to. The entity locking API helps drivers enforcing that requirement. This is not desirable for embedded audio - for example, it is

Re: [RFC/PATCH v6 00/12] Media controller (core and V4L2)

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 03:28:07AM +0100, Laurent Pinchart wrote: I want to emphasize that the media controller API does *not* replace the V4L, DVB or ALSA APIs. It complements them. Overall this looks relatively good and should be mappable onto the embedded audio stack. I'd need to sit down

Re: [RFC/PATCH v6 11/12] v4l: Make video_device inherit from media_entity

2010-11-25 Thread Laurent Pinchart
Hi Hans, Thanks for the review. On Thursday 25 November 2010 12:38:15 Hans Verkuil wrote: On Thursday, November 25, 2010 03:28:18 Laurent Pinchart wrote: V4L2 devices are media entities. As such they need to inherit from (include) the media_entity structure. When

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Laurent Pinchart
Hi Clemens, Thanks for the review. On Thursday 25 November 2010 10:33:02 Clemens Ladisch wrote: Laurent Pinchart wrote: +struct media_device { ... + u8 model[32]; + u8 serial[40]; + u8 bus_info[32]; All drivers and userspace applications have to treat this as char[], so why

[PATCH 0/6] s5p-fimc driver fixes for 2.6.37

2010-11-25 Thread Sylwester Nawrocki
Hello, the following are a few bugfix patches for s5p-fimc driver. Two of them are related to recent BKL removal efforts and others are minor fixes for V4L2 API conformance and correct handling of different IP revisions. The patch series contains: [PATCH 1/6] [media] s5p-fimc: BKL lock removal

[PATCH 1/6] [media] s5p-fimc: BKL lock removal - compilation fix

2010-11-25 Thread Sylwester Nawrocki
Adapt to recent videobuf_queue_dma_contig_init signature change. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-capture.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 2/6] [media] s5p-fimc: Fix vidioc_g_crop/cropcap on camera sensor

2010-11-25 Thread Sylwester Nawrocki
Create separate vidioc_g_crop/vidioc_s_crop handlers for capture video node and so image cropping parameters are properly queried at FIMC input (image sensor) and not at FIMC output. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH 3/6] [media] s5p-fimc: Explicitly add required header file

2010-11-25 Thread Sylwester Nawrocki
Reported by: Dan Carpenter erro...@gmail.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-core.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[PATCH 4/6] [media] s5p-fimc: Convert m2m driver to unlocked_ioctl

2010-11-25 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-core.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-core.c

[PATCH 5/6] [media] s5p-fimc: Use correct fourcc code for 32-bit RGB format

2010-11-25 Thread Sylwester Nawrocki
Replace V4L2_PIX_FMT_RGB24 code with V4L2_PIX_FMT_RGB32 since the hardware uses 24-bits for actual pixel data but pixels are 4-byte aligned in memory. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 6/6] [media] s5p-fimc: Fix output DMA handling in S5PV310 IP revisions

2010-11-25 Thread Sylwester Nawrocki
FIMC IP in S5Pv310 series has extended DMA status registers and some bit fields are marked as reserved comparing to S5PC100/110. Use correct registers for getting DMA write pointer in each SoC variant supported by the driver. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by:

Re: [linux-dvb] [bug] AF9015 message WARNING: tuning failed!!!

2010-11-25 Thread Antti Palosaari
On 11/23/2010 10:11 PM, Paul Gover wrote: On Wednesday 06 October 2010 22:29:35 Antti Palosaari wrote: On 10/06/2010 11:36 PM, dave cunningham wrote: In message4cacd0f3.6030...@iki.fi, Antti Palosaari wrote It is QT1010 tuner driver issue. None is working for that currently or in near

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 04:21:38PM +0100, Laurent Pinchart wrote: On Thursday 25 November 2010 10:38:05 Clemens Ladisch wrote: ALSA has PCM and MIDI devices, and several types of mixer controls. (It also has hardware dependent and timer devices, but I don't think these would need topology

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-25 Thread Laurent Pinchart
Hi Mark, On Thursday 25 November 2010 14:41:35 Mark Brown wrote: On Thu, Nov 25, 2010 at 10:38:05AM +0100, Clemens Ladisch wrote: In USB and HD audio devices, all links are immutable, and the routing is controlled by 'selector' entities that activate exactly one of their input pads. In

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 04:29:53PM +0100, Laurent Pinchart wrote: It depends on how you define nodes. I can certainly imagine a graph with 100 controls, but maybe several controls can be part of the same node ? On the video side we've decided to split entities depending on the possible data

Re: [RFC/PATCH v6 05/12] media: Reference count and power handling

2010-11-25 Thread Laurent Pinchart
Hi Mark, On Thursday 25 November 2010 14:49:08 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:12AM +0100, Laurent Pinchart wrote: If the entity is of node type, the power change is distributed to all connected entities. For non-nodes it only affects that very node. A mutex is

Re: [RFC/PATCH v6 09/12] media: Entity locking and pipeline management

2010-11-25 Thread Laurent Pinchart
Hi Mark, On Thursday 25 November 2010 14:53:51 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:16AM +0100, Laurent Pinchart wrote: Link states must not be modified while streaming is in progress on a graph they belong or connect to. The entity locking API helps drivers enforcing that

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 04:40:41PM +0100, Laurent Pinchart wrote: On Thursday 25 November 2010 14:36:50 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:10AM +0100, Laurent Pinchart wrote: + MEDIA_LINK_FLAG_ACTIVE indicates that the link is active and can be + used to transfer media data.

Re: [PATCH 02/10] MCDE: Add configuration registers

2010-11-25 Thread Arnd Bergmann
On Thursday 25 November 2010, Jimmy RUBIN wrote: All these header files, Configuration, pixel processing, formatter, dsi link registers are auto generated from an xml file. This actually may or may not be a legal problem, because it means that the distributed source code is not the

Re: Media framework backwards compatibility

2010-11-25 Thread Laurent Pinchart
Hi Lane, On Wednesday 24 November 2010 01:14:13 Lane Brooks wrote: On 11/23/2010 04:45 PM, Laurent Pinchart wrote: On Tuesday 23 November 2010 23:29:10 Lane Brooks wrote:Laurent, If the links are setup to the resizer, then it seems that user space applications should be able to talk the

Re: [PATCH 09/10] MCDE: Add build files and bus

2010-11-25 Thread Arnd Bergmann
On Thursday 25 November 2010, Marcus LORENTZON wrote: From: Arnd Bergmann [mailto:a...@arndb.de] On Wednesday 10 November 2010, Jimmy Rubin wrote: This patch adds support for the MCDE, Memory-to-display controller, found in the ST-Ericsson ux500 products. This patch adds the

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-25 Thread Laurent Pinchart
Hi Eino-Ville, On Tuesday 23 November 2010 00:18:18 Eino-Ville Talvala wrote: On 11/19/2010 6:22 AM, Laurent Pinchart wrote: On Friday 19 November 2010 15:15:11 Guennadi Liakhovetski wrote: On Fri, 19 Nov 2010, Laurent Pinchart wrote: On Friday 19 November 2010 14:42:31 Hans Verkuil wrote:

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Andy Walls
The signedness of char is ambiguous for 8 bit data, which is why an API would normally use u8 (or s8, I guess). Since this is known to be character data, I would think char would be fine. I am assuming C compilers would never assume multibyte chars. Regards, Andy Laurent Pinchart

Re: [RFC/PATCH v6 05/12] media: Reference count and power handling

2010-11-25 Thread Sakari Ailus
Laurent Pinchart wrote: Hi Mark, Hi Laurent, others, On Thursday 25 November 2010 14:49:08 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:12AM +0100, Laurent Pinchart wrote: If the entity is of node type, the power change is distributed to all connected entities. For non-nodes it

RE: [PATCH 09/10] MCDE: Add build files and bus

2010-11-25 Thread Marcus LORENTZON
-Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: den 25 november 2010 17:48 To: Marcus LORENTZON Cc: linux-arm-ker...@lists.infradead.org; Jimmy RUBIN; linux- me...@vger.kernel.org; Dan JOHANSSON; Linus WALLEIJ Subject: Re: [PATCH 09/10] MCDE: Add build files and

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Alan Cox
On Thu, 25 Nov 2010 12:20:31 -0500 Andy Walls awa...@md.metrocast.net wrote: The signedness of char is ambiguous for 8 bit data, which is why an API would normally use u8 (or s8, I guess). Since this is known to be character data, I would think char would be fine. I am assuming C

[cron job] v4l-dvb daily build: WARNINGS

2010-11-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Nov 25 19:01:43 CET 2010 git master: 59365d136d205cc20fe666ca7f89b1c5001b0d5a git media-master: gcc version:

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

2010-11-25 Thread Sam Ravnborg
On Thu, Nov 25, 2010 at 12:06:46PM -0500, Arnaud Lacombe wrote: Hi folks, On Sat, Nov 6, 2010 at 5:30 PM, Arnaud Lacombe lacom...@gmail.com wrote: This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

Re: [PATCH] media: fix casting issues in timberdale logiwin

2010-11-25 Thread Richard Röjfors
On 11/24/2010 10:41 AM, Richard Röjfors wrote: On 11/23/2010 09:39 PM, Jarod Wilson wrote: I get warnings about casting to and from pointers and integers of different sizes w/current code, this silences them. Signed-off-by: Jarod Wilson ja...@redhat.com Looks good, and works. I did a

[PATCH] rc-core: add loopback driver

2010-11-25 Thread David Härdeman
This patch adds a loopback driver to rc-core which I've found useful for running scripted tests of different parts of rc-core without having to fiddle with real hardware. Basically it emulates hardware with a learning and a non-learning receiver and two transmitters (which correspond to the two

Re: [RFC/PATCH v6 05/12] media: Reference count and power handling

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 07:49:05PM +0200, Sakari Ailus wrote: Currently when two media entities are connected they will be powered up for the duration of the link setup, just in case the drivers would need to access hardware for some reason. I don't think we have a need for that at the

Re: ATSC Tuner in KWorld PC120-U PCI Hybrid ATSC (17de:a134)

2010-11-25 Thread hermann pitton
Hi, Am Donnerstag, den 25.11.2010, 00:56 -0500 schrieb Hooman B.: Thanks, I see the drivers for both TDA18271HDC2 and TDA8290 loaded. I thought TDA18271HDC2 was the digital channel decoder, isn't it? Is the digital channel decoder different from the digital tuner?? Should be looking for a