[PATCH] media: vb2: fix potential deadlock in mmap vs. get_userptr handling

2011-11-17 Thread Marek Szyprowski
To get direct access to userspace memory pages vb2 allocator needs to gather read access on mmap semaphore in the current process. The same semaphore is taken before calling mmap operation, while both mmap and qbuf are called by the driver or v4l2 core with driver's lock held. To avoid a AB-BA

Re: Cleanup proposal for media/gspca

2011-11-17 Thread Jean-Francois Moine
On Wed, 16 Nov 2011 15:19:04 -0300 Ezequiel García elezegar...@gmail.com wrote: In 'media/video/gspca/gspca.c' I really hated this cast (maybe because I am too dumb to understand it): gspca_dev = (struct gspca_dev *) video_devdata(file); wich is only legal because a struct video_device

[PATCH] m5mols: Fix set_fmt to return proper pixel format code

2011-11-17 Thread Sylwester Nawrocki
In case pixel format is modified in set_fmt by the driver, the changes are not propagated back to the caller. Fix this by adjusting passed data for TRY and ACTIVE format. Also remove redundant pixel format code information from struct m5mols_info, it's already available in 'ffmt' array. Remove

[PATCH v3 3/5] ARM: davinci: dm646x: remove the macros from the header to move to c file

2011-11-17 Thread Manjunath Hadli
move the register base addresses and offsets used only by dm646x platform file from platform header dm646x.h to dm646x.c as they are used only in the c file. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- arch/arm/mach-davinci/dm646x.c |7 +++

[PATCH v3 2/5] ARM: davinci: dm365: remove the macros from the header to move to c file

2011-11-17 Thread Manjunath Hadli
move the register base addresses and offsets used only by dm365 platform file from platform header dm365.h to dm365.c as they are used only in the c file. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- arch/arm/mach-davinci/dm365.c | 16

[PATCH v3 0/5] ARM: davinci: re-arrange definitions to have a common davinci header

2011-11-17 Thread Manjunath Hadli
Re-arrange definitions and remove unnecessary code so that we can have a common header for all davinci platforms. This will enable us to share defines and enable common routines to be used without polluting hardware.h. This patch set forms the base for a later set of patches for having a common

[PATCH v3 5/5] ARM: davinci: delete individual platform header files and use a common header

2011-11-17 Thread Manjunath Hadli
include davinci_common.h file in files using the platform header file for dm355, dm365, dm644x and dm646x and delete the individual platform header files. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- arch/arm/mach-davinci/board-dm355-evm.c |2 +-

[PATCH v3 1/5] ARM: davinci: dm644x: remove the macros from the header to move to c file

2011-11-17 Thread Manjunath Hadli
move the register base addresses and offsets used only by dm644x platform file from platform header dm644x.h to dm644x.c as they are used only in the c file. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- arch/arm/mach-davinci/dm644x.c |7 +++

[PATCH v3 4/5] ARM: davinci: create new common platform header for davinci

2011-11-17 Thread Manjunath Hadli
remove the code from individual platform header files for dm365, dm355, dm644x and dm646x and consolidate it into a single and common header file davinci_common.h. Include the new header file in individual platform header files as a pre-cursor for deleting these headers in follow up patches.

Re: [PATCH v3 4/5] ARM: davinci: create new common platform header for davinci

2011-11-17 Thread Sergei Shtylyov
Hello. On 17-11-2011 14:18, Manjunath Hadli wrote: remove the code from individual platform header files for dm365, dm355, dm644x and dm646x and consolidate it into a single and common header file davinci_common.h. Include the new header file in individual platform header files as a pre-cursor

Re: [PATCH v3 5/5] ARM: davinci: delete individual platform header files and use a common header

2011-11-17 Thread Sergei Shtylyov
Hello. On 17-11-2011 14:18, Manjunath Hadli wrote: include davinci_common.h file in files using the platform Just davinci.h now. header file for dm355, dm365, dm644x and dm646x and delete the individual platform header files. Signed-off-by: Manjunath Hadlimanjunath.ha...@ti.com

Re: [PATCH] media: vb2: vmalloc-based allocator user pointer handling

2011-11-17 Thread javier Martin
Hi all, what is the current status of this patch? Do you plan to send an improved version? I want to test it against my mem2mem driver I recently submitted (emma-PrP) and a UVC camera in order to transform YUYV to YUV420. Provided we ignore the locking problems you have mentioned is it in a

[RESEND RFC PATCH v4 00/15] RFC for Media Controller capture driver for DM365

2011-11-17 Thread Manjunath Hadli
These are a updated subset of patches for Media Controller implementation on DM365. A few more implementation patches which include Resizer, Previewer , AEW and AF are added to provide a broader perspective for review. Manjunath Hadli (15): davinci: vpfe: add dm3xx IPIPEIF hardware support

[RESEND RFC PATCH v4 13/15] davinci: vpfe: add aew driver based on v4l2 media framework

2011-11-17 Thread Manjunath Hadli
Add auto exposure and white balance driver based on v4l2 media framework. The driver processess the bayer data from CCDC and generates the data which will be used for calculation of parameters responsible for auto exposure and white balancing. The driver implement the v4l2 event queing mechanism

[RESEND RFC PATCH v4 11/15] davinci: vpfe: add autofocus driver based on media framework

2011-11-17 Thread Manjunath Hadli
Add autofocus driver based on v4l2 media framework. The driver processess the bayer data from CCDC and generates the data which will be used for calculation of parametsrs responsible for focussing. The driver implement the v4l2 event queing mechanism to know the readiness data from the driver.

[RESEND RFC PATCH v4 01/15] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2011-11-17 Thread Manjunath Hadli
add support for dm3xx IPIPEIF hardware setup. This is the lowest software layer for the dm3x vpfe driver which directly accesses hardware. Add support for features like default pixel correction, dark frame substraction and hardware setup. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com ---

[RESEND RFC PATCH v4 15/15] davinci: vpfe: build infrastructure for dm365

2011-11-17 Thread Manjunath Hadli
add build infrastructure for dm365 specific modules such as IPIPE, AEW, AF. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/video/davinci/Kconfig | 46 - drivers/media/video/davinci/Makefile | 17 +++- 2 files changed, 59

[RESEND RFC PATCH v4 14/15] davinci: vpfe: delete vpfe_types.h

2011-11-17 Thread Manjunath Hadli
delete vpfe_types.h as it is no longer used. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- include/media/davinci/vpfe_types.h | 51 1 files changed, 0 insertions(+), 51 deletions(-) delete mode 100644 include/media/davinci/vpfe_types.h diff

[RESEND RFC PATCH v4 05/15] davinci: vpfe: add ccdc driver with media controller interface

2011-11-17 Thread Manjunath Hadli
Add the CCDC driver for davinci Dm3XX SoCs. The driver supports CCDC as a media entity with 2 pads - 1 input and 1 output. The driver implements streaming support and subdev interface. The ccdc supports bayer and YUV formats. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com ---

[RESEND RFC PATCH v4 07/15] davinci: vpfe: v4l2 capture driver with media interface

2011-11-17 Thread Manjunath Hadli
Add the vpfe capture driver which implements media controller interface. The driver suports all the setup functionality for all all units nnamely- ccdc, previewer, resizer, h3a, aew. The driver supports both dm365 and Dm355. The driver does isr registration, v4l2 device registration, media

[RESEND RFC PATCH v4 08/15] davinci: vpfe: previewer driver based on v4l2 media controller framework

2011-11-17 Thread Manjunath Hadli
Add the video previewer driver with the v4l2 media controller framework which takes care of converting the video frames from bayer to YUV or RGB. the driver supports both continuous mode where it works in tandem with the CCDC and single shot mode where it can be used in isolation. The driver

[RESEND RFC PATCH v4 09/15] davinci: vpfe: resizer driver based on media framework

2011-11-17 Thread Manjunath Hadli
Add the video resizer driver with the v4l2 media controller framework which takes care of resizing the video frames with both up-scaling downscaling facility. The formats that is supported is YUV422. The driver supports both continuous mode where it works in tandem with the CCDC and previewer and

[RESEND RFC PATCH v4 10/15] davinci: vpfe: add DM365 autofoucus(AF) hardware interface

2011-11-17 Thread Manjunath Hadli
add support for autofocus unit of dm365 SoC. The autofocus register seup, isr and parameter calidation functionality is implemented as part of this module. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/video/davinci/dm365_af.c | 564

[RESEND RFC PATCH v4 12/15] davinci: vpfe: add hardware interface for dm365 aew

2011-11-17 Thread Manjunath Hadli
add the hardware functionality for enablling the dm365 auto exposure and white balance unit. The module supports hardware setup, isr management, and parameter validation. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/video/davinci/dm365_a3_hw.c | 387

[RESEND RFC PATCH v4 06/15] davinci: vpfe: add v4l2 video driver support

2011-11-17 Thread Manjunath Hadli
add a generic video driver functionality to be used by all the vpfe drivers for davinci SoCs. The functionality includes all the standard v4l2 interfaces including streaming. The video node interface can be used both as an input and output node for both continuous and single shot modes.Also

[RESEND RFC PATCH v4 02/15] davinci: vpfe: add IPIPE hardware layer support

2011-11-17 Thread Manjunath Hadli
add dm365 IPIPE hardware support. IPIPE is the hardware IP which implements the functionality required for resizer, previewer and the associated feature support. This is built along with the vpfe driver, and implements hardware setup including coeffcient programming for various hardware filters,

Re: [PATCH v3 4/5] ARM: davinci: create new common platform header for davinci

2011-11-17 Thread Sergei Shtylyov
Hello. On 17-11-2011 14:18, Manjunath Hadli wrote: remove the code from individual platform header files for dm365, dm355, dm644x and dm646x and consolidate it into a single and common header file davinci_common.h. Include the new header file in individual platform header files as a pre-cursor

Re: UVC with continuous video buffers.

2011-11-17 Thread javier Martin
On 4 November 2011 11:41, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, On Wednesday 02 November 2011 17:33:16 javier Martin wrote: On 2 November 2011 17:12, Devin Heitmueller wrote: I've actually got a very similar issue and have been looking into it (an em28xx

RE: [PATCH v3 4/5] ARM: davinci: create new common platform header for davinci

2011-11-17 Thread Hadli, Manjunath
Sergei, Thank you for the comments. On Thu, Nov 17, 2011 at 16:18:17, Sergei Shtylyov wrote: Hello. On 17-11-2011 14:18, Manjunath Hadli wrote: remove the code from individual platform header files for dm365, dm355, dm644x and dm646x and consolidate it into a single and common

RE: [PATCH] board-dm646x-evm.c: wrong register used in setup_vpif_input_channel_mode

2011-11-17 Thread Hadli, Manjunath
Hans, Thank you for the patch. I have verified from the data sheet. It might be a copy mistake. It also says the vpif_vsclkdis_reg can be used to disable and enable in case we make any clock switches so as to avoid glitches. In this case I would imagine we would stream off before switching, so

Re: [PATCH 4/4] uvcvideo: Add UVC timestamps support

2011-11-17 Thread javier Martin
Hi Laurent, On 8 November 2011 13:06, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote:  void uvc_queue_init(struct uvc_video_queue *queue, enum v4l2_buf_type type, diff --git a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c index 513ba30..d0600a5 100644

problems getting v4l to start

2011-11-17 Thread Ralf Moeller
Hi, I tried to compile v4l media_build in case of getting a dvb-t card to run. (it uses saa7134) when i made make install and reboot, it says the module saa7134 have unknown symbols. then I tried it by removing older dvb/v4l support from my customkernel (2.6.37.2) rebuild media_build again,

Re: problems getting v4l to start

2011-11-17 Thread Tim Draper
On 17 November 2011 12:27, Ralf Moeller ralf.moel...@mitlab.de wrote: Hi, I tried to compile v4l media_build in case of getting a dvb-t card to run. (it uses saa7134) when i made make install and reboot, it says the module saa7134 have unknown symbols. then I tried it by removing older

Regression with kernel 3.1 and bt87x?

2011-11-17 Thread Sebastian Steinhuber
Hi all, I've got a Hauppauge WinTV pci board that used to be working until kernel 3.1 was used; I tried 3.1.1, too, without luck. 3.0.7 is working, with the same config as the 3.1s regarding the media parts. I'm compiling my customized kernel from vanilla sources and a linux-vserver patch, and I

[PATCH] staging: as102: Add support for Sky Italia Digital Key based on the same chip.

2011-11-17 Thread Gianluca Gennari
Add support for the Sky Italia Digital Key, an USB dongle offered by Sky Italia to its customers for use with their satellite set-top-boxes. This is the green led model based on the Abilis as102 chip, while the so called blue led model is based on the Avermedia A867 design. Cc: Devin Heitmueller

Re: [PATCH 0/3] Move media staging drivers to staging/media

2011-11-17 Thread Tomas Winkler
On Wed, Nov 2, 2011 at 5:10 PM, Greg KH gre...@suse.de wrote: On Wed, Nov 02, 2011 at 09:45:09AM -0200, Mauro Carvalho Chehab wrote: Greg, As agreed, this is the patches that move media drivers to their I've probably missed the news so I'd like ask what is the current patch flow for

Re: Cleanup proposal for media/gspca

2011-11-17 Thread Ezequiel
On Thu, Nov 17, 2011 at 11:07:16AM +0100, Jean-Francois Moine wrote: On Wed, 16 Nov 2011 15:19:04 -0300 Ezequiel Garc??a elezegar...@gmail.com wrote: In 'media/video/gspca/gspca.c' I really hated this cast (maybe because I am too dumb to understand it): gspca_dev = (struct gspca_dev

Re: [PATCH 0/3] Move media staging drivers to staging/media

2011-11-17 Thread Greg KH
On Thu, Nov 17, 2011 at 07:47:50PM +0200, Tomas Winkler wrote: On Wed, Nov 2, 2011 at 5:10 PM, Greg KH gre...@suse.de wrote: On Wed, Nov 02, 2011 at 09:45:09AM -0200, Mauro Carvalho Chehab wrote: Greg, As agreed, this is the patches that move media drivers to their I've probably missed

Re: Hauppauge HVR900H don't work with kernel 3.*

2011-11-17 Thread Esteban Tarroni
Norret Thierry tnorret at yahoo.com writes: Hello, I have this card http://www.linuxtv.org/wiki/index.php/Hauppauge_WinTV-HVR-900H and use gentoo Since I upgrade my kernel from 2.6.38 to 3.* scan for channel doesn't work and channels can't be lock The modules (tm6000) are load, the

cron job: media_tree daily build: ERRORS

2011-11-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Nov 17 19:00:15 CET 2011 git hash:e9eb0dadba932940f721f9d27544a7818b2fa1c5 gcc version: i686-linux-gcc

[GIT PATCHES FOR 3.2] s5p-fimc and m5mols driver fixes

2011-11-17 Thread Sylwester Nawrocki
Hi Mauro, The following changes since commit 31cea59efb3a4210c063f31c061ebcaff833f583: [media] saa7134.h: Suppress compiler warnings when CONFIG_VIDEO_SAA7134_RC is not set (2011-11-03 16:58:20 -0200) are available in the git repository at:

Re: [PATCH 0/3] Move media staging drivers to staging/media

2011-11-17 Thread Tomas Winkler
On Thu, Nov 17, 2011 at 8:09 PM, Greg KH gre...@suse.de wrote: On Thu, Nov 17, 2011 at 07:47:50PM +0200, Tomas Winkler wrote: On Wed, Nov 2, 2011 at 5:10 PM, Greg KH gre...@suse.de wrote: On Wed, Nov 02, 2011 at 09:45:09AM -0200, Mauro Carvalho Chehab wrote: Greg, As agreed, this is the

Re: [PATCH 0/3] Move media staging drivers to staging/media

2011-11-17 Thread Greg KH
On Thu, Nov 17, 2011 at 09:10:27PM +0200, Tomas Winkler wrote: On Thu, Nov 17, 2011 at 8:09 PM, Greg KH gre...@suse.de wrote: On Thu, Nov 17, 2011 at 07:47:50PM +0200, Tomas Winkler wrote: On Wed, Nov 2, 2011 at 5:10 PM, Greg KH gre...@suse.de wrote: On Wed, Nov 02, 2011 at 09:45:09AM

Re: [PATCH v3][media] Exynos4 JPEG codec v4l2 driver

2011-11-17 Thread Sakari Ailus
On Thu, Nov 17, 2011 at 06:14:52PM +0100, Tomasz Stanislawski wrote: Hi Andrzej, Hi Andrzej and Tomasz, Thanks for the patch. I have a few more minor comments below. Please take a look on some comments below. You have done a great work, thanks for using selection API. I fully agree. Thanks,

scan returns channels with no VID

2011-11-17 Thread Brian J. Murrell
Hi. Using dvb-apps 1.1.1+rev1355-1ubuntu1 on Ubuntu, I'm scanning my qam channels with scan on both an Hauppage HVR-950q and HVR-1600 and the resulting output contains channels which I know are both audio and video yet the VID field of the output is 0. i.e. 120:58500:QAM_256:0:5842:11

Re: scan returns channels with no VID

2011-11-17 Thread Devin Heitmueller
On Thu, Nov 17, 2011 at 4:55 PM, Brian J. Murrell br...@interlinx.bc.ca wrote: Hi. Using dvb-apps 1.1.1+rev1355-1ubuntu1 on Ubuntu, I'm scanning my qam channels with scan on both an Hauppage HVR-950q and HVR-1600 and the resulting output contains channels which I know are both audio and video

Re: scan returns channels with no VID

2011-11-17 Thread Brian J. Murrell
On 11-11-17 04:58 PM, Devin Heitmueller wrote: I'm not sure about the ones that don't have a VID, but the ones that have a VID which aren't viewable are probably because they're encrypted. Fair enough. The /usr/bin/scan tool will return channels in the list regardless of whether they can

Re: [PATCH v3][media] Exynos4 JPEG codec v4l2 driver

2011-11-17 Thread Sylwester Nawrocki
Hello, On 11/17/2011 06:14 PM, Tomasz Stanislawski wrote: Hi Andrzej, Please take a look on some comments below. You have done a great work, thanks for using selection API. On 11/17/2011 10:41 AM, Andrzej Pietrasiewicz wrote: Add driver for the JPEG codec IP block available in Samsung