Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Arvydas Sidorenko
why the heck do we need this first_init? first_init was introduced in 7b1c8f58fcdbed75 for turning off LED when the cam finishes the capture. Andrea Anacleto andreaanacl...@libero.it claimed that the change broke his webcam on the same laptop, so he introduced that variable to fix the issue. It

[PATCH] staging/media: Use dev_ printks in cxd2099/cxd2099.[ch]

2012-11-02 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... - WARNING: Prefer netdev_warn(netdev, ... then

[PATCH 1/2] Staging/media: fixed spacing coding style in go7007/wis-ov7640.c

2012-11-02 Thread YAMANE Toshiaki
fixed below checkpatch error. - ERROR: that open brace { should be on the previous line Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com --- drivers/staging/media/go7007/wis-ov7640.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 2/2] Staging/media: Use dev_ printks in go7007/wis-ov7640.c

2012-11-02 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com

Re: [PATCH 1/2] Staging/media: fixed spacing coding style in go7007/wis-ov7640.c

2012-11-02 Thread Peter Senna Tschudin
On Fri, Nov 2, 2012 at 1:08 PM, YAMANE Toshiaki yamaneto...@gmail.com wrote: fixed below checkpatch error. - ERROR: that open brace { should be on the previous line Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com Tested-by: Peter Senna Tschudin peter.se...@gmail.com ---

Re: Skeleton LinuxDVB framework

2012-11-02 Thread Mauro Carvalho Chehab
Em Thu, 1 Nov 2012 16:15:41 -0700 Charlie X. Liu char...@sensoray.com escreveu: You could check or refer to the following links, for start: http://linuxtv.org/wiki/index.php/Main_Page http://www.linuxtv.org/wiki/index.php/LinuxTV_dvb-apps Be careful with the docs below:

Re: [PATCH 2/2] Staging/media: Use dev_ printks in go7007/wis-ov7640.c

2012-11-02 Thread Peter Senna Tschudin
On Fri, Nov 2, 2012 at 1:09 PM, YAMANE Toshiaki yamaneto...@gmail.com wrote: fixed below checkpatch warnings. - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then

Re: [PATCH] staging/media: Use dev_ printks in cxd2099/cxd2099.[ch]

2012-11-02 Thread Peter Senna Tschudin
On Fri, Nov 2, 2012 at 9:48 AM, YAMANE Toshiaki yamaneto...@gmail.com wrote: fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then

[PATCH 0/4] Speedup vivi

2012-11-02 Thread Kirill Smelkov
Hello up there. I was trying to use vivi to generate multiple video streams for my test-lab environment on atom system and noticed it wastes a lot of cpu. Please apply some optimization patches. Thanks, Kirill Kirill Smelkov (4): [media] vivi: Optimize gen_text() [media] vivi:

[PATCH 1/4] [media] vivi: Optimize gen_text()

2012-11-02 Thread Kirill Smelkov
I've noticed that vivi takes a lot of CPU to produce its frames. For example for 8 devices and 8 simple programs running, where each captures YUY2 640x480 and displays it to X via SDL, profile timing is as follows: # cmdline : /home/kirr/local/perf/bin/perf record -g -a sleep 20 #

[PATCH 2/4] [media] vivi: vivi_dev-line[] was not aligned

2012-11-02 Thread Kirill Smelkov
Though dev-line[] is u8 array we work with it as with u16, u24 or u32 pixels, and also pass it to memcpy() and it's better to align it to at least 4. Before the patch, on x86 offsetof(vivi_dev, line) was 1003 and after patch it is 1004. There is slight performance increase, but I think is is

[PATCH 3/4] [media] vivi: Move computations out of vivi_fillbuf linecopy loop

2012-11-02 Thread Kirill Smelkov
The dev-mvcount % wmax thing was showing high in profiles (we do it for each line which ~ 500 per frame) │ 10c0 vivi_fillbuff: ... 0,39 │ 70:┌─→mov0x3ff4(%edi),%esi 0,22 │ 76:│ mov0x2a0(%edi),%eax 0,30 ││ mov-0x84(%ebp),%ebx

[PATCH 4/4] [media] vivi: Optimize precalculate_line()

2012-11-02 Thread Kirill Smelkov
precalculate_line() is not very high on profile, but it calls expensive gen_twopix(), so let's polish it too: call gen_twopix() only once for every color bar and then distribute the result. before: # cmdline : /home/kirr/local/perf/bin/perf record -g -a sleep 20 # # Samples:

drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-02 Thread Mauro Carvalho Chehab
Em Thu, 1 Nov 2012 14:12:44 -0200 Mauro Carvalho Chehab mche...@redhat.com escreveu: Em Thu, 1 Nov 2012 16:44:50 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On Thu October 25 2012 19:27:01 Mauro Carvalho Chehab wrote: Hi Hans, Em Mon, 22 Oct 2012 10:35:56 +0200 Hans Verkuil

Updated patches for (potential) NULL pointer crashes in cir drivers

2012-11-02 Thread Matthijs Kooijman
(Please keep me CC'd, I'm not subscribed to the list) Hi folks, I've updated my patches to apply against Mauro's staging/for_v3.8 branch. The patches have only been modified to apply against recent changes in some of the drivers. Like before, these patches have been really tested only on

[PATCH 1/3] [media] rc: Make probe cleanup goto labels more verbose

2012-11-02 Thread Matthijs Kooijman
Before, labels were simply numbered. Now, the labels are named after the cleanup action they'll perform (first), based on how the winbond-cir driver does it. This makes the code a bit more clear and makes changes in the ordering of labels easier to review. This change is applied only to the rc

[PATCH 2/3] [media] rc: Set rdev before irq setup

2012-11-02 Thread Matthijs Kooijman
This fixes a problem in fintek-cir and nuvoton-cir where the irq handler would trigger during module load before the rdev member was set, causing a NULL pointer crash. It seems this crash is very reproducible (just bombard the receiver with IR signals during module load), probably because when

[PATCH 3/3] [media] rc: Call rc_register_device before irq setup

2012-11-02 Thread Matthijs Kooijman
This should fix a potential race condition, when the irq handler triggers while rc_register_device is still setting up the rdev-raw device. This crash has not been observed in practice, but there should be a very small window where it could occur. Since ir_raw_event_store_with_filter checks if

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Ezequiel Garcia
Hi Arvydas, On Fri, Nov 2, 2012 at 4:35 AM, Arvydas Sidorenko asi...@gmail.com wrote: why the heck do we need this first_init? first_init was introduced in 7b1c8f58fcdbed75 for turning off LED when the cam finishes the capture. Andrea Anacleto andreaanacl...@libero.it claimed that the

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-02 Thread Hans Verkuil
On Fri November 2 2012 14:13:10 Mauro Carvalho Chehab wrote: Em Thu, 1 Nov 2012 14:12:44 -0200 Mauro Carvalho Chehab mche...@redhat.com escreveu: Em Thu, 1 Nov 2012 16:44:50 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On Thu October 25 2012 19:27:01 Mauro Carvalho Chehab wrote:

Re: [PATCH 0/4] Speedup vivi

2012-11-02 Thread Hans Verkuil
On Fri November 2 2012 14:10:29 Kirill Smelkov wrote: Hello up there. I was trying to use vivi to generate multiple video streams for my test-lab environment on atom system and noticed it wastes a lot of cpu. Please apply some optimization patches. Looks good! For the whole series:

Re: [PATCH v3] [media] vivi: Teach it to tune FPS

2012-11-02 Thread Kirill Smelkov
On Tue, Oct 23, 2012 at 05:35:21PM +0400, Kirill Smelkov wrote: On Tue, Oct 23, 2012 at 08:40:04AM +0200, Hans Verkuil wrote: On Mon October 22 2012 19:01:40 Kirill Smelkov wrote: On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote: On Mon October 22 2012 15:54:44 Kirill Smelkov

Re: [PATCH 0/4] Speedup vivi

2012-11-02 Thread Kirill Smelkov
On Fri, Nov 02, 2012 at 02:48:43PM +0100, Hans Verkuil wrote: On Fri November 2 2012 14:10:29 Kirill Smelkov wrote: Hello up there. I was trying to use vivi to generate multiple video streams for my test-lab environment on atom system and noticed it wastes a lot of cpu. Please apply

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-02 Thread Mauro Carvalho Chehab
Em Fri, 2 Nov 2012 14:47:49 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On Fri November 2 2012 14:13:10 Mauro Carvalho Chehab wrote: Em Thu, 1 Nov 2012 14:12:44 -0200 Mauro Carvalho Chehab mche...@redhat.com escreveu: Em Thu, 1 Nov 2012 16:44:50 +0100 Hans Verkuil

Re: [PATCH v3] [media] vivi: Teach it to tune FPS

2012-11-02 Thread Hans Verkuil
Thanks for the ping, I forgot about this patch... On Tue October 23 2012 15:35:21 Kirill Smelkov wrote: On Tue, Oct 23, 2012 at 08:40:04AM +0200, Hans Verkuil wrote: On Mon October 22 2012 19:01:40 Kirill Smelkov wrote: On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote: On

RE: [media-workshop] drivers without explicit MAINTAINERS entry - was: Re: Tentative Agenda for the November workshop

2012-11-02 Thread Palash Bandyopadhyay
Thanks Hans and Mauro. On any of the CX drivers, if we do not have any maintainer or odd fixer, you could add me to the odd fixer list. Rgds, Palash -Original Message- From: media-workshop-boun...@linuxtv.org [mailto:media-workshop-boun...@linuxtv.org] On Behalf Of Mauro Carvalho

Re: [PATCH v3] [media] vivi: Teach it to tune FPS

2012-11-02 Thread Kirill Smelkov
On Fri, Nov 02, 2012 at 03:42:21PM +0100, Hans Verkuil wrote: Thanks for the ping, I forgot about this patch... Thanks for the reply. Have to run now - will try to rework it in several days. Thanks again, Kirill On Tue October 23 2012 15:35:21 Kirill Smelkov wrote: On Tue, Oct 23, 2012 at

Re: [PATCH v7 2/8] of: add helper to parse display timings

2012-11-02 Thread Leela Krishna Amudala
Hello Steffen, On Wed, Oct 31, 2012 at 2:58 PM, Steffen Trumtrar s.trumt...@pengutronix.de wrote: Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 139 +++ drivers/of/Kconfig |6

RE: Skeleton LinuxDVB framework

2012-11-02 Thread Charlie X. Liu
Thanks Mauro, for pointing out and clarifying. -- Charlie -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media-ow...@vger.kernel.org] On Behalf Of Mauro Carvalho Chehab Sent: Friday, November 02, 2012 5:48 AM To: Charlie X. Liu Cc: 'Richard';

Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h

2012-11-02 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [121030 09:31]: OK so are people happy with the patches in this series? Please everybody ack if no more comments so we can move on towards getting CONFIG_MULTIPLATFORM to work for omaps. Looks like Joerg has a new email address, I'll send this series out

[PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c

2012-11-02 Thread Tony Lindgren
This file should not be in arch/arm. Move it to drivers/iommu to allow making most of the header local to drivers/iommu. This is needed as we are removing plat and mach includes from drivers for ARM common zImage support. Cc: Joerg Roedel j...@8bytes.org Cc: Ohad Ben-Cohen o...@wizery.com Cc:

[PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h

2012-11-02 Thread Tony Lindgren
Looks like the iommu framework does not have generic functions exported for all the needs yet. The hardware specific functions are defined in files like intel-iommu.h and amd-iommu.h. Follow the same standard for omap-iommu.h. This is needed because we are removing plat and mach includes for ARM

cron job: media_tree daily build: WARNINGS

2012-11-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Nov 2 19:00:23 CET 2012 git hash:8f7e91a31fb95c50880c76505b416630c0326d93 gcc version: i686-linux-gcc

Re: small regression in mediatree/for_v3.7-3 - media_build

2012-11-02 Thread VDR User
On Tue, Aug 14, 2012 at 4:51 PM, Antti Palosaari cr...@iki.fi wrote: There seems to be a small regression on mediatree/for_v3.7-3 - dmesg/klog get flooded with these: [201145.140260] dvb_frontend_poll: 15 callbacks suppressed [201145.586405] usb_urb_complete: 88 callbacks suppressed