[PATCH v10 2/6] video: add of helper for videomode

2012-11-15 Thread Steffen Trumtrar
This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where each property can have up to 3 values. All children are read into an array, that can be queried. of_get_videomode

[PATCH v10 4/6] fbmon: add of_videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add helper to get fb_videomode from devicetree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/fbmon.c | 42 +- include/linux/fb.h|6 ++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git

[PATCH v10 1/6] video: add display_timing and videomode

2012-11-15 Thread Steffen Trumtrar
Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single value or a range min typ max. Also, add helper functions to convert from display timings to a generic

[PATCH v10 5/6] drm_modes: add videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add conversion from videomode to drm_display_mode Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/gpu/drm/drm_modes.c | 37 + include/drm/drmP.h |6 ++ 2 files changed, 43 insertions(+) diff --git

[PATCH v10 6/6] drm_modes: add of_videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add helper to get drm_display_mode from devicetree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/gpu/drm/drm_modes.c | 35 ++- include/drm/drmP.h |6 ++ 2 files changed, 40 insertions(+), 1 deletion(-) diff --git

[PATCH v10 3/6] fbmon: add videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/fbmon.c | 46 ++ include/linux/fb.h|6 ++ 2 files changed, 52 insertions(+) diff --git

[PATCH v10 0/6] of: add display helper

2012-11-15 Thread Steffen Trumtrar
Hi! Changes since v9: - don't leak memory when previous timings were correct - CodingStyle fixes - move blank lines around Regards, Steffen Steffen Trumtrar (6): video: add display_timing and videomode video: add of helper for videomode fbmon: add videomode

Re: [PATCH v10 6/6] drm_modes: add of_videomode helpers

2012-11-15 Thread Thierry Reding
On Thu, Nov 15, 2012 at 10:23:57AM +0100, Steffen Trumtrar wrote: [...] +int of_get_drm_display_mode(struct device_node *np, + struct drm_display_mode *dmode, unsigned int index) +{ + struct videomode vm; + int ret; + + ret = of_get_videomode(np, vm,

Re: [PATCH v10 6/6] drm_modes: add of_videomode helpers

2012-11-15 Thread Steffen Trumtrar
On Thu, Nov 15, 2012 at 10:58:49AM +0100, Thierry Reding wrote: On Thu, Nov 15, 2012 at 10:23:57AM +0100, Steffen Trumtrar wrote: [...] +int of_get_drm_display_mode(struct device_node *np, + struct drm_display_mode *dmode, unsigned int index) +{ + struct videomode

Re: [PATCH v10 0/6] of: add display helper

2012-11-15 Thread Thierry Reding
On Thu, Nov 15, 2012 at 10:23:51AM +0100, Steffen Trumtrar wrote: Hi! Changes since v9: - don't leak memory when previous timings were correct - CodingStyle fixes - move blank lines around Regards, Steffen Steffen Trumtrar (6): video: add display_timing and

Re: [PATCH v10 0/6] of: add display helper

2012-11-15 Thread Thierry Reding
On Thu, Nov 15, 2012 at 11:24:11AM +0100, Thierry Reding wrote: On Thu, Nov 15, 2012 at 10:23:51AM +0100, Steffen Trumtrar wrote: Hi! Changes since v9: - don't leak memory when previous timings were correct - CodingStyle fixes - move blank lines around Regards,

Re: [PATCH v10 0/6] of: add display helper

2012-11-15 Thread Steffen Trumtrar
On Thu, Nov 15, 2012 at 11:24:11AM +0100, Thierry Reding wrote: On Thu, Nov 15, 2012 at 10:23:51AM +0100, Steffen Trumtrar wrote: Hi! Changes since v9: - don't leak memory when previous timings were correct - CodingStyle fixes - move blank lines around Regards,

[PATCH v11 3/6] fbmon: add videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Reviewed-by: Thierry Reding thierry.red...@avionic-design.de Acked-by: Thierry Reding thierry.red...@avionic-design.de Tested-by: Thierry Reding

[PATCH v11 5/6] drm_modes: add videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add conversion from videomode to drm_display_mode Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Reviewed-by: Thierry Reding thierry.red...@avionic-design.de Acked-by: Thierry Reding thierry.red...@avionic-design.de Tested-by: Thierry Reding thierry.red...@avionic-design.de Tested-by:

[PATCH v11 0/6] of: add display helper

2012-11-15 Thread Steffen Trumtrar
Hi! Changes since v10: - fix function name (drm_)display_mode_from_videomode - add acked-by, reviewed-by, tested-by Regards, Steffen Steffen Trumtrar (6): video: add display_timing and videomode video: add of helper for videomode fbmon: add videomode helpers fbmon: add

[PATCH v11 1/6] video: add display_timing and videomode

2012-11-15 Thread Steffen Trumtrar
Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single value or a range min typ max. Also, add helper functions to convert from display timings to a generic

[PATCH v11 6/6] drm_modes: add of_videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add helper to get drm_display_mode from devicetree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Reviewed-by: Thierry Reding thierry.red...@avionic-design.de Acked-by: Thierry Reding thierry.red...@avionic-design.de Tested-by: Thierry Reding thierry.red...@avionic-design.de

[PATCH v11 4/6] fbmon: add of_videomode helpers

2012-11-15 Thread Steffen Trumtrar
Add helper to get fb_videomode from devicetree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Reviewed-by: Thierry Reding thierry.red...@avionic-design.de Acked-by: Thierry Reding thierry.red...@avionic-design.de Tested-by: Thierry Reding thierry.red...@avionic-design.de Tested-by:

[PATCH v11 2/6] video: add of helper for videomode

2012-11-15 Thread Steffen Trumtrar
This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where each property can have up to 3 values. All children are read into an array, that can be queried. of_get_videomode

[PATCH v2] [media] vpif_capture: fix return value check

2012-11-15 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function vb2_dma_contig_init_ctx() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generate this patch.

Re: [PATCH v10 1/6] video: add display_timing and videomode

2012-11-15 Thread Grant Likely
On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar s.trumt...@pengutronix.de wrote: Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single value or a

Re: [PATCH v10 1/6] video: add display_timing and videomode

2012-11-15 Thread Laurent Pinchart
Hi Grant, On Thursday 15 November 2012 15:47:53 Grant Likely wrote: On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar wrote: Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing

Re: The em28xx driver error

2012-11-15 Thread Frank Schäfer
Am 14.11.2012 18:05, schrieb Devin Heitmueller: On Wed, Nov 14, 2012 at 11:58 AM, Frank Schäfer fschaefer@googlemail.com wrote: This looks indeed like a bug. a = b means a = a b, which in this case means shifting height 480 or 576 bits to the right... height 1 means height /= 2 which

Re: The em28xx driver error

2012-11-15 Thread Devin Heitmueller
On Thu, Nov 15, 2012 at 11:31 AM, Frank Schäfer fschaefer@googlemail.com wrote: Hmm... I've made some experiments to find out what gcc does on x86 and it seems to ignore bit shifting 32. I also noticed that this line has been removed in 3.7-rc. So we do NOT want to halve the height for

Re: The em28xx driver error

2012-11-15 Thread Frank Schäfer
Am 15.11.2012 17:35, schrieb Devin Heitmueller: On Thu, Nov 15, 2012 at 11:31 AM, Frank Schäfer fschaefer@googlemail.com wrote: Hmm... I've made some experiments to find out what gcc does on x86 and it seems to ignore bit shifting 32. I also noticed that this line has been removed in

Re: [GIT PULL FOR v3.8] OMAP3 ISP fixes

2012-11-15 Thread Laurent Pinchart
Hi Mauro, Once again, please cancel this pull request. One of the patches contains a subtle bug, I'll resubmit it. Sorry for the inconvenience. On Tuesday 13 November 2012 15:35:20 Laurent Pinchart wrote: Hi Mauro, The following changes since commit 01aea0bfd8dfa8bc868df33904461984bb10a87a:

[PATCH v3] omap3isp: preview: Add support for 8-bit formats at the sink pad

2012-11-15 Thread Laurent Pinchart
Support both grayscale (Y8) and Bayer (SBGGR8, SGBRG8, SGRBG8 and SRGGB8) formats. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/platform/omap3isp/isppreview.c | 41 + 1 files changed, 28

Re: [PATCH v10 1/6] video: add display_timing and videomode

2012-11-15 Thread Grant Likely
On Thu, 15 Nov 2012 17:00:57 +0100, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Grant, On Thursday 15 November 2012 15:47:53 Grant Likely wrote: On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar wrote: Add display_timing structure and the according helper functions.

Re: hdpvr driver and VIDIOC_G_FMT

2012-11-15 Thread David Röthlisberger
On 1 Oct 2012, at 10:09, Hans Verkuil wrote: On Sun September 30 2012 14:51:36 David Röthlisberger wrote: I am using the Hauppauge HD PVR video-capture device with a GStreamer v4l2src. The HD PVR has an upstream driver called hdpvr:

Re: [PATCH v10 1/6] video: add display_timing and videomode

2012-11-15 Thread Laurent Pinchart
On Thursday 15 November 2012 18:03:59 Grant Likely wrote: On Thu, 15 Nov 2012 17:00:57 +0100, Laurent Pinchart wrote: On Thursday 15 November 2012 15:47:53 Grant Likely wrote: On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar wrote: Add display_timing structure and the according

Linux v3.7-rc2 DVB breaks user space compilation

2012-11-15 Thread Rémi Denis-Courmont
Hello, The following patch broke our userspace software builds. While it does preserve BINARY compatibility, it breaks SOURCE compatibility as the parameter names have changed. I don't see the rationale for breaking compatibility in the patch description. Please consider reverting to

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

2012-11-15 Thread Sakari Ailus
Hi Laurent, Thanks for the comments. On Thu, Nov 15, 2012 at 01:46:23AM +0100, Laurent Pinchart wrote: On Wednesday 14 November 2012 23:13:45 Sakari Ailus wrote: On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: On 11/13/2012 03:24 PM, Sakari Ailus wrote: Hi all,

cron job: media_tree daily build: WARNINGS

2012-11-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Nov 15 19:00:23 CET 2012 git hash:2c4e11b7c15af70580625657a154ea7ea70b8c76 gcc version: i686-linux-gcc

Re: tda8290 regression fix

2012-11-15 Thread Anders Thomson
On 2012-10-01 18:56, Anders Thomson wrote: On 2012-09-23 23:06, Anders Thomson wrote: Awfully sorry about this. After having had the familty sit in and check the differences, I must say that the patch does not fix the issue. This time around I have x11grabs with ffmpeg to show if you

[PATCH RFC v3 0/3] S3C244X/S3C64XX SoC series camera interface driver

2012-11-15 Thread Sylwester Nawrocki
This patch series adds V4L2 driver for Samsung S3C244X/S3C64XX SoCs camera interface. Changes since v2: - use V4L2_CID_TEST_PATTERN instead of a private control, - added explicit PM_RUNTIME dependency, - device name appended in bus_info in vidioc_querycap ioctl, - added image effect controls,

[PATCH 2/4] v4l: Helper function for obtaining timestamps

2012-11-15 Thread Sakari Ailus
v4l2_get_timestamp() produces a monotonic timestamp but unlike ktime_get_ts(), it uses struct timeval instead of struct timespec, saving the drivers the conversion job when getting timestamps for v4l2_buffer's timestamp field. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi ---

[PATCH 1/4] v4l: Define video buffer flags for timestamp types

2012-11-15 Thread Sakari Ailus
Define video buffer flags for different timestamp types. Everything up to now have used either realtime clock or monotonic clock, without a way to tell which clock the timestamp was taken from. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart

[PATCH 4/4] v4l: Tell user space we're using monotonic timestamps

2012-11-15 Thread Sakari Ailus
Set buffer timestamp flags for videobuf, videobuf2 and drivers that use neither. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/pci/meye/meye.c |4 ++-- drivers/media/pci/zoran/zoran_driver.c

[PATCH 0/4] Monotonic timestamps

2012-11-15 Thread Sakari Ailus
Hi all, Here's my first monotonic timestamps patch series. Since the RFC series, I've corrected a warning in drivers/media/usb/s2255/s2255drv.c that was caused by an unused variable. All affected drivers compile without warnings. I've tested this on the OMAP 3 ISP: 02:11:34 sailus@peruna

[yavta PATCH 0/2] Timestamp type support

2012-11-15 Thread Sakari Ailus
Hi, This patchset adds timestamp type printing to yavta. -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

[yavta PATCH 2/2] Print v4l2_buffer timestamp type

2012-11-15 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- yavta.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/yavta.c b/yavta.c index bf3e096..a50f11e 100644 --- a/yavta.c +++ b/yavta.c @@ -464,6 +464,7 @@ static int video_alloc_buffers(struct device *dev, int

Re: Hauppauge WinTV HVR 900 (M/R 65018/B3C0) doesn't work anymore since linux 3.6.6

2012-11-15 Thread Greg KH
On Wed, Nov 14, 2012 at 09:30:14PM +0100, Philippe Valembois - Phil wrote: Hello, I have posted a bug report here : https://bugzilla.kernel.org/show_bug.cgi?id=50361 and I have been told to send it to the ML too. The commit causing the bug has been pushed to kernel between linux-3.5 and

[PATCH] Autoselect more relevant frontends for EM28XX DVB stick

2012-11-15 Thread Jonathan McDowell
Compiling up 3.6.6 for my media box recently I noticed that the EM28XX DVB driver doesn't auto select all of the appropriate DVB tuner modules required. In particular I needed DVB_LGDT3305 for my a340, but it looks like DVB_MT352 + DVB_S5H1409 were missing as well. Patch below adds the appropriate

Re: [PATCH v2] [media] vpif_capture: fix return value check

2012-11-15 Thread Prabhakar Lad
Hi Wei, Thanks for the patch. On Thu, Nov 15, 2012 at 6:48 PM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function vb2_dma_contig_init_ctx() returns ERR_PTR() and never returns NULL. The NULL test in the return value check

[PATCH 1/1] [media] s5p-tv: Use devm_gpio_request in sii9234_drv.c

2012-11-15 Thread Sachin Kamat
devm_gpio_request is a device managed function and will make error handling and cleanup a bit simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/platform/s5p-tv/sii9234_drv.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 1/1] [media] s5p-tv: Use devm_gpio_request in sii9234_drv.c

2012-11-15 Thread Tomasz Stanislawski
On 11/16/2012 05:55 AM, Sachin Kamat wrote: devm_gpio_request is a device managed function and will make error handling and cleanup a bit simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com ---

[PATCH 00/14] Modify signed comparisons of unsigned variables

2012-11-15 Thread Tushar Behera
The occurrences were identified through the coccinelle script at following location. http://www.emn.fr/z-info/coccinelle/rules/find_unsigned.cocci Signed checks for unsigned variables are removed if it is also checked for upper error limit. For error checks, IS_ERR_VALUE() macros is used.

[PATCH 01/14] [media] ivtv: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: ivtv-de...@ivtvdriver.org CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/pci/ivtv/ivtv-ioctl.c |2 +- 1 files changed, 1

[PATCH 03/14] [media] saa7134: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether the unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/pci/saa7134/saa7134-video.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 04/14] [media] tlg2300: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/usb/tlg2300/pd-video.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-15 Thread Tushar Behera
Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/platform/soc_camera/atmel-isi.c |2

[PATCH 02/14] [media] meye: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/pci/meye/meye.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff