Re: [PATCH v2 1/5] V4L2: I2C: ML86V7667 video decoder driver

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 20:40:30 Sergei Shtylyov wrote: From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add OKI Semiconductor ML86V7667 video decoder driver. Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com [Sergei: added v4l2_device_unregister_subdev() call to

Re: [PATCH RFCv3 01/10] [media] Add initial SDR support at V4L2 API

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 21:00:30 Mauro Carvalho Chehab wrote: Adds the basic API bits for Software Digital Radio (SDR) at the V4L2 API. A normal radio device is actually radio and hardware demod. As the demod is in hardware, several things that are required for the demodulate the signal (IF,

Re: [PATCH RFCv3 02/10] [media] videodev2.h: Remove the unused old V4L1 buffer types

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 21:00:31 Mauro Carvalho Chehab wrote: Those aren't used anywhere for a long time. Drop it. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- include/uapi/linux/videodev2.h | 21 - 1 file

Re: [PATCH RFCv3 03/10] [media] V4L2 api: Add a buffer capture type for SDR

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 21:00:32 Mauro Carvalho Chehab wrote: As SDR devices are not video, VBI or RDS devices, it needs its own buffer type for capture. Also, as discussed at: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/63123 It should be a way to

Re: [PATCH RFCv3 04/10] [media] V4L2 sdr API: Add fields for VIDIOC_[G|S]_TUNER

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 21:00:33 Mauro Carvalho Chehab wrote: As discussed at: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/63123 SDR radio require some other things at to set. VIDIOC_[G|S]_TUNER is currently not enough. I proposed there to create an extra

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-22 Thread Prabhakar Lad
Hi Guennadi, Thanks for the patch! On Fri, Apr 12, 2013 at 9:10 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Currently bridge device drivers register devices for all subdevices synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor is attached to a video bridge

Re: [PATCH RFCv3 07/10] [media] tuner-core: add SDR support for g_tuner

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 21:00:36 Mauro Carvalho Chehab wrote: Properly initialize the fields for VIDIOC_G_TUNER, if the device is in SDR mode. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/v4l2-core/tuner-core.c | 29 + 1 file changed,

Re: [PATCH RFCv3 08/10] [media] tuner-core: store tuner ranges at tuner struct

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 21:00:37 Mauro Carvalho Chehab wrote: Instead of using global values for tuner ranges, store them internally. That fixes the need of using a different range for SDR radio, and will help to latter add a tuner ops to retrieve the tuner range for SDR mode. Signed-off-by:

[PATCH] [media] hdpvr: error handling and alloc abuse cleanup.

2013-04-22 Thread Leonid Kegulskiy
Removed unnecessary use of kzalloc() in get_video_info(). Removed unnecessary get_video_info() call from hdpvr_device_init(). Cleaned up error handling in hdpvr_start_streaming() to ensure caller gets a failure status if device is not functioning properly. Cleaned up error handling in

Re: [PATCH RFCv3 00/10] Add SDR at V4L2 API

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 21:00:29 Mauro Carvalho Chehab wrote: This is a version 3 of the V4L2 API bits to support Software Digital Radio (SDR). Changes from version 2: - Patches got better described and named; - Merged all SDR analog TV into just one field; - Documented

Re: [PATCH] [media] hdpvr: error handling and alloc abuse cleanup.

2013-04-22 Thread Hans Verkuil
On Mon April 22 2013 09:23:03 Leonid Kegulskiy wrote: Removed unnecessary use of kzalloc() in get_video_info(). Removed unnecessary get_video_info() call from hdpvr_device_init(). Cleaned up error handling in hdpvr_start_streaming() to ensure caller gets a failure status if device is not

Re: [RFC] Motion Detection API

2013-04-22 Thread Hans Verkuil
On Sun April 21 2013 14:04:26 Ismael Luceno wrote: On Fri, 12 Apr 2013 17:36:16 +0200 Hans Verkuil hverk...@xs4all.nl wrote: This RFC looks at adding support for motion detection to V4L2. This is the main missing piece that prevents the go7007 and solo6x10 drivers from being moved into

[GIT PULL FOR 3.10] DiBxxxx: fixes and improvements

2013-04-22 Thread Patrick Boettcher
Hi Mauro, These patches contains some fixes and changes for the DiBcom demods and SIPs. Please merge for 3.10 if possible. The following changes since commit 60d509fa6a9c4653a86ad830e4c4b30360b23f0e: Linux 3.9-rc8 (2013-04-21 14:38:45 -0700) are available in the git repository at:

Re: [PATCH v2 1/5] V4L2: I2C: ML86V7667 video decoder driver

2013-04-22 Thread Vladimir Barinov
Hi Hans, Thank you for the review. Hans Verkuil wrote: +#include media/v4l2-chip-ident.h This include should be removed as well. ok + +static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std) +{ + struct ml86v7667_priv *priv = to_ml86v7667(sd); + +

Re: [PATCH v2 1/5] V4L2: I2C: ML86V7667 video decoder driver

2013-04-22 Thread Hans Verkuil
On Mon April 22 2013 10:39:42 Vladimir Barinov wrote: Hi Hans, Thank you for the review. Hans Verkuil wrote: +#include media/v4l2-chip-ident.h This include should be removed as well. ok + +static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: 2013/4/21 Tomasz Figa tomasz.f...@gmail.com Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: On 8 April 2013 16:37, Vikas Sajjan vikas.saj...@linaro.org wrote: While migrating to common clock framework

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote: 3) after those two changes, all that remains is to fix compliance with Common Clock Framework, in other words: s/clk_enable/clk_prepare_enable/ and

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-22 Thread Mark Brown
On Mon, Apr 22, 2013 at 01:14:07AM +0200, Laurent Pinchart wrote: I think that Mark's point was that the regulators should be provided by platform code (in the generic sense, it could be DT on ARM, board code, or a USB bridge driver for a webcam that uses the mt9p031 sensor) and used by the

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Sylwester Nawrocki
On 04/22/2013 11:56 AM, Tomasz Figa wrote: On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote: 3) after those two changes, all that remains is to fix compliance with Common Clock Framework, in other words:

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Sylwester Nawrocki
On 04/22/2013 12:03 PM, Inki Dae wrote: Also looks good to me. But what if power domain was disabled without pm runtime? In this case, you must enable the power domain at machine code or bootloader somewhere. This way would not only need some hard codes to turn the

[PATCH RFC v2 0/4] media: davinci: vpif: capture/display support for async subdevice probing

2013-04-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch series adds support for vpif capture and display driver to support asynchronously register subdevices. The first two patches adds asynchronous probing for adv7343 and tvp514x respectively. Need for this support: Currently bridge device

[PATCH RFC v2 1/4] media: i2c: adv7343: add support for asynchronous probing

2013-04-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Both synchronous and asynchronous adv7343 subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com

[PATCH RFC v2 2/4] media: i2c: tvp514x: add support for asynchronous probing

2013-04-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Both synchronous and asynchronous tvp514x subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc:

[PATCH RFC v2 3/4] media: davinci: vpif: capture: add V4L2-async support

2013-04-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which allows to gradually update drivers and platforms. Signed-off-by: Prabhakar Lad prabhakar.cse...@gmail.com Cc:

[PATCH RFC v2 4/4] media: davinci: vpif: display: add V4L2-async support

2013-04-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which allows to gradually update drivers and platforms. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc:

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Viresh Kumar
On 22 April 2013 15:26, Tomasz Figa t.f...@samsung.com wrote: Can you assure that in future SoCs, on which this driver will be used, this assumption will still hold true or even that in current Exynos driver this behavior won't be changed? Probably yes.. Registers for enabling/disabling these

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: On 04/22/2013 12:03 PM, Inki Dae wrote: Also looks good to me. But what if power domain was disabled without pm runtime? In this case, you must enable the power domain at machine code or bootloader

Re: [PATCH RFC v2 1/4] media: i2c: adv7343: add support for asynchronous probing

2013-04-22 Thread Guennadi Liakhovetski
Hi Prabhakar On Mon, 22 Apr 2013, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Both synchronous and asynchronous adv7343 subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Guennadi Liakhovetski

Re: [PATCH RFC v2 1/4] media: i2c: adv7343: add support for asynchronous probing

2013-04-22 Thread Prabhakar Lad
Hi Guennadi, Thanks for the quick review. On Mon, Apr 22, 2013 at 4:08 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Prabhakar On Mon, 22 Apr 2013, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Both synchronous and asynchronous adv7343 subdevice probing

Re: [PATCH] V4L2: fix subdevice matching in asynchronous probing

2013-04-22 Thread Guennadi Liakhovetski
On Mon, 22 Apr 2013, Laurent Pinchart wrote: Hi Guennadi, On Friday 19 April 2013 16:41:02 Guennadi Liakhovetski wrote: A wrapped list iterating loop hasn't been correctly recognised in v4l2_async_belongs(), which led to false positives. Fix the bug by verifying the loop termination

Re: Patch update notification: 2 patches updated

2013-04-22 Thread Prabhakar Lad
Hi Mauro, On Sat, Apr 20, 2013 at 5:43 PM, Patchwork patchw...@linuxtv.org wrote: Hello, The following patches (submitted by you) have been updated in patchwork: * [2/2] media: davinci: vpif_display: move displaying of error to approppraite place -

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Rafael J. Wysocki
On Monday, April 22, 2013 12:37:36 PM Tomasz Figa wrote: On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: On 04/22/2013 12:03 PM, Inki Dae wrote: Also looks good to me. But what if power domain was disabled without pm runtime? In this case, you must enable

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-22 Thread Laurent Pinchart
Hi Guennadi and Sylwester, On Monday 15 April 2013 13:57:17 Sylwester Nawrocki wrote: On 04/12/2013 05:40 PM, Guennadi Liakhovetski wrote: Currently bridge device drivers register devices for all subdevices synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor is

Re: [PATCH RFC] media: videobuf2: fix the length check for mmap

2013-04-22 Thread Mauro Carvalho Chehab
Em 21-04-2013 19:38, Laurent Pinchart escreveu: Hi Mauro, On Friday 19 April 2013 08:18:01 Mauro Carvalho Chehab wrote: Em Fri, 19 Apr 2013 15:16:56 +0530 Prabhakar lad escreveu: From: Lad, Prabhakar prabhakar.cse...@gmail.com From commit 068a0df76023926af958a336a78bef60468d2033 [media]

Re: [PATCH RFCv3 07/10] [media] tuner-core: add SDR support for g_tuner

2013-04-22 Thread Mauro Carvalho Chehab
Em 22-04-2013 04:18, Hans Verkuil escreveu: On Sun April 21 2013 21:00:36 Mauro Carvalho Chehab wrote: Properly initialize the fields for VIDIOC_G_TUNER, if the device is in SDR mode. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/v4l2-core/tuner-core.c | 29

Re: [PATCH 05/24] V4L2: allow dummy file-handle initialisation by v4l2_fh_init()

2013-04-22 Thread Laurent Pinchart
Hi Hans, On Friday 19 April 2013 09:22:50 Hans Verkuil wrote: On Thu April 18 2013 23:35:26 Guennadi Liakhovetski wrote: v4l2_fh_init() can be used to initialise dummy file-handles with vdev == NULL. Why would you want that? The reason is that subdev pad operations require a file handle

Re: [PATCH RFCv3 08/10] [media] tuner-core: store tuner ranges at tuner struct

2013-04-22 Thread Mauro Carvalho Chehab
Em 22-04-2013 04:22, Hans Verkuil escreveu: On Sun April 21 2013 21:00:37 Mauro Carvalho Chehab wrote: Instead of using global values for tuner ranges, store them internally. That fixes the need of using a different range for SDR radio, and will help to latter add a tuner ops to retrieve the

Re: [PATCH 18/24] V4L2: mt9p031: power down the sensor if no supported device has been detected

2013-04-22 Thread Laurent Pinchart
Hi Guennadi, Thanks for the patch. On Thursday 18 April 2013 23:35:39 Guennadi Liakhovetski wrote: The mt9p031 driver first accesses the I2C device in its .registered() method. While doing that it furst powers the device up, but if probing s/furst/first/ fails, it doesn't power the chip

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:05:49 Sylwester Nawrocki wrote: On 04/22/2013 11:56 AM, Tomasz Figa wrote: On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote: 3) after those two changes, all that remains is to fix compliance

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Laurent Pinchart
Hi Guennadi, On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote: On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions to manage sensor power supplies. Signed-off-by:

Re: [PATCH 18/24] V4L2: mt9p031: power down the sensor if no supported device has been detected

2013-04-22 Thread Guennadi Liakhovetski
Hi Laurent On Mon, 22 Apr 2013, Laurent Pinchart wrote: Hi Guennadi, Thanks for the patch. On Thursday 18 April 2013 23:35:39 Guennadi Liakhovetski wrote: The mt9p031 driver first accesses the I2C device in its .registered() method. While doing that it furst powers the device up, but

Re: [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support

2013-04-22 Thread Sergei Shtylyov
Hello. On 22-04-2013 8:57, Simon Horman wrote: From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add VIN clocks and platform devices for R8A7779 SoC; add function to register the VIN platform devices. Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com [Sergei:

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Guennadi Liakhovetski
On Mon, 22 Apr 2013, Laurent Pinchart wrote: Hi Guennadi, On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote: On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions to

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Laurent Pinchart
Hi Guennadi, On Thursday 18 April 2013 23:35:44 Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions to manage sensor power supplies. The mt9p031 driver now handles its regulators explicitly, please see

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-22 Thread Mauro Carvalho Chehab
Em 22-04-2013 07:03, Mark Brown escreveu: On Mon, Apr 22, 2013 at 01:14:07AM +0200, Laurent Pinchart wrote: I think that Mark's point was that the regulators should be provided by platform code (in the generic sense, it could be DT on ARM, board code, or a USB bridge driver for a webcam that

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Laurent Pinchart
On Monday 22 April 2013 14:39:57 Guennadi Liakhovetski wrote: On Mon, 22 Apr 2013, Laurent Pinchart wrote: On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote: On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-22 Thread Mauro Carvalho Chehab
Em 22-04-2013 07:03, Mark Brown escreveu: On Mon, Apr 22, 2013 at 01:14:07AM +0200, Laurent Pinchart wrote: I think that Mark's point was that the regulators should be provided by platform code (in the generic sense, it could be DT on ARM, board code, or a USB bridge driver for a webcam that

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-22 Thread Mark Brown
On Mon, Apr 22, 2013 at 09:46:07AM -0300, Mauro Carvalho Chehab wrote: Em 22-04-2013 07:03, Mark Brown escreveu: Yes, you understood me perfectly - to a good approximation the matching up should be done by whatever the chip is soldered down to. That doesn't make any sense to me. I2C devices

Re: [PATCH RFC] media: videobuf2: fix the length check for mmap

2013-04-22 Thread Laurent Pinchart
Hi Mauro, On Friday 19 April 2013 08:18:01 Mauro Carvalho Chehab wrote: [snip] [media] videobuf2: fix the length check for mmap Memory maps typically require that the buffer size to be page s/that the/the/ aligned. Currently, two memops drivers do such alignment internally, but

[PATCH 00/12] exynos4-is driver fixes

2013-04-22 Thread Sylwester Nawrocki
This patch series includes fixes for several issues found during testing all exynos4-is device drivers build as modules. The exynos4-is build with all sub-drivers as 'M' is hopefully now free of all serious issues, but one. I.e. the requirement now is to have all sub-device drivers, including the

[PATCH 01/12] s5c73m3: Fix remove() callback to free requested resources

2013-04-22 Thread Sylwester Nawrocki
Make sure v4l2_device_unregister_subdev() is called for both: oif and sensor subdev and both media entities are freed on driver removal. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/i2c/s5c73m3/s5c73m3-core.c |

[PATCH 02/12] s5c73m3: Add missing subdev .unregistered callback

2013-04-22 Thread Sylwester Nawrocki
This is needed to free any resources requested in the .registered subdev op. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/i2c/s5c73m3/s5c73m3-core.c |7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 03/12] exynos4-is: Remove redundant MODULE_DEVICE_TABLE entries

2013-04-22 Thread Sylwester Nawrocki
Remove unneeded MODULE_DEVICE_TABLE(of,...) instances from files that are linked into same module. This fixes following error when building as a module: LD [M] drivers/media/platform/exynos4-is/s5p-fimc.o drivers/media/platform/exynos4-is/fimc-is-sensor.o: In function `.LANCHOR1':

[PATCH 04/12] exynos4-is: Fix initialization of subdev 'flags' field

2013-04-22 Thread Sylwester Nawrocki
Ensure the value of struct v4l2_subdev::flags field as set in v4l2_subdev_init() is preserved when initializing it in the subdev drivers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 05/12] exynos4-is: Fix regulator/gpio resource releasing on the driver removal

2013-04-22 Thread Sylwester Nawrocki
Remove regulator_bulk_free() calls as devm_regulator_bulk_get() function is used to get the regulators so those will be freed automatically while the driver is removed. Missing gpio free is fixed by requesting a gpio with the devm_* API. All that is done now in the I2C client driver remove()

[PATCH 06/12] exynos4-is: Don't overwrite subdevdata in the fimc-is sensor driver

2013-04-22 Thread Sylwester Nawrocki
It's an I2C client driver and it must not overwrite the struct v4l2_subdev dev_priv field, which is used by the v4l2 core to store a pointer to struct i2c_client. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 07/12] exynos4-is: Unregister fimc-is subdevs from the media device properly

2013-04-22 Thread Sylwester Nawrocki
Add missing v4l2_device_unregister_subdev() call for the FIMC-IS subdevs (currently there is only the FIMC-IS-ISP subdev) so corresponding resources are properly freed upon the media device driver module removal. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyugmin Park

[PATCH 08/12] exynos4-is: Set fimc-lite subdev subdev owner module

2013-04-22 Thread Sylwester Nawrocki
The FIMC-LITE.n subdevs have currently sd-owner field not set, the exynos-fimc-lite module can be removed at any time, regardless it is in use by other modules. When this module is unloaded the kernel can crash easily by accessing video or media device nodes. Cc: sta...@vger.kernel.org

[PATCH 09/12] exynos4-is: Remove redundant module_put() for MIPI-CSIS module

2013-04-22 Thread Sylwester Nawrocki
Currently there is unbalanced module_put() on the s5p-csis module which prevents it from being unloaded. The subdev's owner module has reference count decremented in v4l2_device_unregister_subdev() so just remove this erroneous call. Cc: sta...@vger.kernel.org # 3.8 Signed-off-by: Sylwester

[PATCH 10/12] exynos4-is: Remove debugfs entries properly

2013-04-22 Thread Sylwester Nawrocki
Ensure both debugfs: fimc_is directory and the fw_log file are properly removed in the driver cleanup sequence. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-is.c |2 +- 1 file

[PATCH 12/12] exynos4-is: Fix runtime PM handling on fimc-is probe error path

2013-04-22 Thread Sylwester Nawrocki
Ensure there is no unbalanced pm_runtime_put(). Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-is.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 00/12] exynos4-is driver fixes

2013-04-22 Thread Sylwester Nawrocki
On 04/22/2013 04:03 PM, Sylwester Nawrocki wrote: This patch series includes fixes for several issues found during testing all exynos4-is device drivers build as modules. The exynos4-is build with all sub-drivers as 'M' is hopefully now free of all serious issues, but one. I.e. the requirement

Re: [RFC v2] video: ARM CLCD: Add DT CDF support

2013-04-22 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 06:33:21PM +0100, Pawel Moll wrote: This patch adds basic DT bindings for the PL11x CLCD cells and make their fbdev driver use them, together with the Common Display Framework. The DT provides information about the hardware configuration and limitations (eg. the

cron job: media_tree daily build: WARNINGS

2013-04-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Apr 22 19:00:21 CEST 2013 git branch: test git hash: 6695be6863b75620ffa6d422965680ce785cb7c8 gcc

[PATCH 3/4] media/rc/imon.c: do not try to register 2nd intf if 1st intf failed

2013-04-22 Thread Kevin Baradon
This bug could be triggered if 1st interface configuration fails: Apr 8 18:20:30 homeserver kernel: usb 5-1: new low-speed USB device number 2 using ohci_hcd Apr 8 18:20:30 homeserver kernel: input: iMON Panel, Knob and Mouse(15c2:0036) as

[PATCH 2/4] media/rc/imon.c: make send_packet() delay larger for 15c2:0036 [v2]

2013-04-22 Thread Kevin Baradon
Imon device 15c2:0036 need a higher delay between send_packet() calls. Also use interruptible wait to avoid load average going too high (and let caller handle signals). Signed-off-by: Kevin Baradon kevin.bara...@gmail.com --- drivers/media/rc/imon.c | 22 -- 1 file

[PATCH 4/4] media/rc/imon.c: kill urb when send_packet() is interrupted

2013-04-22 Thread Kevin Baradon
This avoids: Apr 12 23:52:16 homeserver kernel: imon:send_packet: task interrupted Apr 12 23:52:16 homeserver kernel: [ cut here ] Apr 12 23:52:16 homeserver kernel: WARNING: at drivers/usb/core/urb.c:327 usb_submit_urb+0x353/0x370() Apr 12 23:52:16 homeserver kernel:

[PATCH 1/4] Revert media/rc/imon.c: make send_packet() delay larger for 15c2:0036

2013-04-22 Thread Kevin Baradon
This reverts commit d92f150f9cb80b4df56331d1f42442da78e351f0. It seems send_packet() is used during initialization, before send_packet_delay is set. This will be fixed by another patch. Signed-off-by: Kevin Baradon kevin.bara...@gmail.com --- drivers/media/rc/imon.c | 17 - 1

[PATCH 0/4] Revert buggy patch and fix other issues with imon driver

2013-04-22 Thread Kevin Baradon
Hi, Following patchset fixes several issues with imon driver and reverts one (previously applied) buggy patch. Mauro, could you please apply this on top of your tree? Best regards, Kevin Baradon (4): Revert media/rc/imon.c: make send_packet() delay larger for 15c2:0036 media/rc/imon.c:

Re: [PATCH v2 1/5] V4L2: I2C: ML86V7667 video decoder driver

2013-04-22 Thread Vladimir Barinov
Hi Hans, Hans Verkuil wrote: +*/ + val = i2c_smbus_read_byte_data(client, STATUS_REG); + if (val 0) + return val; + + priv-std = val STATUS_NTSCPAL ? V4L2_STD_PAL : V4L2_STD_NTSC; Shouldn't this be 50 Hz vs 60 Hz formats? There are 60 Hz

Re: [PATCH v2 1/5] V4L2: I2C: ML86V7667 video decoder driver

2013-04-22 Thread Vladimir Barinov
Vladimir Barinov wrote: Hi Hans, Hans Verkuil wrote: + */ +val = i2c_smbus_read_byte_data(client, STATUS_REG); +if (val 0) +return val; + +priv-std = val STATUS_NTSCPAL ? V4L2_STD_PAL : V4L2_STD_NTSC; Shouldn't this be 50 Hz vs 60 Hz formats? There are 60

Re: [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support

2013-04-22 Thread Simon Horman
On Mon, Apr 22, 2013 at 04:37:33PM +0400, Sergei Shtylyov wrote: Hello. On 22-04-2013 8:57, Simon Horman wrote: From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add VIN clocks and platform devices for R8A7779 SoC; add function to register the VIN platform devices.

Re: [PATCH v2 1/4] V4L2: soc_camera: Renesas R-Car VIN driver

2013-04-22 Thread Katsuya MATSUBARA
Hi Sergei, Thanks for the patch. From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Sat, 20 Apr 2013 02:31:31 +0400 From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add Renesas R-Car VIN (Video In) V4L2 driver. Based on the patch by Phil Edworthy

Re: [PATCH v2 1/4] V4L2: soc_camera: Renesas R-Car VIN driver

2013-04-22 Thread Sergei Shtylyov
Hello. On 04/23/2013 07:08 AM, Katsuya MATSUBARA wrote: Hi Sergei, Thanks for the patch. It's not mine. :-) From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add Renesas R-Car VIN (Video In) V4L2 driver. Based on the patch by Phil Edworthy phil.edwor...@renesas.com.

Re: [PATCH v2 1/4] V4L2: soc_camera: Renesas R-Car VIN driver

2013-04-22 Thread Katsuya MATSUBARA
Hi, From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Tue, 23 Apr 2013 08:38:35 +0400 On 04/23/2013 07:08 AM, Katsuya MATSUBARA wrote: From: Vladimir Barinov vladimir.bari...@cogentembedded.com (snip) +/* Register offsets for R-Сar VIN */ Are you using a 2-byte character in