On 26/02/14 17:47, Philipp Zabel wrote:
Ok, that looks compact enough. I still don't see the need to change make
the remote-endpoint property required to achieve this, though. On the
other hand, I wouldn't object to making it mandatory either.
Sure, having remote-endpoint as required doesn't
On 26/02/14 16:48, Philipp Zabel wrote:
I would like the document to acknowledge the difference from the
phandle+args pattern used elsewhere and a description of when it would
be appropriate to use this instead of a simpler binding.
Alright. The main point of this binding is that the
bt-width should be (bt)-width, and same for the other fields.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
include/uapi/linux/videodev2.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index
On 27/02/14 12:52, Philipp Zabel wrote:
This is a bit verbose, and if your output port is on an encoder device
with multiple inputs, the correct port number would become a bit
unintuitive. For example, we'd have to use port@4 as the output encoder
units that have a 4-port input multiplexer
Hi Hans,
Thank you for the patch.
On Tuesday 25 February 2014 13:52:43 Hans Verkuil wrote:
Fix an incorrect test in vb2_internal_qbuf() where only DEQUEUED buffers
are allowed. But PREPARED buffers are also OK.
Introduced by commit 4138111a27859dcc56a5592c804dd16bb12a23d1
(vb2: simplify
Hi Hans,
Thank you for the patch. This is a pretty useful debugging tool. Please see
below for two small comments.
On Tuesday 25 February 2014 13:52:44 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
When a vb2_queue is freed check if all the mem_ops and queue ops were
Hi Hans,
Thank you for the patch.
On Tuesday 25 February 2014 13:52:45 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
The buf_finish op should always work, so change the return type to void.
Update the few drivers that use it. Note that buf_finish can be called
both when the
On 02/27/14 12:15, Laurent Pinchart wrote:
Hi Hans,
Thank you for the patch. This is a pretty useful debugging tool. Please see
below for two small comments.
On Tuesday 25 February 2014 13:52:44 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
When a vb2_queue is freed
On Thursday 27 February 2014 12:23:58 Laurent Pinchart wrote:
On Tuesday 25 February 2014 13:52:45 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
The buf_finish op should always work, so change the return type to void.
Update the few drivers that use it. Note that
And one more separate comment.
On Tuesday 25 February 2014 13:52:45 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
The buf_finish op should always work, so change the return type to void.
Update the few drivers that use it. Note that buf_finish can be called
both when the DMA
Hi Hans,
Thank you for the patch.
On Tuesday 25 February 2014 13:52:46 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Drivers need to be aware that buf_finish can be called when there is no
streaming going on, so make a note of that.
Also add a bunch of missing periods at
Hi Hans,
On Tuesday 25 February 2014 13:52:47 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
This ensures that it is also called from queue_cancel, which also calls
__dqbuf(). Without this change any time queue_cancel is called while
streaming the buf_finish op will not be
Hi Michael, Arnd,
On Thu, Feb 27, 2014 at 7:37 AM, Michael Schmitz
schm...@biophys.uni-duesseldorf.de wrote:
It's been a while since the first submission of these patches,
but a lot of them have made it into linux-next already, so here
is the stuff that is not merged yet, hopefully addressing
Hi Hans,
Thank you for the patch.
On Tuesday 25 February 2014 13:52:49 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
'queued_count' is a bit vague since it is not clear to which queue it
refers to: the vb2 internal list of buffers or the driver-owned list
of buffers.
Hi Hans,
Thank you for the patch.
On Tuesday 25 February 2014 13:52:50 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
__vb2_queue_free() would init the queued_list at all times, even if
q-num_buffers 0. This should only happen if num_buffers == 0.
This situation can
On 02/27/14 12:51, Laurent Pinchart wrote:
Hi Hans,
On Tuesday 25 February 2014 13:52:47 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
This ensures that it is also called from queue_cancel, which also calls
__dqbuf(). Without this change any time queue_cancel is called
The following changes since commit b215621049bd57221455990880fb6b906f7dac21:
Merge branch 'v4l_for_linus' into to_next (2014-02-04 06:48:49 -0200)
are available in the git repository at:
git://linuxtv.org/kdebski/media_tree_2.git master
for you to fetch changes up to
A quick question: can dma_buf_unmap_attachment be called from
interrupt context? It is the dmabuf equivalent to e.g. dma_sync_sg_for_cpu
or dma_unmap_sg, and those can be called from interrupt context.
I cannot see anything specific about this in the sources or dma-buf-sharing.txt.
If it turns
From: Heinrich Schuchardt xypron.g...@gmx.de
An attempt was made to read dvbs2_snr_tab[80],
though dvbs2_snr_tab has only 80 elements.
Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de
---
drivers/media/dvb-frontends/ds3000.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This patch fixes the following warning:
drivers/media/i2c/tvp5150.c: In function '__tvp5150_try_crop':
include/linux/kernel.h:762:17: warning: comparison of distinct pointer types
lacks a cast [enabled by default]
(void) (__val == __min); \
^
Set permissions on the debug module parameter to make it appear in sysfs.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/i2c/tvp5150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index
For simple devices with only one port, it can be made implicit.
The endpoint node can be a direct child of the device node.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/of/base.c | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git
Hi,
this version of the OF graph helper move series addresses a few of
Grant's and Tomi's comments.
Changes since v4:
- Moved graph helpers into drivers/of/base.c
- Fixed endpoint parsing patch to update users
- Improved documentation, emphasizing features that differentiate
the graph
This patch moves the parsing helpers used to parse connected graphs
in the device tree, like the video interface bindings documented in
Documentation/devicetree/bindings/media/video-interfaces.txt, from
drivers/media/v4l2-core/v4l2-of.c into drivers/of/base.c.
This allows to reuse the same parser
For simple devices with only one port, it can be made implicit.
The endpoint node can be a direct child of the device node.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
Documentation/devicetree/bindings/graph.txt | 8
1 file changed, 8 insertions(+)
diff --git
A 'return endpoint;' at the end of the (!prev) case allows to
reduce the indentation level of the (prev) case.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/of/base.c | 42 ++
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git
If of_graph_get_next_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index
The device tree graph bindings as used by V4L2 and documented in
Documentation/device-tree/bindings/media/video-interfaces.txt contain
generic parts that are not media specific but could be useful for any
subsystem with data flow between multiple devices. This document
describe the generic
This patch adds a new struct of_endpoint which is then embedded in struct
v4l2_of_endpoint and contains the endpoint properties that are not V4L2
(or even media) specific: the port number, endpoint id, local device tree
node and remote endpoint phandle. of_graph_parse_endpoint parses those
On Sunday 16 February 2014 19:04:01 Antti Seppälä wrote:
On 12 February 2014 01:39, James Hogan james.ho...@imgtec.com wrote:
On Tuesday 11 February 2014 20:14:19 Antti Seppälä wrote:
Are you working on the wakeup protocol selector sysfs interface?
I gave it a try yesterday, but it's a
Hi Rob, Mark + DT maintainers,
On Friday 07 February 2014 15:49:15 James Hogan wrote:
Add device tree binding for ImgTec Consumer Infrared block, specifically
major revision 1 of the hardware.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
On Thu, Feb 27, 2014 at 4:52 PM, James Hogan james.ho...@imgtec.com wrote:
Hi Rob, Mark + DT maintainers,
On Friday 07 February 2014 15:49:15 James Hogan wrote:
Add device tree binding for ImgTec Consumer Infrared block, specifically
major revision 1 of the hardware.
Signed-off-by: James
I added two patches to this branch - This request supersedes yesterday's
pull request.
The following changes since commit
efab6b6a6ea9364ececb955f69a9d3ffc6b782a1:
[media] vivi: queue_setup improvements (2014-02-24 10:59:15 -0300)
are available in the git repository at:
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Feb 28 04:00:27 CET 2014
git branch: test
git hash: efab6b6a6ea9364ececb955f69a9d3ffc6b782a1
gcc
34 matches
Mail list logo
