Re: [PATCH/RFC v6 3/3] leds: Add LED Flash Class wrapper to LED subsystem

2014-11-04 Thread Jacek Anaszewski
Hi Bryan, Thanks for a review. On 11/04/2014 02:34 AM, Bryan Wu wrote: On Mon, Sep 22, 2014 at 8:21 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Some LED devices support two operation modes - torch and flash. I got several terms here: flash, torch and indicator. And we have 3 CAPs

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-04 Thread Sudip Mukherjee
On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- drivers/staging/media/lirc/lirc_zilog.c | 2 +- 1 file changed, 1

[PATCH 00/15] [media] Make mediabus format subsystem neutral

2014-11-04 Thread Boris Brezillon
Hello, This patch series prepares the use of media bus formats outside of the V4L2 subsytem (my final goal is to use it in the Atmel HLCDC DRM driver where I have to configure my DPI/RGB bus according to the connected display). The series first defines a new enum with a neutral name

[PATCH 09/15] gpu: ipu-v3: Make use of media_bus_format enum

2014-11-04 Thread Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've moved media bus definition to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Reference new definitions in the ipu-v3 driver. Signed-off-by: Boris Brezillon

[PATCH 06/15] [media] platform: Make use of media_bus_format enum

2014-11-04 Thread Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've moved media bus definition to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Reference new definitions in all platform drivers. Signed-off-by: Boris Brezillon

[PATCH 15/15] staging: media: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h

2014-11-04 Thread Boris Brezillon
The v4l2-mediabus.h header is now deprecated and should be replaced with v4l2-mbus.h. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/staging/media/omap4iss/iss_csi2.c | 2 +- drivers/staging/media/omap4iss/iss_video.h | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 07/15] [media] usb: Make use of media_bus_format enum

2014-11-04 Thread Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've moved media bus definition to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Reference new definitions in all usb drivers. Signed-off-by: Boris Brezillon

[PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-04 Thread Boris Brezillon
The v4l2_mbus_pixelcode enum (or its values) should be replaced by the media_bus_format enum. Keep this enum in v4l2-mediabus.h and create a new header containing the v4l2_mbus_framefmt struct definition (which is not deprecated) so that we can add a #warning statement in v4l2-mediabus.h and

[PATCH 08/15] staging: media: Make use of media_bus_format enum

2014-11-04 Thread Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've moved media bus definition to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Reference new definitions in all media drivers residing in staging. Signed-off-by: Boris

[PATCH 12/15] [media] i2c: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h

2014-11-04 Thread Boris Brezillon
The v4l2-mediabus.h header is now deprecated and should be replaced with v4l2-mbus.h. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/media/i2c/mt9m032.c | 2 +- drivers/media/i2c/mt9t001.c | 2 +- drivers/media/i2c/mt9v032.c

[PATCH 10/15] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel

2014-11-04 Thread Boris Brezillon
Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel users don't have access to these definitions. We have to keep this definition for user-space users even though they're encouraged to move to the new media_bus_format enum. Signed-off-by: Boris Brezillon

[PATCH 03/15] [media] Make use of the new media_bus_format definitions

2014-11-04 Thread Boris Brezillon
Replace references to the v4l2_mbus_pixelcode enum with the new media_bus_format enum in all common headers. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- include/media/v4l2-mediabus.h| 2 +- include/media/v4l2-subdev.h | 2 +- include/uapi/linux/v4l2-subdev.h |

[PATCH 05/15] [media] pci: Make use of media_bus_format enum

2014-11-04 Thread Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've moved media bus definition to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Replace all references to the old definition in pci drivers. Signed-off-by: Boris

[PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-04 Thread Boris Brezillon
Rename mediabus formats and move the enum into a separate header file so that it can be used by DRM/KMS subsystem without any reference to the V4L2 subsystem. Old V4L2_MBUS_FMT_ definitions are now referencing MEDIA_BUS_FMT_ value. Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

[PATCH 13/15] gpu: ipu-v3: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h

2014-11-04 Thread Boris Brezillon
The v4l2-mediabus.h header is now deprecated and should be replaced with v4l2-mbus.h. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/gpu/ipu-v3/ipu-csi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/ipu-v3/ipu-csi.c

[PATCH 14/15] [media] platform: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h

2014-11-04 Thread Boris Brezillon
The v4l2-mediabus.h header is now deprecated and should be replaced with v4l2-mbus.h. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/media/platform/omap3isp/ispcsi2.c | 2 +- drivers/media/platform/omap3isp/ispvideo.h | 2 +-

[PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values

2014-11-04 Thread Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've moved media bus definition to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Update the v4l documentation accordingly. Signed-off-by: Boris Brezillon

[PATCH 04/15] [media] i2c: Make use of media_bus_format enum

2014-11-04 Thread Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've moved media bus definitions to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Replace all references to the old definitions in i2c drivers. Signed-off-by: Boris

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-04 Thread Hans Verkuil
Hi Boris, On 11/04/14 10:54, Boris Brezillon wrote: Rename mediabus formats and move the enum into a separate header file so that it can be used by DRM/KMS subsystem without any reference to the V4L2 subsystem. Old V4L2_MBUS_FMT_ definitions are now referencing MEDIA_BUS_FMT_ value. I

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-04 Thread Hans Verkuil
On 11/04/14 11:20, Hans Verkuil wrote: Hi Boris, On 11/04/14 10:54, Boris Brezillon wrote: Rename mediabus formats and move the enum into a separate header file so that it can be used by DRM/KMS subsystem without any reference to the V4L2 subsystem. Old V4L2_MBUS_FMT_ definitions are

[PATCH] MAINTAINERS: add maintainer for CODA video4linux mem2mem driver

2014-11-04 Thread Philipp Zabel
Add myself as maintainer for the CODA V4L2 mem2mem driver. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3c64271..34d3671 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2487,6

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-04 Thread Boris Brezillon
Hi Hans, On Tue, 04 Nov 2014 11:20:40 +0100 Hans Verkuil hansv...@cisco.com wrote: Hi Boris, On 11/04/14 10:54, Boris Brezillon wrote: Rename mediabus formats and move the enum into a separate header file so that it can be used by DRM/KMS subsystem without any reference to the V4L2

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-04 Thread Hans Verkuil
Well, I gave two alternatives :-) Both are fine as far as I am concerned, but it would be nice to hear what others think. Regards, Hans On 11/04/14 11:45, Boris Brezillon wrote: Hi Hans, On Tue, 04 Nov 2014 11:20:40 +0100 Hans Verkuil hansv...@cisco.com wrote: Hi Boris, On

Re: [PATCH 4/5] [media] vivid: add support for contiguous DMA buffers

2014-11-04 Thread Philipp Zabel
Hi Hans, Am Montag, den 03.11.2014, 14:38 +0100 schrieb Hans Verkuil: Hi Philipp, I've been playing with this and I cannot make it work. One thing that is missing in this patch is that the device struct isn't passed to v4l2_device_register. Without that the vb2 allocation context will

Re: (bisected) Logitech C920 (uvcvideo) stutters since 3.9

2014-11-04 Thread Sakari Ailus
Hi Grazvydas, On Tue, Nov 04, 2014 at 01:16:03AM +0200, Grazvydas Ignotas wrote: Hi, On Mon, Nov 3, 2014 at 12:57 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Grazvydas, On Sun, Nov 02, 2014 at 04:03:55AM +0200, Grazvydas Ignotas wrote: There is periodic stutter (seen in vlc, for

Re: (bisected) Logitech C920 (uvcvideo) stutters since 3.9

2014-11-04 Thread Rémi Denis-Courmont
Le 2014-11-04 14:58, Sakari Ailus a écrit : Have you tried with a different application to see if the problem persists? Tried mplayer and cheese now, and it seems they are not affected, so it's an issue with vlc. I wonder why it doesn't like newer flags.. Ohwell, sorry for the noise. I

[PATCH 1/1] smipcie: add DVBSky S952 V3 support

2014-11-04 Thread Nibble Max
DVBSky S952 V3 card has a dual channels of dvb-s/s2. 1Frontend: Integrated tuner and demod: M88RS6000 2PCIe bridge: SMI PCIe Signed-off-by: Nibble Max nibble@gmail.com --- drivers/media/pci/smipcie/Kconfig | 2 + drivers/media/pci/smipcie/smipcie.c | 78

Re: [PATCH 1/1] smipcie: add DVBSky S952 V3 support

2014-11-04 Thread Nibble Max
Hello Mauro, I check media_tree.git on linuxtv.org that the media tree does not include S952 V3 code. S952 V3 card has M88RS6000 dvb frontend. S950 V3 card has M88TS2022/M88DS3103 dvb frontend. There are 2 reasons: 1 I submit two patchs for smipcie bridge driver. first one for S950 V3:

Re: (bisected) Logitech C920 (uvcvideo) stutters since 3.9

2014-11-04 Thread Paulo Assis
I've add to change guvcview so that it now generates it's own monotonic timestamps, kernel timestamps (uvcvideo at least), caused a similar problem, e.g: I would get a couple of frames with correct timestamps, then I would get at least one with a value lower than the rest, this caused playback to

Re: (bisected) Logitech C920 (uvcvideo) stutters since 3.9

2014-11-04 Thread Sakari Ailus
Hi, On Tue, Nov 04, 2014 at 03:02:58PM +, Paulo Assis wrote: I've add to change guvcview so that it now generates it's own monotonic timestamps, kernel timestamps (uvcvideo at least), caused a similar problem, e.g: I would get a couple of frames with correct timestamps, then I would get

Re: [PATCH 1/1] of: Add a function to read 64-bit arrays

2014-11-04 Thread Grant Likely
On Fri, 3 Oct 2014 00:59:23 +0300 , Sakari Ailus sakari.ai...@iki.fi wrote: Implement of_property_read_u64_array() for reading 64-bit arrays. This is needed for e.g. reading the valid link frequencies in the smiapp driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi A patch that

Re: [PATCH 4/4] [media] solo6x10: don't turn off/on encoder interrupt in processing loop

2014-11-04 Thread Andrey Utkin
2014-11-03 19:15 GMT+04:00 Hans Verkuil hverk...@xs4all.nl: Hi Andrey, On 10/29/2014 05:03 PM, Andrey Utkin wrote: The used approach actually cannot prevent new encoder interrupt to appear, because interrupt handler can execute in different thread, and in current implementation there is

Re: [PATCH v2] ARM: imx: Fix the removal of CONFIG_SPI option

2014-11-04 Thread Antti Palosaari
Moikka, On 11/04/2014 09:18 PM, Uwe Kleine-König wrote: Hello, On Tue, Nov 04, 2014 at 05:55:31PM +0200, Antti Palosaari wrote: On 11/04/2014 05:26 PM, Uwe Kleine-König wrote: [Note, this is a resend of a mail I accidently only sent to Fabio before.] Hello, On Tue, Nov 04, 2014 at

[PATCH] [media] af0933: Don't go past to clock_adc_lut buffer

2014-11-04 Thread Mauro Carvalho Chehab
Fixes the following sparse warnings: drivers/media/dvb-frontends/af9033.c:295 af9033_init() error: buffer overflow 'clock_adc_lut' 11 = 11 drivers/media/dvb-frontends/af9033.c:300 af9033_init() error: buffer overflow 'clock_adc_lut' 11 = 11

[PATCHv2] [media] af0933: Don't go past arrays

2014-11-04 Thread Mauro Carvalho Chehab
Fixes the following sparse warnings: drivers/media/dvb-frontends/af9033.c:295 af9033_init() error: buffer overflow 'clock_adc_lut' 11 = 11 drivers/media/dvb-frontends/af9033.c:300 af9033_init() error: buffer overflow 'clock_adc_lut' 11 = 11

Re: (bisected) Logitech C920 (uvcvideo) stutters since 3.9

2014-11-04 Thread Rémi Denis-Courmont
Le mardi 04 novembre 2014, 15:42:37 Rémi Denis-Courmont a écrit : Le 2014-11-04 14:58, Sakari Ailus a écrit : Have you tried with a different application to see if the problem persists? Tried mplayer and cheese now, and it seems they are not affected, so it's an issue with vlc. I

[PATCH] [media] s2255drv: fix spinlock issue

2014-11-04 Thread Dean Anderson
qlock spinlock controls access to buf_list and sequence. qlock spinlock should not be locked during a copy to video buffers, an operation that may sleep. Signed-off-by: Dean Anderson linux-...@sensoray.com --- drivers/media/usb/s2255/s2255drv.c | 23 +++ 1 file changed, 11

v4l2-ctl bug(?) printing ctrl payload array

2014-11-04 Thread Andrey Utkin
I used today's git master HEAD of v4l-utils. There's a device which provides r/w v4l2 control for a map of motion thresholds by regions. See md_threshold_grid (u16): min=0 max=65535 step=1 default=768 [45][45] flags=has-payload So when i print its value with -C md_threshold_grid, i see MD

Re: Patch mceusb: fix invalid urb interval

2014-11-04 Thread Sean Young
On Mon, Nov 03, 2014 at 02:49:45PM -0200, Mauro Carvalho Chehab wrote: Em Mon, 20 Jan 2014 12:36:26 -0500 Jarod Wilson ja...@redhat.com escreveu: On Sun, Jan 19, 2014 at 09:56:48PM +, Sean Young wrote: On Sun, Jan 19, 2014 at 10:05:15PM +0100, Martin Kittel wrote: Hi Mauro, hi

[PATCH] staging: media: lirc: modify print calls

2014-11-04 Thread Aya Mahfouz
This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- drivers/staging/media/lirc/lirc_zilog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFCv2 5/8] [media] si4713: add device tree support

2014-11-04 Thread Sakari Ailus
Hi Sebastian, Nice set of patches! Thanks! :-) On Tue, Oct 21, 2014 at 05:07:04PM +0200, Sebastian Reichel wrote: Add device tree support by changing the device registration order. In the device tree the si4713 node is a normal I2C device, which will be probed as such. Thus the V4L device

Re: Patch mceusb: fix invalid urb interval

2014-11-04 Thread Mauro Carvalho Chehab
Em Tue, 04 Nov 2014 21:25:49 + Sean Young s...@mess.org escreveu: On Mon, Nov 03, 2014 at 02:49:45PM -0200, Mauro Carvalho Chehab wrote: Em Mon, 20 Jan 2014 12:36:26 -0500 Jarod Wilson ja...@redhat.com escreveu: On Sun, Jan 19, 2014 at 09:56:48PM +, Sean Young wrote: On

Re: [PATCH] [media] s2255drv: fix spinlock issue

2014-11-04 Thread Dean Anderson
This patch is not so urgent, but should still be considered. Please disregard the second comment below, which is not correct. The original code, however, holds the spinlock for a long time. From the structure of videobuf2, we could just hold qlock during buf_list and sequence accesses.

[RFCv2] Media Token API Spec.

2014-11-04 Thread Shuah Khan
Hi Mauro, Here is the RFC as promised. I also included the Media controller as a an alternative and captured the discussion in the thread on that topic. Please review. -- Shuah - RFC Media Token API Specification Let's start with

Re: (bisected) Logitech C920 (uvcvideo) stutters since 3.9

2014-11-04 Thread Sakari Ailus
Sakari Ailus wrote: yavta does, for example, print both the monotonic timestamp from the buffer and the time when the buffer has been dequeued: URL:http://git.ideasonboard.org/yavta.git $ yavta -c /dev/video0 should do it. The first timestamp is the buffer timestamp, and the

Re: [PATCHv2] [media] af0933: Don't go past arrays

2014-11-04 Thread Antti Palosaari
Acked-by: Antti Palosaari cr...@iki.fi Reviewed-by: Antti Palosaari cr...@iki.fi anyhow, I think these branches could never taken in real life. But as a killing warnings and potential future changes I am pretty fine! regards Antti On 11/04/2014 10:35 PM, Mauro Carvalho Chehab wrote: Fixes

cron job: media_tree daily build: ERRORS

2014-11-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Nov 5 04:00:16 CET 2014 git branch: test git hash: a8f29e89f2b54fbf2c52be341f149bc195b63a8b gcc

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-04 Thread Sudip Mukherjee
On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote: On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote: On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed.