Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

Hi Mikhail, Thank you for the patch! I have one high-level comment: please rename the source to r-car-jpu.c. It's good practice to start with the SoC name since 'jpu' by itself is not very descriptive. I have a few more comments (mostly easy ones) below: On 04/29/2015 11:53 PM, Mikhail Ulyanov

Re: [PATCH v5 06/11] cec: add HDMI CEC framework

Hi Kamil, Here is my review: On 04/29/2015 12:02 PM, Kamil Debski wrote: From: Hans Verkuil hansv...@cisco.com The added HDMI CEC framework provides a generic kernel interface for HDMI CEC devices. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged CEC Updates

Re: Kernel crash with dvb devices

Hi, I don’t have S660 but the S650 and I have hat also kernel crash see on the link [1]. For this i am using an workaround inside grub (I am on Archlinux x86_64): /etc/default/grub: GRUB_CMDLINE_LINUX_DEFAULT=irqpoll ipv6.disable=1 With the irqpoll I don’t have crashes. Of course it would be

issue with videobuf2-dma-sg.ko

Hi I am trying to load the cx23885 module. It fails to load and I get this in dmesg; [ 433.506983] videobuf2_dma_sg: Unknown symbol dma_buf_export (err 0) I wrote a small script to load each of the dependencies one at a time, which shows pretty clearly the problem is videobuf2-dma-sg.ko. I

Re: Mystique SaTiX-S2 Sky V2 USB (DVBSKY S960 clone) - Linux driver.

Hi Steve, I've got the device in question and can confirm that it works ok. lsusb definitely should work ok - maybe there's indeed something wrong with your device. As suggested by P. van Gaans, maybe you can try your device on another computer or even on Windows and see if it works there.

Re: issue with videobuf2-dma-sg.ko

Hi Vince, On 05/03/2015 09:14 AM, Vincent McIntyre wrote: Hi I am trying to load the cx23885 module. It fails to load and I get this in dmesg; [ 433.506983] videobuf2_dma_sg: Unknown symbol dma_buf_export (err 0) I wrote a small script to load each of the dependencies one at a

Re: soc-camera: opinion poll - future directions

Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: Hi Guennadi, On 05/03/2015 06:11 PM, Guennadi Liakhovetski wrote: Hi all, Just a quick opinion poll - where and how should the soc-camera framework and drivers be heading? Possible (probably not all) directions: (1) all is good,

Re: [PATCH 5/9] ov5642: avoid calling ov5642_find_datafmt() twice

Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov5642_set_fmt(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov5642.c | 7 --- 1

Re: [PATCH 6/9] ov772x: avoid calling ov772x_select_params() twice

On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Merge ov772x_s_fmt into ov772x_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Re: [PATCH 8/9] ov9740: avoid calling ov9740_res_roundup() twice

Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov9740_s_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov9740.c | 18

Re: [PATCH 9/9] mt9t112: initialize left and top

On Sun, 3 May 2015, Guennadi Liakhovetski wrote: Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The left and top variables were uninitialized, leading to unexpected results. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

Re: [PATCH 7/9] ov9640: avoid calling ov9640_res_roundup() twice

Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov9640_s_fmt and ov9640_set_fmt Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov9640.c |

Re: [PATCH 9/9] mt9t112: initialize left and top

Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The left and top variables were uninitialized, leading to unexpected results. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/soc_camera/mt9t112.c | 3 ++- 1 file

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon May 4 04:00:19 CEST 2015 git branch: test git hash: ebf984bb151e9952cccd060d3aba0b4d30a87e81 gcc

[PATCH v3 4/6] rtl28xxu: add I2C read without write

Add support for I2C read operation without a preceeding write. While here, change the error code to EOPNOTSUPP in case an unsupported I2C operation is attempted. Signed-off-by: Olli Salonen olli.salo...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 8 +++- 1 file changed, 7

[PATCH v3 5/6] si2168: add I2C error handling

Return error from si2168_cmd_execute in case the demodulator returns an error. Signed-off-by: Olli Salonen olli.salo...@iki.fi --- drivers/media/dvb-frontends/si2168.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/dvb-frontends/si2168.c

[PATCH v3 6/6] rtl2832: add support for GoTView MasterHD 3 USB tuner

GoTView MasterHD 3 is a DVB-T2/C USB 2.0 tuner. It's based on the following components: - USB bridge: RTL2832P (contains also DVB-T demodulator) - Demodulator: Si2168-A30 - Tuner: Si2148-A20 The demodulator and the tuner will need firmwares. The Si2148 uses Si2158 firmware. Antti has the

[PATCH v3 1/6] si2168: add support for gapped clock

Add a parameter in si2168_config to support gapped clock. This might be necessary on some devices with higher bitrates. Signed-off-by: Olli Salonen olli.salo...@iki.fi --- drivers/media/dvb-frontends/si2168.c | 3 +++ drivers/media/dvb-frontends/si2168.h | 3 +++

[PATCH v3 2/6] dvbsky: use si2168 config option ts_clock_gapped

Change the dvbsky driver to support gapped clock instead of the current hack. Signed-off-by: Olli Salonen olli.salo...@iki.fi --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c

[PATCH 0/9] soc-camera sensor improvements

From: Hans Verkuil hans.verk...@cisco.com As per Guennadi's suggestions, improve the code of various soc-camera sensor drivers to avoid duplicating code. Note that the mt9t112 issue is something I discovered and that has been there from before my recent patches that removed the old video ops.

[PATCH 1/9] imx074: don't call imx074_find_datafmt() twice

From: Hans Verkuil hans.verk...@cisco.com Simplify imx074_set_fmt(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/imx074.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 2/9] mt9m001: avoid calling mt9m001_find_datafmt() twice

From: Hans Verkuil hans.verk...@cisco.com Simplify mt9m001_s_fmt and mt9m001_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/mt9m001.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 3/9] mt9v022: avoid calling mt9v022_find_datafmt() twice

From: Hans Verkuil hans.verk...@cisco.com Simplify mt9v022_s_fmt and mt9v022_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/mt9v022.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 5/9] ov5642: avoid calling ov5642_find_datafmt() twice

From: Hans Verkuil hans.verk...@cisco.com Simplify ov5642_set_fmt(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov5642.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 7/9] ov9640: avoid calling ov9640_res_roundup() twice

From: Hans Verkuil hans.verk...@cisco.com Simplify ov9640_s_fmt and ov9640_set_fmt Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov9640.c | 24 +++- 1 file changed, 3

[PATCH 4/9] ov2640: avoid calling ov2640_select_win() twice

From: Hans Verkuil hans.verk...@cisco.com Simplify ov2640_set_params and ov2640_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov2640.c | 21 ++--- 1 file changed, 10

[PATCH 6/9] ov772x: avoid calling ov772x_select_params() twice

From: Hans Verkuil hans.verk...@cisco.com Merge ov772x_s_fmt into ov772x_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov772x.c | 41 +++ 1 file changed, 13

[PATCH 8/9] ov9740: avoid calling ov9740_res_roundup() twice

From: Hans Verkuil hans.verk...@cisco.com Simplify ov9740_s_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov9740.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff

[PATCH 9/9] mt9t112: initialize left and top

From: Hans Verkuil hans.verk...@cisco.com The left and top variables were uninitialized, leading to unexpected results. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/soc_camera/mt9t112.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: issue with videobuf2-dma-sg.ko

On Sun, May 03, 2015 at 10:45:37AM +0200, Hans Verkuil wrote: Hi Vince, On 05/03/2015 09:14 AM, Vincent McIntyre wrote: Hi I am trying to load the cx23885 module. It fails to load and I get this in dmesg; [ 433.506983] videobuf2_dma_sg: Unknown symbol dma_buf_export (err 0)

[PATCH v3 3/6] si2157: support selection of IF interface

The chips supported by the si2157 driver have two IF outputs (either pins 12+13 or pins 9+11). Instead of hardcoding the output to be used add an option to choose which output shall be used. As this patch changes the default behaviour, the IF interface is specified in each driver currently using

Re: [PATCH v5 11/11] DocBook/media: add CEC documentation

Some comments: On 04/29/2015 12:02 PM, Kamil Debski wrote: From: Hans Verkuil hverk...@xs4all.nl Add DocBook documentation for the CEC API. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: add documentation for passthrough mode] [k.deb...@samsung.com: minor fixes and

Re: [PATCH 0/3] Add media bdisp driver for stihxxx platforms

On 04/27/2015 06:25 PM, Hans Verkuil wrote: Hi Fabien, Thank you for this driver! Good to see V4L2 support for this SoC. I did a quick initial scan over the driver and there are a few things that need to be addressed: - I think bdisp as the driver name is a bit generic, perhaps

Re: Kernel crash with dvb devices

Thanks for the reply, I am not sure if it is related to the TeVii. Someone could say which device is crashing? I see [dib7000p] in the call trace, maybe it could be Hauppauge Nova-TD Stick (52009) device, it use dvb_usb_dib0700 module. Regards. 2015-05-03 13:03 GMT+02:00 crow

soc-camera: opinion poll - future directions

Hi all, Just a quick opinion poll - where and how should the soc-camera framework and drivers be heading? Possible (probably not all) directions: (1) all is good, keep as is. That means keep all drivers, killing them off only when it becomes very obvious, that noone wants them, keep developing

Re: [PATCH 1/9] imx074: don't call imx074_find_datafmt() twice

Hi Hans, Thanks for fixing the drivers! On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify imx074_set_fmt(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de ---

Re: soc-camera: opinion poll - future directions

Hi Guennadi, On 05/03/2015 06:11 PM, Guennadi Liakhovetski wrote: Hi all, Just a quick opinion poll - where and how should the soc-camera framework and drivers be heading? Possible (probably not all) directions: (1) all is good, keep as is. That means keep all drivers, killing them off

Re: [PATCH 3/9] mt9v022: avoid calling mt9v022_find_datafmt() twice

On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify mt9v022_s_fmt and mt9v022_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Re: [PATCH 2/9] mt9m001: avoid calling mt9m001_find_datafmt() twice

On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify mt9m001_s_fmt and mt9m001_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Payment

Dear Winner, You have been awarded the sum of 8,000,000.00 (Eight Million Pounds sterling) with reference number 77100146. This compensation funds from the United Nation.Send us your personal details to deliver your funds. Gloria Peter -- To unsubscribe from this list: send the line

Re: [PATCH 4/9] ov2640: avoid calling ov2640_select_win() twice

Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov2640_set_params and ov2640_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de ---