Re: [PATCH 02/18] [media] au0828: add support for the connectors

Em Fri, 11 Sep 2015 16:57:22 +0200 Hans Verkuil escreveu: > On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > > Depending on the input, an au0828 may have a different > > number of connectors. add entities to represent them. > > Hmm, this patch uses the new connector

Re: [PATCH 12/18] [media] media-entity: must check media_create_pad_link()

Em Mon, 23 Nov 2015 19:54:17 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 14:30:55 Mauro Carvalho Chehab wrote: > > Drivers should check if media_create_pad_link() actually > > worked. > > > >

Re: [PATCH 15/18] [media] uapi/media.h: Rename entities types to functions

Em Fri, 11 Sep 2015 17:36:42 +0200 Hans Verkuil escreveu: > On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > > Rename the userspace types from MEDIA_ENT_T_ to MEDIA_ENT_F_ > > and add the backward compatibility bits. > > > > The changes at the .c files was generated by

Re: [PATCH 18/18] [media] dvbdev: Don't create indirect links

Em Fri, 11 Sep 2015 17:48:19 +0200 Hans Verkuil escreveu: > On 09/06/2015 07:31 PM, Mauro Carvalho Chehab wrote: > > Indirect links are those whose the interface indirectly controls > > s/the// > > > other functions. > > > > There are two interfaces that have indirect

Re: [PATCH] us-ATSC-center-frequencies-8VSB: Added channel numbers in comments to make the file easier to use by comparing against local channel lists.

Em Wed, 9 Dec 2015 21:47:10 -0500 Maury Markowitz escreveu: > This is my first attempt at a patch, so please be gentle. > > Signed-off-by: Maury Markowitz > > --- > atsc/us-ATSC-center-frequencies-8VSB | 78 >

Re: dtv-scan-table has two ATSC files?

Em Wed, 9 Dec 2015 20:04:57 -0500 Maury Markowitz escreveu: > I’m making some updates to the ATSC dtv-scan-tables. Two questions: > > 1) > Why do we have "us-ATSC-center-frequencies-8VSB” *and* > "us-NTSC-center-frequencies-8VSB”? They appear to be identical. The

Media Controller patches

Hi, I've been working during this week to address the issues pointed during the Media Controller really long review process. We should avoid taking so long to review patches in the future, as it is really painful to go back to the already done work 4/5/7 months after the patchsets (yes, there are

Re: v4l2 kernel module debugging methods

On Sun, Dec 6, 2015 at 2:23 AM, Nicolas Dufresne wrote: > Le dimanche 06 décembre 2015 à 00:00 +0200, Ran Shalit a écrit : >> Hello, >> >> I would like to ask a general question regarding methods to debug a >> v4l2 device driver. >> Since I assume that the kernel

Re: v4l2 kernel module debugging methods

Le jeudi 10 décembre 2015 à 23:46 +0200, Ran Shalit a écrit : > Thank you for the comment. > As someone expreinced with v4l2 device driver, do you recommened > using > debugging technique such as qemu (or kgdb) or do you rather use plain > printing ? I never used that, printing I used. You should

Re: [PATCH] ca-ON-Toronto: adding scan file for Toronto, Canada

Em Wed, 9 Dec 2015 22:04:41 -0500 Maury Markowitz escreveu: > My second patch, you can be slightly less gentle now :-) > > This is a scan listing for the Toronto area, along with some of the harder to > get signals. I was unsure how to enter the NTSC (analog) signals

[PATCH] [media] v4l2-core: create MC interfaces for devnodes

V4L2 device (and subdevice) nodes should create an interface, if the Media Controller support is enabled. Please notice that radio devices should not create an entity, as radio input/output is either via wires or via ALSA. PS.: Before this patch, au0828 should remove the media_device earlier.

Re: [PATCH] [media] v4l2-core: create MC interfaces for devnodes

Em Thu, 10 Dec 2015 08:32:21 -0200 Mauro Carvalho Chehab escreveu: > V4L2 device (and subdevice) nodes should create an interface, if the > Media Controller support is enabled. > > Please notice that radio devices should not create an entity, as radio > input/output is

Re: [PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

Hi Bryan, I came across a few bugs, see comments in the code: On 11/11/15 20:50, Bryan Wu wrote: > NVIDIA Tegra processor contains a powerful Video Input (VI) hardware > controller which can support up to 6 MIPI CSI camera sensors. > > This patch adds a V4L2 media controller and capture driver

Re: dtv-scan-table has two ATSC files?

> On Dec 10, 2015, at 4:57 AM, Mauro Carvalho Chehab > wrote: > > Hmm... maybe we could, instead, keep one of them as a "complete" ATSC > possible channel list, and the other ones with the unregulated channels > stripped. OK I will upload a new patch “turning off” the

[PATCH] libmediactl.c: add poor man's udev support

If libudev is not available (android!), then just try to find the device in /dev. It's a poor man's solution, but it is better than nothing. Signed-off-by: Hans Verkuil diff --git a/utils/media-ctl/libmediactl.c b/utils/media-ctl/libmediactl.c index 4a82d24..1577783

[PATCH] [media] media-entity: protect object creation/removal using spin lock

Some parts of the media controller are using mutexes while others are using spin locks in order to protect creation and removal of elements in the graph. That's wrong! Also, the V4L2 core can remove graph elements on non-interactive context: BUG: sleeping function called from invalid

Re: [PATCH 05/18] [media] media-controller: enable all interface links at init

Em Mon, 23 Nov 2015 21:46:53 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 14:30:48 Mauro Carvalho Chehab wrote: > > Interface links are normally enabled, meaning that the interfaces are > > bound to

[PATCH] [media] au0828: postpone call to au0828_unregister_media_device()

The DVB core needs to unregister the media device. So, we can't call au0828_unregister_media_device() before calling au0828_dvb_unregister(), otherwise the DVB MC free code (that will be implemented on the next patch) will fail. Signed-off-by: Mauro Carvalho Chehab ---

Re: [PATCH 07/18] [media] dvbdev: returns error if graph object creation fails

Em Fri, 11 Sep 2015 17:20:47 +0200 Hans Verkuil escreveu: > On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > > Right now, if something gets wrong at dvb_create_media_entity() > > or at dvb_create_media_graph(), the device will still be > > registered. > > > > Change

[PATCH] [media] media-entity: fix backlink removal on __media_entity_remove_link()

The logic is testing if num_links==0 at the wrong place. Due to that, a backlink may be kept without removal, causing KASAN to complain about usage after free during either entity or link removal. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-entity.c | 6

Re: [PATCH 06/18] [media] media.h: create connector entities for hybrid TV devices

Em Mon, 23 Nov 2015 20:09:02 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 14:30:49 Mauro Carvalho Chehab wrote: > > Add entities to represent the connectors that exists inside a > > hybrid TV

Crash on suspend from pvrusb2 on suspend

[I think some thing ate this message so I apologize if this is a duplicate] Hi, We have a report (https://bugzilla.redhat.com/show_bug.cgi?id=1288856) of a crash from pvrusb2 when suspending to ram: - [ 95.801325] e1000e: eno1 NIC Link is Down [ 95.864208] PM: Syncing filesystems ...

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Dec 11 04:00:20 CET 2015 git branch: test git hash: 991ce92f8de24cde063d531246602b6e14d3fef2 gcc

[PATCH 2] ca-ON-Toronto: adding scan file for Toronto, Canada, added channel numbers

I have moved the channel numbers into the CHANNEL lines. I used the “physical channel number” which seems appropriate in this case. I would like to add a working entry for 22, but not sure what the DELIVERY_SYSTEM is? --- atsc/ca-ON-Toronto | 200

Re: [v4l-utils PATCH 1/1] Allow building static binaries

Hi Gregor, I discussed with Hans and he thought you'd be the best person to take a look at this. The case is that I'd like to build static binaries and that doesn't seem to work with what's in Makefile.am for libv4l1 and libv4l2 at the moment. Thanks. On Tue, Dec 08, 2015 at 05:18:21PM +0200,

[PATCH] tc358743: Use local array with fixed size in i2c write

From: Mats Randgaard i2c_wr() is called from ops and the interrupt service routine, while state->wr_data is shared and unprotected, and could be overwritten. This shared buffer is therefore replaced with a local array with fixed size. The array has the size of one EDID block

[PATCH] renaming NTSC file because it doesnt actually use 8VSV, updating channel listings, add channel numbers

This file is renamed to more accurately reflect its contents, as well as including all channels every used in NTSC. This is primarily of historical interest, the ATSC file has a more up-to-date (and much shorter) list to scan against. I notice that my local repo has the rm, but this isn’t

[PATCH] tc358743: Print timings only when debug level is set

From: Mats Randgaard Signed-off-by: Mats Randgaard --- drivers/media/i2c/tc358743.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index cc38896..e9129d1 100644 ---

Re: [PATCH v8 55/55] [media] media-entity.h: document all the structs

Em Mon, 23 Nov 2015 22:19:19 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 09:03:14 Mauro Carvalho Chehab wrote: > > Only a few structs are documented on kernel-doc-nano format > > (the ones added by

[PATCH] [media] staging/davinci_vfpe: allow modular build

It has never been possible to actually build this driver as a loadable module, only built-in because the Makefile attempts to build each file into its own module and fails: ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined! ERROR: "vpfe_resizer_register_entities"

Re: [PATCH] [media] staging/davinci_vfpe: allow modular build

Em Thu, 10 Dec 2015 15:29:38 +0100 Arnd Bergmann escreveu: > It has never been possible to actually build this driver as > a loadable module, only built-in because the Makefile attempts > to build each file into its own module and fails: > > ERROR: "mbus_to_pix"

Re: [PATCH] [media] staging/davinci_vfpe: allow modular build

On Thursday 10 December 2015 08:10 PM, Mauro Carvalho Chehab wrote: > Em Thu, 10 Dec 2015 15:29:38 +0100 > Arnd Bergmann escreveu: > >> It has never been possible to actually build this driver as >> a loadable module, only built-in because the Makefile attempts >> to build each