A bugfix removed the two callers of s5p_cec_runtime_suspend
and s5p_cec_runtime_resume, leading to the return of a harmless
warning that I had previously fixed in commit aee8937089b1
("[media] s5p_cec: mark suspend/resume as __maybe_unused"):
staging/media/s5p-cec/s5p_cec.c:234:12: error:
Forgot to add changelog:
Changes since v7:
- fixed and improved ctrl ioctl handlers
Best regards,
Jacek Anaszewski
On 10/13/2016 04:19 PM, Jacek Anaszewski wrote:
The plugin provides support for the media device on Exynos4 SoC.
It performs single plane <-> multi plane API conversion,
video
From: Markus Elfring
Date: Thu, 13 Oct 2016 17:13:41 +0200
Move the assignment for the local variable "rr3" behind the source code
for a memory allocation by this function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 13 Oct 2016 14:50:05 +0200
Move the assignment for the local variable "prod" behind the source code
for a memory allocation by this function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 13 Oct 2016 17:50:11 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 13 Oct 2016 14:54:46 +0200
Return directly after a call of the function "rc_allocate_device" failed
at the beginning.
Signed-off-by: Markus Elfring
---
drivers/media/rc/redrat3.c | 2 +-
1 file
From: Markus Elfring
Date: Thu, 13 Oct 2016 17:40:34 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script "checkpatch.pl" pointed information out like the following.
Comparison to NULL could be written !…
Thus
From: Markus Elfring
Date: Thu, 13 Oct 2016 13:20:19 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: Possible unnecessary 'out of memory' message
Thus remove such a logging statement in five functions.
Link:
From: Markus Elfring
Date: Thu, 13 Oct 2016 10:50:24 +0200
The kfree() function was called in one case by the
redrat3_transmit_ir() function during error handling
even if the passed variable contained a null pointer.
* Adjust jump targets according to the Linux
From: Markus Elfring
Date: Thu, 13 Oct 2016 14:17:43 +0200
The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 13 Oct 2016 15:00:12 +0200
Adjust a jump label according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/media/rc/redrat3.c | 5 ++---
1 file changed, 2 insertions(+),
From: Markus Elfring
Date: Thu, 13 Oct 2016 18:06:18 +0200
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (18):
Use kcalloc() in two functions
Move two assignments in redrat3_transmit_ir()
Return directly
From: Markus Elfring
Date: Thu, 13 Oct 2016 14:40:11 +0200
Use the data structure member "dev" directly without assigning it
to an intermediate variable.
Thus delete the extra variable definition at the beginning.
Signed-off-by: Markus Elfring
Brian Starkey writes:
> Hi Eric,
>
> On Tue, Oct 11, 2016 at 12:01:14PM -0700, Eric Anholt wrote:
>>Brian Starkey writes:
>>
>>> Hi,
>>>
>>> This RFC series introduces a new connector type:
>>> DRM_MODE_CONNECTOR_WRITEBACK
>>> It is a follow-on
From: Markus Elfring
Date: Thu, 13 Oct 2016 10:25:57 +0200
Move the assignment for the data structure member "transmitting"
and the local variable "curlencheck" behind the source code
for memory allocations by this function.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 13 Oct 2016 15:40:33 +0200
* Use the data structure members "dev" and "udev" directly
without assigning them to intermediate variables.
Thus delete the extra variable definitions at the beginning.
* Fix indentation for the
From: Markus Elfring
Date: Thu, 13 Oct 2016 13:31:17 +0200
Replace the specification of a data type by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 13 Oct 2016 13:23:22 +0200
Replace the specification of a data type by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 13 Oct 2016 14:07:03 +0200
* One local variable was set to an error code before a concrete
error situation was detected. Thus move the corresponding assignment
into three if branches to indicate a memory allocation failure there.
From: Markus Elfring
Date: Thu, 13 Oct 2016 10:34:29 +0200
* Return directly after a call of the function "kcalloc" failed
at the beginning.
* Reorder two calls for the function "kfree" at the end.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 13 Oct 2016 13:21:55 +0200
The local variable "rc" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
On Thu, 2016-10-13 at 18:18 +0200, SF Markus Elfring wrote:
> diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
[]
> @@ -549,7 +549,7 @@ static void redrat3_get_firmware_rev(struct redrat3_dev
> *rr3)
> int rc = 0;
> char *buffer;
>
> - buffer =
From: Markus Elfring
Date: Thu, 13 Oct 2016 08:35:57 +0200
* Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".
This issue was detected by
On Thu, Oct 13, 2016 at 03:51:39PM +0200, Geert Uytterhoeven wrote:
> drivers/media/usb/dvb-usb/dib0700_core.c: In function
> ‘dib0700_rc_urb_completion’:
> drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be
> used uninitialized in this function
>
> When receiving
When receiving a nec repeat, ensure the correct scancode is repeated
rather than a random value from the stack. This removes the need
for the bogus uninitialized_var() and also fixes the warnings:
drivers/media/usb/dvb-usb/dib0700_core.c: In function
‘dib0700_rc_urb_completion’:
On Thu, Oct 13, 2016 at 06:39:23PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 13 Oct 2016 14:50:05 +0200
>
> Move the assignment for the local variable "prod" behind the source code
> for a memory allocation by this function.
The redrat3
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Oct 14 05:00:14 CEST 2016
media-tree git hash:9fce0c226536fc36c7fb0a8ca38a995be43e
media_build
> Markus, please stop being _so_ mechanical and use your
> brain a little too. By definition, sizeof(char) == 1.
>
> This _really_ should be kzalloc(RR3_FW_VERSION_LEN + 1,...)
Do you expect that function call examples like the following will be equivalent?
zbuffer = kzalloc(123, …);
On 13/10/2016 02:20, Lorenzo Stoakes wrote:
> This patch removes the write and force parameters from
> __get_user_pages_unlocked() to make the use of FOLL_FORCE explicit in callers
> as
> use of this flag can result in surprising behaviour (and hence bugs) within
> the
> mm subsystem.
>
>
Hello,
I have a system with 4GB ram and two Hauppauge PVR-500 cards (each
with a daughter card). With kernel 4.0.9 both the cards were working
fine. However, after upgrading to 8GB ram, the kernel paniced with an
error, "Random memory could be DMA written".
I upgraded to kernel 4.4.21 which is
drivers/media/usb/dvb-usb/dib0700_core.c: In function
‘dib0700_rc_urb_completion’:
drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be
used uninitialized in this function
When receiving an NEC repeat code, protocol is indeed not initialized.
Set it to RC_TYPE_NECX
Am 13.10.2016 um 02:20 schrieb Lorenzo Stoakes:
This patch series adjusts functions in the get_user_pages* family such that
desired FOLL_* flags are passed as an argument rather than implied by flags.
The purpose of this change is to make the use of FOLL_FORCE explicit so it is
easier to grep
Hi Philipp,
On Wed, Oct 12, 2016 at 03:26:48PM +0200, Philipp Zabel wrote:
> On Fri, Oct 7, 2016 at 11:52 PM, Sakari Ailus wrote:
> > Hi Philipp,
> >
> > On Fri, Oct 07, 2016 at 06:00:47PM +0200, Philipp Zabel wrote:
> >> Currently the v4l2_async_notifier needs to be given a
If CONFIG_PM_SLEEP=n:
drivers/staging/media/s5p-cec/s5p_cec.c:235: warning:
‘s5p_cec_runtime_suspend’ defined but not used
drivers/staging/media/s5p-cec/s5p_cec.c:243: warning:
‘s5p_cec_runtime_resume’ defined but not used
Mark these functions as__maybe_unused to fix this without
The plugin provides support for the media device on Exynos4 SoC.
It performs single plane <-> multi plane API conversion,
video pipeline linking and takes care of automatic data format
negotiation for the whole pipeline, after intercepting
VIDIOC_S_FMT or VIDIOC_TRY_FMT ioctls.
Signed-off-by:
This patch removes the write and force parameters from get_user_pages_locked()
and replaces them with a gup_flags parameter to make the use of FOLL_FORCE
explicit in callers as use of this flag can result in surprising behaviour (and
hence bugs) within the mm subsystem.
Signed-off-by: Lorenzo
36 matches
Mail list logo