[PATCH] staging: atomisp: gc2235: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 107541360 4 121182f56

Re: [PATCH v2] [media] uvcvideo: Prevent heap overflow in uvc driver

2017-07-06 Thread Guenter Roeck
On Fri, Jun 30, 2017 at 09:21:56AM -0700, Guenter Roeck wrote: > The size of uvc_control_mapping is user controlled leading to a > potential heap overflow in the uvc driver. This adds a check to verify > the user provided size fits within the bounds of the defined buffer > size. > >

[PATCH] rcar_fdp1: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-07-06 Thread Sergei Shtylyov
Hello! On 07/03/2017 03:43 PM, Hans Verkuil wrote: Index: media_tree/Documentation/media/v4l-drivers/rcar_imr.rst === --- /dev/null +++ media_tree/Documentation/media/v4l-drivers/rcar_imr.rst @@ -0,0 +1,86 @@ +Renesas R-Car Image

[PATCH] stm32-dcmi: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

[PATCH] staging: atomisp: mt9m114: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 151482640 8 177964584

Re: [PATCH v1 1/4] dt-bindings: media: mtk-cir: Add support for MT7622 SoC

2017-07-06 Thread Rob Herring
On Fri, Jun 30, 2017 at 02:03:04PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Document the devicetree bindings for CIR on MediaTek MT7622 > SoC. > > Signed-off-by: Sean Wang > --- >

[PATCH] atmel-isc: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-06 Thread Sylwester Nawrocki
On 07/06/2017 12:24 PM, Jose Abreu wrote: >>> +- edid-phandle: phandle to the EDID handler block. >> >> Could you make this property optional and when it is missing assume that >> device >> corresponding to the parent node of this node handles EDID? This way we could >> avoid having property

[PATCH] mediatek: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

[PATCH] davinci: vpif_display: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-06 Thread kbuild test robot
Hi Jose, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170706] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jose-Abreu/Synopsys

[PATCH] mtk-mdp: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

[PATCH] davinci: vpif_capture: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

[PATCH] pxa_camera: constify vb2_ops structure

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

Re: [PATCH 03/12] [media] vb2: add in-fence support to QBUF

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers are only queued > to the driver once they are ready. A buffer is ready when

Re: [PATCH 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver (fwd)

2017-07-06 Thread Julia Lawall
Please check on this (line 199). julia -- Forwarded message -- Date: Thu, 6 Jul 2017 13:58:29 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Re: [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera

2017-07-06 Thread Hugues FRUCHET
Hi Sylwester, Do you have the possibility to check for non-regression of this patchset on 9650/52 camera ? Best regards, Hugues. On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > This patchset enables OV9655 camera support. > > OV9655 support has been tested using STM32F4DIS-CAM extension board

Re: [PATCH 02/12] [media] vb2: split out queueing from vb_core_qbuf()

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > In order to support explicit synchronization we need to divide > vb2_core_qbuf() in two parts, one to be executed before the fence > signals and another one to do the actual queueing of the

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 5:26 PM, Arnd Bergmann wrote: > On Thu, Jul 6, 2017 at 3:44 AM, Tomasz Figa wrote: >> On Thu, Jul 6, 2017 at 2:20 AM, Christoph Hellwig wrote: >>> On Thu, Jul 06, 2017 at 12:22:35AM +0900, Tomasz Figa wrote: > >>> In general

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 5:26 PM, Arnd Bergmann wrote: >> On Thu, Jul 6, 2017 at 3:44 AM, Tomasz Figa wrote: >>> On Thu, Jul 6, 2017 at 2:20 AM, Christoph Hellwig wrote:

Re: [PATCH 05/12] [media] vivid: assign the specific device to the vb2_queue->dev

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > Instead of assigning the global v4l2 device, assign the specific device. > This was causing trouble when using using V4L2 events with vivid > devices. The device's queue should be the same we

Re: [PATCH 12/12] [media] vb2: add out-fence support to QBUF

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create > an out_fence for the buffer and return it to userspace on the fence_fd > field. It only works with ordered queues. > > The

Re: [PATCH 03/12] [media] vb2: add in-fence support to QBUF

2017-07-06 Thread Hans Verkuil
On 07/03/17 20:16, Gustavo Padovan wrote: >>> @@ -1436,6 +1481,11 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int >>> index, void *pb) >>> if (pb) >>> call_void_bufop(q, fill_user_buffer, vb, pb); >>> >>> + vb->in_fence = fence; >>> + if (fence &&

Re: v4l2-fwnode: status, plans for merge, any branch to merge against?

2017-07-06 Thread Pavel Machek
Hi! > > > > > I expect to have most of them in during the next merge window. > > > > > > > > So git://linuxtv.org/media_tree.git branch master is the right one to > > > > work one? > > > > > > I also pushed the rebased ccp2 branch there: > > > > > >

Re: [PATCH 12/12] [media] vb2: add out-fence support to QBUF

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create > an out_fence for the buffer and return it to userspace on the fence_fd > field. It only works with ordered queues. > > The

Re: [PATCH 09/12] [media] vivid: mark vivid queues as ordered

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > To enable vivid to be used with explicit synchronization we need > to mark its queues as ordered. > > Signed-off-by: Gustavo Padovan Acked-by: Hans Verkuil

Re: [PATCH 7/8] omap3isp: Check for valid port in endpoints

2017-07-06 Thread Sebastian Reichel
Hi, On Thu, Jul 06, 2017 at 02:00:18AM +0300, Sakari Ailus wrote: > Check that we do have a valid port in an endpoint, return an error if not. > > Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- >

Re: [PATCH 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-06 Thread Neil Armstrong
On 07/06/2017 12:55 PM, Hans Verkuil wrote: > On 07/06/17 12:27, Neil Armstrong wrote: >> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >> for such controller. >> The controller does not need HPD to be active, and could support up to max >> 5 logical addresses, but

Re: [PATCH 07/12] [media] v4l: add support to BUF_QUEUED event

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > Implement the needed pieces to let userspace subscribe for > V4L2_EVENT_BUF_QUEUED events. Videobuf2 will queue the event for the > DQEVENT ioctl. > > Signed-off-by: Gustavo Padovan

Re: [PATCH 08/12] [media] vb2: add 'ordered' property to queues

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > For explicit synchronization (and soon for HAL3/Request API) we need > the v4l2-driver to guarantee the ordering which the buffer were queued > by userspace. This is already true for many

[PATCH 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-06 Thread Neil Armstrong
The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver for such controller. The controller does not need HPD to be active, and could support up to max 5 logical addresses, but only 1 is handled since the Suspend firmware can make use of this unique logical address to wake up

[PATCH 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-06 Thread Neil Armstrong
The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver for such controller. The controller does not need HPD to be active, and could support up to max 5 logical addresses, but only 1 is handled since the Suspend firmware can make use of this unique logical address to wake up

[PATCH 2/2] dt-bindings: media: Add Amlogic Meson AO-CEC bindings

2017-07-06 Thread Neil Armstrong
The Amlogic SoCs embeds a standalone CEC Controller, this patch adds this device bindings. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/media/meson-ao-cec.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644

Re: [PATCH 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-06 Thread Hans Verkuil
On 07/06/17 12:27, Neil Armstrong wrote: > The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver > for such controller. > The controller does not need HPD to be active, and could support up to max > 5 logical addresses, but only 1 is handled since the Suspend firmware can >

Re: [PATCH 5/8] v4l: Add support for CSI-1 and CCP2 busses

2017-07-06 Thread Sebastian Reichel
Hi, On Thu, Jul 06, 2017 at 02:00:16AM +0300, Sakari Ailus wrote: > From: Sakari Ailus > > CCP2 and CSI-1, are older single data lane serial busses. > > Signed-off-by: Sakari Ailus > Signed-off-by: Pavel Machek Reviewed-by:

Re: [PATCH 4/8] v4l: fwnode: Obtain data bus type from FW

2017-07-06 Thread Sebastian Reichel
Hi, On Thu, Jul 06, 2017 at 02:00:15AM +0300, Sakari Ailus wrote: > From: Sakari Ailus > > Just obtain it. It'll actually get used soon with CSI-1/CCP2. > > Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel

Re: [PATCH 3/8] v4l: fwnode: Call CSI2 bus csi2, not csi

2017-07-06 Thread Sebastian Reichel
Hi, On Thu, Jul 06, 2017 at 02:00:14AM +0300, Sakari Ailus wrote: > The function to parse CSI2 bus parameters was called > v4l2_fwnode_endpoint_parse_csi_bus(), rename it as > v4l2_fwnode_endpoint_parse_csi2_bus() in anticipation of CSI1/CCP2 > support. > > Signed-off-by: Sakari Ailus

Re: [PATCH 03/12] [media] vb2: add in-fence support to QBUF

2017-07-06 Thread Hans Verkuil
On 06/16/17 09:39, Gustavo Padovan wrote: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers are only queued > to the driver once they are ready. A buffer is ready when

Re: [PATCH 07/12] [media] v4l: add support to BUF_QUEUED event

2017-07-06 Thread Hans Verkuil
On 06/30/17 14:04, Mauro Carvalho Chehab wrote: > Em Fri, 16 Jun 2017 16:39:10 +0900 > Gustavo Padovan escreveu: > >> From: Gustavo Padovan >> >> Implement the needed pieces to let userspace subscribe for >> V4L2_EVENT_BUF_QUEUED events.

Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-06 Thread Jose Abreu
Hi Sylwester, On 05-07-2017 21:52, Sylwester Nawrocki wrote: > On 07/04/2017 04:11 PM, Jose Abreu wrote: >> Document the bindings for the Synopsys Designware HDMI RX. >> >> Signed-off-by: Jose Abreu >> --- >> .../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 70 >>

Re: [PATCH 0/8] Prepare for CCP2 / CSI-1 support, omap3isp fixes

2017-07-06 Thread Pavel Machek
Hi! > Most of these patches have been posted to the list in some form or other > already but a lot has happened since. Thus reposting. There are more > patches in my ccp2 branch but they're not quite ready as such, for the > reasons discussed previously. I'm using Sakari's ccp2 branch as a basis

[PATCH v7 3/3] MAINTAINERS: Add ADV748x driver

2017-07-06 Thread Kieran Bingham
From: Kieran Bingham The ADV7481 is an integrated video decoder and combined HDMI/MHL receiver. Signed-off-by: Kieran Bingham Acked-by: Laurent Pinchart --- MAINTAINERS | 6

[PATCH v7 1/3] media: adv748x: Add adv7481, adv7482 bindings

2017-07-06 Thread Kieran Bingham
From: Kieran Bingham Create device tree bindings documentation for the ADV748x. The ADV748x supports both the ADV7481 and ADV7482 chips which provide analogue decoding and HDMI receiving capabilities Signed-off-by: Kieran Bingham

[PATCH v7 0/3] ADV748x HDMI/Analog video receiver

2017-07-06 Thread Kieran Bingham
From: Kieran Bingham This is a driver for the Analog Devices ADV748x device, and follows on from a previous posting by Niklas Söderlund [0] of an earlier incarnation of this driver, and earlier versions posted by myself. ADV748x === The ADV7481 and

[PATCH v7 2/3] media: i2c: adv748x: add adv748x driver

2017-07-06 Thread Kieran Bingham
From: Kieran Bingham Provide support for the ADV7481 and ADV7482. The driver is modelled with 4 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs though two CSI TX entities. The HDMI entity is linked to the TXA

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa wrote: >> On Thu, Jul 6, 2017 at 5:26 PM, Arnd Bergmann wrote: >>> On Thu, Jul 6, 2017 at 3:44 AM, Tomasz Figa wrote: >>

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2017 at 3:31 PM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 9:23 PM, Arnd Bergmann wrote: >> On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa wrote: >>> On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa wrote: >>>

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 9:23 PM, Arnd Bergmann wrote: >> On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa wrote: >>> On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa wrote:

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 11:02 PM, Arnd Bergmann wrote: > On Thu, Jul 6, 2017 at 3:49 PM, Tomasz Figa wrote: >> On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa wrote: > >>> On the other hand, if it's strictly about base/dma-mapping, we might >>>

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2017 at 3:49 PM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa wrote: >> On the other hand, if it's strictly about base/dma-mapping, we might >> not need it indeed. The driver could call iommu-dma helpers directly, >>

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2017 at 4:06 PM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 11:02 PM, Arnd Bergmann wrote: >> On Thu, Jul 6, 2017 at 3:49 PM, Tomasz Figa wrote: >>> On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa wrote: >>

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 9:23 PM, Arnd Bergmann wrote: > On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa wrote: >> On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa wrote: >>> On Thu, Jul 6, 2017 at 5:26 PM, Arnd Bergmann wrote:

Re: [PATCH v2 08/19] media: camss: Add files which handle the video device nodes

2017-07-06 Thread Todor Tomov
Hello Hans, Thank you for the time spent to review. On 07/03/2017 02:32 PM, Hans Verkuil wrote: > On 06/19/2017 04:48 PM, Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. >> >> Signed-off-by: Todor Tomov >> --- >>

[PATCH] cec: only increase the seqnr if CEC_TRANSMIT would return 0

2017-07-06 Thread Hans Verkuil
The transmit code would increase the sequence number first thing, even though CEC_TRANSMIT would return an error due to a malformatted cec_msg struct later on. While valid behavior, this had the disadvantage of producing holes in the sequence list that made debugging harder. Only increase the

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 11:27 PM, Arnd Bergmann wrote: > On Thu, Jul 6, 2017 at 4:06 PM, Tomasz Figa wrote: >> On Thu, Jul 6, 2017 at 11:02 PM, Arnd Bergmann wrote: >>> On Thu, Jul 6, 2017 at 3:49 PM, Tomasz Figa wrote:

Re: [PATCH v2 08/19] media: camss: Add files which handle the video device nodes

2017-07-06 Thread Hans Verkuil
On 07/06/17 15:44, Todor Tomov wrote: > Hello Hans, > > Thank you for the time spent to review. > > On 07/03/2017 02:32 PM, Hans Verkuil wrote: >> On 06/19/2017 04:48 PM, Todor Tomov wrote: >>> These files handle the video device nodes of the camss driver. >>> >>> Signed-off-by: Todor Tomov

[PATCH] staging: atomisp: lm3554: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 53471920 2472911c7b

[PATCH] staging: atomisp: ov2680: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 124663120 8 155943cea

[PATCH] staging: atomisp: ov8858: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 238048448 0 322527dfc

[PATCH] staging: atomisp: gc0310: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 102971888 0 121852f99

[PATCH] staging: atomisp: ov2722: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 147711880 0 16651410b

[PATCH] staging: atomisp: ov5693: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 207293264 0 239935db9

Re: [PATCH] rcar_fdp1: constify vb2_ops structure

2017-07-06 Thread Kieran Bingham
Hi Gustavo, Thank you for the patch. On 06/07/17 21:25, Gustavo A. R. Silva wrote: > Check for vb2_ops structures that are only stored in the ops field of a > vb2_queue structure. That field is declared const, so vb2_ops structures > that have this property can be declared as const also. > >

Re: [PATCH 03/12] [media] vb2: add in-fence support to QBUF

2017-07-06 Thread Gustavo Padovan
2017-07-06 Hans Verkuil : > On 06/16/17 09:39, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers are only queued >

Re: [PATCH 02/12] [media] vb2: split out queueing from vb_core_qbuf()

2017-07-06 Thread Gustavo Padovan
2017-07-06 Hans Verkuil : > On 06/16/17 09:39, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > In order to support explicit synchronization we need to divide > > vb2_core_qbuf() in two parts, one to be executed before the fence > >

[PATCH] st-delta: constify vb2_ops structures

2017-07-06 Thread Gustavo A. R. Silva
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable

Re: [PATCH 03/12] [media] vb2: add in-fence support to QBUF

2017-07-06 Thread Gustavo Padovan
2017-07-06 Hans Verkuil : > On 07/03/17 20:16, Gustavo Padovan wrote: > >>> @@ -1436,6 +1481,11 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned > >>> int index, void *pb) > >>> if (pb) > >>> call_void_bufop(q, fill_user_buffer, vb, pb); > >>> > >>> +

Re: [PATCH 03/12] [media] vb2: add in-fence support to QBUF

2017-07-06 Thread Gustavo Padovan
2017-07-06 Hans Verkuil : > On 06/16/17 09:39, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers are only queued >