Re: [PATCH v2 1/6] [media] v4l: add blend modes controls

2017-07-15 Thread Laurent Pinchart
Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:35 Jacob Chen wrote: > At peresent, we don't have a control for Compositing and Blend. > All drivers are just doing copies while actually many hardwares > supports more functions. > > So Adding V4L2 controls for Compositing and

Re: [PATCH 1/3] [media] uvcvideo: variable size controls

2017-07-15 Thread Laurent Pinchart
Hi Philipp, Thank you for the patch. On Friday 14 Jul 2017 22:14:22 Philipp Zabel wrote: > Some USB webcam controllers have extension unit controls that report > different lengths via GET_LEN, depending on internal state. If I ever need to hire a hardware designer, I'll make sure to reject any

Re: rc-core: how to use hid (hardware) decoder?

2017-07-15 Thread Sean Young
Hello, On Fri, Jul 14, 2017 at 04:14:05AM +0300, Antti Palosaari wrote: > Moikka! > Some remote controller receivers uses HID interface. I looked rc-core > implementation, but failed to find how it could be used for hid. I need > somehow get scancodes and keycodes out from rc-core and write those

Re: rc-core: how to use hid (hardware) decoder?

2017-07-15 Thread Antti Palosaari
On 07/15/2017 12:05 PM, Sean Young wrote: Hello, On Fri, Jul 14, 2017 at 04:14:05AM +0300, Antti Palosaari wrote: Moikka! Some remote controller receivers uses HID interface. I looked rc-core implementation, but failed to find how it could be used for hid. I need somehow get scancodes and

Re: [PATCH 3/3] [media] uvcvideo: skip non-extension unit controls on Oculus Rift Sensors

2017-07-15 Thread Laurent Pinchart
Hi Philipp, Thank you for the patch. On Friday 14 Jul 2017 22:14:24 Philipp Zabel wrote: > The Oculus Rift Sensors (DK2 and CV1) allow to configure their sensor chips > directly via I2C commands using extension unit controls. The processing and > camera unit controls do not function at all. Do

[PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings

2017-07-15 Thread Jacob Chen
Add DT bindings documentation for Rockchip RGA Signed-off-by: Yakir Yang Signed-off-by: Jacob Chen --- .../devicetree/bindings/media/rockchip-rga.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644

[PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices

2017-07-15 Thread Jacob Chen
Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288-evb.dtsi | 4 arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 arch/arm/boot/dts/rk3288-firefly.dtsi | 4 arch/arm/boot/dts/rk3288-miqi.dts | 4

Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices

2017-07-15 Thread Laurent Pinchart
Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote: > Signed-off-by: Jacob Chen > --- > arch/arm/boot/dts/rk3288-evb.dtsi | 4 > arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 >

Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings

2017-07-15 Thread Laurent Pinchart
Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:40 Jacob Chen wrote: > Add DT bindings documentation for Rockchip RGA > > Signed-off-by: Yakir Yang > Signed-off-by: Jacob Chen > --- > .../devicetree/bindings/media/rockchip-rga.txt

Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

2017-07-15 Thread Laurent Pinchart
Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:36 Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image blur/sharpness.

[PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

2017-07-15 Thread Jacob Chen
Rockchip RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D graphics operations, such as point/line drawing, image scaling, rotation, BitBLT, alpha blending and image blur/sharpness. The drvier is mostly based on s5p-g2d v4l2 m2m driver. And supports various operations from

[PATCH v2 0/6] Add Rockchip RGA V4l2 support

2017-07-15 Thread Jacob Chen
This patch series add a v4l2 m2m drvier for rockchip RGA direct rendering based 2d graphics acceleration module. change in V2: - generalize the controls. - map buffers (10-50 us) in every cmd-run rather than in buffer-import to avoid get_free_pages failed on actively used systems. - remove

[PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288

2017-07-15 Thread Jacob Chen
This patch add the RGA dt config of rk3288 SoC. Signed-off-by: Yakir Yang Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v2 1/6] [media] v4l: add blend modes controls

2017-07-15 Thread Jacob Chen
At peresent, we don't have a control for Compositing and Blend. All drivers are just doing copies while actually many hardwares supports more functions. So Adding V4L2 controls for Compositing and Blend, used for for composting streams. The values are based on porter duff operations. Defined in

[PATCH v2 4/6] ARM: dts: rockchip: add RGA device node for RK3399

2017-07-15 Thread Jacob Chen
This patch add the RGA dt config of RK3399 SoC. Signed-off-by: Yakir Yang Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288

2017-07-15 Thread Heiko Stuebner
Hi Jacob, Am Samstag, 15. Juli 2017, 14:58:37 CEST schrieb Jacob Chen: > This patch add the RGA dt config of rk3288 SoC. > > Signed-off-by: Yakir Yang > Signed-off-by: Jacob Chen from the Signed-off it looks like Yakir was te original author of the

Re: [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read

2017-07-15 Thread Jonathan Cameron
On Fri, 14 Jul 2017 11:31:03 +0200 Arnd Bergmann wrote: > gcc-7 points out an older regression: > > drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw': > drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean > context, did you mean '<' ?

[PATCH for 4.13] cec-notifier: small improvements

2017-07-15 Thread Hans Verkuil
Allow calling cec_notifier_set_phys_addr and cec_notifier_set_phys_addr_from_edid with a NULL notifier, in which case these functions do nothing. Add a cec_notifier_phys_addr_invalidate helper function (the notifier equivalent of cec_phys_addr_invalidate). These changes simplify drm CEC driver

[PATCH 4/4] drm/tegra: add cec-notifier support

2017-07-15 Thread Hans Verkuil
From: Hans Verkuil In order to support CEC the HDMI driver has to inform the CEC driver whenever the physical address changes. So when the EDID is read the CEC driver has to be informed and whenever the hotplug detect goes away. This is done through the cec-notifier

[PATCH 1/4] dt-bindings: document the tegra CEC bindings

2017-07-15 Thread Hans Verkuil
From: Hans Verkuil This documents the binding for the Tegra CEC module. Signed-off-by: Hans Verkuil --- .../devicetree/bindings/media/tegra-cec.txt| 26 ++ 1 file changed, 26 insertions(+) create mode 100644

[PATCH 3/4] tegra-cec: add Tegra HDMI CEC driver

2017-07-15 Thread Hans Verkuil
From: Hans Verkuil This driver adds support for the Tegra CEC IP. It is based on the NVIDIA drivers/misc/tegra-cec driver in their 3.10 kernel. This has been converted to the CEC framework and cleaned up. Tested with my Jetson TK1 board. It has also been tested with the

[PATCH 2/4] ARM: tegra: add CEC support to tegra124.dtsi

2017-07-15 Thread Hans Verkuil
From: Hans Verkuil Add support for the Tegra CEC IP to tegra124.dtsi and enable it on the Jetson TK1. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4 arch/arm/boot/dts/tegra124.dtsi | 12

[PATCH 0/4] tegra-cec: add Tegra HDMI CEC support

2017-07-15 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the Tegra CEC functionality. It has two prerequisites: this cec-notifier patch: https://patchwork.linuxtv.org/patch/42521/ and this workaround: http://www.spinics.net/lists/dri-devel/msg147038.html A proper fix

Re: [PATCH, RESEND 02/14] ata: avoid gcc-7 warning in ata_timing_quantize

2017-07-15 Thread Tejun Heo
On Fri, Jul 14, 2017 at 11:25:14AM +0200, Arnd Bergmann wrote: > gcc-7 warns about the result of a constant multiplication used as > a boolean: > > drivers/ata/libata-core.c: In function 'ata_timing_quantize': > drivers/ata/libata-core.c:3164:30: warning: '*' in boolean context, suggest > '&&'

Re: Lots of new warnings with gcc-7.1.1

2017-07-15 Thread Tejun Heo
Hello, On Wed, Jul 12, 2017 at 03:31:02PM +0200, Arnd Bergmann wrote: > > We also have about a bazillion > > > > warning: ‘*’ in boolean context, suggest ‘&&’ instead > > > > warnings in drivers/ata/libata-core.c, all due to a single macro that > > uses a pattern that gcc-7.1.1 doesn't like.

Re: [PATCH 3/3] [media] uvcvideo: skip non-extension unit controls on Oculus Rift Sensors

2017-07-15 Thread Philipp Zabel
Am Samstag, den 15.07.2017, 12:54 +0300 schrieb Laurent Pinchart: > Hi Philipp, > > Thank you for the patch. > > On Friday 14 Jul 2017 22:14:24 Philipp Zabel wrote: > > The Oculus Rift Sensors (DK2 and CV1) allow to configure their sensor chips > > directly via I2C commands using extension unit

[PATCH] cec: drop senseless message

2017-07-15 Thread Hans Verkuil
Especially the '0.10' version number is confusing since CEC_ADAP_G_CAPS returns a completely different version number. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH 1/3] [media] uvcvideo: variable size controls

2017-07-15 Thread Philipp Zabel
Hi Laurent, Am Samstag, den 15.07.2017, 12:49 +0300 schrieb Laurent Pinchart: > Hi Philipp, > > Thank you for the patch. Thank you for the review. > On Friday 14 Jul 2017 22:14:22 Philipp Zabel wrote: > > Some USB webcam controllers have extension unit controls that report > > different

Re: [PATCH v7 2/3] media: i2c: adv748x: add adv748x driver

2017-07-15 Thread Niklas Söderlund
Hi Kieran, On 2017-07-14 17:45:02 +0100, Kieran Bingham wrote: > Hi Niklas > > On 13/07/17 07:28, Niklas Söderlund wrote: > > > > Hi Kieran, > > > > Thanks for your hard work. > > And thank you for your support! > > > On 2017-07-06 12:01:16 +0100, Kieran Bingham wrote: > >> From: Kieran

Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

2017-07-15 Thread Personnel
Le samedi 15 juillet 2017 à 12:42 +0300, Laurent Pinchart a écrit : > Hi Jacob, > > Thank you for the patch. > > On Saturday 15 Jul 2017 14:58:36 Jacob Chen wrote: > > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > > accelerates 2D graphics operations, such as point/line

Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

2017-07-15 Thread kbuild test robot
/20170715-214326 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next coccinelle warnings: (new ones prefixed by >>) >> drivers/media/platform/rockchip-rga/rga-hw.c:124:2-3: Unneeded semicolon Please review and possibly fold the followup patch

[PATCH] rockchip/rga: fix semicolon.cocci warnings

2017-07-15 Thread kbuild test robot
drivers/media/platform/rockchip-rga/rga-hw.c:124:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 6f3d6aeab3cb ("rockchip/rga: v4l2 m2m support") CC: Jacob Chen Signed-off-by: Fengguang Wu

Re: [PATCH 00/14] ddbridge: bump to ddbridge-0.9.29

2017-07-15 Thread Richard Scobie
Daniel Scheller wrote: From: Daniel Scheller Preferrably for Linux 4.14 (to get things done). Hard-depends on the STV0910/STV6111 driver patchset as the diff and the updated code depends on the driver and the changes involved with the glue code of the STV/DDCineS2V7 series

[PATCH] media: rc: nuvoton: remove rudimentary transmit functionality

2017-07-15 Thread Heiner Kallweit
Transmit support in this driver was never tested and based on the code it can't work. Just one example: The buffer provided to nvt_tx_ir holds unsigned int values in micro seconds: First value is for a pulse, second for a pause, etc. Bytes in this buffer are copied as-is to the chip FIFO what

Re: [PATCH 1/3] [media] uvcvideo: variable size controls (fwd)

2017-07-15 Thread Julia Lawall
drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/uvcvideo-variable-size-controls/20170715-193137 base: git://linuxtv.org/media_tree.git master :: branch date: 2 hours ago :: commit date: 2 hours ago >> drivers/media/u

[PATCH] pulse8-cec/rainshadow-cec: make adapter name unique

2017-07-15 Thread Hans Verkuil
The CEC adapter name used by the pulse8-cec and rainshadow-cec USB device drivers was a fixed string, but it should be unique if you connect multiple of these devices to the same computer. Use dev_name(>dev) instead, which make it unique again. Signed-off-by: Hans Verkuil

cron job: media_tree daily build: ERRORS

2017-07-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Jul 16 05:00:20 CEST 2017 media-tree git hash:2748e76ddb2967c4030171342ebdd3faa6a5e8e8 media_build

Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices

2017-07-15 Thread Jacob Chen
Hi Laurent, 2017-07-15 17:16 GMT+08:00 Laurent Pinchart : > Hi Jacob, > > Thank you for the patch. > > On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote: >> Signed-off-by: Jacob Chen >> --- >> arch/arm/boot/dts/rk3288-evb.dtsi

[PATCH V3 10/16] [media] dvb-core/dvb_ca_en50221.c: Fixed C++ comments

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich - Changed all C++ style comments ("// ..") to C style ones ("/* .. */"). Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH V3 09/16] [media] dvb-core/dvb_ca_en50221.c: Removed unused symbol

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich - The STATUSREG_TXERR definition is not used and it has style problems, too. Removing it seems to solve both issues. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH V3 14/16] [media] dvb-core/dvb_ca_en50221.c: Fixed remaining block comments

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich - Added the missing opening empty comment line. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c

[PATCH V3 08/16] [media] dvb-core/dvb_ca_en50221.c: Removed useless braces

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Fixed all: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-)

[PATCH V3 04/16] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Added also the missing opening empty comment line. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 29 +++-- 1 file changed, 19

[PATCH V3 06/16] [media] dvb-core/dvb_ca_en50221.c: Used a helper variable

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Used a helper variable "struct dvb_ca_slot *sl" instead of "ca->slot_info[slot]". This reduces the line length and simplifies code reading. Fixed also "-strict" checks in this patch: - Comparison to NULL written as "!". Signed-off-by: Jasmin Jessich

[PATCH V3 02/16] [media] dvb-core/dvb_ca_en50221.c: New function dvb_ca_en50221_poll_cam_gone

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich The CAM poll code for the budget-av is exactly the same on several places. Extracting the code to a new function improves maintainability. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 66

[PATCH V3 03/16] [media] dvb-core/dvb_ca_en50221.c: use usleep_range

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Fixed all: WARNING: msleep < 20ms can sleep for up to 20ms by using usleep_range. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V3 05/16] [media] dvb-core/dvb_ca_en50221.c: Avoid assignments in ifs

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Fixed all: ERROR: do not use assignment in if condition Fixed also "-strict" checks in this patch: - Changed "if (ret != 0)" to "if (ret)". - Camel case variables have been converted to kernel_case. - Comparison to NULL written as "!". - No space is

[PATCH V3 00/16] Fix coding style in en50221 CAM functions

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Changes V2 to V3: Fixed the remarks from Antti Polosaari. Checked the code with checkpatch.pl -strict and fixed all the findings. These patch series is the V3 version adapted to the already merged patches from V1 and other merged patches. It does no longer

[PATCH V3 01/16] [media] dvb-core/dvb_ca_en50221.c: Refactored dvb_ca_en50221_thread

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Refactored "dvb_ca_en50221_thread" by moving the state machine into the new function "dvb_ca_en50221_thread_state_machine". This reduces the thread function size and reduces the structural complexity and of course gives us more space to meet the line length

[PATCH V3 11/16] [media] dvb-core/dvb_ca_en50221.c: Fixed 80 char limit

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Fixed most of: WARNING: line over 80 characters The remaining lines are printk strings, which should not be split and lines where I thing they should stay as they are. Signed-off-by: Jasmin Jessich ---

[PATCH V3 13/16] [media] dvb-core/dvb_ca_en50221.c: Fix again wrong EXPORT_SYMBOL order

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Some EXPORT_SYMBOL() on this file don't match the name of functions that precedes them. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH V3 12/16] [media] dvb-core/dvb_ca_en50221.c: Fixed typo

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich - "dont" -> "don't" Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c

[PATCH V3 16/16] [media] dvb-core/dvb_ca_en50221.c: Fixed multiple blank lines

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich - Running "checkpatch.pl -strict -f ..." complained * Please don't use multiple blank lines Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 40 - 1 file changed, 40 deletions(-)

[PATCH V3 07/16] [media] dvb-core/dvb_ca_en50221.c: Added line breaks

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich Fixed all: WARNING: Missing a blank line after declarations Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH V3 15/16] [media] dvb-core/dvb_ca_en50221.c: Fixed style issues on the whole file

2017-07-15 Thread Jasmin J.
From: Jasmin Jessich - Running "checkpatch.pl -strict -f ..." gave more checks to fix. * Blank lines aren't necessary after an open brace '{' * Comparison to NULL written as "!" * CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Jasmin Jessich

Re: [PATCH v8 5/5] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-15 Thread kbuild test robot
Hi Jose, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.13-rc1 next-20170714] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

2017-07-15 Thread Jacob Chen
Hi all, 2017-07-16 0:49 GMT+08:00 Personnel : > Le samedi 15 juillet 2017 à 12:42 +0300, Laurent Pinchart a écrit : >> Hi Jacob, >> >> Thank you for the patch. >> >> On Saturday 15 Jul 2017 14:58:36 Jacob Chen wrote: >> > Rockchip RGA is a separate 2D raster graphic