Re: [RFC PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
Grrr. Please ignore, I pressed send even though I wanted to make some more changes. I'll post a v2 soon. Regards, Hans On 07/28/2017 12:52 PM, Hans Verkuil wrote: > From: Hans Verkuil > > I tried to get this in back in 2015, but that effort stalled. > >

Re: [PATCH 4/6 v5] uvcvideo: add a metadata device node

2017-07-28 Thread Guennadi Liakhovetski
Hi Hans, On Fri, 28 Jul 2017, Hans Verkuil wrote: > On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote: [snip] > > +/** > > + * struct uvc_meta_buf - metadata buffer building block > > + * @ns - system timestamp of the payload in nanoseconds > > + * @sof- USB Frame

[GIT PULL FOR v4.14] Add meson-ao-cec driver

2017-07-28 Thread Hans Verkuil
The following changes since commit da48c948c263c9d87dfc64566b3373a858cc8aa2: media: fix warning on v4l2_subdev_call() result interpreted as bool (2017-07-26 13:43:17 -0400) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git meson-cec for you to fetch changes

Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs

2017-07-28 Thread Hans Verkuil
On 06/28/2017 12:57 AM, Hirokazu Honda wrote: > Hi, > > According to patch work, this patch are not approved yet and its > status are "Changes Requested." > What changes are necessary actually? > If there is no necessary change, can you approve this patch? I was considering to have more fine

[PATCH] cec: documentation fixes

2017-07-28 Thread Hans Verkuil
Various references to open() et al were wrong. Fix this so following the link will get you to the correct place. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/cec/cec-func-close.rst | 2 +- Documentation/media/uapi/cec/cec-func-ioctl.rst | 2 +-

[RFC PATCH 2/2] v4l: document VIDIOC_SUBDEV_QUERYCAP

2017-07-28 Thread Hans Verkuil
From: Hans Verkuil Add documentation for the new VIDIOC_SUBDEV_QUERYCAP ioctl. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/user-func.rst | 1 + .../media/uapi/v4l/vidioc-subdev-querycap.rst | 118

[RFC PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
From: Hans Verkuil I tried to get this in back in 2015, but that effort stalled. Trying again, since I really need this in order to add proper v4l-subdev support to v4l2-ctl and v4l2-compliance. There currently is no way of unique identifying that the device really is a

[RFC PATCH 1/2] v4l2-subdev: add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
From: Hans Verkuil While normal video/radio/vbi/swradio nodes have a proper QUERYCAP ioctl that apps can call to determine that it is indeed a V4L2 device, there is currently no equivalent for v4l-subdev nodes. Adding this ioctl will solve that, and it will allow

Re: [PATCH] v4l: rcar-vin: Simplify rvin_group_notify_{bound,unbind}

2017-07-28 Thread Hans Verkuil
On 07/21/2017 11:55 AM, Kieran Bingham wrote: > Use a container_of macro to obtain the graph entity object from the ASD > This removes the error conditions, and reduces the lock contention. > > (The locking may even be potentially removed) I've set the status in patchwork to 'Not Applicable'

Re: [RFC 04/19] dt: bindings: Add lens-focus binding for image sensors

2017-07-28 Thread Pavel Machek
Hi! > Is the lens-focus phandle specific to voice-coil controllers? What about > motor-controlled focus systems? What when there are multiple motors? E.g. > one for the focus, one for the iris control (yes, we have that). I'd say motor vs. coil is not important. Iris control should go to

Re: [RFCv2 PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Laurent Pinchart
Hi Hans, Thank you for the patches. On Friday 28 Jul 2017 13:05:27 Hans Verkuil wrote: > From: Hans Verkuil > > I tried to get this in back in 2015, but that effort stalled. > > Trying again, since I really need this in order to add proper v4l-subdev > support to

Re: [RFCv2 PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
On 07/28/2017 03:25 PM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patches. > > On Friday 28 Jul 2017 13:05:27 Hans Verkuil wrote: >> From: Hans Verkuil >> >> I tried to get this in back in 2015, but that effort stalled. >> >> Trying again, since I really

[PATCH] vimc: add test_pattern and h/vflip controls to the sensor

2017-07-28 Thread Hans Verkuil
Add support for the test_pattern control and the h/vflip controls. This makes it possible to switch to more interesting test patterns and to test control handling in v4l-subdevs. There are more tpg-related controls that can be added, but this is a good start. Signed-off-by: Hans Verkuil

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-28 Thread Laurent Pinchart
Hi Guennadi, On Friday 28 Jul 2017 10:59:29 Guennadi Liakhovetski wrote: > On Fri, 28 Jul 2017, Laurent Pinchart wrote: > > On Tuesday 25 Jul 2017 15:27:24 Guennadi Liakhovetski wrote: > >> On Fri, 21 Jul 2017, Laurent Pinchart wrote: > >>> Hi Guennadi, > >>> > >>> Thank you for the patch. > >>>

Re: [PATCH v3 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-28 Thread Hans Verkuil
Hi Neil, On 07/27/2017 05:20 PM, Neil Armstrong wrote: > The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver > for such controller. > The controller does not need HPD to be active, and could support up to max > 5 logical addresses, but only 1 is handled since the Suspend

Re: [PATCH v3 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-28 Thread Hans Verkuil
On 07/28/2017 02:35 PM, Hans Verkuil wrote: > Hi Neil, > > On 07/27/2017 05:20 PM, Neil Armstrong wrote: >> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >> for such controller. >> The controller does not need HPD to be active, and could support up to max >> 5

Re: [PATCH v3 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-28 Thread Hans Verkuil
On 07/27/2017 05:20 PM, Neil Armstrong wrote: > The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver > for such controller. > The controller does not need HPD to be active, and could support up to max > 5 logical addresses, but only 1 is handled since the Suspend firmware

[PATCH] [media] coda: reduce iram size to leave space for suspend to ram

2017-07-28 Thread Philipp Zabel
From: Jan Luebbe The on-chip SRAM of i.MX6S is only 128 KiB. 4 KiB of that are allocated for suspend to RAM since commit df595746fa69 ("ARM: imx: add suspend in ocram support for i.mx6q"). Reduce the requested IRAM size to 124 KiB to avoid an allocation failure that causes

[PATCH] [media] coda: fix decoder sequence init escape flag

2017-07-28 Thread Philipp Zabel
coda_command_sync calls coda_command_async, which writes the bit_stream_param context variable into the BIT_STREAM_PARAM register, overwriting the previously set value during coda_start_decoding. Instead of writing to the register, set bit_stream_param to ensure that the decoder sequence init

[RFCv2 PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
From: Hans Verkuil I tried to get this in back in 2015, but that effort stalled. Trying again, since I really need this in order to add proper v4l-subdev support to v4l2-ctl and v4l2-compliance. There currently is no way of unique identifying that the device really is a

[RFCv2 PATCH 2/2] v4l: document VIDIOC_SUBDEV_QUERYCAP

2017-07-28 Thread Hans Verkuil
From: Hans Verkuil Add documentation for the new VIDIOC_SUBDEV_QUERYCAP ioctl. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/user-func.rst | 1 + .../media/uapi/v4l/vidioc-subdev-querycap.rst | 121

[RFCv2 PATCH 1/2] v4l2-subdev: add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
From: Hans Verkuil While normal video/radio/vbi/swradio nodes have a proper QUERYCAP ioctl that apps can call to determine that it is indeed a V4L2 device, there is currently no equivalent for v4l-subdev nodes. Adding this ioctl will solve that, and it will allow

[PATCH 0/6 v5] uvcvideo: metadata nodes and controls

2017-07-28 Thread Guennadi Liakhovetski
The first four patches are for UVC metadata nodes, the last two patches are for asynchronous controls and control error reporting. Thanks Guennadi Guennadi Liakhovetski (6): UVC: fix .queue_setup() to check the number of planes V4L: Add a UVC Metadata format uvcvideo: convert from using an

[PATCH 6/6 v5] uvcvideo: handle control pipe protocol STALLs

2017-07-28 Thread Guennadi Liakhovetski
When a command ends up in a STALL on the control pipe, use the Request Error Code control to provide a more precise error information to the user. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_video.c | 59

[PATCH 2/6 v5] V4L: Add a UVC Metadata format

2017-07-28 Thread Guennadi Liakhovetski
Add a pixel format, used by the UVC driver to stream metadata. Signed-off-by: Guennadi Liakhovetski --- Documentation/media/uapi/v4l/meta-formats.rst| 1 + Documentation/media/uapi/v4l/pixfmt-meta-uvc.rst | 39

[PATCH 4/6 v5] uvcvideo: add a metadata device node

2017-07-28 Thread Guennadi Liakhovetski
Some UVC video cameras contain metadata in their payload headers. This patch extracts that data, adding more clock synchronisation information, on both bulk and isochronous endpoints and makes it available to the user space on a separate video node, using the V4L2_CAP_META_CAPTURE capability and

[PATCH 3/6 v5] uvcvideo: convert from using an atomic variable to a reference count

2017-07-28 Thread Guennadi Liakhovetski
When adding support for metadata nodes, we'll have to keep video devices registered until all metadata nodes are closed too. Since this has nothing to do with stream counting, replace the nstreams atomic variable with a reference counter. Signed-off-by: Guennadi Liakhovetski

[PATCH 5/6 v5] uvcvideo: send a control event when a Control Change interrupt arrives

2017-07-28 Thread Guennadi Liakhovetski
UVC defines a method of handling asynchronous controls, which sends a USB packet over the interrupt pipe. This patch implements support for such packets by sending a control event to the user. Since this can involve USB traffic and, therefore, scheduling, this has to be done in a work queue.

[PATCH 1/6 v5] UVC: fix .queue_setup() to check the number of planes

2017-07-28 Thread Guennadi Liakhovetski
According to documentation of struct vb2_ops the .queue_setup() callback should return an error if the number of planes parameter contains an invalid value on input. Fix this instead of ignoring the value. Signed-off-by: Guennadi Liakhovetski ---

[PATCH] v4l: use struct v4l2_buffer explicitly instead of void *

2017-07-28 Thread Guennadi Liakhovetski
A number of functions use void * for a struct v4l2_buffer parameter. Avoid that to improve compile-time checking. Signed-off-by: Guennadi Liakhovetski --- This probably was done on purpose, maybe to reuse the video buffers by other than V4L2 users, but I

Re: [PATCH 2/6 v5] V4L: Add a UVC Metadata format

2017-07-28 Thread Hans Verkuil
On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote: > Add a pixel format, used by the UVC driver to stream metadata. > > Signed-off-by: Guennadi Liakhovetski > --- > Documentation/media/uapi/v4l/meta-formats.rst| 1 + >

Re: [PATCH 4/6 v5] uvcvideo: add a metadata device node

2017-07-28 Thread Hans Verkuil
On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote: > Some UVC video cameras contain metadata in their payload headers. This > patch extracts that data, adding more clock synchronisation information, > on both bulk and isochronous endpoints and makes it available to the > user space on a separate

Re: [PATCH v3 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-28 Thread Neil Armstrong
On 07/28/2017 02:37 PM, Hans Verkuil wrote: > On 07/28/2017 02:35 PM, Hans Verkuil wrote: >> Hi Neil, >> >> On 07/27/2017 05:20 PM, Neil Armstrong wrote: >>> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >>> for such controller. >>> The controller does not need HPD

Re: [media] vimc: API proposal, configuring the topology from user space

2017-07-28 Thread Hans Verkuil
Hi Helen, Finally after way too long I found some time to review this. See my comments below. On 04/11/2017 12:53 AM, Helen Koike wrote: > > Hi, > > Continuing the discussion about the API of the vimc driver, I made some > changes > based on the previous comments, please see below and let me

[GIT PULL FOR v4.14] Various fixes

2017-07-28 Thread Hans Verkuil
The following changes since commit da48c948c263c9d87dfc64566b3373a858cc8aa2: media: fix warning on v4l2_subdev_call() result interpreted as bool (2017-07-26 13:43:17 -0400) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.14c for you to fetch

Re: [PATCH v3 02/12] intel-ipu3: mmu: implement driver

2017-07-28 Thread Robin Murphy
On 26/07/17 11:38, Tomasz Figa wrote: > Hi Robin, > > On Wed, Jul 19, 2017 at 10:37 PM, Robin Murphy wrote: >> On 19/07/17 04:12, Yong Zhi wrote: >>> From: Tomasz Figa >>> >>> This driver translates Intel IPU3 internal virtual >>> address to physical

Re: [RFCv2 PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
On 07/28/2017 04:04 PM, Hans Verkuil wrote: > On 07/28/2017 03:25 PM, Laurent Pinchart wrote: >> To solve this, if you really want to identify the type of device node at >> runtime, we should have a single ioctl supported by the two device nodes. >> Given that we"re running out of capabilities

Re: [RFCv2 PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Laurent Pinchart
Hi Hans, On Friday 28 Jul 2017 16:04:48 Hans Verkuil wrote: > On 07/28/2017 03:25 PM, Laurent Pinchart wrote: > > On Friday 28 Jul 2017 13:05:27 Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> I tried to get this in back in 2015, but that effort stalled. > >> > >>

Re: [RFCv2 PATCH 0/2] add VIDIOC_SUBDEV_QUERYCAP ioctl

2017-07-28 Thread Hans Verkuil
On 07/28/2017 04:28 PM, Laurent Pinchart wrote: > Hi Hans, > > On Friday 28 Jul 2017 16:04:48 Hans Verkuil wrote: >> On 07/28/2017 03:25 PM, Laurent Pinchart wrote: >>> On Friday 28 Jul 2017 13:05:27 Hans Verkuil wrote: From: Hans Verkuil I tried to get

Re: pull request: linux-firmware: Update Mediatek MT8173 VPU firmware

2017-07-28 Thread andrew-ct chen
Hi linux-firmware maintainers, Sorry, problems with this release firmware. We will release v1.0.6 in a few days. Thanks a lot. Andrew On Thu, 2017-07-20 at 15:59 +0800, Andrew-CT Chen wrote: > Hi linux-firmware maintainers, > > The following changes since commit

[GIT PULL FOR v4.14] Use LINUX_VERSION_CODE for media versioning

2017-07-28 Thread Hans Verkuil
Just a little thing that always annoyed me: the driver_version shouldn't be set in drivers. The version number never, ever gets updated in drivers. We saw that in the other media subsystems and now the core always sets it, not drivers. This works much better, and also works well when

[GIT PULL FOR v4.14] v2: Use LINUX_VERSION_CODE for media versioning

2017-07-28 Thread Hans Verkuil
Just a little thing that always annoyed me: the driver_version shouldn't be set in drivers. The version number never, ever gets updated in drivers. We saw that in the other media subsystems and now the core always sets it, not drivers. This works much better, and also works well when

[GIT PULL FOR v4.14] Doc and TGP fixes

2017-07-28 Thread Hans Verkuil
Hi Mauro, Here are various documentation fixes/improvements. The first patch renames the old pixfmt-0XX.rst files to something I can understand since I could never find the right rst file for the colorspace documentation... Regards, Hans The following changes since commit

Re: [RFC 04/19] dt: bindings: Add lens-focus binding for image sensors

2017-07-28 Thread Hans Verkuil
Hi Sakari, Is the lens-focus phandle specific to voice-coil controllers? What about motor-controlled focus systems? What when there are multiple motors? E.g. one for the focus, one for the iris control (yes, we have that). What if you have two sensors (stereoscopic) controlled by one motor?

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-28 Thread Guennadi Liakhovetski
Hi Laurent, On Fri, 28 Jul 2017, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 25 Jul 2017 15:27:24 Guennadi Liakhovetski wrote: > > On Fri, 21 Jul 2017, Laurent Pinchart wrote: > > > Hi Guennadi, > > > > > > Thank you for the patch. > > > > > >> Some UVC video cameras contain

[PATCH v1 3/5] [media] stm32-dcmi: cleanup variable/fields namings

2017-07-28 Thread Hugues Fruchet
Uniformize "pixfmt" variables to "pix". Change "current_fmt" & "dcmi_fmt" variables to variables with "sd_" prefix to explicitly refer to subdev format. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 103 -- 1

[PATCH v1 1/5] [media] stm32-dcmi: catch dma submission error

2017-07-28 Thread Hugues Fruchet
Test cookie return by dmaengine_submit() and return error if any. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c

[PATCH v1 5/5] [media] stm32-dcmi: g_/s_selection crop support

2017-07-28 Thread Hugues Fruchet
Implements g_/s_selection crop support by using DCMI crop hardware feature. User can first get the maximum supported resolution of the sensor by calling g_selection(V4L2_SEL_TGT_CROP_BOUNDS). Then user call to s_selection(V4L2_SEL_TGT_CROP) will reset sensor to its maximum resolution and crop

[PATCH v1 2/5] [media] stm32-dcmi: revisit control register handling

2017-07-28 Thread Hugues Fruchet
Simplify bits handling of DCMI_CR register. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c

[PATCH v1 0/5] STM32 DCMI camera interface crop support

2017-07-28 Thread Hugues Fruchet
This patchset implements crop feature of Digital Camera Memory Interface (DCMI) of STMicroelectronics STM32 SoC series, allowing user to crop at pixel level inside sensor captured frame. This patchset follows discussions initiated from a first submission of DCMI crop support, see [1]. First part

[PATCH v1 4/5] [media] stm32-dcmi: set default format at open()

2017-07-28 Thread Hugues Fruchet
Ensure that we start with default pixel format and resolution when opening a new instance. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 49 ++- 1 file changed, 28 insertions(+), 21 deletions(-) diff --git

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-28 Thread Maxime Ripard
Hi, Thanks for the second iteration! On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > and CSI1 is used for parallel interface. This is not documented in > datasheet but by testing and guess. > > This patch

Re: [PATCH v2 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2017-07-28 Thread Maxime Ripard
Hi, On Thu, Jul 27, 2017 at 01:01:36PM +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Signed-off-by: Yong Deng > --- > .../devicetree/bindings/media/sun6i-csi.txt| 49 > ++ > 1 file changed, 49 insertions(+) >

[PATCH v1] media: ov13858: Correct link-frequency and pixel-rate

2017-07-28 Thread Chiranjeevi Rapolu
Previously both link-frequency and pixel-rate reported by the sensor was incorrect, resulting in incorrect FPS. Report link-frequency in Hz rather than link data rate in bps. Calculate pixel-rate from link-frequency. Signed-off-by: Chiranjeevi Rapolu ---

[PATCH v1] media: ov13858: Increase digital gain granularity, range

2017-07-28 Thread Chiranjeevi Rapolu
Previously, possible digital gains were just 1x, 2x and 4x. These coarse gains were not sufficient in fine-tuning the image capture. Now, digital gain range is [0, 16x] with each step 1/1024, default 1x. This is achieved through OV13858 MWB R/G/B gain controls. Signed-off-by: Chiranjeevi Rapolu

Re: [PATCH v3 02/12] intel-ipu3: mmu: implement driver

2017-07-28 Thread Tomasz Figa
On Fri, Jul 28, 2017 at 11:10 PM, Robin Murphy wrote: > On 26/07/17 11:38, Tomasz Figa wrote: >> Hi Robin, >> >> On Wed, Jul 19, 2017 at 10:37 PM, Robin Murphy wrote: >>> On 19/07/17 04:12, Yong Zhi wrote: From: Tomasz Figa

Re: [PATCH v1] media: ov13858: Correct link-frequency and pixel-rate

2017-07-28 Thread Tomasz Figa
Hi Chiranjeevi, On Sat, Jul 29, 2017 at 3:48 AM, Chiranjeevi Rapolu wrote: > Previously both link-frequency and pixel-rate reported by > the sensor was incorrect, resulting in incorrect FPS. > Report link-frequency in Hz rather than link data rate in bps. >

cron job: media_tree daily build: ERRORS

2017-07-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jul 29 05:00:15 CEST 2017 media-tree git hash:da48c948c263c9d87dfc64566b3373a858cc8aa2 media_build

Re: Kworld 340U (1b80:a340) kernel 4.8.0 ERROR: i2c_transfer returned: -6

2017-07-28 Thread Kumar Vivek
Thank you Frank! I appreciate your time. This is what I have done so far - On Wed, Jul 19, 2017 at 2:44 PM, Frank Schäfer wrote: > > Hi Kumar, > > I don't have time for the em28xx driver at the moment (and I also do not > have access to a device with tda18271