Make this const as it is only stored in a const field of a
video_device structure.
Signed-off-by: Bhumika Goyal
---
drivers/staging/media/omap4iss/iss_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss_video.c
Make this const as it is only stored in a const field of a
video_device structure.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/omap3isp/ispvideo.c
Make this const as it is only stored in a const field of a
video_device structure.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/cx18/cx18-streams.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx18/cx18-streams.c
Make this const as it is only stored in a const field of a
video_device structure.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/usbtv/usbtv-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/usbtv/usbtv-video.c
The dib9000_remove_slave_frontend() function isn't used.
I was reviewing it because my static checker claims it writes one
element beyond the end of the array. That's a false positive. What it
actually does is, if there are two or more front ends, then it prints a
debug message to say that it
This function is broken. It sets the wrong front_end to NULL. But it's
not used, so let's just delete it.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb-frontends/dib8000.h
b/drivers/media/dvb-frontends/dib8000.h
index 2b8b4b1656a2..75cc8e47ec8f 100644
Sphinx 1.6 changed the way tables are produced, adding some new
macros before tables that do vertical alignments. This is incompatible
with adjustbox, used by the media book, causing build to fail.
This series fix such issues and make the layout on Sphinx 1.6 acceptable.
The first patch in this
Sphinx 1.6 generates some LaTeX code before each table,
starting its own environment before calling tabulary,
apparently to improve table layout.
The problem is that such environment is incompatible with
adjustbox. While, in thesis, it should be possible to override
it or to redefine tabulary, I
Now that the PDF building issues with Sphinx 1.6 got fixed,
update the documentation and scripts accordingly.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/sphinx.rst | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
On Sphinx 1.6, fancy boxes are used for verbatim. The sphinx.sty
sets verbatim font is always \small. That causes a problem
inside tables that use smaller fonts, as it can be too big for
the box.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/conf.py | 2 +-
1
Em Thu, 24 Aug 2017 13:29:14 -0600
Jonathan Corbet escreveu:
> On Thu, 24 Aug 2017 13:26:28 -0600
> Jonathan Corbet wrote:
>
> > > - % To allow adjusting table sizes
> > > - \\usepackage{adjustbox}
> > > -
> > > '''
> > > }
> >
> > So this change
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/marvell-ccic/mcam-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/s5p-g2d/g2d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-g2d/g2d.c
b/drivers/media/platform/s5p-g2d/g2d.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/mx2_emmaprp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/mx2_emmaprp.c
b/drivers/media/platform/mx2_emmaprp.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/dt3155/dt3155.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/dt3155/dt3155.c
b/drivers/media/pci/dt3155/dt3155.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/vim2m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
index afbaa35..b01fba0
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/m2m-deinterlace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/m2m-deinterlace.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/fsl-viu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/via-camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/via-camera.c
b/drivers/media/platform/via-camera.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/platform/ti-vpe/cal.c | 2 +-
drivers/media/platform/ti-vpe/vpe.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/cal.c
Em Fri, 25 Aug 2017 15:42:21 +0200
Hans Verkuil escreveu:
> On 25/08/17 14:52, Mauro Carvalho Chehab wrote:
> > From: "mche...@s-opensource.com"
> >
> > When we added support for omap3, back in 2010, we added a new
> > type of V4L2 devices that
Move the calculation to where it is needed, so the result doesn't
need to be stored in the device struct.
Signed-off-by: Sean Young
---
drivers/media/rc/serial_ir.c | 34 ++
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git
From: Jasmin Jessich
Prefer using accessor functions so we are not dependent on the ktime_t
type.
Signed-off-by: Jasmin Jessich
Signed-off-by: Sean Young
---
drivers/media/rc/rc-ir-raw.c | 11 ++-
1 file changed, 6 insertions(+), 5
Prefer using accessor functions so we are not dependent on the ktime_t
type.
Signed-off-by: Sean Young
---
drivers/media/rc/gpio-ir-tx.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-tx.c b/drivers/media/rc/gpio-ir-tx.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/s2255/s2255drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255/s2255drv.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/stkwebcam/stk-webcam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c
Make video_device const.
Bhumika Goyal (11):
[media] zr364xx: make video_device const
[media] stkwebcam: make video_device const
[media] stk1160: make video_device const
[media] s2255drv: make video_device const
[media] pwc: make video_device const
[media] pvrusb2: make video_device
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/stk1160/stk1160-v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/hackrf/hackrf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/hackrf/hackrf.c
b/drivers/media/usb/hackrf/hackrf.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/go7007/go7007-v4l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/go7007/go7007-v4l2.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/msi2500/msi2500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/msi2500/msi2500.c
b/drivers/media/usb/msi2500/msi2500.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/pwc/pwc-if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
index 22420c1..eb6921d
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/zr364xx/zr364xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/zr364xx/zr364xx.c
b/drivers/media/usb/zr364xx/zr364xx.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/airspy/airspy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/airspy/airspy.c
b/drivers/media/usb/airspy/airspy.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/cpia2/cpia2_v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/cpia2/cpia2_v4l.c
b/drivers/media/usb/cpia2/cpia2_v4l.c
index
Hi Mauro,
Without the ktime_t accessor functions, the pre-v4.10 media_build broken.
Also there is a fix for the serial_ir on 32-bit builds.
Please merge where you see fit.
Thanks
Sean
The following changes since commit 0779b8855c746c90b85bfe6e16d5dfa2a6a46655:
media: ddbridge: fix
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/sta2x11/sta2x11_vip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/solo6x10/solo6x10-v4l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/tw68/tw68-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/tw68/tw68-video.c
b/drivers/media/pci/tw68/tw68-video.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/saa7134/saa7134-empress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/saa7134/saa7134-empress.c
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/meye/meye.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c
index 0fe76be..49e047e
Make video_device const.
Bhumika Goyal (5):
[media] meye: make video_device const
[media] saa7134: make video_device const
[media] solo6x10: make video_device const
[media] sta2x11: make video_device const
[media] tw68: make video_device const
drivers/media/pci/meye/meye.c
On Kernel 2.6.39, the omap3 driver was introduced together with a new way
to control complex V4L2 devices used on embedded systems, but this was
never documented, as the original idea were to have "soon" support for
standard apps to use it as well, via libv4l, but that didn't happen so far.
As both vdev-centric and MC-centric devices may implement the
same APIs, we need a flag to allow userspace to distinguish
between them.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/v4l/open.rst| 7 +++
minor numbers use to range between 0 to 255, but that
was changed a long time ago. While it still applies when
CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is
dynamically allocated, this may not be true. In any case,
this is not relevant, as udev will take care of it.
So, remove this
Add a glossary of terms for V4L2, as several concepts are complex
enough to cause misunderstandings.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/v4l/glossary.rst | 98 +++
Documentation/media/uapi/v4l/v4l2.rst | 1
Right now, only kAPI documentation describes the device naming.
However, such description is needed at the uAPI too. Add it,
and describe how to get an unique identify for a given device.
Acked-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
When we added support for omap3, back in 2010, we added a new
type of V4L2 devices that aren't fully controlled via the V4L2
device node.
Yet, we have never clearly documented in the V4L2 specification
the differences between the two types.
Let's document them based on the the current
On Sat, Aug 26, 2017 at 5:29 PM, Mauro Carvalho Chehab
wrote:
> Em Sat, 26 Aug 2017 15:50:02 +0530
> Bhumika Goyal escreveu:
>
>> Make make video_device const.
>>
>> Bhumika Goyal (10):
>> [media] cx88: make video_device const
>> [media] dt3155:
On Thu, Aug 24, 2017 at 10:58:07AM +0200, Maciej Purski wrote:
> MHL specification defines Remote Control Protocol(RCP) to
> send input events between MHL devices.
> The driver now recognizes RCP messages and reacts to them
> by reporting key events to input subsystem, allowing
> a user to control
Only the media PDF book was requiring adjustbox, in order to
scale big tables. That worked pretty good with Sphinx versions
1.4 and 1.5, but Spinx 1.6 changed the way tables are produced,
by introducing some weird macros before tabulary.
That causes adjustbox to fail. So, it can't be used anymore,
Do some minor editorial changes to make this chapter visually
better, and the example a little bit clearer.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/dvb/dvbproperty.rst | 25 -
1 file changed, 12 insertions(+), 13
The ATSC 3.0 uses MPEG Media Transport, with is not currently
supported. Yet, we'll need to implement it sooner or later.
So, mention about it at the specs.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/dvb/frontend.rst | 5 ++---
1 file changed, 2
The description of what SEC means fits well as a footnote.
That makes the need of saying that SEC is only for Satellite
when it was mentioned, as the footnote already says that.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/dvb/frontend.rst | 19
The introduction for the frontend chapter is not quite
correct:
- it tells that it supports only three types of
delivery systems, in opposite to three *groups*;
- It adds ISDB-C to the list of supported systems,
but, this is not true.
Fix it.
Signed-off-by: Mauro Carvalho Chehab
The description of the DVBv5 API was written a long time ago,
where the API was still new, and there were not apps using it.
Now that the API is stable and used by new applications, clarify
that DVBv3 calls should not be used and why.
Signed-off-by: Mauro Carvalho Chehab
The device numbering for DVB uses "M" and "N" as vars for the
number of the device, but sometimes this is printed using normal
font instead of verbatim.
While here, remove an extra space after quotation marks.
This is a minor cleanup with no changes at the text.
Signed-off-by: Mauro Carvalho
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
Em Sat, 26 Aug 2017 15:50:02 +0530
Bhumika Goyal escreveu:
> Make make video_device const.
>
> Bhumika Goyal (10):
> [media] cx88: make video_device const
> [media] dt3155: make video_device const
> [media]: marvell-ccic: make video_device const
> [media]
Make these const as they are only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/radio/radio-tea5764.c| 2 +-
drivers/media/radio/radio-wl1273.c | 2 +-
drivers/media/radio/si4713/radio-platform-si4713.c | 2 +-
Make this const as it is only passed to the const argument of the
function cx88_vdev_init.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/cx88/cx88-blackbird.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx88/cx88-blackbird.c
Make make video_device const.
Bhumika Goyal (10):
[media] cx88: make video_device const
[media] dt3155: make video_device const
[media]: marvell-ccic: make video_device const
[media] mx2-emmaprp: make video_device const
[media]: s5p-g2d: make video_device const
[media]: ti-vpe: make
As we now have a glossary, some terms used on open.rst
require adjustments.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/v4l/open.rst | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
The documentation doesn't mention if vdev-centric hardware
control would have subdev API or not.
Add a notice about that, reflecting the current status, where
three drivers use it, in order to support some subdev-specific
controls.
Signed-off-by: Mauro Carvalho Chehab
Em Sat, 26 Aug 2017 17:42:34 +0530
Bhumika Goyal escreveu:
> On Sat, Aug 26, 2017 at 5:29 PM, Mauro Carvalho Chehab
> wrote:
> > Em Sat, 26 Aug 2017 15:50:02 +0530
> > Bhumika Goyal escreveu:
> >
> >> Make make video_device
Make these const as they are either used during a copy operation or
passed to a const argument of the function cx88_vdev_init.
Signed-off-by: Bhumika Goyal
---
* Combine the patch series sent for drivers/media/pci/ into a
single patch.
Em Wed, 23 Aug 2017 16:48:25 +0200
Hans Verkuil escreveu:
> Hi Mauro,
>
> Some more constify stuff and some fixes. The vb2 patch required to fix a
> venus bug is the most interesting change here.
>
> I tried the -p flag for this pull request. I'm not convinced how useful it
Make these const as they are only used during a copy operation.
Done using Coccinelle:
@match disable optional_qualifier@
identifier s;
@@
static struct video_device s = {...};
@ref@
position p;
identifier match.s;
@@
s@p
@good1@
identifier match.s;
expression list[3] es;
position ref.p;
@@
Acked-by: Mike Isely
-Mike
On Sat, 26 Aug 2017, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
>
> Signed-off-by: Bhumika Goyal
> ---
> Changes in v2:
> * Combine the patch series sent for drivers/media/usb/
Make these const as they are only used during a copy operation.
Signed-off-by: Bhumika Goyal
---
Changes in v2:
* Combine the patch series sent for drivers/media/usb/ into a
single patch.
drivers/media/usb/airspy/airspy.c| 2 +-
drivers/media/usb/cpia2/cpia2_v4l.c
On Sat, 26 Aug 2017 06:28:24 -0300
Mauro Carvalho Chehab wrote:
> IMHO, the best is if I apply patch 2 on my trees. Please apply
> patches 1 and 3 on your tree.
>
> Patch 4 can only be applied after patch 2 gets merged, but it
> is just a cleanup patch that can be
From: Markus Elfring
Date: Sat, 26 Aug 2017 22:22:13 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sat, 26 Aug 2017 22:36:54 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation in usbvision_probe()
Adjust eight checks
From: Markus Elfring
Date: Sat, 26 Aug 2017 22:06:05 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 26 Aug 2017 22:16:52 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus
Kfree on NULL pointer is a no-op and therefore checking is redundant.
Signed-off-by: Himanshu Jha
---
.../staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c| 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
From: Jasmin Jessich
- Added v3.16_gpio-ir-tx.patch
- gpio_ir_tx needs 3.13. at least
Signed-off-by: Jasmin Jessich
---
backports/backports.txt | 1 +
backports/v3.16_gpio-ir-tx.patch | 25 +
v4l/versions.txt | 1
From: Jasmin Jessich
Kernel 3.17 introduces GPIOD_OUT_LOW/HIGH. gpio-ir-tx requires this
definitions. This patch adds the API calls prior to 3.17 to be used
by gpio-ir-tx.
With that gpio-ir-tx can be compiled back to Kernel 3.13.
I tested the compilation (not the functionality!)
v4l2_subdev_sensor_ops are not supposed to change at runtime.
v4l2_subdev_sensor_ops are working with const 'sensor' field of
sturct v4l2_subdev_ops. So mark the non-const v4l2_subdev_sensor_ops
structs as const.
Signed-off-by: Arvind Yadav
---
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sun Aug 27 05:00:17 CEST 2017
media-tree git hash:0b56d1c8fd8991b0ae5255151c54ed20deb49a28
media_build
81 matches
Mail list logo