Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback

Hi Sakari, On 2017/9/18 15:36, Sakari Ailus wrote: Hi Wenyou, On Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote: @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd, ret = ov7670_try_fmt_internal(sd, >format, NULL, NULL); if (ret)

Re: [PATCH v5 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

Hi Leon, Thanks for the update. Please see my comments below. On Fri, Sep 15, 2017 at 03:49:52PM +0800, Leon Luo wrote: > The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. > It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface > is 4-lane MIPI CSI-2 running at

[PATCH v4] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

Hello Mr Chehab, It seems that there is a mismatch among tab spacing in local patch on my PC, the patch in email and the patch in lkml site. This is causing alignment problem. Even if I fix alignment problem in my PC, alignment is different in lkml and email. Anyway, I have run checkpatch and got

[PATCH] cec-ioc-dqevent.rst: fix typo

The documentation talked about INITIAL_VALUE when the actual define is INITIAL_STATE. Fix this. Signed-off-by: Hans Verkuil Reported-by: Jonas Karlman --- diff --git a/Documentation/media/uapi/cec/cec-ioc-dqevent.rst

Re: [PATCH] Staging: media: atomisp: Merge assignment with return

On Tue, Sep 12, 2017 at 07:55:07PM +0530, Srishti Sharma wrote: > Merge the assignment and the return statements to return the value > directly. Done using the following semantic patch by coccinelle. > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return

[PATCH] cec-core.rst/cec-ioc-receive.rst: clarify CEC_TX_STATUS_ERROR

CEC_TX_STATUS_ERROR can be used if the HW cannot tell LOST_ARB and LOW_DRIVE apart, or when some other error occurs. It is not a replacement for NACK. So the hardware must be able to tell the difference between OK, NACK and 'something else'. Clarify the documentation (both public and kernel

Re: as3645a flash userland interface

Hi Jacek, On Tue, Sep 12, 2017 at 08:53:33PM +0200, Jacek Anaszewski wrote: > Hi Pavel, > > On 09/12/2017 12:36 PM, Pavel Machek wrote: > > Hi! > > > > There were some changes to as3645a flash controller. Before we have > > stable interface we have to keep forever I want to ask: > > Note that

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

Hi! > Specify the exact label used if the label property is omitted in DT, as > well as use label in the example that conforms to LED device naming. > > @@ -69,11 +73,11 @@ Example > flash-max-microamp = <32>; > led-max-microamp = <6>; >

Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation

Hi Sakari, On 2017/9/18 15:35, Sakari Ailus wrote: Hi Wenyou, Thanks for the update. The driver exposes controls that are accessible through the sub-device node even if the device hasn't been powered on. Many ISP and bridge drivers will also power the sensor down once the last user of the

[RESEND PATCH v2 3/6] as3645a: Use integer numbers for parsing LEDs

Use integer numbers for LEDs, 0 is the flash and 1 is the indicator. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Acked-by: Jacek Anaszewski --- arch/arm/boot/dts/omap3-n950-n9.dtsi | 8 ++--

[RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

Specify the exact label used if the label property is omitted in DT, as well as use label in the example that conforms to LED device naming. Signed-off-by: Sakari Ailus --- Documentation/devicetree/bindings/leds/ams,as3645a.txt | 12 1 file changed, 8

[RESEND PATCH v2 1/6] as3645a: Use ams,input-max-microamp as documented in DT bindings

DT bindings document the property "ams,input-max-microamp" that limits the chip's maximum input current. The driver and the DTS however used "peak-current-limit" property. Fix this by using the property documented in DT binding documentation. Signed-off-by: Sakari Ailus

[RESEND PATCH v2 2/6] dt: bindings: as3645a: Use LED number to refer to LEDs

Use integers (reg property) to tell the number of the LED to the driver instead of the node name. While both of these approaches are currently used by the LED bindings, using integers will require less driver changes for ACPI support. Additionally, it will make possible LED naming using chip and

[RESEND PATCH v2 6/6] as3645a: Unregister indicator LED on device unbind

The indicator LED was registered in probe but was not removed in driver remove callback. Fix this. Signed-off-by: Sakari Ailus --- drivers/leds/leds-as3645a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-as3645a.c

[RESEND PATCH v2 0/6] AS3645A fixes

Hi folks, (Resending, fixed linux-media list address.) Here are a few fixes for the as3645a DTS as well as changes in bindings. The driver is not in a release yet. I'd like to get these in as through the media tree fixes branch. since v1: - Add LED colour to the name of the LED, this adds two

[RESEND PATCH v2 5/6] as3645a: Add colour to LED name

Add the colour of the LED to the LED name, as specified in Documentation/leds/leds-class.txt. Signed-off-by: Sakari Ailus --- drivers/leds/leds-as3645a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-as3645a.c

Re: [PATCHv4 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

On Mon, Sep 18, 2017 at 05:26:43PM +0200, Hans Verkuil wrote: > On 09/18/2017 04:36 PM, Ville Syrjälä wrote: > > On Mon, Sep 18, 2017 at 04:07:41PM +0200, Hans Verkuil wrote: > >> Hi Ville, > >> > >> On 09/18/2017 03:05 PM, Ville Syrjälä wrote: > >>> On Sat, Sep 16, 2017 at 04:17:26PM +0200, Hans

[PATCH] [media] gspca: Use common error handling code in gspca_init_transfer()

From: Markus Elfring Date: Mon, 18 Sep 2017 18:40:05 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation

Hi Wenyou, On Mon, Sep 18, 2017 at 05:26:16PM +0800, Yang, Wenyou wrote: > Hi Sakari, > > > On 2017/9/18 15:35, Sakari Ailus wrote: > > Hi Wenyou, > > > > Thanks for the update. > > > > The driver exposes controls that are accessible through the sub-device node > > even if the device hasn't

[PATCH 3/6] [media] go7007: Improve a size determination in four functions

From: Markus Elfring Date: Mon, 18 Sep 2017 11:27:30 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

Re: [PATCHv4 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

Hi Ville, On 09/18/2017 03:05 PM, Ville Syrjälä wrote: > On Sat, Sep 16, 2017 at 04:17:26PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Implement support for this DisplayPort feature. >> >> The cec device is created whenever it detects an adapter that >> has

[PATCH] media: rc: Delete duplicate debug message

ir_setkeytable() and ir_create_table() print the same debug message. Delete the one in ir_setkeytable() Signed-off-by: Marc Gonzalez --- drivers/media/rc/rc-main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/rc/rc-main.c

[PATCH] [media] gspca: Delete two error messages for a failed memory allocation in gspca_dev_probe2()

From: Markus Elfring Date: Mon, 18 Sep 2017 17:47:58 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

Marc Gonzalez writes: > The tango IR decoder supports NEC, RC-5, RC-6 protocols. > NB: Only the NEC decoder was tested. > > Signed-off-by: Marc Gonzalez > --- > drivers/media/rc/Kconfig| 5 + > drivers/media/rc/Makefile |

Re: [PATCHv4 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

On 09/18/2017 04:36 PM, Ville Syrjälä wrote: > On Mon, Sep 18, 2017 at 04:07:41PM +0200, Hans Verkuil wrote: >> Hi Ville, >> >> On 09/18/2017 03:05 PM, Ville Syrjälä wrote: >>> On Sat, Sep 16, 2017 at 04:17:26PM +0200, Hans Verkuil wrote: From: Hans Verkuil

Re: [PATCHv4 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

On Sat, Sep 16, 2017 at 04:17:26PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Implement support for this DisplayPort feature. > > The cec device is created whenever it detects an adapter that > has this feature. It is only removed when a new adapter is connected

[PATCH 0/6] [media] Go7007: Adjustments for some function implementations

From: Markus Elfring Date: Mon, 18 Sep 2017 14:54:32 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (6): Delete an error message for a failed memory allocation in go7007_load_encoder() Adjust 35 checks

Re: [PATCH] media: i2c: OV5647: ensure clock lane in LP-11 state before streaming on

Hi Jacob, On Mon, Sep 11, 2017 at 09:53:40AM +0800, Jacob Chen wrote: > When I was supporting Rpi Camera Module on the ASUS Tinker board, > I found this driver have some issues with rockchip's mipi-csi driver. > It didn't place clock lane in LP-11 state before performing > D-PHY initialisation. >

Re: [PATCH] Support HVR-1200 analog video as a clone of HVR-1500. Tested, composite and s-video inputs.

On Sun, Sep 17, 2017 at 5:42 PM, Nigel Kettlewell wrote: > I propose the following patch to support Hauppauge HVR-1200 analog video, > nothing more than a clone of HVR-1500. Patch based on Linux 4.9 commit > 69973b830859bc6529a7a0468ba0d80ee5117826 > > I have

Re: [PATCHv4 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

On Sat, Sep 16, 2017 at 04:17:24PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This adds support for the DisplayPort CEC-Tunneling-over-AUX > feature that is part of the DisplayPort 1.3 standard. > > Unfortunately, not all DisplayPort/USB-C to HDMI adapters with

[PATCH 1/1] staging: atomisp: Add driver prefix to Kconfig option and module names

By adding the "atomisp-" prefix to module names (and "ATOMISP_" to Kconfig options), the staging drivers for e.g. sensors are labelled as being specific to atomisp, which they effectively are. Signed-off-by: Sakari Ailus ---

Re: [PATCH v4] drm/bridge/sii8620: add remote control support

Hi Hans, some time ago in reply to your email I described what messages does the MHL driver receive and at what time intervals. Regarding that information, do you think that a similar solution as in [1] is required? Would it be OK, if I just set REP_DELAY and REP_PERIOD to values, which I

Re: [PATCH v4] drm/bridge/sii8620: add remote control support

On 09/18/2017 04:15 PM, Maciej Purski wrote: > Hi Hans, > some time ago in reply to your email I described what messages does > the MHL driver receive and at what time intervals. > Regarding that information, do you think that a similar solution as > in [1] is required? Would it be OK, if I just

[PATCH 2/6] [media] go7007: Adjust 35 checks for null pointers

From: Markus Elfring Date: Mon, 18 Sep 2017 11:13:27 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH v1] media: rc: Add driver for tango IR decoder

The tango IR decoder supports NEC, RC-5, RC-6 protocols. NB: Only the NEC decoder was tested. Signed-off-by: Marc Gonzalez --- drivers/media/rc/Kconfig| 5 + drivers/media/rc/Makefile | 1 + drivers/media/rc/tango-ir.c | 263

[PATCH] [media] cxusb: pass buf as a const u8 * pointer and make buf static const

From: Colin Ian King Don't populate the read-only u8 array buf on the stack at run time but instead make it static const; makes object code smaller saving over 480 bytes: Before: textdata bss dec hex filename 33030 65936 192 99158 18356

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

Hi Pavel, On Mon, Sep 18, 2017 at 12:56:55PM +0200, Pavel Machek wrote: > Hi! > > > Specify the exact label used if the label property is omitted in DT, as > > well as use label in the example that conforms to LED device naming. > > > > @@ -69,11 +73,11 @@ Example > >

[PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()

From: Markus Elfring Date: Mon, 18 Sep 2017 14:28:59 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()

From: Markus Elfring Date: Mon, 18 Sep 2017 13:50:45 +0200 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This refactoring might fix also an error situation where the function "i2c_unregister_device" was

[PATCH 1/6] [media] go7007: Delete an error message for a failed memory allocation in go7007_load_encoder()

From: Markus Elfring Date: Mon, 18 Sep 2017 10:52:42 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 6/6] [media] go7007: Delete an unnecessary variable initialisation in go7007_snd_init()

From: Markus Elfring Date: Mon, 18 Sep 2017 14:35:43 +0200 The variable "ret" will eventually be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

Re: [PATCHv4 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

On Mon, Sep 18, 2017 at 04:07:41PM +0200, Hans Verkuil wrote: > Hi Ville, > > On 09/18/2017 03:05 PM, Ville Syrjälä wrote: > > On Sat, Sep 16, 2017 at 04:17:26PM +0200, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Implement support for this DisplayPort feature. >

Re: [PATCH v2] media: ov13858: Calculate pixel-rate at runtime, use mode

Hi Chiranjeevi, On Wed, Sep 06, 2017 at 11:26:33AM -0700, Chiranjeevi Rapolu wrote: > Calculate pixel-rate at run time instead of compile time. > > Instead of using hardcoded pixels-per-line, extract it from current sensor > mode. > > Signed-off-by: Chiranjeevi Rapolu

[PATCH] [media] jl2005bcd: Delete an error message for a failed memory allocation in jl2005c_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 19:24:24 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] [media] sq905: Delete an error message for a failed memory allocation in sq905_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 21:30:58 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH v5 1/2] media:imx274 device tree binding file

On Fri, Sep 15, 2017 at 03:49:51PM +0800, Leon Luo wrote: > The binding file for imx274 CMOS sensor V4l2 driver > > Signed-off-by: Leon Luo > --- > v5: > - add 'port' and 'endpoint' information > v4: > - no changes > v3: > - remove redundant properties and references

[PATCH 1/1] staging: media: MAINTAINERS: Add entry for atomisp driver

Add the maintainers entry to the atomisp staging media driver. Signed-off-by: Sakari Ailus --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb930eb..3e25df3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

Dave Stevenson writes: > diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c > b/drivers/media/platform/bcm2835/bcm2835-unicam.c > new file mode 100644 > index 000..5b1adc3 > --- /dev/null > +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c > @@

Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties

On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote: > Document optional lens-focus and flash properties for the smiapp driver. > > Signed-off-by: Sakari Ailus > --- > Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ > 1 file changed, 2

[PATCH 0/2] [media] ViCam: Adjustments for vicam_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 22:05:22 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Return directly after a failed kmalloc()

[PATCH 1/2] [media] vicam: Delete an error message for a failed memory allocation in vicam_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 21:48:55 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

On Mon 2017-09-18 17:49:23, Sakari Ailus wrote: > Hi Pavel, > > On Mon, Sep 18, 2017 at 12:56:55PM +0200, Pavel Machek wrote: > > Hi! > > > > > Specify the exact label used if the label property is omitted in DT, as > > > well as use label in the example that conforms to LED device naming. > > >

Re: [PATCHv6 3/5] dt-bindings: document the CEC GPIO bindings

On Sun, Sep 17, 2017 at 5:15 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Document the bindings for the cec-gpio module for hardware where the > CEC line and optionally the HPD line are connected to GPIO lines. > > Signed-off-by: Hans Verkuil

[PATCH 2/2] [media] vicam: Return directly after a failed kmalloc() in vicam_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 21:56:55 +0200 * Return directly after a call of the function "kmalloc" failed at the beginning. * Delete the jump target "exit" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring

Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties

Hi Rob, Rob Herring wrote: On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote: Document optional lens-focus and flash properties for the smiapp driver. Signed-off-by: Sakari Ailus --- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++

RE: [PATCH v1] media: ov13858: Fix 4224x3136 video flickering at some vblanks

Hi Tomasz, >The change of register values itself doesn't give any information about what >is changed. Could you explain the following: >- What is the "crop" in this case? The new crop is (0,8), (4255, 3159). >- What value was it set to before and why was it wrong? Old crop was (0, 0), (4255,

[PATCH v2] media: ov13858: Fix 4224x3136 video flickering at some vblanks

Previously, with crop (0, 0), (4255, 3167), VTS < 0xC9E was resulting in blank frames sometimes. This appeared as video flickering. But we need VTS < 0xC9E to get ~30fps. Omni Vision recommends to use crop (0,8), (4255, 3159) for 4224x3136. With this crop, VTS 0xC8E is supported and yields

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 19 05:00:19 CEST 2017 media-tree git hash:1efdf1776e2253b77413c997bed862410e4b6aaf media_build

Re: [PATCH v2] media: ov13858: Fix 4224x3136 video flickering at some vblanks

Hi Chiranjeevi, On Tue, Sep 19, 2017 at 7:47 AM, Chiranjeevi Rapolu wrote: > Previously, with crop (0, 0), (4255, 3167), VTS < 0xC9E was resulting in blank > frames sometimes. This appeared as video flickering. But we need VTS < 0xC9E > to > get ~30fps. > > Omni

[PATCH v2 5/5] media: atmel-isc: Rework the format list

To improve the readability of code, split the format array into two, one for the format description, other for the register configuration. Meanwhile, add the flag member to indicate the format can be achieved from the sensor or be produced by the controller, and rename members related to the

[PATCH v2 4/5] media: atmel-isc: Remove unnecessary member

Remove the memeber *config from the isc_subdev_entity struct, the member is useless afterward. Signed-off-by: Wenyou Yang --- Changes in v2: None drivers/media/platform/atmel/atmel-isc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git

[PATCH v4 2/3] media: ov7670: Add the get_fmt callback

Add the get_fmt callback, also enable V4L2_SUBDEV_FL_HAS_DEVNODE flag to make this subdev has device node. Signed-off-by: Wenyou Yang --- Changes in v4: - Fix the build error when not enabling V4L2 sub-device userspace API option. Changes in v3: - Keep tried format

[PATCH v4 1/3] media: ov7670: Add entity pads initialization

Add the media entity pads initialization. Signed-off-by: Wenyou Yang --- Changes in v4: - Fix the build error when not enabling Media Controller API option. Changes in v3: None Changes in v2: None drivers/media/i2c/ov7670.c | 21 - 1 file

[PATCH v4 3/3] media: ov7670: Add the s_power operation

Add the s_power operation which is responsible for manipulating the power dowm mode through the PWDN pin and the reset operation through the RESET pin. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: None Changes in v2: - Add the patch to support

[PATCH v4 0/3] media: ov7670: Add entity init and power operation

This patch set is to add the media entity pads initialization, the s_power operation and get_fmt callback support. Changes in v4: - Fix the build error when not enabling Media Controller API option. - Fix the build error when not enabling V4L2 sub-device userspace API option. Changes in v3: -

Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback

Hi Wenyou, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.14-rc1 next-20170918] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wenyou-Yang/media-ov7670-Add

Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation

Hi Wenyou, Thanks for the update. The driver exposes controls that are accessible through the sub-device node even if the device hasn't been powered on. Many ISP and bridge drivers will also power the sensor down once the last user of the user space device nodes disappears. You could keep the

[PATCH v2 0/5] media: atmel-isc: Rework the format list and the clock

To improve the readability of code, rework the format list table, split the format array into two. Meanwhile, fix the clock operation issue. Changes in v2: - Add the new patch to remove the unnecessary member from isc_subdev_entity struct. - Rebase on the patch set, [PATCH 0/6]

[PATCH v2 1/5] media: atmel_isc: Add spin lock for clock enable ops

Add the spin lock for the clock enable and disable operations. Signed-off-by: Wenyou Yang --- Changes in v2: None drivers/media/platform/atmel/atmel-isc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH v2 3/5] media: atmel-isc: Enable the clocks during probe

To meet the relationship, enable the HCLOCK and ispck during the device probe, "isc_pck frequency is less than or equal to isc_ispck, and isc_ispck is greater than or equal to HCLOCK." Meanwhile, call the pm_runtime_enable() in the right place. Signed-off-by: Wenyou Yang

[PATCH v2 2/5] media: atmel-isc: Add prepare and unprepare ops

A software write operation to the ISC_CLKEN or ISC_CLKDIS register requires double clock domain synchronization and is not permitted when the ISC_SR.SIP is asserted. So add the .prepare and .unprepare ops to make sure the ISC_CLKSR.SIP is unasserted before the write operation to the ISC_CLKEN or

Re: [PATCH] staging: atomisp: add a driver for ov5648 camera sensor

On Mon, 2017-09-11 at 20:03 +0200, Devid Antonio Filoni wrote: > On Mon, Sep 11, 2017 at 05:55:29PM +0300, Sakari Ailus wrote: > > Hi Devid, > > > > Please see my comments below. > > > > Andy: please look for "INT5648". > > Hi Sakari, > I'm replying below to your comments. I'll work on a v2

Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback

Hi Wenyou, On Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote: > @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd, > ret = ov7670_try_fmt_internal(sd, >format, NULL, NULL); > if (ret) > return ret; > -

[PATCH 0/2] [media] dvb_usb_core: Adjustments for two function implementations

From: Markus Elfring Date: Mon, 18 Sep 2017 09:51:23 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation in dvb_usbv2_probe() Improve a size

[PATCH 1/2] [media] dvb_usb_core: Delete two error messages for a failed memory allocation in dvb_usbv2_probe()

From: Markus Elfring Date: Mon, 18 Sep 2017 09:25:19 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 2/2] [media] dvb_usb_core: Improve a size determination in two functions

From: Markus Elfring Date: Mon, 18 Sep 2017 09:36:33 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH v3] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

Hello Mr Chehab, Thanks for the review. I have modified the code and documentation as per your comments. Please let me know if this patch is ready for merging. Signed-off-by: Satendra Singh Thakur --- Documentation/media/uapi/dvb/fe-get-property.rst | 24 ++-

[PATCH 2/2] dt: bindings: media: Document data lane numbering without lane reordering

Most devices do not support lane reordering and in many cases the documentation of the data-lanes property is incomplete for such devices. Document that in case the lane reordering isn't supported, monotonically incremented values from 0 or 1 shall be used. Signed-off-by: Sakari Ailus

[PATCH 1/2] dt: bindings: media: Document port and endpoint numbering

A lot of devices do not need and do not document port or endpoint numbering at all, e.g. in case where there's just a single port and a single endpoint. Whereas this is just common sense, document it to make it explicit. Signed-off-by: Sakari Ailus ---

[PATCH 0/2] Improve generic DT binding documentation for media devices

Hi folks, This set improves the DT binding documentation for media devices where device specific documentation is lacking: - Port and endpoint numbering - lane numbering for the data-lanes property Sakari Ailus (2): dt: bindings: media: Document port and endpoint numbering dt: bindings:

[PATCH v3] media: ov13858: Calculate pixel-rate at runtime, use mode

Calculate pixel-rate at run time instead of compile time. Instead of using hardcoded pixels-per-line, extract it from current sensor mode. Signed-off-by: Chiranjeevi Rapolu --- Changes in v3: - Use LINK_FREQ_TO_PIXEL_RATE macro. - Fix incorrect

[PATCH] media: imx: Fix VDIC CSI1 selection

When using VDIC with CSI1, make sure to select the correct CSI in IPU_CONF. Fixes: f0d9c8924e2c3376 ("[media] media: imx: Add IC subdev drivers") Suggested-by: Marek Vasut Signed-off-by: Tim Harvey --- drivers/staging/media/imx/imx-ic-prp.c | 5 +++-- 1

Re: [PATCH] media: imx: Fix VDIC CSI1 selection

Thanks Tim for catching this error. Acked-by: Steve Longerbeam On 09/18/2017 04:08 PM, Tim Harvey wrote: When using VDIC with CSI1, make sure to select the correct CSI in IPU_CONF. Fixes: f0d9c8924e2c3376 ("[media] media: imx: Add IC subdev drivers")

[PATCH v5 1/3] media: ov7670: Add entity pads initialization

Add the media entity pads initialization. Signed-off-by: Wenyou Yang --- Changes in v5: None Changes in v4: - Fix the build error when not enabling Media Controller API option. Changes in v3: None Changes in v2: None drivers/media/i2c/ov7670.c | 21

[PATCH v5 0/3] media: ov7670: Add entity init and power operation

This patch set is to add the media entity pads initialization, the s_power operation and get_fmt callback support. Changes in v5: - Fix the build warning on the declaration *mbus_fmt(ISO C90 forbids mixed). Changes in v4: - Fix the build error when not enabling Media Controller API option. -

[PATCH v5 2/3] media: ov7670: Add the get_fmt callback

Add the get_fmt callback, also enable V4L2_SUBDEV_FL_HAS_DEVNODE flag to make this subdev has device node. Signed-off-by: Wenyou Yang --- Changes in v5: - Fix the build warning on the declaration *mbus_fmt(ISO C90 forbids mixed). Changes in v4: - Fix the build

[PATCH v5 3/3] media: ov7670: Add the s_power operation

Add the s_power operation which is responsible for manipulating the power dowm mode through the PWDN pin and the reset operation through the RESET pin. Signed-off-by: Wenyou Yang --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Add the