[PATCH v14 14/28] v4l: async: Prepare for async sub-device notifiers

Refactor the V4L2 async framework a little in preparation for async sub-device notifiers. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-async.c | 66 +--- 1 file changed, 47 insertions(+), 19 deletions(-) diff --git

[PATCH v14 09/28] omap3isp: Print the name of the entity where no source pads could be found

If no source pads are found in an entity, print the name of the entity. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/platform/omap3isp/isp.c | 4 ++-- 1 file changed, 2

[PATCH v14 18/28] dt: bindings: Add lens-focus binding for image sensors

The lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Reviewed-by: Sebastian Reichel

[PATCH v14 16/28] v4l: async: Ensure only unique fwnodes are registered to notifiers

While registering a notifier, check that each newly added fwnode is unique, and return an error if it is not. Also check that a newly added notifier does not have the same fwnodes twice. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-async.c | 88

[PATCH v14 03/28] v4l: async: Use more intuitive names for internal functions

Rename internal functions to make the names of the functions better describe what they do. Old nameNew name v4l2_async_test_notify v4l2_async_match_notify v4l2_async_belongs v4l2_async_find_match Signed-off-by: Sakari Ailus

Re: [PATCH] v4l: vsp1: Start and stop DRM pipeline independently of planes

Hi Kieran, On Monday, 25 September 2017 20:25:14 EEST Kieran Bingham wrote: > On 15/08/17 23:57, Laurent Pinchart wrote: > > The KMS API supports enabling a CRTC without any plane. To enable that > > use case, we need to start the pipeline when configuring the LIF, > > instead of when enabling

fs/sysfs/group.c:237 device_del+0x54/0x260 and fs/sysfs/group.c:237 sysfs_remove_groups+0x29/0x40

Hi, I've been notified of this error shortly after unplugging my webcam, so I'm reporting it to you. Regards, Alexandre-Xavier === [ 4675.198429] usb 1-2: new high-speed USB device number 3 using xhci_hcd [ 4675.359123] usb 1-2: New USB

Re: [PATCH v4 8/9] netlink: fix nla_put_{u8,u16,u32} for KASAN

From: Arnd Bergmann Date: Fri, 22 Sep 2017 23:29:19 +0200 > When CONFIG_KASAN is enabled, the "--param asan-stack=1" causes rather large > stack frames in some functions. This goes unnoticed normally because > CONFIG_FRAME_WARN is disabled with CONFIG_KASAN by default as of commit

Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN

From: Arnd Bergmann Date: Fri, 22 Sep 2017 23:29:18 +0200 > Inlining these functions creates lots of stack variables that each take > 64 bytes when KASAN is enabled, leading to this warning about potential > stack overflow: > > drivers/net/ethernet/rocker/rocker_ofdpa.c: In

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 26 05:00:18 CEST 2017 media-tree git hash:d5426f4c2ebac8cf05de43988c3fccddbee13d28 media_build

Re: f26: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

On 25/09/17 23:24, Vincent McIntyre wrote: On Mon, Sep 25, 2017 at 10:16:23AM +1000, Eyal Lebedinsky wrote: Turn on debug printing for the modules of interest # echo 'module rtl2832 +p' > /sys/kernel/debug/dynamic_debug/control # echo 'module dvb_usb_rtl28xxu +p' >

Re: [PATCH v2 5/5] media: atmel-isc: Rework the format list

Hi Wenyou, On 18/09/17 08:39, Wenyou Yang wrote: > To improve the readability of code, split the format array into two, > one for the format description, other for the register configuration. > Meanwhile, add the flag member to indicate the format can be achieved > from the sensor or be produced

Re: f26: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

Thanks Vincent, On 25/09/17 23:24, Vincent McIntyre wrote: On Mon, Sep 25, 2017 at 10:16:23AM +1000, Eyal Lebedinsky wrote: Turn on debug printing for the modules of interest # echo 'module rtl2832 +p' > /sys/kernel/debug/dynamic_debug/control # echo 'module dvb_usb_rtl28xxu +p' >

Re: [PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

On 25/09/2017 16:08, Måns Rullgård wrote: > Marc Gonzalez writes: > > Why did you put this way early now? Registering the device should be > the last thing you do (LIKE I DID IT, DAMMIT). Otherwise something might > try to use it before it is fully configured. > >> +err =

Re: f26: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

On Mon, Sep 25, 2017 at 10:16:23AM +1000, Eyal Lebedinsky wrote: > >Turn on debug printing for the modules of interest > ># echo 'module rtl2832 +p' > /sys/kernel/debug/dynamic_debug/control > ># echo 'module dvb_usb_rtl28xxu +p' > /sys/kernel/debug/dynamic_debug/control > > Have done this.

Re: usb/media/lmedm04: GPF in lme2510_int_read/usb_pipe_endpoint

On 25/09/17 13:39, Andrey Konovalov wrote: Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2). usb 1-1: new full-speed USB device number 2 using dummy_hcd gadgetfs: connected gadgetfs: disconnected

Re: [PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

Marc Gonzalez writes: > From: Mans Rullgard > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez > --- > Changes between v3 and v4 > * Add one line to Kconfig help

RE: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

From: Arnd Bergmann > Sent: 22 September 2017 22:29 ... > It seems that this is triggered in part by using strlcpy(), which the > compiler doesn't recognize as copying at most 'len' bytes, since strlcpy > is not part of the C standard. Neither is strncpy(). It'll almost certainly be a marker in

[PATCH] cec-gpio: don't generate spurious HPD events

Only send HPD_LOW/HIGH event if the gpio actually changed value. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/cec-gpio/cec-gpio.c b/drivers/media/platform/cec-gpio/cec-gpio.c index 548c9dffec73..4a96856f8b36 100644 ---

Re: [PATCH v6 19/25] rcar-vin: add group allocator functions

On 23/08/17 01:26, Niklas Söderlund wrote: > In media controller mode all VIN instances needs to be part of the same > media graph. There is also a need to each VIN instance to know and in > some cases be able to communicate with other VIN instances. > > Add a allocator framework where the first

Re: [PATCH v6 20/25] rcar-vin: add chsel information to rvin_info

On 23/08/17 01:26, Niklas Söderlund wrote: > Each Gen3 SoC has a limited set of predefined routing possibilities for > which CSI-2 device and virtual channel can be routed to which VIN > instance. Prepare to store this information in the struct rvin_info. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v6 21/25] rcar-vin: parse Gen3 OF and setup media graph

On 23/08/17 01:26, Niklas Söderlund wrote: > Parse the VIN Gen3 OF graph and register all CSI-2 devices in the VIN > group common media device. Once all CSI-2 subdevice is added to the subdevice is -> subdevices are > common media device create links between them. > > The parsing and

Re: [PATCH v6 22/25] rcar-vin: add link notify for Gen3

On 23/08/17 01:26, Niklas Söderlund wrote: > Add the ability to process media device link change request. Link > enablement are a bit complicated on Gen3, if it's possible to enable a enablement are -> enabling is if -> whether or not > link depends on what other links already are enabled. On

Re: [PATCH v6 24/25] rcar-vin: enable support for r8a7795

On 23/08/17 01:26, Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7795. > > Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil Regards, Hans > --- >

Re: [PATCH v6 23/25] rcar-vin: extend {start,stop}_streaming to work with media controller

On 23/08/17 01:26, Niklas Söderlund wrote: > The procedure to start or stop streaming using the none MC single none MC -> non-MC > subdevice and the MC graph and multiple subdevices are quiet different. quiet -> quite > Create a new function to abstract which method is used based on which >

Re: [PATCH v6 25/25] rcar-vin: enable support for r8a7796

On 23/08/17 01:26, Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7796. > > Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil Regards, Hans > --- >

Re: [PATCH v5 2/2] media: rc: Add driver for tango HW IR decoder

Marc Gonzalez writes: > * Delete two writes clearing interrupts in probe (cleared is reset value) Noo. You can't know what state the hardware is in when this code runs. Drivers should *always* fully initialise the hardware to a known state. It is

Re: f26: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

On 25/09/17 23:24, Vincent McIntyre wrote: On Mon, Sep 25, 2017 at 10:16:23AM +1000, Eyal Lebedinsky wrote: Turn on debug printing for the modules of interest # echo 'module rtl2832 +p' > /sys/kernel/debug/dynamic_debug/control # echo 'module dvb_usb_rtl28xxu +p' >

[GIT PULL FOR v4.15] Fixes, cleanups

The following changes since commit d5426f4c2ebac8cf05de43988c3fccddbee13d28: media: staging: atomisp: use clock framework for camera clocks (2017-09-23 15:09:37 -0400) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.15c for you to fetch changes up

Re: [PATCH v2 1/2] [media] tc358743: fix connected/active CSI-2 lane reporting

On 21 September 2017 at 16:30, Philipp Zabel wrote: > g_mbus_config was supposed to indicate all supported lane numbers, not > only the number of those currently in active use. Since the TC358743 > can dynamically reduce the number of active lanes if the required >

[PATCH v5 2/2] media: rc: Add driver for tango HW IR decoder

From: Mans Rullgard The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez --- Changes between v4 and v5 * Restore inits in same order as original driver (except for devm_rc_allocate_device before

Re: [PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

Marc Gonzalez writes: > On 25/09/2017 16:08, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >> Why did you put this way early now? Registering the device should be >> the last thing you do (LIKE I DID IT, DAMMIT). Otherwise something might >> try to use it

Re: [PATCH v2] scripts: kernel-doc: fix nexted handling

> Am 24.09.2017 um 19:38 schrieb Mauro Carvalho Chehab > : > > Em Sun, 24 Sep 2017 17:13:13 +0200 > Markus Heiser escreveu: > >>> Am 24.09.2017 um 12:23 schrieb Mauro Carvalho Che >>> >>> v2: handle embedded structs/unions from inner to

Re: [PATCH] v4l: vsp1: Start and stop DRM pipeline independently of planes

Hi Laurent, Thankyou for the patch. On 15/08/17 23:57, Laurent Pinchart wrote: > The KMS API supports enabling a CRTC without any plane. To enable that > use case, we need to start the pipeline when configuring the LIF, > instead of when enabling the first plane. Tested and verified on

[PATCH] scripts: kernel-doc: parse next structs/unions

There are several places within the Kernel tree with nested structs/unions, like this one: struct ingenic_cgu_clk_info { const char *name; enum { CGU_CLK_NONE = 0, CGU_CLK_EXT = BIT(0), CGU_CLK_PLL = BIT(1), CGU_CLK_GATE = BIT(2), CGU_CLK_MUX = BIT(3),

Re: [PATCH v2] scripts: kernel-doc: fix nexted handling

Em Mon, 25 Sep 2017 18:58:14 +0200 Markus Heiser escreveu: > > As reference, I'm testing it with: > > > > $ scripts/kernel-doc -rst ./drivers/clk/ingenic/cgu.h > > > > PS.: I'm pretty sure it can be improved. Also, only the ReST output > > is working properly on

[PATCH] [media] cx88: Use common error handling code in get_key_pvr2000()

From: Markus Elfring Date: Mon, 25 Sep 2017 21:03:57 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [progress]: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

On 18/09/17 14:26, Eyal Lebedinsky wrote: I have just upgraded to f24. I am now using the standard dvb_usb_rtl28xxu fe which logs messages suggesting all is well (I get the /dev/dvb/adapter? etc.) but I get no channels tuned when I run mythfrontend or scandvb. Is anyone using this combination?

[PATCH] [media] bt8xx: Use common error handling code in two functions

From: Markus Elfring Date: Mon, 25 Sep 2017 22:10:17 +0200 Adjust jump targets so that a bit of exception handling can be better reused at the end of these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [PATCH 3/4] media: i2c: Add TDA1997x HDMI receiver driver

On Sat, Sep 23, 2017 at 12:30 AM, Hans Verkuil wrote: > Hi Tim, > > On 23/09/17 00:24, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. > Hans, Thanks for the quick review! > I did a very quick high-level scan and found a few blockers: > > 1) You *must*

[PATCH v14 04/28] v4l: async: Add V4L2 async documentation to the documentation build

The V4L2 async wasn't part of the documentation build. Fix this. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart

[PATCH v14 00/28] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

Hi folks, We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority

[PATCH v14 07/28] rcar-vin: Use generic parser for parsing fwnode endpoints

Instead of using a custom driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil ---

[PATCH v14 05/28] v4l: fwnode: Support generic parsing of graph endpoints in a device

Add two functions for parsing devices graph endpoints: v4l2_async_notifier_parse_fwnode_endpoints and v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates over all endpoints whereas the latter only iterates over the endpoints in a given port. The former is mostly useful for

[PATCH v14 06/28] omap3isp: Use generic parser for parsing fwnode endpoints

Instead of using a custom driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart

[PATCH v14 13/28] v4l: async: Allow async notifier register call succeed with no subdevs

The information on how many async sub-devices would be bindable to a notifier is typically dependent on information from platform firmware and it's not driver's business to be aware of that. Many V4L2 main drivers are perfectly usable (and useful) without async sub-devices and so if there aren't

[PATCH v14 10/28] v4l: async: Move async subdev notifier operations to a separate structure

From: Laurent Pinchart The async subdev notifier .bound(), .unbind() and .complete() operations are function pointers stored directly in the v4l2_async_subdev structure. As the structure isn't immutable, this creates a potential security risk as the function

[PATCH v14 22/28] v4l: async: Add a convenience function for registering sensors

Add a convenience function for parsing firmware for information on related devices using v4l2_async_notifier_parse_fwnode_sensor_common() registering the notifier and finally the async sub-device itself. This should be useful for sensor drivers that do not have device specific requirements

[PATCH v14 20/28] v4l: fwnode: Add a helper function to obtain device / integer references

v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under the device's own fwnode, it will follow child fwnodes with the given property-value pair and return the resulting fwnode. Signed-off-by: Sakari Ailus ---

[PATCH v14 22/28] v4l: fwnode: Add a convenience function for registering sensors

Add a convenience function for parsing firmware for information on related devices using v4l2_async_notifier_parse_fwnode_sensor_common() registering the notifier and finally the async sub-device itself. This should be useful for sensor drivers that do not have device specific requirements

[PATCH v14 15/28] v4l: async: Allow binding notifiers to sub-devices

Registering a notifier has required the knowledge of struct v4l2_device for the reason that sub-devices generally are registered to the v4l2_device (as well as the media device, also available through v4l2_device). This information is not available for sub-device drivers at probe time. What this

[PATCH v14 17/28] dt: bindings: Add a binding for flash LED devices associated to a sensor

Camera flash drivers (and LEDs) are separate from the sensor devices in DT. In order to make an association between the two, provide the association information to the software. Signed-off-by: Sakari Ailus Acked-by: Rob Herring Acked-by: Hans

[PATCH v14 12/28] v4l: async: Register sub-devices before calling bound callback

Register the sub-device before calling the notifier's bound callback. Doing this the other way around is problematic as the struct v4l2_device has not assigned for the sub-device yet and may be required by the bound callback. Signed-off-by: Sakari Ailus Acked-by:

[PATCH v14 21/28] v4l: fwnode: Add convenience function for parsing common external refs

Add v4l2_fwnode_parse_reference_sensor_common for parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips. As this is an association only, there's little a regular driver needs to know about these devices as such. Signed-off-by: Sakari Ailus

[PATCH v14 11/28] v4l: async: Introduce helpers for calling async ops callbacks

Add three helper functions to call async operations callbacks. Besides simplifying callbacks, this allows async notifiers to have no ops set, i.e. it can be left NULL. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek

[PATCH v14 19/28] v4l: fwnode: Add a helper function for parsing generic references

Add function v4l2_fwnode_reference_parse() for parsing them as async sub-devices. This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[PATCH v14 01/28] v4l: fwnode: Move KernelDoc documentation to the header

In V4L2 the practice is to have the KernelDoc documentation in the header and not in .c source code files. This consequently makes the V4L2 fwnode function documentation part of the Media documentation build. Also correct the link related function and argument naming in documentation.

[PATCH v14 02/28] v4l: async: Remove re-probing support

Remove V4L2 async re-probing support. The re-probing support has been there to support cases where the sub-devices require resources provided by the main driver's hardware to function, such as clocks. Reprobing has allowed unbinding and again binding the main driver without explicilty unbinding

[PATCH v14 08/28] omap3isp: Fix check for our own sub-devices

We only want to link sub-devices that were bound to the async notifier the isp driver registered but there may be other sub-devices in the v4l2_device as well. Check for the correct async notifier. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[PATCH v14 27/28] ov13858: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov13858.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov13858.c

[PATCH v14 25/28] et8ek8: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v14 28/28] arm: dts: omap3: N9/N950: Add flash references to the camera

Add flash and indicator LED phandles to the sensor node. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++--

[PATCH v14 23/28] dt: bindings: smiapp: Document lens-focus and flash-leds properties

Document optional lens-focus and flash-leds properties for the smiapp driver. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1

[PATCH v14 26/28] ov5670: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov5670.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5670.c

[PATCH v14 24/28] smiapp: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module ---

[PATCH] v4l2-ctrls.c: allow empty control handlers

If you have a control handler that does not contain any controls, then currently calling VIDIOC_G/S/TRY_EXT_CTRLS with count == 0 will return -EINVAL in the class_check() function. This is not correct, there is no reason why this should return an error. The purpose of setting count to 0 is to

Re: [PATCH v6 03/25] rcar-vin: move chip information to own struct

On 23/08/17 01:26, Niklas Söderlund wrote: > When Gen3 support is added to the driver more then chip id will be then -> than > different for the different Soc. To avoid a lot of if statements in the > code create a struct chip_info to contain this information. > > Signed-off-by: Niklas

Re: [PATCH v6 04/25] rcar-vin: move max width and height information to chip information

On 23/08/17 01:26, Niklas Söderlund wrote: > On Gen3 the max supported width and height will be different from Gen2. > Move the limits to the struct rvin_info to prepare for Gen3 support. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Kieran Bingham

Re: [PATCH v6 06/25] rcar-vin: move functions regarding scaling

On 23/08/17 01:26, Niklas Söderlund wrote: > In preparation of refactoring the scaling code move the code regarding > scaling to to the top of the file to avoid the need to add forward > declarations. No code is changed in this commit only whole functions > moved inside the same file. > >

Re: [PATCH v6 07/25] rcar-vin: all Gen2 boards can scale simplify logic

On 23/08/17 01:26, Niklas Söderlund wrote: > The logic to preserve the requested format width and height are too > complex and come from a premature optimization for Gen3. All Gen2 SoC > can scale and the Gen3 implementation will not use these functions at > all so simply preserve the width and

Re: [PATCH v6 05/25] rcar-vin: change name of video device

On 23/08/17 01:26, Niklas Söderlund wrote: > The rcar-vin driver needs to be part of a media controller to support > Gen3. Give each VIN instance a unique name so it can be referenced from > userspace. > > Signed-off-by: Niklas Söderlund > Reviewed-by:

Re: [PATCH v6 09/25] rcar-vin: do not allow changing scaling and composing while streaming

On 23/08/17 01:26, Niklas Söderlund wrote: > It is possible on Gen2 to change the registers controlling composing and > scaling while the stream is running. Is however not a good idea to do so Is -> It > and could result in trouble. There are also no good reason to allow reason -> reasons >

Re: [PATCH v6 08/25] rcar-vin: do not reset crop and compose when setting format

On 23/08/17 01:26, Niklas Söderlund wrote: > It was a bad idea to reset the crop and compose settings when a new > format is set. This would overwrite any crop/compose set by s_select and > cause unexpected behaviors, remove it. Also fold the reset helper in to > the only remaining caller. > >

Re: [PATCH v6 10/25] rcar-vin: read subdevice format for crop only when needed

On 23/08/17 01:26, Niklas Söderlund wrote: > Instead of caching the subdevice format each time the video device > format is set read it directly when its needed. As it turns out the its -> it's > format is only needed when figuring out the max rectangle for cropping. > > This simplify the code

Re: [PATCH v6 11/25] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

On 23/08/17 01:26, Niklas Söderlund wrote: > It was never proper support in the VIN driver to deliver ALTERNATING It -> There > field format to user-space, remove this field option. For sources using > this field format instead use the VIN hardware feature of combining the > fields to an

Re: [PATCH] v4l2-ctrls.c: allow empty control handlers

On Mon, Sep 25, 2017 at 11:41:02AM +0200, Hans Verkuil wrote: > If you have a control handler that does not contain any controls, then > currently calling VIDIOC_G/S/TRY_EXT_CTRLS with count == 0 will return > -EINVAL in the class_check() function. > > This is not correct, there is no reason why

Re: [PATCH v6 12/25] rcar-vin: move media bus configuration to struct rvin_info

On 23/08/17 01:26, Niklas Söderlund wrote: > Bus configuration will once the driver is extended to to support Gen3 to to -> to > contain information not specific to only the directly connected parallel > subdevice. Move it to struct rvin_info to show it's not always coupled > to the parallel

Re: [PATCH v6 13/25] rcar-vin: enable Gen3 hardware configuration

On 23/08/17 01:26, Niklas Söderlund wrote: > Add the register needed to work with Gen3 hardware. This patch adds > the logic for how to work with the Gen3 hardware. More work is required > to enable the subdevice structure needed to configure capturing. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v6 15/25] rcar-vin: add flag to switch to media controller mode

On 23/08/17 01:26, Niklas Söderlund wrote: > On Gen3 a media controller API needs to be used to allow userspace to > configure the subdevices in the pipeline instead of directly controlling > a single source subdevice, which is and will continue to be the mode of > operation on Gen2. > > Prepare

Re: [PATCH v6 14/25] rcar-vin: add functions to manipulate Gen3 CHSEL value

On 23/08/17 01:26, Niklas Söderlund wrote: > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > feature of this register is that it's only present in the VIN0 and VIN4 > instances. The register in VIN0 controls the routing for VIN0-3 and the > register in VIN4 controls

Re: [PATCH v6 16/25] rcar-vin: break out format alignment and checking

On 23/08/17 01:26, Niklas Söderlund wrote: > Part of the format aliment and checking can be shared with the Gen3 aliment -> alignment > format handling. Break that part out to it's own function. While doing it's -> its > this clean up the checking and add more checks. > > Signed-off-by:

Re: [PATCH v6 17/25] rcar-vin: use different v4l2 operations in media controller mode

On 23/08/17 01:26, Niklas Söderlund wrote: > When the driver runs in media controller mode it should not directly > control the subdevice instead userspace will be responsible for > configuring the pipeline. To be able to run in this mode a different set > of v4l2 operations needs to be used. > >

Re: [PATCH v6 18/25] rcar-vin: prepare for media controller mode initialization

On 23/08/17 01:26, Niklas Söderlund wrote: > When running in media controller mode a media pad is needed, register > one. Also set the media bus format to CSI-2. > > Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil

Re: [PATCH v2 0/4] BCM283x Camera Receiver driver

On 22 September 2017 at 18:17, Hans Verkuil wrote: > On 22/09/17 18:31, Dave Stevenson wrote: >> On 22 September 2017 at 12:00, Hans Verkuil wrote: >>> On 13/09/17 17:49, Dave Stevenson wrote: OV5647 v4l2-compliance SHA :

Re: [PATCH v2] staging: atomisp: add a driver for ov5648 camera sensor

On Sun, 2017-09-24 at 16:59 +0200, Devid Antonio Floni wrote: > The ov5648 5-megapixel camera sensor from OmniVision supports up to > 2592x1944 > resolution and MIPI CSI-2 interface. Output format is raw sRGB/Bayer > with > 10 bits per colour (SGRBG10_1X10). > > This patch is a port of ov5648

[PATCH 1/1] staging: atomisp: Update TODO regarding sensors

There was no specific item regarding what should be done to sensor, lens and flash drivers. Add one, to replace the vague item denoting support only to particular sensor, lens and flash devices. Signed-off-by: Sakari Ailus --- drivers/staging/media/atomisp/TODO |

Re: [PATCHv4 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

Hi Ville, On 18/09/17 17:49, Ville Syrjälä wrote: > On Mon, Sep 18, 2017 at 05:26:43PM +0200, Hans Verkuil wrote: >> On 09/18/2017 04:36 PM, Ville Syrjälä wrote: >>> On Mon, Sep 18, 2017 at 04:07:41PM +0200, Hans Verkuil wrote: Hi Ville, On 09/18/2017 03:05 PM, Ville Syrjälä wrote:

[PATCH v4 1/2] media: dt: bindings: Add binding for tango HW IR decoder

Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. Signed-off-by: Marc Gonzalez --- .../devicetree/bindings/media/tango-ir.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644

[PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

From: Mans Rullgard The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez --- Changes between v3 and v4 * Add one line to Kconfig help message * Add DRIVER_NAME macro * Move devm_request_irq() call to the end of

usb/media/lmedm04: GPF in lme2510_int_read/usb_pipe_endpoint

Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2). usb 1-1: new full-speed USB device number 2 using dummy_hcd gadgetfs: connected gadgetfs: disconnected gadgetfs: connected usb 1-1: config 63 interface 0

usb/media/uvc: warning in uvc_scan_chain_forward/__list_add

Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2). list_add double add: new=880069084010, prev=880069084010, next=880067d22298. [ cut here ] WARNING: CPU: 1 PID: 1846 at