[PATCH] staging/media/davinci_vpfe: Use common error handling code in vpfe_attach_irq()

2017-11-03 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 3 Nov 2017 10:45:31 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: 32bit userland cannot work with DVB drivers in 64bit kernel, design issue

2017-11-03 Thread Menion
For the moment, I am focusing on the frontend ioctl problem According to the fops: static const struct file_operations dvb_frontend_fops = { .owner = THIS_MODULE, .unlocked_ioctl = dvb_generic_ioctl, .poll = dvb_frontend_poll, .open = dvb_frontend_open, .release = dvb_frontend_release, .llseek =

Re: [PATCH v4 2/3] media: ov7740: Document device tree bindings

2017-11-03 Thread Sakari Ailus
Hi Rob, On Wed, Nov 01, 2017 at 04:51:57PM -0500, Rob Herring wrote: > On Tue, Oct 31, 2017 at 09:11:44AM +0800, Wenyou Yang wrote: > > Add the device tree binding documentation for the ov7740 sensor driver. > > > > Signed-off-by: Wenyou Yang > > --- > > > > Changes

Re: [PATCH 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

2017-11-03 Thread Shuah Khan
On 11/02/2017 06:43 PM, Marian Mihailescu wrote: > I can confirm, with this patch, there is always error loading MFC in > boot log, since FS is not mounted. > > -Marian > Please refrain from top posting to a kernel email threads. It is very difficult to follow. Bottom post is the norm. thanks,

[PATCH v1] [media] v4l2-ctrls: Don't validate BITMASK twice

2017-11-03 Thread Andy Shevchenko
There is no need to repeat what check_range() does for us, i.e. BITMASK validation in v4l2_ctrl_new(). Signed-off-by: Andy Shevchenko --- drivers/media/v4l2-core/v4l2-ctrls.c | 4 1 file changed, 4 deletions(-) diff --git

usb/media/em28xx: use-after-free in em28xx_dvb_fini

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). em28xx 1-1:2.0: New device a @ 480 Mbps (eb1a:2801, interface 0, class 0) em28xx 1-1:2.0: Audio interface 0 found (Vendor Class) em28xx 1-1:2.0: chip ID is

usb/media/pvrusb2: WARNING in pvr2_i2c_core_done/sysfs_remove_group

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). pvrusb2: Hardware description: OnAir Creator Hybrid USB tuner pvrusb2: Invalid write control endpoint ... pvrusb2: Invalid write control endpoint pvrusb2:

Re: [RFC v4 17/17] [media] v4l: Document explicit synchronization behaviour

2017-11-03 Thread Gustavo Padovan
Hi Hans, 2017-11-03 Hans Verkuil : > On 10/20/2017 11:50 PM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Add section to VIDIOC_QBUF about it > > > > v3: > > - make the out_fence refer to the current buffer (Hans) > > -

net/media/em28xx: use-after-free in v4l2_fh_init

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). em28xx 1-1:0.0: analog set to bulk mode. em28xx 1-1:0.0: Registering V4L2 extension usb 1-1: USB disconnect, device number 39 em28xx 1-1:0.0: Disconnecting

Re: usb/media/em28xx: use-after-free in em28xx_dvb_fini

2017-11-03 Thread Andrey Konovalov
On Fri, Nov 3, 2017 at 3:44 PM, Andrey Konovalov wrote: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). > > em28xx 1-1:2.0: New device a @ 480 Mbps (eb1a:2801, interface 0,

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-03 Thread Nicolas Dufresne
Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit : > MFC driver supports only MMAP operation mode mainly due to the hardware > restrictions of the addresses of the DMA buffers (MFC v5 hardware can > access buffers only in 128MiB memory region starting from the base address > of

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-03 Thread Tobias Jakobi
Tobias Jakobi wrote: > Nicolas Dufresne wrote: >> Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit : >>> MFC driver supports only MMAP operation mode mainly due to the hardware >>> restrictions of the addresses of the DMA buffers (MFC v5 hardware can >>> access buffers only in

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-03 Thread Tobias Jakobi
Nicolas Dufresne wrote: > Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit : >> MFC driver supports only MMAP operation mode mainly due to the hardware >> restrictions of the addresses of the DMA buffers (MFC v5 hardware can >> access buffers only in 128MiB memory region

[PATCH] uvc: Add D3DFMT_L8 support

2017-11-03 Thread Nicolas Dufresne
Microsoft HoloLense UVC sensor uses D3DFMT instead of FOURCC when exposing formats. This add support for D3DFMT_L8 as exposed from the Acer Windows Mixed Reality Headset. Signed-off-by: Nicolas Dufresne --- drivers/media/usb/uvc/uvc_driver.c | 5 +

[GIT PULL for 4.15] V4L2 async and imx274 fixes

2017-11-03 Thread Sakari Ailus
Hi Mauro, Here are two bugfixes for V4L2 async and imx274. Please pull. The following changes since commit 9917fbcfa20ab987d6381fd0365665e5c1402d75: media: camss-vfe: always initialize reg at vfe_set_xbar_cfg() (2017-11-01 12:25:59 -0400) are available in the git repository at:

usb/media/dw2102: null-ptr-deref in dvb_usb_adapter_frontend_init/tt_s2_4600_frontend_attach

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). The report is a little confusing, as the top stack frame is not actually present. As far as my debugging showed, the NULL pointer that's being executed

Re: [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check

2017-11-03 Thread Kieran Bingham
Hi Andy, Thankyou for the patch. On 31/10/17 14:21, Andy Shevchenko wrote: > Since i2c_unregister_device() became NULL-aware we may remove duplicate > NULL check. > > Cc: Kieran Bingham > Cc: Mauro Carvalho Chehab > Cc:

[PATCH] media: imx274: fix missing return assignment from call to imx274_mode_regs

2017-11-03 Thread Colin King
From: Colin Ian King The variable ret is being checked for failure however it is not being set from the return status from the call to imx274_mode_regs. Currently ret is alwayus zero and the check is redundant. Fix this by assigning it. Detected by CoverityScan,

Re: [PATCH v9 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-11-03 Thread Leon Luo
Hi Vishal, In probe(), it calls imx274_load_default(imx274), which has I2C register read/write to the IMX274. If it fails, it will exit probe(). So it works as a sensor detection function as you suggested. Regards, Leon Luo 1130 Cadillac CT Milpitas, CA 95035 Phone: (510)371-1169 Fax: (408)

[PATCH] media: v4l: async: fix unregister for implicitly registered sub-device notifiers

2017-11-03 Thread Niklas Söderlund
The commit aef69d54755d45ed ("media: v4l: fwnode: Add a convenience function for registering sensors") adds the function v4l2_async_notifier_parse_fwnode_sensor_common() to parse and register a subdevice and a subdev-notifier by parsing firmware information. This new subdev-notifier is stored in

Re: [PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

2017-11-03 Thread Kees Cook
On Fri, Nov 3, 2017 at 3:17 PM, Dmitry Torokhov wrote: > On Thu, Nov 02, 2017 at 10:16:58PM -0200, Mauro Carvalho Chehab wrote: >> Em Thu, 2 Nov 2017 16:50:37 -0700 >> Dmitry Torokhov escreveu: >> >> > On Thu, Nov 02, 2017 at 04:24:27PM

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-03 Thread Tim Harvey
On Mon, Oct 23, 2017 at 10:05 AM, Tim Harvey wrote: > > On Fri, Oct 20, 2017 at 9:23 AM, Hans Verkuil wrote: > > >> > >> I see the AVI infoframe has hdmi_quantization_range and > >> hdmi_ycc_quantization_range along with vid_code. > >> > >> I'm not at

[PATCH v2 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

2017-11-03 Thread Shuah Khan
Driver calls request_firmware() whenever the device is opened for the first time. As the device gets opened and closed, dev->num_inst == 1 is true several times. This is not necessary since the firmware is saved in the fw_buf. s5p_mfc_load_firmware() copies the buffer returned by the

[PATCH v2 1/2] media: s5p-mfc: remove firmware buf null check in s5p_mfc_load_firmware()

2017-11-03 Thread Shuah Khan
s5p_mfc_load_firmware() will not get called if fw_buf.virt allocation fails. The allocation happens very early on in the probe routine and probe fails if allocation fails. There is no need to check if it is null in s5p_mfc_load_firmware(). Remove the check. Signed-off-by: Shuah Khan

[PATCH v2 0/2] Fix s5p-mfc lock contention in request firmware paths

2017-11-03 Thread Shuah Khan
This patch series fixes inefficiencies and lock contention in the request firmware paths. Changes since v2: - Addressed Andre's review comments. Removed fw_buf->virt null check as it is not needed. Removed handling s5p_mfc_load_firmware() from probe routine. Simply try loading in case it

Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP Konditionen an

2017-11-03 Thread Martin Kelly
Sehr geehrte Damen und Herren, Sie brauchen Geld? Sie sind auf der suche nach einem Darlehnen? Seriös und unkompliziert? Dann sind Sie hier bei uns genau richtig. Durch unsere jahrelange Erfahrung und kompetente Beratung sind wir Europaweit tätig. Wir bieten jedem ein GÜNSTIGES Darlehnen zu

Re: [PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

2017-11-03 Thread Dmitry Torokhov
On Thu, Nov 02, 2017 at 10:16:58PM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 2 Nov 2017 16:50:37 -0700 > Dmitry Torokhov escreveu: > > > On Thu, Nov 02, 2017 at 04:24:27PM -0700, Kees Cook wrote: > > > On Tue, Oct 31, 2017 at 1:11 PM, Sean Young

[PATCH 1/1] s2255drv: update firmware load.

2017-11-03 Thread Dean Anderson
fixes intermittent soft reboot issue with firmware load increases wait time of reset, as required by HW Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

cron job: media_tree daily build: ERRORS

2017-11-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Nov 4 05:00:27 CET 2017 media-tree git hash:9917fbcfa20ab987d6381fd0365665e5c1402d75 media_build

Re: [RFC v4 09/17] [media] vb2: add 'ordered_in_vb2' property to queues

2017-11-03 Thread Hans Verkuil
On 10/20/2017 11:50 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > By setting this member on vb2_queue the driver tell vb2 core that > it requires the buffers queued in QBUF to be queued with same order to the > driver. As we discussed in Prague this

Re: [PATCH] media: v4l: async: fix return of unitialized variable ret

2017-11-03 Thread Niklas Söderlund
Hi Colin, Thanks for your patch. On 2017-11-03 06:58:27 +, Colin King wrote: > From: Colin Ian King > > A shadow declaration of variable ret is being assigned a return error > status and this value is being lost when the error exit goto's jump > out of the local

[PATCH] media: v4l: async: fix return of unitialized variable ret

2017-11-03 Thread Colin King
From: Colin Ian King A shadow declaration of variable ret is being assigned a return error status and this value is being lost when the error exit goto's jump out of the local scope. This leads to an uninitalized error return value in the outer scope being returned. Fix

Re: [RFC v4 04/17] WIP: [media] v4l2: add v4l2_event_queue_fh_with_cb()

2017-11-03 Thread Hans Verkuil
On 10/20/2017 11:49 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > For some type of events we may require the event user in the > kernel to run some operation when DQ_EVENT() is called. > V4L2_EVENT_OUT_FENCE is the first user of this mechanism as it needs

Re: [RFC v4 12/17] [media] vb2: add explicit fence user API

2017-11-03 Thread Hans Verkuil
On 10/20/2017 11:50 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will use to send > an in-fence to the kernel and return an out-fence from the kernel to > userspace. > > Two new flags were added,

Re: [PATCH 0/4] dma-buf: Silence dma_fence __rcu sparse warnings

2017-11-03 Thread Christian König
Patch #4 is Reviewed-by: Christian König . The rest is Acked-by: Christian König . Regards, Christian. Am 02.11.2017 um 21:03 schrieb Ville Syrjala: From: Ville Syrjälä When building drm+i915 I get around 150

Re: [RFC v4 17/17] [media] v4l: Document explicit synchronization behaviour

2017-11-03 Thread Hans Verkuil
On 10/20/2017 11:50 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add section to VIDIOC_QBUF about it > > v3: > - make the out_fence refer to the current buffer (Hans) > - Note what happens when the IN_FENCE is not set (Hans) > > v2: >

[PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-03 Thread Marek Szyprowski
MFC driver supports only MMAP operation mode mainly due to the hardware restrictions of the addresses of the DMA buffers (MFC v5 hardware can access buffers only in 128MiB memory region starting from the base address of its firmware). When IOMMU is available, this requirement is easily fulfilled