Re: [PATCH 3/3] [media] v4l2: disable filesystem-dax mapping support

2017-11-07 Thread Mauro Carvalho Chehab
Em Mon, 06 Nov 2017 16:57:28 -0800 Dan Williams escreveu: > V4L2 memory registrations are incompatible with filesystem-dax that > needs the ability to revoke dma access to a mapping at will, or > otherwise allow the kernel to wait for completion of DMA. The >

Re: [PATCH 0/4] dma-buf: Silence dma_fence __rcu sparse warnings

2017-11-07 Thread Sumit Semwal
Hi Ville, On 3 November 2017 at 13:18, Christian König wrote: > Patch #4 is Reviewed-by: Christian König . > > The rest is Acked-by: Christian König . > > Regards, > Christian. > > > Am 02.11.2017 um 21:03 schrieb

Re: [PATCH 1/7] au0828: fix spelling mistake: "synchronuously" -> "synchronously"

2017-11-07 Thread Mauro Carvalho Chehab
Em Thu, 2 Nov 2017 10:11:47 + Colin King escreveu: > From: Colin Ian King > > Trivial fix to spelling mistake in error message text > > Signed-off-by: Colin Ian King > --- >

Re: HDMI field order

2017-11-07 Thread Hans Verkuil
On 11/07/2017 11:35 PM, Carlos Rafael Giani wrote: > I was discussing this with Tim earlier, and there was a little > confusion. He meant V4L2_FIELD_SEQ_TB/BT, not V4L2_FIELD_INTERLACED. > > When I tried out 1080i50 with HDMI in and the i.MX6, I got something > that looks like

Re: [PATCH 3/3] [media] v4l2: disable filesystem-dax mapping support

2017-11-07 Thread Dan Williams
On Tue, Nov 7, 2017 at 12:39 PM, Mauro Carvalho Chehab wrote: > Em Tue, 7 Nov 2017 09:43:41 -0800 > Dan Williams escreveu: > >> On Tue, Nov 7, 2017 at 12:33 AM, Mauro Carvalho Chehab >> wrote: >> > Em Mon, 06 Nov 2017

cron job: media_tree daily build: ERRORS

2017-11-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Nov 8 05:00:16 CET 2017 media-tree git hash:eb0c19942288569e0ae492476534d5a485fb8ab4 media_build

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

2017-11-07 Thread Mauro Carvalho Chehab
Hi Sean/Laurent, Care sending me a final version of the patch? Thanks! Mauro Em Mon, 30 Oct 2017 21:59:34 +0100 Laurent Caumont escreveu: > Hi Sean, > > I found the problem. The read buffer needs to be allocated with kmalloc too. > > int dibusb_read_eeprom_byte(struct

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

2017-11-07 Thread Sean Young
Hi Laurent, Sorry about the delay, I forgot about this. :/ On Mon, Oct 30, 2017 at 09:59:34PM +0100, Laurent Caumont wrote: > Hi Sean, > > I found the problem. The read buffer needs to be allocated with kmalloc too. > > int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u8 offs, u8 *val) >

Re: usb/media/dtt200u: use-after-free in __dvb_frontend_free

2017-11-07 Thread Mauro Carvalho Chehab
Em Mon, 23 Oct 2017 20:58:09 +0200 Matthias Schwarzott escreveu: > Am 23.10.2017 um 16:41 schrieb Andrey Konovalov: > > Hi! > > > > I've got the following report while fuzzing the kernel with syzkaller. > > > > On commit 3e0cc09a3a2c40ec1ffb6b4e12da86e98feccb11 (4.14-rc5+). >

Re: [PATCH] [media] dvb-core: dvb_frontend_handle_ioctl(): init err to -EOPNOTSUPP

2017-11-07 Thread Mauro Carvalho Chehab
Em Mon, 30 Oct 2017 23:18:08 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > Fixes: d73dcf0cdb95 ("media: dvb_frontend: cleanup ioctl handling logic") > > The mentioned commit cleaned up the ioctl handling, but caused an issue > with

Re: [PATCH] [media] dvb-frontends/stv0910: prevent consecutive mutex_unlock()'s

2017-11-07 Thread Mauro Carvalho Chehab
Em Sat, 21 Oct 2017 11:57:57 +0200 Daniel Scheller escreveu: > Am Sat, 21 Oct 2017 11:28:10 +0200 > schrieb Ralph Metzler : > > > Daniel Scheller writes: > > > From: Daniel Scheller > > > > > > When calling gate_ctrl()

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-07 Thread Tim Harvey
On Mon, Nov 6, 2017 at 11:47 PM, Hans Verkuil wrote: > On 11/07/2017 07:04 AM, Tim Harvey wrote: >> On Fri, Oct 20, 2017 at 7:00 AM, Tim Harvey wrote: >>> On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: >>> > >

Re: HDMI field order

2017-11-07 Thread Carlos Rafael Giani
I was discussing this with Tim earlier, and there was a little confusion. He meant V4L2_FIELD_SEQ_TB/BT, not V4L2_FIELD_INTERLACED. When I tried out 1080i50 with HDMI in and the i.MX6, I got something that looks like V4L2_FIELD_SEQ_TB. The question though is: are the field rows always

Re: [PATCH 3/3] [media] v4l2: disable filesystem-dax mapping support

2017-11-07 Thread Mauro Carvalho Chehab
Em Tue, 7 Nov 2017 09:43:41 -0800 Dan Williams escreveu: > On Tue, Nov 7, 2017 at 12:33 AM, Mauro Carvalho Chehab > wrote: > > Em Mon, 06 Nov 2017 16:57:28 -0800 > > Dan Williams escreveu: > > > >> V4L2 memory

Re: [PATCH 1/2] media: usb: uvc: remove duplicate & operation

2017-11-07 Thread Laurent Pinchart
Hello Jaejoong, Thank you for the patch. On Friday, 20 October 2017 10:25:27 EET Jaejoong Kim wrote: > usb_endpoint_maxp() has an inline keyword and searches for bits[10:0] > by & operation with 0x7ff. So, we can remove the duplicate & operation > with 0x7ff. > > Signed-off-by: Jaejoong Kim

Re: usb/media/dtt200u: use-after-free in __dvb_frontend_free

2017-11-07 Thread Andrey Konovalov
On Tue, Nov 7, 2017 at 11:31 AM, Mauro Carvalho Chehab wrote: > Em Mon, 23 Oct 2017 20:58:09 +0200 > Matthias Schwarzott escreveu: > >> Am 23.10.2017 um 16:41 schrieb Andrey Konovalov: >> > Hi! >> > >> > I've got the following report while fuzzing the

Re: [PATCH 2/6 v5] V4L: Add a UVC Metadata format

2017-11-07 Thread Laurent Pinchart
Hi Guennadi, On Monday, 6 November 2017 16:53:10 EET Guennadi Liakhovetski wrote: > On Mon, 30 Oct 2017, Hans Verkuil wrote: > > On 07/28/2017 02:46 PM, Hans Verkuil wrote: > >> On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote: > >>> Add a pixel format, used by the UVC driver to stream

[PATCH] dvb_frontend: don't use-after-free the frontend struct

2017-11-07 Thread Mauro Carvalho Chehab
dvb_frontend_invoke_release() may free the frontend struct. So, the free logic can't update it anymore after calling it. That's OK, as __dvb_frontend_free() is called only when the krefs are zeroed, so nobody is using it anymore. That should fix the following KASAN error: The KASAN report looks

HDMI field order

2017-11-07 Thread Tim Harvey
Greetings, I'm trying to understand the various field orders supported by v4l2 [1]. Do HDMI sources always use V4L2_FIELD_INTERLACED or can they support alternate modes as well? Regards, Tim [1] - https://www.linuxtv.org/downloads/legacy/video4linux/API/V4L2_API/spec/ch03s06.html

Re: [PATCH 3/3] [media] v4l2: disable filesystem-dax mapping support

2017-11-07 Thread Dan Williams
On Tue, Nov 7, 2017 at 12:33 AM, Mauro Carvalho Chehab wrote: > Em Mon, 06 Nov 2017 16:57:28 -0800 > Dan Williams escreveu: > >> V4L2 memory registrations are incompatible with filesystem-dax that >> needs the ability to revoke dma access to a

Re: [PATCH v2 02/26] media: dvb_frontend: be sure to init dvb_frontend_handle_ioctl() return code

2017-11-07 Thread Daniel Scheller
Am Wed, 1 Nov 2017 17:05:39 -0400 schrieb Mauro Carvalho Chehab : > As smatch warned: > drivers/media/dvb-core/dvb_frontend.c:2468 > dvb_frontend_handle_ioctl() error: uninitialized symbol 'err'. > > The ioctl handler actually got a regression here: before

Re: [PATCH] dvb_frontend: don't use-after-free the frontend struct

2017-11-07 Thread Matthias Schwarzott
Am 07.11.2017 um 14:44 schrieb Mauro Carvalho Chehab: > diff --git a/drivers/media/dvb-core/dvb_frontend.c > b/drivers/media/dvb-core/dvb_frontend.c > index d485d5f6cc88..3ad83359098b 100644 > --- a/drivers/media/dvb-core/dvb_frontend.c > +++ b/drivers/media/dvb-core/dvb_frontend.c > @@ -150,11

Re: [PATCH v2 1/2] media: exynos-gsc: fix lockdep warning

2017-11-07 Thread Shuah Khan
On 10/16/2017 09:18 AM, Hans Verkuil wrote: > On 10/16/2017 05:16 PM, Shuah Khan wrote: >> The driver mmap functions shouldn't take lock when calling vb2_mmap(). >> Fix it to not take the lock. >> >> Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3 >> and