Re: [RFC PATCH] media-device: add index field to media_v2_pad

Em Sun, 4 Feb 2018 14:53:31 +0100 Hans Verkuil escreveu: > Userspace has no way of knowing the pad index for the entity that > owns the pad with the MEDIA_IOC_G_TOPOLOGY ioctl. However, various > v4l-subdev ioctls need to pass this as an argument. While I'm OK on adding a

media_device.c question: can this workaround be removed?

The function media_device_enum_entities() has this workaround: /* * Workaround for a bug at media-ctl <= v1.10 that makes it to * do the wrong thing if the entity function doesn't belong to * either MEDIA_ENT_F_OLD_BASE or MEDIA_ENT_F_OLD_SUBDEV_BASE *

[RFC PATCH] media.h: reorganize header to make it easier to understand

The media.h public header is very messy. It mixes legacy and 'new' defines and it is not easy to figure out what should and what shouldn't be used. It also contains confusing comment that are either out of date or completely uninteresting for anyone that needs to use this header. The patch groups

Re: [RFC PATCH] media.h: reorganize header to make it easier to understand

Since this patch is hard to read, here is the 'post-patch' header: cut here -- /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ /* * Multimedia device API * * Copyright (C) 2010 Nokia Corporation * * Contacts: Laurent Pinchart

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: > Hi Hans, > > Em Sun, 4 Feb 2018 14:06:42 +0100 > Hans Verkuil escreveu: > >> Hi Mauro, >> >> I'm working on adding proper compliance tests for the MC but I think >> something >> is missing in the G_TOPOLOGY ioctl w.r.t.

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: > Hi Hans, > > Em Sun, 4 Feb 2018 14:06:42 +0100 > Hans Verkuil escreveu: > >> Hi Mauro, >> >> I'm working on adding proper compliance tests for the MC but I think >> something >> is missing in the G_TOPOLOGY ioctl w.r.t.

Re: media_device.c question: can this workaround be removed?

On 02/05/2018 12:59 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote: >> The function media_device_enum_entities() has this workaround: >> >> /* >> * Workaround for a bug at media-ctl <= v1.10 that makes it to >> * do

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Sun, 04 Feb 2018 15:20:55 +0200 Laurent Pinchart escreveu: > Hi Hans, > > On Sunday, 4 February 2018 15:16:26 EET Hans Verkuil wrote: > > On 02/04/2018 02:13 PM, Laurent Pinchart wrote: > > > On Sunday, 4 February 2018 15:06:42 EET Hans Verkuil wrote: >

Re: [PATCH 0/2] DW9807 DT binding and driver patches

Hi Andy, On Thu, Feb 01, 2018 at 11:47:46PM +0800, Andy Yeh wrote: > From: Alan Chiang > > Hi Sakari and Tomasz, > > The two patches are the DT binding and driver for DW9807 VCM controller. Thanks for the update. Next time when you're sending a patchset, could you

RE: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

Hello Maxime, thank you for your feedback. > > > +/* > > > + * configure parallel port control lines polarity > > > + * > > > + * POLARITY CTRL0 > > > + * - [5]:PCLK polarity (0: active low, 1: active high) > > > + * - [1]:HREF polarity (0: active low, 1: active high) > > > + * - [0]:VSYNC

Re: media_device.c question: can this workaround be removed?

Hi Hans, On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote: > The function media_device_enum_entities() has this workaround: > > /* > * Workaround for a bug at media-ctl <= v1.10 that makes it to > * do the wrong thing if the entity function doesn't belong to

Re: [RFC PATCH] media-device: add index field to media_v2_pad

On 02/05/2018 01:39 PM, Mauro Carvalho Chehab wrote: > Em Sun, 4 Feb 2018 14:53:31 +0100 > Hans Verkuil escreveu: > >> Userspace has no way of knowing the pad index for the entity that >> owns the pad with the MEDIA_IOC_G_TOPOLOGY ioctl. However, various >> v4l-subdev ioctls

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Hi Hans, Em Sun, 4 Feb 2018 14:06:42 +0100 Hans Verkuil escreveu: > Hi Mauro, > > I'm working on adding proper compliance tests for the MC but I think something > is missing in the G_TOPOLOGY ioctl w.r.t. pads. > > In several v4l-subdev ioctls you need to pass the pad.

Re: [PATCH 2/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

Hi Andy, On Thu, Feb 01, 2018 at 11:48:12PM +0800, Andy Yeh wrote: > From: Alan Chiang > > Dongwoon DW9807 is a voice coil lens driver. > > Also add a vendor prefix for Dongwoon for one did not exist previously. > > Signed-off-by: Andy Yeh Could

Re: [PATCH] [BUGFIX] media: vb2: Fix videobuf2 to map correct area

On Mon, 05 Feb 2018 09:47:46 +0100 Marek Szyprowski wrote: > Hi Masami, > > On 2018-02-05 03:30, Masami Hiramatsu wrote: > > Fixes vb2_vmalloc_get_userptr() to ioremap correct area. > > Since the current code does ioremap the page address, if the offset > 0, > > it

Re: media_device.c question: can this workaround be removed?

Hi Hans, On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote: > On 02/05/2018 12:59 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote: > >> The function media_device_enum_entities() has this workaround: > >> > >> /* > >>

[PATCH] drivers: staging: media: atomisp: pci: atomisp2: css2400: fix misspellings

From: Alona Solntseva Misspelled words are fixed in several places. Signed-off-by: Alona Solntseva --- .../staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Mon, 5 Feb 2018 14:47:51 +0100 Hans Verkuil escreveu: > On 02/05/2018 02:17 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 5 Feb 2018 12:55:21 +0100 > > Hans Verkuil escreveu: > > > >> On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: > >>> Hi

Re: [PATCH 1/1] vb2: core: Finish buffers at the end of the stream

Hi Sakari, I tried this patch, and I no longer see the messages in dmesg output when closing the V4L2 device node. Tested-by: Devin Heitmueller Thanks, Devin On Fri, Feb 2, 2018 at 8:57 AM, Devin Heitmueller wrote: > Hello Sakari, >

[PATCH 2/5] add video control register definitions

Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index 8375b06..0dbb004 100644 ---

[PATCH 1/5] add missing blob structure tag field

Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index f16f835..8375b06 100644 ---

[PATCH 4/5] add V4L2 control functions

Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 114 ++ 1 file changed, 114 insertions(+) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index 63c7264b..c4b7cf1 100644 ---

[PATCH 3/5] add video control register handlers

Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index 0dbb004..63c7264b 100644 ---

[PATCH 0/5] [RFC] add video controls to SUR40 driver

The SUR40 (aka Pixelsense) has internal registers that expose sensor parameters such as brightness, gain etc. This patch creates V4L2 control items and maps them to the appropriate parameters. This is an initial submission for review, comments welcome! Best regards, Florian

[PATCH 5/5] add default control values as module parameters

Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index c4b7cf1..d612f3f 100644 ---

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Mon, 5 Feb 2018 12:55:21 +0100 Hans Verkuil escreveu: > On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: > > Hi Hans, > > > > Em Sun, 4 Feb 2018 14:06:42 +0100 > > Hans Verkuil escreveu: > > > >> Hi Mauro, > >> > >> I'm working on adding proper

Re: [RFC PATCH] media-device: add index field to media_v2_pad

Em Mon, 5 Feb 2018 13:42:48 +0100 Hans Verkuil escreveu: > On 02/05/2018 01:39 PM, Mauro Carvalho Chehab wrote: > > Em Sun, 4 Feb 2018 14:53:31 +0100 > > Hans Verkuil escreveu: > > > >> Userspace has no way of knowing the pad index for the entity that

Re: [PATCH 4/5] add V4L2 control functions

On 02/05/2018 03:29 PM, Florian Echtler wrote: > Signed-off-by: Florian Echtler > --- > drivers/input/touchscreen/sur40.c | 114 > ++ > 1 file changed, 114 insertions(+) > > diff --git a/drivers/input/touchscreen/sur40.c >

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Mon, 5 Feb 2018 12:38:29 +0100 Hans Verkuil escreveu: > On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: > > Hi Hans, > > > > Em Sun, 4 Feb 2018 14:06:42 +0100 > > Hans Verkuil escreveu: > > > >> Hi Mauro, > >> > >> I'm working on adding proper

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

On 02/05/2018 02:17 PM, Mauro Carvalho Chehab wrote: > Em Mon, 5 Feb 2018 12:55:21 +0100 > Hans Verkuil escreveu: > >> On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: >>> Hi Hans, >>> >>> Em Sun, 4 Feb 2018 14:06:42 +0100 >>> Hans Verkuil escreveu:

Re: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

On Mon, Feb 05, 2018 at 11:42:11AM +, Fabrizio Castro wrote: > Hello Maxime, > > thank you for your feedback. > > > > > +/* > > > > + * configure parallel port control lines polarity > > > > + * > > > > + * POLARITY CTRL0 > > > > + * - [5]:PCLK polarity (0: active low, 1: active high) > > >

Re: [PATCH 5/5] add default control values as module parameters

On 02/05/2018 03:29 PM, Florian Echtler wrote: > Signed-off-by: Florian Echtler Please add a change log when you make a patch. I for one would like to know why this has to be supplied as a module option. Some documentation in the code would be helpful as well (e.g. I have

Re: media_device.c question: can this workaround be removed?

On 02/05/2018 03:30 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote: >> On 02/05/2018 12:59 PM, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote: The function media_device_enum_entities()

Re: Please help test the new v4l-subdev support in v4l2-compliance

On 02/05/2018 05:21 PM, Tim Harvey wrote: > > I ran a 'make distclean; ./bootstrap.sh && ./configure && make' > > last version I built successfully was '1bb8c70 v4l2-ctl: mention that > --set-subdev-fps is for testing only' That's a lot of revisions ago. I've been busy last weekend :-) Do a

Re: Please help test the new v4l-subdev support in v4l2-compliance

On Sat, Feb 3, 2018 at 7:56 AM, Hans Verkuil wrote: > Hi Tim, Jacopo, > > I have now finished writing the v4l2-compliance tests for the various > v4l-subdev > ioctls. I managed to test some with the vimc driver, but that doesn't > implement all > ioctls, so I could use some

Re: media_device.c question: can this workaround be removed?

Em Mon, 5 Feb 2018 16:19:28 +0100 Hans Verkuil escreveu: > On 02/05/2018 03:30 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote: > >> On 02/05/2018 12:59 PM, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Mon,

Re: Please help test the new v4l-subdev support in v4l2-compliance

Em Mon, 5 Feb 2018 08:21:54 -0800 Tim Harvey escreveu: > Hans, > > I'm failing compile (of master 4ee9911) with: > > CXX v4l2_compliance-media-info.o > media-info.cpp: In function ‘media_type media_detect_type(const char*)’: > media-info.cpp:79:39: error: no

Re: Please help test the new v4l-subdev support in v4l2-compliance

On Mon, Feb 5, 2018 at 8:27 AM, Hans Verkuil wrote: > On 02/05/2018 05:21 PM, Tim Harvey wrote: > > > >> >> I ran a 'make distclean; ./bootstrap.sh && ./configure && make' >> >> last version I built successfully was '1bb8c70 v4l2-ctl: mention that >> --set-subdev-fps is for

Re: Please help test the new v4l-subdev support in v4l2-compliance

Em Mon, 5 Feb 2018 14:37:29 -0200 Mauro Carvalho Chehab escreveu: > Em Mon, 5 Feb 2018 08:21:54 -0800 > Tim Harvey escreveu: > > > Hans, > > > > I'm failing compile (of master 4ee9911) with: > > > > CXX v4l2_compliance-media-info.o > >

Re: Please help test the new v4l-subdev support in v4l2-compliance

On 02/05/2018 05:37 PM, Mauro Carvalho Chehab wrote: > Em Mon, 5 Feb 2018 08:21:54 -0800 > Tim Harvey escreveu: > >> Hans, >> >> I'm failing compile (of master 4ee9911) with: >> >> CXX v4l2_compliance-media-info.o >> media-info.cpp: In function ‘media_type

Re: Please help test the new v4l-subdev support in v4l2-compliance

On 02/05/2018 05:55 PM, Mauro Carvalho Chehab wrote: > Em Mon, 5 Feb 2018 14:37:29 -0200 > Mauro Carvalho Chehab escreveu: > >> Em Mon, 5 Feb 2018 08:21:54 -0800 >> Tim Harvey escreveu: >> >>> Hans, >>> >>> I'm failing compile (of master 4ee9911) with:

Re: Please help test the new v4l-subdev support in v4l2-compliance

On 02/05/2018 05:59 PM, Hans Verkuil wrote: > On 02/05/2018 05:55 PM, Mauro Carvalho Chehab wrote: >> Em Mon, 5 Feb 2018 14:37:29 -0200 >> Mauro Carvalho Chehab escreveu: >> >>> Em Mon, 5 Feb 2018 08:21:54 -0800 >>> Tim Harvey escreveu: >>> Hans,

Re: [PATCH] [BUGFIX] media: vb2: Fix videobuf2 to map correct area

Hi Masami, On 2018-02-05 03:30, Masami Hiramatsu wrote: Fixes vb2_vmalloc_get_userptr() to ioremap correct area. Since the current code does ioremap the page address, if the offset > 0, it does not do ioremap the last page and results in kernel panic. This fixes to pass the page address +

Re: Compliance tests for new public API features

Hi Hans, On Sun, Feb 4, 2018 at 10:30 PM, Hans Verkuil wrote: > Hi Gustavo, Alexandre, > > As you may have seen I have been extending the v4l2-compliance utility with > tests > for v4l-subdevX and mediaX devices. In the process of doing that I promptly > found a bunch of

[PATCH] media.h: fix confusing typo in comment

Subdevs are initialized with MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN, not MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN. Signed-off-by: Hans Verkuil --- diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index b9b9446095e9..573da38a21c3 100644 --- a/include/uapi/linux/media.h

[PATCH v2 5/8] pci: cx88-input: use 64-bit arithmetic instead of 32-bit

Add suffix LL to constant 100 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type ktime_t (64 bits, signed). The expression ir->polling * 100 is currently being evaluated

[PATCH v2 0/8] use 64-bit arithmetic instead of 32-bit

Add suffix LL and ULL to various constants in order to give the compiler complete information about the proper arithmetic to use. Such constants are used in contexts that expect expressions of type u64 (64 bits, unsigned) and s64 (64 bits, signed). The mentioned expressions are currently being

[PATCH v2 1/8] rtl2832: use 64-bit arithmetic instead of 32-bit in rtl2832_set_frontend

Add suffix ULL to constant 7 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type u64 (64 bits, unsigned). The expression dev->pdata->clk * 7 is currently being evaluated using

[PATCH v2 2/8] dvb-frontends: ves1820: use 64-bit arithmetic instead of 32-bit

Add suffix ULL to constant 10 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type u64 (64 bits, unsigned). The expression fpxin = state->config->xin * 10 is currently being

Re: Please help test the new v4l-subdev support in v4l2-compliance

Em Mon, 5 Feb 2018 18:01:34 +0100 Hans Verkuil escreveu: > On 02/05/2018 05:59 PM, Hans Verkuil wrote: > > On 02/05/2018 05:55 PM, Mauro Carvalho Chehab wrote: > >> Em Mon, 5 Feb 2018 14:37:29 -0200 > >> Mauro Carvalho Chehab escreveu: > >> > >>> Em

[PATCH v2 3/8] i2c: max2175: use 64-bit arithmetic instead of 32-bit

Add suffix LL to constant 2 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type s64 (64 bits, signed). The expression 2 * (clock_rate - abs_nco_freq) is currently being evaluated

[PATCH v2 4/8] i2c: ov9650: use 64-bit arithmetic instead of 32-bit

Add suffix ULL to constants 1 and 100 in order to give the compiler complete information about the proper arithmetic to use. Notice that these constants are used in contexts that expect expressions of type u64 (64 bits, unsigned). The following expressions: (u64)(fi->interval.numerator *

[PATCH] media: intel-ipu3: cio2: Use SPDX license headers

Adopt SPDX license headers and update year to 2018. Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 12 ++-- drivers/media/pci/intel/ipu3/ipu3-cio2.h | 14 ++ 2 files changed, 4 insertions(+), 22 deletions(-) diff --git

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 6 05:00:24 CET 2018 media-tree git hash:273caa260035c03d89ad63d72d8cd3d9e5c5e3f1 media_build

[PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

In one Renesas driver, I found a typo which turned an intended bit shift ('<<') into a comparison ('<'). Because this is a subtle issue, I looked tree wide for similar patterns. This small patch series is the outcome. Buildbot and checkpatch are happy. Only compile-tested. To be applied

[PATCH 3/4] v4l: dvb-frontends: stb0899: fix comparison to bitshift when dealing with a mask

Due to a typo, the mask was destroyed by a comparison instead of a bit shift. Signed-off-by: Wolfram Sang --- Only build tested. To be applied individually per subsystem. drivers/media/dvb-frontends/stb0899_reg.h | 8 1 file changed, 4 insertions(+),

[PATCH 1/4] v4l: vsp1: fix mask creation for MULT_ALPHA_RATIO

Due to a typo, the mask was destroyed by a comparison instead of a bit shift. No regression since the mask has not been used yet. Signed-off-by: Wolfram Sang --- Only build tested. To be applied individually per subsystem.

Re: media_device.c question: can this workaround be removed?

Hi Mauro and Hans, On Mon, Feb 05, 2018 at 02:32:28PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 5 Feb 2018 16:19:28 +0100 > Hans Verkuil escreveu: > > > On 02/05/2018 03:30 PM, Sakari Ailus wrote: > > > Hi Hans, > > > > > > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans

Re: [PATCH v2 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

Hi Hans, Quoting Hans Verkuil : On 02/05/2018 09:36 PM, Gustavo A. R. Silva wrote: Add suffix ULL to constant 10 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression

Re: Please help test the new v4l-subdev support in v4l2-compliance

On Sat, Feb 3, 2018 at 7:56 AM, Hans Verkuil wrote: > Hi Tim, Jacopo, > > I have now finished writing the v4l2-compliance tests for the various > v4l-subdev > ioctls. I managed to test some with the vimc driver, but that doesn't > implement all > ioctls, so I could use some

Re: Please help test the new v4l-subdev support in v4l2-compliance

On 02/06/2018 08:16 AM, Tim Harvey wrote: > On Sat, Feb 3, 2018 at 7:56 AM, Hans Verkuil wrote: >> Hi Tim, Jacopo, >> >> I have now finished writing the v4l2-compliance tests for the various >> v4l-subdev >> ioctls. I managed to test some with the vimc driver, but that

Re: [PATCH 0/2 v6] uvcvideo: asynchronous controls

Hi Laurent, Any update on this? Thanks Guennadi On Wed, 13 Dec 2017, Guennadi Liakhovetski wrote: > This is an update of the two patches, adding asynchronous control > support to the uvcvideo driver. If a control is sent, while the camera > is still processing an earlier control, it will

[PATCH v2 6/8] rockchip/rga: use 64-bit arithmetic instead of 32-bit

Cast p to dma_addr_t in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type dma_addr_t (u64). The expression p << PAGE_SHIFT is currently being evaluated using 32-bit arithmetic. Addresses-Coverity-ID: 1458347 Signed-off-by:

[PATCH v2 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

Add suffix ULL to constant 10 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type u64 (64 bits, unsigned). The expression len * 10 * CEC_TIM_DATA_BIT_TOTAL is currently being

[PATCH v2 7/8] platform: sh_veu: use 64-bit arithmetic instead of 32-bit

Cast left and top to dma_addr_t in order to give the compiler complete information about the proper arithmetic to use. Notice that these variables are being used in contexts that expect expressions of type dma_addr_t (64 bit, unsigned). Such expressions are currently being evaluated using 32-bit

Re: [PATCH v2 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

On 02/05/2018 09:36 PM, Gustavo A. R. Silva wrote: > Add suffix ULL to constant 10 in order to give the compiler complete > information about the proper arithmetic to use. Notice that this > constant is used in a context that expects an expression of type > u64 (64 bits, unsigned). > > The

Re: [PATCH 4/5] add V4L2 control functions

Hello Hans, On Mon, 5 Feb 2018, Hans Verkuil wrote: On 02/05/2018 03:29 PM, Florian Echtler wrote: + +static int sur40_vidioc_queryctrl(struct file *file, void *fh, + struct v4l2_queryctrl *qc) Sorry, but this is very wrong. Use the control framework instead. See

Re: [PATCH 4/5] add V4L2 control functions

On 02/05/2018 10:36 PM, Florian Echtler wrote: > Hello Hans, > > On Mon, 5 Feb 2018, Hans Verkuil wrote: >> On 02/05/2018 03:29 PM, Florian Echtler wrote: >>> + >>> +static int sur40_vidioc_queryctrl(struct file *file, void *fh, >>> + struct v4l2_queryctrl *qc) >> >>

Re: media_device.c question: can this workaround be removed?

Hi Hans, On Mon, Feb 05, 2018 at 04:19:28PM +0100, Hans Verkuil wrote: > On 02/05/2018 03:30 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote: > >> On 02/05/2018 12:59 PM, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Mon, Feb 05, 2018