Re: [PATCH 2/8] media: s5p-jpeg: Use bulk clk API

2018-02-19 Thread kbuild test robot
Hi Maciej, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc2 next-20180219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

2018-02-19 Thread kbuild test robot
Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[RFCv4 12/21] media: videobuf2: add support for requests

2018-02-19 Thread Alexandre Courbot
Make vb2 core aware of requests. Drivers can specify whether a given queue accepts requests or not. Signed-off-by: Alexandre Courbot --- drivers/media/common/videobuf2/videobuf2-core.c | 3 +++ include/media/videobuf2-core.h | 4 2 files changed, 7

[RFCv4 13/21] media: videobuf2-v4l2: support for requests

2018-02-19 Thread Alexandre Courbot
Add a new vb2_qbuf_request() (a request-aware version of vb2_qbuf()) that request-aware drivers can call to queue a buffer into a request instead of directly into the vb2 queue if relevent. This function expects that drivers invoking it are using instances of v4l2_request_entity and

[RFCv4 14/21] videodev2.h: add request_fd field to v4l2_ext_controls

2018-02-19 Thread Alexandre Courbot
Allow to specify a request to be used with the S_EXT_CTRLS and G_EXT_CTRLS operations. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- include/uapi/linux/videodev2.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff

[RFCv4 17/21] media: mem2mem: support for requests

2018-02-19 Thread Alexandre Courbot
Add generic support for requests to the mem2mem framework. This just requires calling vb2_qbuf_request() instead of vb2_qbuf() in v4l2_m2m_qbuf(). Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-mem2mem.c | 3 ++- 1 file changed, 2 insertions(+), 1

[RFCv4 15/21] v4l2-ctrls: support requests in EXT_CTRLS ioctls

2018-02-19 Thread Alexandre Courbot
Read and use the request_fd field of struct v4l2_ext_controls to apply VIDIOC_G_EXT_CTRLS or VIDIOC_S_EXT_CTRLS to a request when asked by userspace. Signed-off-by: Alexandre Courbot --- drivers/media/platform/omap3isp/ispvideo.c | 2 +-

[RFCv4 16/21] v4l2: video_device: support for creating requests

2018-02-19 Thread Alexandre Courbot
Add a new VIDIOC_NEW_REQUEST ioctl, which allows to instanciate requests on devices that support the request API. Requests created that way can only control the device they originate from, making them suitable for simple devices, but not complex pipelines. Signed-off-by: Alexandre Courbot

[RFCv4 00/21] Request API

2018-02-19 Thread Alexandre Courbot
Hi everyone, And thanks for all the feedback on the previous version! I have tried to address as much as possible, which results in (another) almost rewrite. But I think the behavior and structure are converging to something satisfying and usable. Besides the buffer queuing behavior that has

[RFCv4 02/21] v4l2-ctrls: v4l2_ctrl_add_handler: add from_other_dev

2018-02-19 Thread Alexandre Courbot
From: Hans Verkuil Add a 'bool from_other_dev' argument: set to true if the two handlers refer to different devices (e.g. it is true when inheriting controls from a subdev into a main v4l2 bridge driver). This will be used later when implementing support for the request

Re: [PATCH 4/8] drm/exynos/dsi: Use clk bulk API

2018-02-19 Thread kbuild test robot
Hi Maciej, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc2 next-20180219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[RFCv4 11/21] media: v4l2_fh: add request entity field

2018-02-19 Thread Alexandre Courbot
Allow drivers to assign a request entity to v4l2_fh. This will be useful for request-aware ioctls to find out which request entity to use. Signed-off-by: Alexandre Courbot --- include/media/v4l2-fh.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[RFCv4 09/21] v4l2: add request API support

2018-02-19 Thread Alexandre Courbot
Add a v4l2 request entity data structure that takes care of storing the request-related state of a V4L2 device ; in this case, its controls. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/v4l2-request.c | 178

[RFCv4 10/21] videodev2.h: Add request_fd field to v4l2_buffer

2018-02-19 Thread Alexandre Courbot
From: Hans Verkuil When queuing buffers allow for passing the request that should be associated with this buffer. Signed-off-by: Hans Verkuil [acour...@chromium.org: make request ID 32-bit] Signed-off-by: Alexandre Courbot

[RFCv4 04/21] v4l2-ctrls: add core request API

2018-02-19 Thread Alexandre Courbot
From: Hans Verkuil Add the four core request functions: v4l2_ctrl_request_init() initializes a new (empty) request. v4l2_ctrl_request_clone() resets a request based on another request (or clears it if that request is NULL). v4l2_ctrl_request_get(): increase refcount

[RFCv4 06/21] v4l2-ctrls: support g/s_ext_ctrls for requests

2018-02-19 Thread Alexandre Courbot
From: Hans Verkuil The v4l2_g/s_ext_ctrls functions now support control handlers that represent requests. Signed-off-by: Hans Verkuil Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ctrls.c | 37

[RFCv4 03/21] v4l2-ctrls: prepare internal structs for request API

2018-02-19 Thread Alexandre Courbot
From: Hans Verkuil Add a refcount and is_request bool to struct v4l2_ctrl_handler: this is used to refcount a handler that represents a request. Add a p_req field to struct v4l2_ctrl_ref that will store the request value. Signed-off-by: Hans Verkuil

[RFCv4 05/21] v4l2-ctrls: use ref in helper instead of ctrl

2018-02-19 Thread Alexandre Courbot
From: Hans Verkuil The next patch needs the reference to a control instead of the control itself, so change struct v4l2_ctrl_helper accordingly. Signed-off-by: Hans Verkuil Signed-off-by: Alexandre Courbot ---

[RFCv4 08/21] [WAR] v4l2-ctrls: do not clone non-standard controls

2018-02-19 Thread Alexandre Courbot
Only standard controls can be successfully cloned: handler_new_ref, used by v4l2_ctrl_request_clone(), forcibly calls v4l2_ctrl_new_std() which fails to find custom controls names, and we eventually hit the condition that name == NULL in v4l2_ctrl_new(). This prevents us from using non-standard

[RFCv4 07/21] v4l2-ctrls: add v4l2_ctrl_request_setup

2018-02-19 Thread Alexandre Courbot
From: Hans Verkuil Add a helper function that can set controls from a request. Signed-off-by: Hans Verkuil Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ctrls.c | 71

Re: [PATCH 8/8] [media] s5p-mfc: Use clk bulk API

2018-02-19 Thread kbuild test robot
Hi Maciej, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16-rc2 next-20180219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

2018-02-19 Thread kbuild test robot
Hi Jacopo, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Hello Beautiful

2018-02-19 Thread Jack
Good day dear, i hope this mail meets you well? my name is Jack, from the U.S. I know this may seem inappropriate so i ask for your forgiveness but i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am

[RFCv4 00/21] Request API

2018-02-19 Thread Alexandre Courbot
(resending with correct word-wrap - sorry for the inconvenience) Hi everyone, And thanks for all the feedback on the previous version! I have tried to address as much as possible, which results in (another) almost rewrite. But I think the behavior and structure are converging to something

Re: [PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

2018-02-19 Thread kbuild test robot
Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[RFC PATCH] media: i2c: ov772x: ov772x_frame_intervals[] can be static

2018-02-19 Thread kbuild test robot
Fixes: 42b7d5be5f1f ("media: i2c: ov772x: Support frame interval handling") Signed-off-by: Fengguang Wu --- ov772x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index eba71d97..0d8ce2a

[RFCv4 21/21] [WIP] media: media-device: support for creating requests

2018-02-19 Thread Alexandre Courbot
Add a new MEDIA_IOC_NEW_REQUEST ioctl, which can be used to instantiate a request suitable to control the media device topology as well as the parameters and buffer flow of its entities. This is still very early work, and mainly here to demonstrate that it is still possible to bind requests to

[RFCv4 19/21] media: vim2m: add request support

2018-02-19 Thread Alexandre Courbot
Set the necessary ops for supporting requests in vim2m. Signed-off-by: Alexandre Courbot --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/vim2m.c | 75 ++ 2 files changed, 76 insertions(+) diff --git

[RFCv4 18/21] Documentation: v4l: document request API

2018-02-19 Thread Alexandre Courbot
Document the request API for V4L2 devices, and amend the documentation of system calls influenced by it. Signed-off-by: Alexandre Courbot --- Documentation/media/uapi/v4l/buffer.rst | 9 +- Documentation/media/uapi/v4l/common.rst | 1 +

[RFCv4 20/21] media: vivid: add request support for the video capture device

2018-02-19 Thread Alexandre Courbot
Allow to use requests with the video capture device. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vivid/Kconfig | 1 + drivers/media/platform/vivid/vivid-core.c | 63 ++- drivers/media/platform/vivid/vivid-core.h | 3 +

cron job: media_tree daily build: ABI WARNING

2018-02-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 20 05:00:11 CET 2018 media-tree git hash:29422737017b866d4a51014cc7522fa3a99e8852 media_build

[RFCv4 01/21] media: add request API core and UAPI

2018-02-19 Thread Alexandre Courbot
The request API provides a way to group buffers and device parameters into units of work to be queued and executed. This patch introduces the UAPI and core framework. This patch is based on the previous work by Laurent Pinchart. The core has changed considerably, but the UAPI is mostly untouched.

Re: [RFCv4 09/21] v4l2: add request API support

2018-02-19 Thread Philippe Ombredanne
On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot wrote: > Add a v4l2 request entity data structure that takes care of storing the > request-related state of a V4L2 device ; in this case, its controls. > > Signed-off-by: Alexandre Courbot > ---

[PATCH v2] Staging: bcm2048: Fix function argument alignment in radio-bcm2048.c.

2018-02-19 Thread Quytelda Kahja
Fix a coding style problem. Signed-off-by: Quytelda Kahja --- This is the patch without the unnecessary fixes for line length. drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[no subject]

2018-02-19 Thread Alfred Cheuk Yu Chow
Good Day, This is the second time i am sending you this mail. I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, need your alliance in a deal that will be of mutual benefit. Email me personally for more details. Regards.

[PATCHv3 12/15] media: zero reservedX fields in media_v2_topology

2018-02-19 Thread Hans Verkuil
The MEDIA_IOC_G_TOPOLOGY implementation did not zero the reservedX fields. Fix this. Found with v4l2-compliance. Signed-off-by: Hans Verkuil --- drivers/media/media-device.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/media-device.c

[PATCHv3 11/15] media.h: fix confusing typo in comment

2018-02-19 Thread Hans Verkuil
Subdevs are initialized with MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN, not MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- include/uapi/linux/media.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCHv3 15/15] media.h: reorganize header to make it easier to understand

2018-02-19 Thread Hans Verkuil
The media.h public header is very messy. It mixes legacy and 'new' defines and it is not easy to figure out what should and what shouldn't be used. It also contains confusing comment that are either out of date or completely uninteresting for anyone that needs to use this header. The patch groups

[PATCHv3 14/15] media-ioc-enum-entities/links.rst: document reserved fields

2018-02-19 Thread Hans Verkuil
These structures have reserved fields that were never documented. Signed-off-by: Hans Verkuil --- .../uapi/mediactl/media-ioc-enum-entities.rst | 18 .../media/uapi/mediactl/media-ioc-enum-links.rst | 25 ++ 2 files changed, 39

[PATCHv3 04/15] v4l2-subdev: clear reserved fields

2018-02-19 Thread Hans Verkuil
Clear the reserved fields for these ioctls according to the specification: VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL VIDIOC_SUBDEV_ENUM_FRAME_SIZE VIDIOC_SUBDEV_ENUM_MBUS_CODE VIDIOC_SUBDEV_G_CROP, VIDIOC_SUBDEV_S_CROP VIDIOC_SUBDEV_G_FMT, VIDIOC_SUBDEV_S_FMT VIDIOC_SUBDEV_G_FRAME_INTERVAL,

[PATCHv3 07/15] media-ioc-g-topology.rst: fix interface-to-entity link description

2018-02-19 Thread Hans Verkuil
The source_id and sink_id descriptions were the same for interface-to-entity links. The source_id is the interface ID, not the entity ID. Fix this. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus ---

[PATCHv3 09/15] media: media-types.rst: fix typo

2018-02-19 Thread Hans Verkuil
From: Alexandre Courbot with -> which Signed-off-by: Alexandre Courbot Acked-by: Sakari Ailus --- Documentation/media/uapi/mediactl/media-types.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv3 08/15] media-types.rst: fix type, small improvements

2018-02-19 Thread Hans Verkuil
data conector -> connector ... -> etc. '...' looked odd when my browser put the ... by itself on the next line, 'etc.' is clearer IMHO. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus ---

[PATCHv3 02/15] vimc: use correct subdev functions

2018-02-19 Thread Hans Verkuil
Instead of calling everything a MEDIA_ENT_F_ATV_DECODER, pick the correct functions for these blocks. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/platform/vimc/vimc-debayer.c | 2 +-

[PATCHv3 13/15] media: document the reservedX fields in media_v2_topology

2018-02-19 Thread Hans Verkuil
The MEDIA_IOC_G_TOPOLOGY documentation didn't document the reservedX fields. Related to that was that the documented type of the num_* fields was also wrong. Fix both. Signed-off-by: Hans Verkuil --- .../media/uapi/mediactl/media-ioc-g-topology.rst | 52

[PATCHv3 06/15] subdev-formats.rst: fix incorrect types

2018-02-19 Thread Hans Verkuil
The ycbcr_enc, quantization and xfer_func fields are __u16 and not enums. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- Documentation/media/uapi/v4l/subdev-formats.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCHv3 10/15] media-device.c: zero reserved fields

2018-02-19 Thread Hans Verkuil
MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc struct. Do so in media_device_setup_link(). MEDIA_IOC_ENUM_LINKS didn't zero the reserved field of the media_links_enum struct. Do so in media_device_enum_links(). Signed-off-by: Hans Verkuil ---

[PATCHv3 05/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-19 Thread Hans Verkuil
The VIDIOC_DBG_G/S_REGISTER ioctls imply that VIDIOC_DBG_G_CHIP_INFO is also present, since without that you cannot use v4l2-dbg. Just like the implementation in v4l2-ioctl.c this can be implemented in the core and no drivers need to be modified. It also makes it possible for v4l2-compliance to

[PATCHv3 03/15] v4l2-subdev: without controls return -ENOTTY

2018-02-19 Thread Hans Verkuil
If the subdev did not define any controls, then return -ENOTTY if userspace attempts to call these ioctls. The control framework functions will return -EINVAL, not -ENOTTY if vfh->ctrl_handler is NULL. Several of these framework functions are also called directly from drivers, so I don't want to

Re: [PATCH v2.1 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-02-19 Thread Sakari Ailus
On Mon, Feb 19, 2018 at 02:58:45PM +0100, Hans Verkuil wrote: > On 02/19/2018 02:48 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Feb 19, 2018 at 02:30:18PM +0100, Hans Verkuil wrote: > >> On 02/19/2018 02:27 PM, Sakari Ailus wrote: > >>> These sensor drivers have use case specific mode

[bug report] V4L/DVB (3420): Added iocls to configure VBI on tvp5150

2018-02-19 Thread Dan Carpenter
[ This is obviously ancient code. It's probably fine. I've just been going through all array overflow warnings recently. - dan ] Hello Mauro Carvalho Chehab, The patch 12db56071b47: "V4L/DVB (3420): Added iocls to configure VBI on tvp5150" from Jan 23, 2006, leads to the following static

[PATCHv3 00/10] media: replace g/s_parm by g/s_frame_interval

2018-02-19 Thread Hans Verkuil
From: Hans Verkuil There are currently two subdev ops variants to get/set the frame interval: g/s_parm and g/s_frame_interval. This patch series replaces all g/s_parm calls by g/s_frame_interval. The first patch clears the reserved fields in v4l2-subdev.c. It's taken

[PATCHv3 07/10] staging: atomisp: mt9m114: Drop empty s_parm callback

2018-02-19 Thread Hans Verkuil
From: Sakari Ailus The s_parm callback in mt9m114 driver did nothing, remove it. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 6 -- 1

[PATCHv3 10/10] vidioc-g-parm.rst: also allow _MPLANE buffer types

2018-02-19 Thread Hans Verkuil
From: Hans Verkuil The specification mentions that type can be V4L2_BUF_TYPE_VIDEO_CAPTURE, but the v4l2 core implementation also allows the _MPLANE variant. Document this. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus

Re: [PATCH v2.1 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-02-19 Thread Hans Verkuil
On 02/19/2018 02:48 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Feb 19, 2018 at 02:30:18PM +0100, Hans Verkuil wrote: >> On 02/19/2018 02:27 PM, Sakari Ailus wrote: >>> These sensor drivers have use case specific mode lists. There's no need >>> for this nor there is a standard API for

[PATCHv3 05/10] staging: atomisp: i2c: Disable non-preview configurations

2018-02-19 Thread Hans Verkuil
From: Sakari Ailus These sensor drivers have use case specific mode lists. This is currently not used nor there is a standard API for selecting the mode list. Disable configurations for non-preview modes until configuration selection is improved so that all the

[PATCHv3 08/10] staging: atomisp: Drop g_parm and s_parm subdev ops use

2018-02-19 Thread Hans Verkuil
From: Sakari Ailus The s_parm and g_parm did nothing. Remove them. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- .../staging/media/atomisp/pci/atomisp2/atomisp_file.c| 16

[PATCHv3 06/10] staging: atomisp: i2c: Drop g_parm support in sensor drivers

2018-02-19 Thread Hans Verkuil
From: Sakari Ailus These drivers already support g_frame_interval. Therefore just dropping g_parm is enough. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil ---

[PATCHv3 01/10] v4l2-subdev: clear reserved fields

2018-02-19 Thread Hans Verkuil
Clear the reserved fields for these ioctls according to the specification: VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL VIDIOC_SUBDEV_ENUM_FRAME_SIZE VIDIOC_SUBDEV_ENUM_MBUS_CODE VIDIOC_SUBDEV_G_CROP, VIDIOC_SUBDEV_S_CROP VIDIOC_SUBDEV_G_FMT, VIDIOC_SUBDEV_S_FMT VIDIOC_SUBDEV_G_FRAME_INTERVAL,

[PATCHv3 09/10] v4l2-subdev.h: remove obsolete g/s_parm

2018-02-19 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- include/media/v4l2-subdev.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index

[PATCHv3 02/10] v4l2-common: create v4l2_g/s_parm_cap helpers

2018-02-19 Thread Hans Verkuil
From: Hans Verkuil Create helpers to handle VIDIOC_G/S_PARM by querying the g/s_frame_interval v4l2_subdev ops. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-common.c | 48

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

2018-02-19 Thread Philipp Zabel
Hi Gustavo, On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote: > Hi all, > > I was just wondering about the status of this patch. It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR") in Hans' for-v4.17a branch:

[PATCHv3 03/10] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-02-19 Thread Hans Verkuil
From: Hans Verkuil Convert all g/s_parm calls to g/s_frame_interval. This allows us to remove the g/s_parm ops since those are a duplicate of g/s_frame_interval. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus

[PATCHv3 04/10] staging: atomisp: Kill subdev s_parm abuse

2018-02-19 Thread Hans Verkuil
From: Sakari Ailus Remove sensor driver's interface for setting the use case specific mode list as well as the mode lists that are related to other than CI_MODE_PREVIEW. This removes s_parm abuse in using driver specific values in

Re: [PATCH v2.1 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-02-19 Thread Hans Verkuil
On 02/19/2018 02:27 PM, Sakari Ailus wrote: > These sensor drivers have use case specific mode lists. There's no need > for this nor there is a standard API for selecting the mode list. Disable > configurations for non-preview modes until configuration selection is > improved so that all the

Re: Bug: Two device nodes created in /dev for a single UVC webcam

2018-02-19 Thread Kieran Bingham
Hi Alexandre, Thankyou for your bug report, On 17/02/18 20:47, Alexandre-Xavier Labonté-Lamoureux wrote: > Hi, > > I'm running Linux 4.9.0-5-amd64 on Debian. I built the drivers from > the latest git and installed the modules. Could you please be specific here? Are you referring to

[GIT PULL for 4.17] Sensor and lens driver patches

2018-02-19 Thread Sakari Ailus
Hi Mauro, Here's the first pile of sensor and lens driver patches for 4.17. The most noteworthy parts are perhaps - moving unmaintained imx074 and mt9t031 SoC camera drivers to staging in hope someone would start looking after them, - add DT bindings and driver upport for the bindings for

Re: [PATCHv2 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-02-19 Thread Sakari Ailus
Hi Mauro, On Fri, Feb 16, 2018 at 10:04:13AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 16 Feb 2018 12:12:20 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Wed, Feb 14, 2018 at 02:20:50PM -0200, Mauro Carvalho Chehab wrote: > > > Em Mon, 22 Jan 2018 13:31:20

[RFC PATCH] Add core tuner_standby op, use where needed

2018-02-19 Thread Hans Verkuil
The v4l2_subdev core s_power op was used to two different things: power on/off sensors or video decoders/encoders and to put a tuner in standby (and only the tuner). There is no 'tuner wakeup' op, that's done automatically when the tuner is accessed. The danger with calling (s_power, 0) to put a

Re: [PATCH v2.1 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-02-19 Thread Sakari Ailus
Hi Hans, On Mon, Feb 19, 2018 at 02:30:18PM +0100, Hans Verkuil wrote: > On 02/19/2018 02:27 PM, Sakari Ailus wrote: > > These sensor drivers have use case specific mode lists. There's no need > > for this nor there is a standard API for selecting the mode list. Disable > > configurations for

Re: [PATCH] media: imx.rst: Fix formatting errors

2018-02-19 Thread Philipp Zabel
On Fri, 2018-02-16 at 17:54 -0800, Steve Longerbeam wrote: > Fix a few formatting errors. > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp

[PATCHv3 01/15] vimc: fix control event handling

2018-02-19 Thread Hans Verkuil
The sensor subdev didn't handle control events. Add support for this. Found with v4l2-compliance. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/platform/vimc/vimc-common.c | 4 +++-

[PATCHv3 00/15] Media Controller compliance fixes

2018-02-19 Thread Hans Verkuil
From: Hans Verkuil Hi all, Here is v3 of this patch series fixing various MC compliance and documentation issues. Changes since v2: - I dropped "v4l2-ioctl.c: fix VIDIOC_DV_TIMINGS_CAP: don't clear pad" as it is already included in the pull request for the tda1997x

[GIT PULL for 4.17] IPU3 CIO2 patches

2018-02-19 Thread Sakari Ailus
Hi Mauro, Here's a bugfix and a switch for the SPDX tags for IPU3 CIO2 driver. Please pull. The following changes since commit 29422737017b866d4a51014cc7522fa3a99e8852: media: rc: get start time just before calling driver tx (2018-02-14 14:17:21 -0500) are available in the git repository

[PATCH v2.1 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-02-19 Thread Sakari Ailus
These sensor drivers have use case specific mode lists. There's no need for this nor there is a standard API for selecting the mode list. Disable configurations for non-preview modes until configuration selection is improved so that all the configurations are always usable. Signed-off-by: Sakari

Re: [PATCHv2 3/9] staging: atomisp: Kill subdev s_parm abuse

2018-02-19 Thread Hans Verkuil
On 02/16/2018 12:58 PM, Mauro Carvalho Chehab wrote: > Em Fri, 16 Feb 2018 11:04:36 +0200 > Sakari Ailus escreveu: > >> On Wed, Feb 14, 2018 at 02:14:30PM -0200, Mauro Carvalho Chehab wrote: >>> Sakari, >>> >>> Em Mon, 22 Jan 2018 13:31:19 +0100 >>> Hans Verkuil

Re: Bug: Two device nodes created in /dev for a single UVC webcam

2018-02-19 Thread Guennadi Liakhovetski
Hi Kieran, On Mon, 19 Feb 2018, Kieran Bingham wrote: > Hi Alexandre, > > Thankyou for your bug report, > > On 17/02/18 20:47, Alexandre-Xavier Labonté-Lamoureux wrote: > > Hi, > > > > I'm running Linux 4.9.0-5-amd64 on Debian. I built the drivers from > > the latest git and installed the

[PATCH 2/8] media: s5p-jpeg: Use bulk clk API

2018-02-19 Thread Maciej Purski
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk functions instead of iterating over an array of clks. Signed-off-by: Maciej Purski --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 45 -

[PATCH 8/8] [media] s5p-mfc: Use clk bulk API

2018-02-19 Thread Maciej Purski
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk functions instead of iterating over an array of clks. Signed-off-by: Maciej Purski --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 6 ++-- drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 41

[PATCH 6/8] drm/exynos/hdmi: Use clk bulk API

2018-02-19 Thread Maciej Purski
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk functions instead of iterating over an array of clks. Signed-off-by: Maciej Purski --- drivers/gpu/drm/exynos/exynos_hdmi.c | 97 ++-- 1 file changed, 27 insertions(+),

Re: Bug: Two device nodes created in /dev for a single UVC webcam

2018-02-19 Thread Laurent Pinchart
Hello, On Monday, 19 February 2018 15:58:40 EET Guennadi Liakhovetski wrote: > On Mon, 19 Feb 2018, Kieran Bingham wrote: > > On 17/02/18 20:47, Alexandre-Xavier Labonté-Lamoureux wrote: > >> Hi, > >> > >> I'm running Linux 4.9.0-5-amd64 on Debian. I built the drivers from > >> the latest git

Re: [PATCH 1/8] clk: Add clk_bulk_alloc functions

2018-02-19 Thread Robin Murphy
Hi Maciej, On 19/02/18 15:43, Maciej Purski wrote: When a driver is going to use clk_bulk_get() function, it has to initialize an array of clk_bulk_data, by filling its id fields. Add a new function to the core, which dynamically allocates clk_bulk_data array and fills its id fields. Add

[PATCH 1/8] clk: Add clk_bulk_alloc functions

2018-02-19 Thread Maciej Purski
When a driver is going to use clk_bulk_get() function, it has to initialize an array of clk_bulk_data, by filling its id fields. Add a new function to the core, which dynamically allocates clk_bulk_data array and fills its id fields. Add clk_bulk_free() function, which frees the array allocated

[PATCH v9 05/11] media: i2c: Copy ov772x soc_camera sensor driver

2018-02-19 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH 4/8] drm/exynos/dsi: Use clk bulk API

2018-02-19 Thread Maciej Purski
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk functions instead of iterating over an array of clks. In order to achieve consistency with other drivers, define clock names in driver's variants structures. Signed-off-by: Maciej Purski ---

[PATCH 3/8] drm/exynos/decon: Use clk bulk API

2018-02-19 Thread Maciej Purski
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk functions instead of iterating over an array of clks. Signed-off-by: Maciej Purski --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 50 --- 1 file changed, 15 insertions(+),

[PATCH] v4l2-compliance: Relax g/s_parm type check

2018-02-19 Thread Jacopo Mondi
Since commit commit 2e564ee56978874ddd4a8d061d37be088f130fd9 Author: Hans Verkuil vidioc-g-parm.rst: also allow _MPLANE buffer types V4L2 allows _MPLANE buffer types for capture/output on s/g_parm operations. Relax v4l2-compliance check to comply with this.

[PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

2018-02-19 Thread Jacopo Mondi
Add support to ov772x driver for frame intervals handling and enumeration. Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for 10, 15 and 30 frame per second rates. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart

[PATCH v9 09/11] media: i2c: tw9910: Remove soc_camera dependencies

2018-02-19 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v9 06/11] media: i2c: ov772x: Remove soc_camera dependencies

2018-02-19 Thread Jacopo Mondi
Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

Waiting for your Urgent Responds,

2018-02-19 Thread Mrs.Louisa Benicio
My Sincere Greetings, I am (Mrs.Louisa Benicio) I have decided to donate ($5.5million Dollars) to you / Motherless babies/ less privileged/ Churches/ Widows from what I have inherited from my late Husband because I am diagnosing of throat Cancer and hospitalize for 2 years and some months now. I

[RESEND PATCH 0/2] DW9807 DT binding and driver patches

2018-02-19 Thread Andy Yeh
From: Alan Chiang Hi Sakari and Tomasz, The two patches are the DT binding and driver for DW9807 VCM controller. Alan Chiang (2): media: dw9807: Add dw9807 vcm driver media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

[PATCH v9 03/11] media: platform: Add Renesas CEU driver

2018-02-19 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v9 02/11] include: media: Add Renesas CEU driver interface

2018-02-19 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

[PATCH v9 01/11] dt-bindings: media: Add Renesas CEU bindings

2018-02-19 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH v9 00/11] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-02-19 Thread Jacopo Mondi
Hello, finally I addressed Laurent's comment on ov772x frame rate handling, which I almost forgot about :) Also, Sergei reported that the ceu node name should be generic, so I changed it to "ceu: camera@e821". All patches but the trivial [11/11] one are now reviewed/acked. Hope this is

[PATCH v9 04/11] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-19 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

RE: i.MX53 using imx-media to capture analog video through ADV7180

2018-02-19 Thread Matthew Starr
On 02/16/2018 07:03 PM, Steve Longerbeam wrote: > On 02/14/2018 07:44 AM, Fabio Estevam wrote: > > [Adding Steve and Philipp in case they could provide some suggestions] > > > > On Wed, Feb 14, 2018 at 1:21 PM, Matthew Starr > wrote: > >> I have successfully modified device

Re: [PATCH v2] [media] Use common error handling code in 20 functions

2018-02-19 Thread Laurent Pinchart
Hello Markus, On Monday, 19 February 2018 20:11:56 EET SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 19 Feb 2018 18:50:40 +0100 > > Adjust jump targets so that a bit of exception handling can be better > reused at the end of these functions. > >

Re: [bug report] V4L/DVB (3420): Added iocls to configure VBI on tvp5150

2018-02-19 Thread Mauro Carvalho Chehab
Em Mon, 19 Feb 2018 17:27:52 +0300 Dan Carpenter escreveu: > [ This is obviously ancient code. It's probably fine. I've just been > going through all array overflow warnings recently. - dan ] > > Hello Mauro Carvalho Chehab, > > The patch 12db56071b47: "V4L/DVB

  1   2   >