Re: [PATCH v11 19/32] rcar-vin: add function to manipulate Gen3 chsel value

Hi Laurent, Thank you for your feedback. On 2018-03-02 13:31:47 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 2 March 2018 03:57:38 EET Niklas Söderlund wrote: > > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > > feature of

Re: [PATCH v11 28/32] rcar-vin: add link notify for Gen3

Hi Laurent, Thanks for your feedback. On 2018-03-02 14:00:19 +0200, Laurent Pinchart wrote: [snip] > > + > > + /* If any entity is in use don't allow link changes. */ > > + media_device_for_each_entity(entity, >mdev) > > + if (entity->use_count) > > + return

Re: [PATCH v11 12/32] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

Hi Laurent, Thanks for your comments. On 2018-03-02 12:48:55 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 2 March 2018 03:57:31 EET Niklas Söderlund wrote: > > There was never proper support in the VIN driver to deliver ALTERNATING > > field format to

[PATCH v3] media: siano: Fix coherent memory allocation failure on arm64

From: Tomoki Sekiyama On some architectures such as arm64, siano chip based TV-tuner USB devices are not recognized correctly due to coherent memory allocation failure with the following error: [ 663.556135] usbcore: deregistering interface driver smsusb [

[PATCH v3 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

From: Fabio Estevam Since commit 52e17089d185 ("media: imx: Don't initialize vars that won't be used") imx_csi_probe() fails to probe after propagating the devm_pinctrl_get_select_default() error. devm_pinctrl_get_select_default() may return -ENODEV when the CSI pinctrl

[PATCH v3 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

From: Gustavo A. R. Silva Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. The proper pointer to be passed as argument is pinctrl instead of priv->vdev. This issue was detected with the help of Coccinelle. Fixes: 52e17089d185 ("media: imx: Don't initialize vars

Re: [PATCH v11 17/32] rcar-vin: move media bus configuration to struct rvin_info

Hi Laurent, Thanks for your feedback. On 2018-03-02 13:26:58 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 2 March 2018 03:57:36 EET Niklas Söderlund wrote: > > Bus configuration will once the driver is extended to support Gen3 > > contain information

[PATCH 1/2] media: s5h1409: fix a typo on one of its enum values

There is a typo there: continous wer spelled incorrectly. Fix it with this script: for i in $(git grep -l S5H1409_MPEGTIMING_CONTINOUS_NONINVERTING_CLOCK); do sed s,S5H1409_MPEGTIMING_CONTINOUS_NONINVERTING_CLOCK,S5H1409_MPEGTIMING_CONTINUOUS_NONINVERTING_CLOCK,g -i $i done

[PATCH 2/2] media: em28xx-dvb: do some coding style improvements

As we're touching a lot on this file, let's solve several Coding Style issues there using checkpatch --fix-inline --strict, and manually adjusting the results. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-dvb.c | 194

Re: [PATCH v11 15/32] rcar-vin: break out format alignment and checking

Hi Laurent, Thanks for your feedback. On 2018-03-02 11:53:54 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 2 March 2018 03:57:34 EET Niklas Söderlund wrote: > > Part of the format alignment and checking can be shared with the Gen3 > > format handling.

Re: [PATCH v11 22/32] rcar-vin: force default colorspace for media centric mode

Hi Laurent, Thanks for your feedback. On 2018-03-02 11:59:14 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 2 March 2018 03:57:41 EET Niklas Söderlund wrote: > > When the VIN driver is running in media centric mode (on Gen3) the > > colorspace is not

Re: [PATCH v11 16/32] rcar-vin: read subdevice format for crop only when needed

Hi Laurent, Thanks for your feedback. On 2018-03-02 13:06:27 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 2 March 2018 03:57:35 EET Niklas Söderlund wrote: > > Instead of caching the subdevice format each time the video device > > format is set read

Re: [PATCH 5/8] media: em28xx: adjust I2C timeout according with I2C speed

Em Fri, 2 Mar 2018 16:34:46 -0300 Mauro Carvalho Chehab escreveu: > + switch (dev->i2c_speed & 0x03) { > + case EM28XX_I2C_FREQ_25_KHZ: > + return time += 4; /* Assume 4 ms for transfers */ > + break; This is obviously

[PATCH] staging: media: Remove unnecessary semicolon

Remove unnecessary semicolon found using semicolon.cocci Coccinelle script. Signed-off-by: Arushi Singhal --- .../media/atomisp/pci/atomisp2/css2400/runtime/frame/src/frame.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] media: siano: Fix coherent memory allocation failure on arm64

Hi Tomoki, Em Sat, 3 Mar 2018 21:20:17 +0900 tomoki.sekiy...@gmail.com escreveu: > From: Tomoki Sekiyama > > On some architectures such as arm64, siano chip based TV-tuner > USB devices are not recognized correctly due to coherent memory > allocation failure with

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Mar 4 05:00:11 CET 2018 media-tree git hash:e3e389f931a14ddf43089c7db92fc5d74edf93a4 media_build

[PATCH AUTOSEL for 4.15 005/102] video/hdmi: Allow "empty" HDMI infoframes

From: Ville Syrjälä [ Upstream commit 593f4b19a094c4426bd1e1e3cbab87a48bd13c71 ] HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to transmit the

Re: [Outreachy kernel] [PATCH] staging: media: Remove unnecessary semicolon

On Sun, 4 Mar 2018, Arushi Singhal wrote: > Remove unnecessary semicolon found using semicolon.cocci Coccinelle > script. > > Signed-off-by: Arushi Singhal Acked-by: Julia Lawall > --- >

[PATCH 09/11] media: em28xx-i2c: fix most coding style issues

There are a number of coding style issues at em28xx-i2c. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 11/11] media: em28xx-video: fix most coding style issues

There are a number of coding style issues at em28xx-video. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 05/11] media: em28xx-camera: fix coding style issues

There are some coding style issues at em28xx-camera. Fix them, by using checkpatch in strict mode to point for it. Automatic fixes with --fix-inplace were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-camera.c |

[PATCH 00/11] em28xx: coding style improvements

As there are significant changes on em28xx-cards and em28xx-dvb, take some time to solve coding style issues there. This series contain only "cosmetic" changes, although there is a non-trivial change at em28xx-cards, making its probe function easier to read. Anyway, no behavior changes should be

[PATCH 04/11] media: em28xx-audio: fix coding style issues

There are a number of coding style issues at em28xx-audio. Fix them, by using checkpatch in strict mode to point for it. Automatic fixes with --fix-inplace were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 07/11] media: em28xx-cards: rework the em28xx probing code

There is a complex loop there with identifies the em28xx endpoints. It has lots of identations inside, and big names, making harder to understand. Simplify it by moving the main logic into a static function. While here, rename "interface" var to "intf". Signed-off-by: Mauro Carvalho Chehab

[PATCH 06/11] media: em28xx-cards: fix most coding style issues

There are a number of coding style issues, pointed by checkpatch on strict mode. Fix the ones that don't require code refactor here. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c | 305 +++- 1 file

[PATCH 03/11] media: em28xx-reg.h: Fix coding style issues

Use BIT() macros and fix one comment that is not following the Kernel coding style. It should be noticed that the registers bit masks should be casted to unsigned char, as, otherwise, it would produce warnings like: drivers/media/usb/em28xx/em28xx-cards.c:81:33: warning: large integer

[PATCH 02/11] em28xx.h: Fix most coding style issues

There used to have a lot of coding style issues there. The ones detected by checkpatch, in strict mode, got fixed. Still, we need to work more on it, in order to document all struct fields using kernel-doc macros, but this will be done on some future patch. Signed-off-by: Mauro Carvalho Chehab

[PATCH 10/11] media: em28xx-input: fix most coding style issues

There are a number of coding style issues at em28xx-input. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 01/11] em28xx: Add SPDX license tags where needed

Most of the files there are missing a SPDX license tag. Add. While here fix some DRIVER_LICENSE macro in order to reflect the source file license, as some of the headers are GPL v2 only. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-audio.c

[PATCH 08/11] media: em28xx-core: fix most coding style issues

There are a number of coding style issues at em28xx-core. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH AUTOSEL for 4.14 03/84] video/hdmi: Allow "empty" HDMI infoframes

From: Ville Syrjälä [ Upstream commit 593f4b19a094c4426bd1e1e3cbab87a48bd13c71 ] HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to transmit the

[PATCH AUTOSEL for 4.4 085/115] video/hdmi: Allow "empty" HDMI infoframes

From: Ville Syrjälä [ Upstream commit 593f4b19a094c4426bd1e1e3cbab87a48bd13c71 ] HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to transmit the

[PATCH AUTOSEL for 4.9 172/219] video/hdmi: Allow "empty" HDMI infoframes

From: Ville Syrjälä [ Upstream commit 593f4b19a094c4426bd1e1e3cbab87a48bd13c71 ] HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to transmit the

[no subject]

hi My name is Vanessa Ali. a France Nationality, I am a widow, currently hospitalized due to cancer illness . Meanwhile, I have decided to donate my fund to you as a reliable individual that will use this money wisely, €2,800.000 Million Euros. to help the poor and less privileged. So if you are

[GIT PULL for v4.16-rc4] media fixes

Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.16-3 For: - some build fixes with randconfigs; - a fix at m88ds3103 to prevent an OOPS if the chip doesn't provide a right version during probe (with can happen if the hardware

[PATCH v2 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

From: Gustavo A. R. Silva Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. The proper pointer to be passed as argument is pinctrl instead of priv->vdev. This issue was detected with the help of Coccinelle. Fixes: 52e17089d185 ("media: imx: Don't initialize vars

[PATCH v2 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

From: Fabio Estevam Since commit 52e17089d185 ("media: imx: Don't initialize vars that won't be used") imx_csi_probe() fails to probe after propagating the devm_pinctrl_get_select_default() error. devm_pinctrl_get_select_default() may return -ENODEV when the CSI pinctrl

[PATCH v2] media: siano: Fix coherent memory allocation failure on arm64

From: Tomoki Sekiyama On some architectures such as arm64, siano chip based TV-tuner USB devices are not recognized correctly due to coherent memory allocation failure with the following error: [ 663.556135] usbcore: deregistering interface driver smsusb [