Re: [PATCH v5 02/16] media: doc: add document for rkisp1 meta buffer format

Hi Hans, 2018-02-06 22:27 GMT+08:00 Hans Verkuil : > On 12/29/17 08:52, Shunqian Zheng wrote: >> From: Jacob Chen >> >> This commit add docuemnt for rkisp1 meta buffer format >> >> Signed-off-by: Jacob Chen >> --- >>

Re: [PATCH] media: ov5640: fix get_/set_fmt colorspace related fields

Hi Sakari, This is the right one and it's OK to swap the lines for local variables, I'll keep this in mind for next changes. Best regards, Hugues. On 03/07/2018 09:13 AM, Sakari Ailus wrote: > Hi Hugues, > > On Tue, Mar 06, 2018 at 06:04:39PM +0100, Hugues Fruchet wrote: >> Fix set of missing

[PATCH v6 01/17] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format

From: Shunqian Zheng Add the Rockchip ISP1 specific processing parameter format V4L2_META_FMT_RK_ISP1_PARAMS and metadata format V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen

Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

Hi Hans, 2018-02-07 20:00 GMT+08:00 Hans Verkuil : > On 12/29/17 08:52, Shunqian Zheng wrote: >> From: Jeffy Chen >> >> Add the header for userspace > > General note: I saw four cases where this documentation referred to the > datasheet. Three

[PATCH v6 08/17] media: rkisp1: add capture device driver

From: Jacob Chen This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from ISP1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong

[PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver

From: Jacob Chen Add the core driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen

[PATCH v6 10/17] dt-bindings: Document the Rockchip ISP1 bindings

From: Jacob Chen Add DT bindings documentation for Rockchip ISP1 Signed-off-by: Jacob Chen Reviewed-by: Rob Herring --- .../devicetree/bindings/media/rockchip-isp1.txt| 69 ++ 1 file changed, 69

[PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen

[PATCH v6 12/17] ARM: dts: rockchip: add isp node for rk3288

From: Jacob Chen rk3288 have a Embedded 13M ISP Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

Re: [PATCH v2] i2c: adv748x: afe: fix sparse warning

On Thu, Mar 8, 2018 at 12:02 AM, Niklas Söderlund wrote: > CC linux-media. > > It's linux-media@vger.kernel.org not linux-me...@vger.kernel.or, sorry > for the noise. > > On 2018-03-07 23:58:16 +0100, Niklas Söderlund wrote: >> This fixes the following sparse

[PATCH v6 15/17] arm64: dts: rockchip: add isp0 node for rk3399

From: Shunqian Zheng rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 15

[PATCH v6 13/17] ARM: dts: rockchip: add rx0 mipi-phy for rk3288

From: Jacob Chen It's a Designware MIPI D-PHY, used by ISP in rk3288. Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v6 11/17] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

From: Jacob Chen Add DT bindings documentation for Rockchip MIPI D-PHY RX Signed-off-by: Jacob Chen Reviewed-by: Rob Herring --- .../bindings/media/rockchip-mipi-dphy.txt | 90 ++ 1 file

[PATCH] media: em28xx-cards: fix em28xx_duplicate_dev()

There is a double sizeof() typo here so we don't duplicate the struct properly. Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality") Signed-off-by: Dan Carpenter diff --git a/drivers/media/usb/em28xx/em28xx-cards.c

[PATCH v6 16/17] arm64: dts: rockchip: add rx0 mipi-phy for rk3399

From: Shunqian Zheng It's a Designware MIPI D-PHY, used for ISP0 in rk3399. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++ 1 file changed, 10

[PATCH v6 14/17] ARM: dts: rockchip: Add dts mipi-dphy TXRX1 node for rk3288

From: Wen Nuan Change-Id: I0b6122b2b34ae0f24f0d4ac1bbe6018cac4e Signed-off-by: Wen Nuan --- arch/arm/boot/dts/rk3288.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v6 17/17] MAINTAINERS: add entry for Rockchip ISP1 driver

From: Jacob Chen Add MAINTAINERS entry for the rockchip isp1 driver. This driver is maintained by rockchip officially and it will be used for rockchip SoC on all linux-kernel based OS. Signed-off-by: Jacob Chen --- MAINTAINERS | 10

[PATCH v6 03/17] media: rkisp1: Add user space ABI definitions

From: Jeffy Chen Add the header for userspace Signed-off-by: Jeffy Chen Signed-off-by: Jacob Chen --- include/uapi/linux/rkisp1-config.h | 798 + 1 file changed, 798

[PATCH v6 04/17] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

From: Jacob Chen This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa ---

[PATCH v6 00/17] Rockchip ISP1 Driver

From: Jacob Chen changes in V6: - add mipi txrx phy support - remove bool and enum from uapi header - add buf_prepare op - correct some spelling problems - return all queued buffers when starting stream failed changes in V5: Sync with local changes, - fix

[PATCH v6 07/17] media: rkisp1: add ISP1 params driver

From: Jacob Chen Add the output video driver that accept params from userspace. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen

[PATCH v6 06/17] media: rkisp1: add ISP1 statistics driver

From: Jacob Chen Add the capture video driver for rockchip isp1 statistics block. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob

[PATCH] media: ov5640: fix frame interval enumeration

Driver must reject frame interval enumeration of unsupported resolution. This was detected by v4l2-compliance format ioctl test: v4l2-compliance Format ioctls: info: found 2 frameintervals for pixel format 4745504a and size 176x144 fail: v4l2-test-formats.cpp(123):

[PATCH v6 02/17] media: doc: add document for rkisp1 meta buffer format

From: Jacob Chen This commit add docuemnt for rkisp1 meta buffer format Signed-off-by: Jacob Chen Acked-by: Hans Verkuil --- Documentation/media/uapi/v4l/meta-formats.rst| 2 ++

Re: [RFCv4,19/21] media: vim2m: add request support

Hi Paul! Thanks a lot for taking the time to try this! I am also working on getting it to work with an actual driver, but you apparently found rough edges that I missed. On Thu, Mar 8, 2018 at 1:37 AM, Paul Kocialkowski wrote: > Hi, > > First off, I'd like to take

Re: [RFCv4,13/21] media: videobuf2-v4l2: support for requests

On Thu, Mar 8, 2018 at 1:50 AM, Paul Kocialkowski wrote: > Hi, > > On Tue, 2018-02-20 at 13:44 +0900, Alexandre Courbot wrote: >> Add a new vb2_qbuf_request() (a request-aware version of vb2_qbuf()) >> that request-aware drivers can call to queue a buffer into a

Re: [PATCH] media: ov5640: fix frame interval enumeration

Em Thu, 8 Mar 2018 10:01:59 +0100 Hugues Fruchet escreveu: > Driver must reject frame interval enumeration of unsupported resolution. > This was detected by v4l2-compliance format ioctl test: > v4l2-compliance Format ioctls: > info: found 2 frameintervals for pixel

[PATCH v2] media: stm32-dcmi: rework overrun/error case

Do not stop/restart dma on overrun or errors. Dma will be restarted on current frame transfer completion. Frame transfer completion is ensured even if overrun or error occurs by DCMI continuous capture mode which restarts data transfer at next frame sync. Do no warn on overrun while in irq thread,

[PATCH v2] media: rc: add new imon protocol decoder and encoder

This makes it possible to use the various iMON remotes with any raw IR RC device. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 9 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/ir-imon-decoder.c | 193

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > SoC. > > Wiki Pages: > http://opensource.rock-chips.com/wiki_Rockchip-isp1 > > The deprecated g_mbus_config op is not dropped in V6 because i am

[PATCH v2 1/3] media: vb2-core: vb2_buffer_done: consolidate docs

Documentation about what start_streaming() should do on failure are scattered in two places and mostly duplicated, so consolidate them in one of the two places. Signed-off-by: Luca Ceresoli Cc: Laurent Pinchart Cc: Pawel Osciak

[PATCH v2 2/3] media: vb2-core: document the REQUEUEING state

VB2_BUF_STATE_REQUEUEING is accepted by vb2_buffer_done() but not documented, so add it along with notes about calls in interrupt context. Signed-off-by: Luca Ceresoli Cc: Laurent Pinchart Cc: Pawel Osciak Cc: Marek

[PATCH v2 3/3] media: vb2-core: vb2_ops: document non-interrupt-context calling

Driver writers can benefit in knowing if/when callbacks are called in interrupt context. But it is not completely obvious here, so document it. Signed-off-by: Luca Ceresoli Cc: Laurent Pinchart Cc: Pawel Osciak Cc:

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

On Thu, Mar 8, 2018 at 6:47 PM, Jacob Chen wrote: > From: Jacob Chen > > changes in V6: > - add mipi txrx phy support > - remove bool and enum from uapi header > - add buf_prepare op > - correct some spelling problems > - return all

Re: [PATCH] media: ov5640: fix frame interval enumeration

Em Thu, 8 Mar 2018 07:39:09 -0300 Mauro Carvalho Chehab escreveu: > Also, if this function starts returning NULL, I suspect that you also > need to change ov5640_s_frame_interval(), as currently it is called > at ov5640_s_frame_interval() as: > > sensor->current_mode =

Re: [PATCH] media: em28xx-cards: fix em28xx_duplicate_dev()

Hi Dan, On 2018-03-08 03:31, Dan Carpenter wrote: > There is a double sizeof() typo here so we don't duplicate the struct > properly. > > Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner > functionality") > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH] media: ov5640: fix frame interval enumeration

Hi Mauro, Thanks for review, I've just sent a v2 to rearrange code as per your suggestion and also add a NULL test case for mode even if this should not happen. Best regards, Hugues. On 03/08/2018 11:46 AM, Mauro Carvalho Chehab wrote: > Em Thu, 8 Mar 2018 07:39:09 -0300 > Mauro Carvalho

[PATCH v2] media: ov5640: fix frame interval enumeration

Driver must reject frame interval enumeration of unsupported resolution. This was detected by v4l2-compliance format ioctl test: v4l2-compliance Format ioctls: info: found 2 frameintervals for pixel format 4745504a and size 176x144 fail: v4l2-test-formats.cpp(123):

[PATCH RESEND 0/2 v6] uvcvideo: asynchronous controls

This is an update of the two patches, adding asynchronous control support to the uvcvideo driver. If a control is sent, while the camera is still processing an earlier control, it will generate a protocol STALL condition on the control pipe. Thanks Guennadi Guennadi Liakhovetski (2): uvcvideo:

Re: Patch review

Em Wed, 28 Feb 2018 17:21:27 +0200 Laurent Pinchart escreveu: > Hi Guennadi, > > On Wednesday, 28 February 2018 17:07:00 EET Guennadi Liakhovetski wrote: > > Hi, > > > > I know the "development process and responsibilities" was the main topic > > during the

[GIT PULL FOR v4.17] RC imon and sunxi fixes

Hi Mauro, There is a new driver for older, raw IR imon devices and a raw decoder for the imon protocol for imon pad remotes. Thanks, Sean The following changes since commit 50718972f555cc7a061162003f1bc59ef6635db1: media: em28xx-cards: fix em28xx_duplicate_dev() (2018-03-08 05:23:45 -0500)

[PATCH] media: dvb-usb-v2: stop using coherent memory for URBs

There's no need to use coherent buffers there. So, let the DVB core do the allocation. That should give some performance gain outside x86. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/dvb-usb-v2/usb_urb.c | 17 - 1 file changed, 4

[PATCH v5 1/2] media: dt-bindings: Add bindings for panasonic,amg88xx

Define the device tree bindings for the panasonic,amg88xx i2c video driver. Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Matt Ranostay --- .../bindings/media/i2c/panasonic,amg88xx.txt | 19 +++ 1

[PATCH v5 2/2] media: video-i2c: add video-i2c driver

There are several thermal sensors that only have a low-speed bus interface but output valid video data. This patchset enables support for the AMG88xx "Grid-Eye" sensor family. Signed-off-by: Matt Ranostay --- MAINTAINERS | 6 +

[PATCH v5 0/2] media: video-i2c: add video-i2c driver support

Add support for video-i2c polling driver Changes from v1: * Switch to SPDX tags versus GPLv2 license text * Remove unneeded zeroing of data structures * Add video_i2c_try_fmt_vid_cap call in video_i2c_s_fmt_vid_cap function Changes from v2: * Add missing linux/kthread.h include that broke x86_64

Re: [PATCH] media: rc: meson-ir: add timeout on idle

Hi Matthias, On Tue, Mar 06, 2018 at 06:41:22PM +0100, Matthias Reichl wrote: > Meson doesn't seem to be able to generate timeout events > in hardware. So install a software timer to generate the > timeout events required by the decoders to prevent > "ghost keypresses". > > Signed-off-by:

[PATCH 2/2] media: dvbsky: fix driver unregister logic

There's an user-after-free there, if the frontend is attached via the new I2C way: [ 112.539806] usbcore: deregistering interface driver dvb_usb_dvbsky [ 112.568489] == [ 112.568600] BUG: KASAN: use-after-free in

[PATCH 1/2] media: dvbsky: use the new dvb_module_probe() API

Instead of repeating countless times a complex logic, use the new dvb_module_probe()/dvb_module_release(), simplifying the module. That reduced about 15% at the module's size: textdata bss dec hex filename 70831108 128203200b

[PATCH RESEND 2/2 v6] uvcvideo: handle control pipe protocol STALLs

When a command ends up in a STALL on the control pipe, use the Request Error Code control to provide a more precise error information to the user. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_video.c | 59

[PATCH RESEND 1/2 v6] uvcvideo: send a control event when a Control Change interrupt arrives

UVC defines a method of handling asynchronous controls, which sends a USB packet over the interrupt pipe. This patch implements support for such packets by sending a control event to the user. Since this can involve USB traffic and, therefore, scheduling, this has to be done in a work queue.

Re: [PATCH v9 2/2] media: V3s: Add support for Allwinner CSI.

Hi, On Tue, 6 Mar 2018 17:14:18 +0200 Sakari Ailus wrote: > Hi Yong, > > Thanks for the patchset; please see my comments below. > > On Tue, Mar 06, 2018 at 10:16:02AM +0800, Yong Deng wrote: > > Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Mar 9 05:00:10 CET 2018 media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e media_build

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Baruch, 2018-03-09 12:09 GMT+08:00 Baruch Siach : > Hi Jacob, > > On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: >> 2018-03-08 20:02 GMT+08:00 Baruch Siach : >> > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: >> >> This patch

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, On Fri, Mar 09, 2018 at 01:05:28PM +0800, Jacob Chen wrote: > 2018-03-09 12:09 GMT+08:00 Baruch Siach : > > On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > >> 2018-03-08 20:02 GMT+08:00 Baruch Siach : > >> > On Thu, Mar 08, 2018 at

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Baruch, 2018-03-08 20:02 GMT+08:00 Baruch Siach : > Hi Jacob, > > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: >> This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 >> SoC. >> >> Wiki Pages: >>

Re: [PATCH] dvb: Save port number and provide sysfs attributes to pass values to udev

Mauro Carvalho Chehab wrote: > > + dvb_class->dev_groups = dvb_class_groups, > > dvb_class->dev_uevent = dvb_uevent; > > dvb_class->devnode = dvb_devnode; > > return 0; > > The patch itself looks good, but I'm not seeing any documentation. I should probably

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > 2018-03-08 20:02 GMT+08:00 Baruch Siach : > > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > >> This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > >> SoC. > >> > >>

[PATCH v8] media: imx258: Add imx258 camera sensor driver

Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Jason Chen Signed-off-by: Alan Chiang --- since v2: -- Update the streaming function