[PATCH 1/4] dma-buf: add optional invalidate_mappings callback

Each importer can now provide an invalidate_mappings callback. This allows the exporter to provide the mappings without the need to pin the backing store. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 25 +

[PATCH 10/11] media: vsp1: Support Interlaced display pipelines

Calculate the top and bottom fields for the interlaced frames and utilise the extended display list command feature to implement the auto-field operations. This allows the DU to update the VSP2 registers dynamically based upon the currently processing field. Signed-off-by: Kieran Bingham

[PATCH 09/11] media: vsp1: Provide support for extended command pools

VSPD and VSP-DL devices can provide extended display lists supporting extended command display list objects. These extended commands require their own dma memory areas for a header and body specific to the command type. Implement a command pool to allocate all necessary memory in a single DMA

[PATCH 00/11] R-Car DU Interlaced support through VSP1

The Gen3 R-Car DU devices make use of the VSP to handle frame processing. In this series we implement support for handling interlaced pipelines by using the auto-fld feature of the VSP hardware. The implementation is preceded by some cleanup work and refactoring, through patches 1 to 6. These

[PATCH 4/4] drm/amdgpu: add independent DMA-buf import

Instead of relying on the DRM functions just implement our own import functions. This adds support for taking care of unpinned DMA-buf. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 64 +--

RFC: unpinned DMA-buf exporting

This set of patches adds an option invalidate_mappings callback to each DMA-buf attachment which can be filled in by the importer. This callback allows the exporter to provided the DMA-buf content without pinning it. The reservation objects lock acts as synchronization point for buffer moves

[PATCH 2/4] drm/ttm: keep a reference to transfer pipelined BOs

Make sure the transfered BO is never destroy before the transfer BO. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 50 +++ 1 file changed, 30 insertions(+), 20 deletions(-) diff --git

[PATCH 1/4] dma-buf: add optional invalidate_mappings callback

Each importer can now provide an invalidate_mappings callback. This allows the exporter to provide the mappings without the need to pin the backing store. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 25 +

[PATCH 3/4] drm/amdgpu: add independent DMA-buf export

Instead of relying on the DRM functions just implement our own export functions. This adds support for taking care of unpinned DMA-buf. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c|

[PATCH 06/11] media: vsp1: Provide VSP1 feature helper macro

The VSP1 devices define their specific capabilities through features marked in their device info structure. Various parts of the code read this info structure to infer if the features are available. Wrap this into a more readable vsp1_feature(vsp1, f) macro to ensure that usage is consistent

[PATCH 07/11] media: vsp1: Use header display lists for all WPF outputs linked to the DU

Header mode display lists are now supported on all WPF outputs. To support extended headers and auto-fld capabilities for interlaced mode handling only header mode display lists can be used. Disable the headerless display list configuration, and remove the dead code. Signed-off-by: Kieran

[PATCH 02/11] media: vsp1: use kernel __packed for structures

The kernel provides a __packed definition to abstract away from the compiler specific attributes tag. Convert all packed structures in VSP1 to use it. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 6 +++--- 1 file changed, 3

[PATCH 03/11] media: vsp1: Rename dl_child to dl_next

Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display list chain referencing the nodes as children, when in reality they are siblings. Update the terminology to 'dl_next' to be consistent with the vsp1_video_pipeline_run() usage. Signed-off-by: Kieran Bingham

[PATCH 01/11] media: vsp1: drm: Fix minor grammar error

The pixel format is 'unsupported'. Fix the small debug message which incorrectly declares this. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3] [media] Use common error handling code in 19 functions

From: Markus Elfring Date: Fri, 9 Mar 2018 21:00:12 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of these functions. This issue was partly detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 08/11] media: vsp1: Add support for extended display list headers

Extended display list headers allow pre and post command lists to be executed by the VSP pipeline. This provides the base support for features such as AUTO_FLD (for interlaced support) and AUTO_DISP (for supporting continuous camera preview pipelines. Signed-off-by: Kieran Bingham

[PATCH 11/11] drm: rcar-du: Support interlaced video output through vsp1

Use the newly exposed VSP1 interface to enable interlaced frame support through the VSP1 lif pipelines. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 + drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 3 +++ 2 files changed, 4

[PATCH 04/11] media: vsp1: Remove unused display list structure field

The vsp1 reference in the vsp1_dl_body structure is not used. Remove it. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c

Re: [PATCH v8 07/13] [media] vb2: mark codec drivers as unordered

Le vendredi 09 mars 2018 à 14:49 -0300, Gustavo Padovan a écrit : > From: Gustavo Padovan > > In preparation to have full support to explicit fence we are > marking codec as non-ordered preventively. It is easier and safer from an The usage of "codec" is soso

Re: [PATCH v5 0/2] media: video-i2c: add video-i2c driver support

On Fri, Mar 9, 2018 at 4:45 AM, Hans Verkuil wrote: > Hi Matt, > > This is looking good. One request before I merge: please run the > 'v4l2-compliance -s -f' utility and post the result here. > > I don't think I've asked you to do that before (or if I did, I couldn't > find it

[PATCH 2/3] rcar-vin: allocate a scratch buffer at stream start

Before starting capturing allocate a scratch buffer which can be used by the driver to give to the hardware if no buffers are available from userspace. The buffer is not used in this patch but prepares for future refactoring where the scratch buffer can be used to avoid the need to fallback on

[PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

This is an error from when the driver where converted from soc-camera. There is absolutely no gain to check the state variable two times to be extra sure if the hardware is stopped. Signed-off-by: Niklas Söderlund ---

[PATCH 0/3] rcar-vin: always run in continues mode

Hi, This series reworks the R-Car VIN driver to only run using its continues capture mode. This improves performance a lot when userspace struggles to keep up and queue buffers as fast as the VIN driver consumes them. The solution to always be able to run in continues is to introduce a

[PATCH 3/3] rcar-vin: use scratch buffer and always run in continuous mode

Instead of switching capture mode depending on how many buffers are available use a scratch buffer and always run in continuous mode. By using a scratch buffer the responsiveness of the capture loop is increased as it can keep running even if there are no buffers available from userspace. As soon

[RFC 8/8] vb2: Add support for requests

Associate a buffer to a request when it is queued and disassociate when it is done. Signed-off-by: Sakari Ailus --- drivers/media/common/videobuf2/videobuf2-core.c | 43 - drivers/media/common/videobuf2/videobuf2-v4l2.c | 24 +-

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 10 05:00:13 CET 2018 media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e media_build

[RFC 1/8] media: Support variable size IOCTL arguments

Maintain a list of supported IOCTL argument sizes and allow only those in the list. As an additional bonus, IOCTL handlers will be able to check whether the caller actually set (using the argument size) the field vs. assigning it to zero. Separate macro can be provided for that. This will be

[RFC 5/8] videodev2.h: Add request_fd field to v4l2_buffer

From: Hans Verkuil When queuing buffers allow for passing the request that should be associated with this buffer. Signed-off-by: Hans Verkuil [acour...@chromium.org: make request ID 32-bit] Signed-off-by: Alexandre Courbot

[RFC 0/8] Preparing the request API

Hi folks, This preliminary RFC patchset prepares for the request API. What's new here is support for binding arbitrary configuration or resources to requests. There are a few new concepts here: Class --- a type of configuration or resource a driver (or e.g. the V4L2 framework) can attach to a

[RFC 2/8] media: Add request API

From: Laurent Pinchart The request API allows bundling media device parameters with request objects and applying them atomically, either synchronously or asynchronously. Signed-off-by: Laurent Pinchart

[RFC 4/8] media: Add support for request classes and objects

Media requests may contain multiple objects (e.g. V4L2 format or video buffers). The media request objects support managing these in a generic way. The classes are effectively a helper for managing certain kinds of objects. Objects may be sticky (the previous configuration matters, e.g. V4L2

[RFC 6/8] videodev2.h: add request_fd field to v4l2_ext_controls

From: Alexandre Courbot Allow to specify a request to be used with the S_EXT_CTRLS and G_EXT_CTRLS operations. Signed-off-by: Alexandre Courbot [Sakari Ailus: reserved no longer an array, add compat32 code] Signed-off-by: Sakari Ailus

[RFC 7/8] staging: media: atomisp: Remove v4l2_buffer.reserved2 field hack

The atomisp driver used to use the reserved2 field in struct v4l2_buffer for picking a particular ISP configuration for the buffer. As reserved2 field will have new use soon, remove this hack. Signed-off-by: Sakari Ailus ---

[RFC 3/8] media: Support polling for completed requests

Implement poll for events. POLLPRI is used to notify the user an event is complete. Signed-off-by: Sakari Ailus --- drivers/media/media-device.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/media-device.c

[PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

From: Florent Revest This patch adds a "sunxi-cedrus" v4l2 m2m decoder driver for Allwinner's Video Processing Unit. This VPU has a low-level interface which requires manual registers writing for frame headers. Hence, it depends on the Request API to

[PATCH 3/9] v4l: Add sunxi Video Engine pixel format

From: Florent Revest Add support for the allwinner's proprietary pixel format described in details here: http://linux-sunxi.org/File:Ve_tile_format_v1.pdf This format is similar to V4L2_PIX_FMT_NV12M but the planes are divided in tiles of 32x32px.

[PATCH 7/9] ARM: dts: sun5i: Use video-engine node

From: Florent Revest Now that we have a driver matching "allwinner,sun4i-a10-video-engine" we can load it. The "video-engine" node depends on the new sunxi-ng's CCU clock and reset bindings. This patch also includes a ve_reserved DMA pool for videobuf2 buffer

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Tomasz, My apology. Actually I obsoleted this [V8] https://patchwork.linuxtv.org/patch/47768/ just after submitted. Since I found few comments as what you pointed below were not addressed yet. Didn’t expect you to check this. I shall send an email to notify you two the obsolete state as

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

On Fri, Mar 9, 2018 at 7:46 PM, Yeh, Andy wrote: > Hi Tomasz, > > My apology. Actually I obsoleted this [V8] > https://patchwork.linuxtv.org/patch/47768/ just after submitted. > Since I found few comments as what you pointed below were not addressed yet. > Didn’t expect you

Re: [PATCH v4 1/2] [media] Add Rockchip RK1608 driver

Hi Leo, Some more review comments below: On 08/03/18 07:38, Wen Nuan wrote: > From: Leo Wen > > Rk1608 is used as a PreISP to link on Soc, which mainly has two functions. > One is to download the firmware of RK1608, and the other is to match the > extra sensor such as

Re: [PATCH 1/2] usbtv: Use same decoder sequence as Windows driver

On 27/02/18 23:35, Hugo "Bonstra" Grostabussiat wrote: > Le 26/02/2018 à 15:12, Hans Verkuil a écrit : >> Thanks for this patch, but I am a bit hesitant to apply it. Did you test >> that PAL and NTSC still work after this change? > > I did test with both a PAL and a NTSC source before submitting

[PATCH 2/9] media: videobuf2-v4l2: Copy planes when needed in request qbuf

Multiplanar formats require an extra planes array in their buffers, that is copied from userspace by the video_usercopy function prior to dispatching the ioctl request. This wrapper also frees the allocated planes array after the ioctl handler has returned. In the context of the V4L2 request API,

[PATCH 4/9] v4l: Add MPEG2 low-level decoder API control

From: Florent Revest This control is to be used with the new low-level decoder API for MPEG2 to provide additional parameters for the hardware that cannot parse the input stream. Signed-off-by: Florent Revest ---

[PATCH 8/9] ARM: dts: sun8i: add video engine support for A33

From: Icenowy Zheng A33 has a video engine just like the one in A10. Add the support for it in the device tree. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-a33.dtsi | 39 +++ 1 file changed, 39 insertions(+)

Re: [PATCH 03/12] media: ov5640: Don't force the auto exposure state at start time

On Fri, Mar 02, 2018 at 03:34:51PM +0100, Maxime Ripard wrote: > The sensor needs to have the auto exposure stopped while changing mode. > However, when the new mode is set, the driver will force the auto exposure > on, disregarding whether the control has been changed or not. > > Bypass the

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Understood. Thank you Tomasz too. -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Friday, March 9, 2018 6:48 PM To: Yeh, Andy Cc: Sakari Ailus ; Linux Media Mailing List ; Chen, JasonX

Re: [PATCH v2] V4L2 SDR: Add Real U8 format (V4L2_SDR_FMT_RU8)

Hi Bertold, I'm going through old patches in my TODO list and found this one. It clearly fell through the cracks, for which I apologize. The problem with this patch is that there is no kernel driver that supports this format. The general policy is that we don't add formats unless some driver

[PATCH 9/9] ARM: dts: sun7i: Add video engine support for the A20

From: Thomas van Kleef The A20 has a video engine similare to the one in the A13. Add the device node in the A20. Signed-off-by: Thomas van Kleef Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun7i-a20.dtsi | 47

[PATCH 6/9] sunxi-cedrus: Add device tree binding document

From: Florent Revest Device Tree bindings for the Allwinner's video engine Signed-off-by: Florent Revest --- .../devicetree/bindings/media/sunxi-cedrus.txt | 44 ++ 1 file changed, 44 insertions(+)

[GIT PULL FOR v4.17] cec: add error injection support + other improvements

Hi Mauro, This series adds support for CEC error injection via debugfs. It's fantastic for verifying CEC implementations. We (Cisco) have been developing and testing this for quite some time now and it has been incredibly useful for low-level CEC verification. And cheap too :-) See the section

Re: [PATCH 0/9] Sunxi-Cedrus driver for the Allwinner Video Engine, using the V4L2 request API

On Fri, 2018-03-09 at 11:09 +0100, Paul Kocialkowski wrote: > This presents a newer version of the Sunxi-Cedrus driver, that > supports > the Video Engine found in most Allwinner SoCs, starting with the A10. I had to send this series in two parts (and tried to keep them under the original thread)

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Andy, Sakari, On Fri, Mar 9, 2018 at 5:54 PM, Sakari Ailus wrote: > Hi Andy, > > Thanks for the update. Please see my comments below. > > On Fri, Mar 09, 2018 at 12:15:54AM +0800, Andy Yeh wrote: >> Add a V4L2 sub-device driver for the Sony IMX258 image sensor.

Re: [PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

Hi Maxime, On Fri, Mar 02, 2018 at 03:34:56PM +0100, Maxime Ripard wrote: ... > @@ -902,6 +920,246 @@ static int ov5640_mod_reg(struct ov5640_dev *sensor, > u16 reg, > return ov5640_write_reg(sensor, reg, val); > } > > +/* > + * After spending way too much time trying the various

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

On 22/02/18 14:46, Greg KH wrote: > On Wed, Feb 21, 2018 at 02:43:14PM -0800, Rohit Athavale wrote: >> This commit adds driver support for the pre-release Xilinx M2M Video >> Scaler IP. There are three parts to this driver : >> >> - The Hardware/IP layer that reads and writes register of the IP

[PATCH] media: em28xx: fix a regression with HVR-950

Changeset be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality") removed the logic with sets the alternate for the DVB device. Without setting the right alternate, the device won't be able to submit URBs, and userspace fails with -EMSGSIZE: ERROR

Re: [PATCH] dvb: Save port number and provide sysfs attributes to pass values to udev

Em Thu, 08 Mar 2018 23:35:45 + David Howells escreveu: > Mauro Carvalho Chehab wrote: > > > > + dvb_class->dev_groups = dvb_class_groups, > > > dvb_class->dev_uevent = dvb_uevent; > > > dvb_class->devnode = dvb_devnode; > > > return 0; > >

[PATCH 2/2] media: v4l2-core: get rid of videobuf-dvb

Videobuf has been replaced by videobuf2. Now, no drivers use the videobuf-dvb helper module anymore. So, get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/Kconfig| 4 - drivers/media/v4l2-core/Makefile | 1 -

[PATCH 1/2] media: cx231xx: get rid of videobuf-dvb dependency

This driver doesn't use videobuf-dvb. So, stop adding an unused struct and unused header on it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/Kconfig | 1 - drivers/media/usb/cx231xx/cx231xx-dvb.c | 6 +-

[GIT PULL v2 for 4.17] Add V4L2 framework function for selecting the most suitable size

Hi Mauro, In drivers for hardware that have a discrete set of supported sizes, the size selection is a commonly needed functionality. This set implements it in a way that is usable in drivers and converts a few existing drivers to use it. since v1: - Fix KernelDoc documentation - Align

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

Hi Miguel, Thanks for the update. On Wed, Feb 28, 2018 at 03:27:23PM +, Rui Miguel Silva wrote: > This patch adds V4L2 sub-device driver for OV2680 image sensor. > The OV2680 is a 1/5" CMOS color sensor from Omnivision. > Supports output format: 10-bit Raw RGB. > The OV2680 has a single lane

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

Hi Geert, Thanks for your patch. On 2018-03-09 10:34:40 +0100, Geert Uytterhoeven wrote: > According to the Devicetree Specification, "ok" is not a valid status. > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > Signed-off-by: Geert Uytterhoeven

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Andy, Thanks for the update. Please see my comments below. On Fri, Mar 09, 2018 at 12:15:54AM +0800, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Jason

Re: [PATCH 2/2] media: v4l2-core: get rid of videobuf-dvb

On Fri, Mar 09, 2018 at 05:30:48AM -0300, Mauro Carvalho Chehab wrote: > Videobuf has been replaced by videobuf2. Now, no drivers use > the videobuf-dvb helper module anymore. So, get rid of it. > > Signed-off-by: Mauro Carvalho Chehab Nice set! Acked-by: Sakari Ailus

[PATCH] dt-bindings: media: rcar_vin: Use status "okay"

According to the Devicetree Specification, "ok" is not a valid status. Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") Signed-off-by: Geert Uytterhoeven --- For the checkpatch TODO list? https://www.devicetree.org/

[PATCH 0/9] Sunxi-Cedrus driver for the Allwinner Video Engine, using the V4L2 request API

This presents a newer version of the Sunxi-Cedrus driver, that supports the Video Engine found in most Allwinner SoCs, starting with the A10. The first version of this driver[0] was originally written and submitted by Florent Revest using a previous version of the request API, that is necessary

[PATCH 1/9] media: vim2m: Try to schedule a m2m device run on request submission

In the most basic use scenario, where only one output and one capture buffers are queued and the request is submitted, there is no provision to try to schedule a m2m device run. This adds the appropriate call to the vim2m_request_submit so that it can start in that scenario. Signed-off-by: Paul

[PATCH] V4L: remove myself as soc-camera maintainer

The soc-camera framework is deprecated, patches for it are very rare and only contain trivial clean up. Further I haven't got any more soc-camera systems running modern kernels. Signed-off-by: Guennadi Liakhovetski --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+),

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

Hi Hans, Thanks for your feedback. On 2018-03-09 17:28:39 +0100, Hans Verkuil wrote: > On 09/03/18 17:17, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your feedback, I don't think I can appreciate how happy I'm > > that you reviewed this patch-set, Thank you! > > You're welcome! >

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

On 09/03/18 18:07, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your feedback. > > On 2018-03-09 17:28:39 +0100, Hans Verkuil wrote: >> On 09/03/18 17:17, Niklas Söderlund wrote: >>> Hi Hans, >>> >>> Thanks for your feedback, I don't think I can appreciate how happy I'm >>> that you

Re: [PATCH v5 0/2] media: video-i2c: add video-i2c driver support

Hi Matt, This is looking good. One request before I merge: please run the 'v4l2-compliance -s -f' utility and post the result here. I don't think I've asked you to do that before (or if I did, I couldn't find it in my mail archive). It should run without failures. Use the latest version from

Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

On 08/03/18 11:00, Jacob Chen wrote: > Hi Hans, > > 2018-02-07 20:00 GMT+08:00 Hans Verkuil : >> On 12/29/17 08:52, Shunqian Zheng wrote: >>> From: Jeffy Chen >>> >>> Add the header for userspace >> >> General note: I saw four cases where this

Re: [PATCH v6 02/17] media: doc: add document for rkisp1 meta buffer format

On 08/03/18 10:47, Jacob Chen wrote: > From: Jacob Chen > > This commit add docuemnt for rkisp1 meta buffer format > > Signed-off-by: Jacob Chen > Acked-by: Hans Verkuil > --- >

Re: [linux-sunxi] [PATCH 6/9] sunxi-cedrus: Add device tree binding document

On Fri, Mar 09, 2018 at 11:14:42AM +0100, Paul Kocialkowski wrote: > From: Florent Revest > > Device Tree bindings for the Allwinner's video engine > > Signed-off-by: Florent Revest > --- >

Re: [PATCH v6 06/17] media: rkisp1: add ISP1 statistics driver

On 08/03/18 10:47, Jacob Chen wrote: > From: Jacob Chen > > Add the capture video driver for rockchip isp1 statistics block. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong

Re: [PATCH v6 07/17] media: rkisp1: add ISP1 params driver

On 08/03/18 10:47, Jacob Chen wrote: > From: Jacob Chen > > Add the output video driver that accept params from userspace. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong

Re: [PATCH 00/13] media: imx: Switch to subdev notifiers

Hi Steve, I understand there will be a v2 of this series? If so, then I can mark this series as 'Changes Requested' in patchwork. Regards, Hans On 22/02/18 02:39, Steve Longerbeam wrote: > This patchset converts the imx-media driver and its dependent > subdevs to use subdev notifiers.

Re: [PATCH v6 03/17] media: rkisp1: Add user space ABI definitions

A quick review: On 08/03/18 10:47, Jacob Chen wrote: > From: Jeffy Chen > > Add the header for userspace > > Signed-off-by: Jeffy Chen > Signed-off-by: Jacob Chen > --- > include/uapi/linux/rkisp1-config.h |

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

On 08/03/18 10:47, Jacob Chen wrote: > From: Jacob Chen > > Add the subdev driver for rockchip isp1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong

Re: [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

Hi, On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote: > +/* > + * mem2mem callbacks > + */ > + > +void job_abort(void *priv) > +{} Is that still needed? > +/* > + * device_run() - prepares and starts processing > + */ > +void device_run(void *priv) > +{ This function (and the

Re: [PATCH v6 08/17] media: rkisp1: add capture device driver

On 08/03/18 10:47, Jacob Chen wrote: > From: Jacob Chen > > This is the capture device interface driver that provides the v4l2 > user interface. Frames can be received from ISP1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, This is getting very close. Besides this round of review comments the main blocker is mbus_config. But Thomasz is looking at that, so I will wait until that is resolved. Also for your v7 include the patches from Sakari that add Meta Output support. This patch series relies on those,

Re: [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

Hi, On Fri, 2018-03-09 at 14:57 +0100, Maxime Ripard wrote: > Hi, > > On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote: > > +/* > > + * mem2mem callbacks > > + */ > > + > > +void job_abort(void *priv) > > +{} > > Is that still needed? It looks like we need a dummy callback

Re: [linux-sunxi] [PATCH 6/9] sunxi-cedrus: Add device tree binding document

Hi, Thanks for the review! On Fri, 2018-03-09 at 15:38 +0200, Priit Laes wrote: > On Fri, Mar 09, 2018 at 11:14:42AM +0100, Paul Kocialkowski wrote: > > From: Florent Revest > > > > Device Tree bindings for the Allwinner's video engine > > > > Signed-off-by:

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

On 07/03/18 23:04, Niklas Söderlund wrote: > If the field is not supported by the driver it should not try to keep > the current field. Instead it should set it to a default fallback. Since > trying a format should always result in the same state regardless of the > current state of the device. >

Re: [PATCH v12 12/33] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

On 07/03/18 23:04, Niklas Söderlund wrote: > There was never proper support in the VIN driver to deliver ALTERNATING > field format to user-space, remove this field option. The problem is > that ALTERNATING field order requires the sequence numbers of buffers > returned to userspace to reflect if

Re: [PATCH v12 13/33] rcar-vin: update bytesperline and sizeimage calculation

On 07/03/18 23:04, Niklas Söderlund wrote: > Remove over complicated logic to calculate the value for bytesperline > and sizeimage that was carried over from the soc_camera port. There is > no need to find the max value of bytesperline and sizeimage from > user-space as they are set to 0 before

Re: [PATCH v12 15/33] rcar-vin: break out format alignment and checking

On 07/03/18 23:04, Niklas Söderlund wrote: > Part of the format alignment and checking can be shared with the Gen3 > format handling. Break that part out to a separate function. > > Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil

Re: [PATCH v12 23/33] rcar-vin: force default colorspace for media centric mode

On 07/03/18 23:05, Niklas Söderlund wrote: > The V4L2 specification clearly documents the colorspace fields as being > set by drivers for capture devices. Using the values supplied by > userspace thus wouldn't comply with the API. Until the API is updated to > allow for userspace to set these Hans

Re: [PATCH v12 32/33] rcar-vin: enable support for r8a7796

On 07/03/18 23:05, Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7796. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil

Re: [PATCH v12 31/33] rcar-vin: enable support for r8a7795

On 07/03/18 23:05, Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil

Re: [RFCv4,19/21] media: vim2m: add request support

Hi, On Thu, 2018-03-08 at 22:48 +0900, Alexandre Courbot wrote: > Hi Paul! > > Thanks a lot for taking the time to try this! I am also working on > getting it to work with an actual driver, but you apparently found > rough edges that I missed. > > On Thu, Mar 8, 2018 at 1:37 AM, Paul

Re: [PATCH v12 06/33] rcar-vin: move subdevice handling to async callbacks

On 07/03/18 23:04, Niklas Söderlund wrote: > In preparation for Gen3 support move the subdevice initialization and > clean up from rvin_v4l2_{register,unregister}() directly to the async > callbacks. This simplifies the addition of Gen3 support as the > rvin_v4l2_register() can be shared for both

Re: [PATCH v12 14/33] rcar-vin: align pixelformat check

On 07/03/18 23:04, Niklas Söderlund wrote: > If the pixelformat is not supported it should not fail but be set to > something that works. While we are at it move the two different > checks of the pixelformat to the same statement. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v8 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 RX

On Thu, Feb 15, 2018 at 02:33:33PM +0100, Maxime Ripard wrote: > Hi, > > Here is another attempt at supporting the MIPI-CSI2 RX block from > Cadence. > > This IP block is able to receive CSI data over up to 4 lanes, and > split it to over 4 streams. Those streams are basically the interfaces >

Re: [PATCH v12 17/33] rcar-vin: cache video standard

On 07/03/18 23:04, Niklas Söderlund wrote: > At stream on time the driver should not query the subdevice for which > standard are used. Instead it should be cached when userspace sets the > standard and used at stream on time. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v12 26/33] rcar-vin: change name of video device

On 07/03/18 23:05, Niklas Söderlund wrote: > The rcar-vin driver needs to be part of a media controller to support > Gen3. Give each VIN instance a unique name so it can be referenced from > userspace. > > Signed-off-by: Niklas Söderlund > Reviewed-by:

Re: [PATCH v12 20/33] rcar-vin: add function to manipulate Gen3 chsel value

On 07/03/18 23:04, Niklas Söderlund wrote: > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > feature of this register is that it's only present in the VIN0 and VIN4 > instances. The register in VIN0 controls the routing for VIN0-3 and the > register in VIN4 controls

Re: [PATCH v12 28/33] rcar-vin: parse Gen3 OF and setup media graph

On 07/03/18 23:05, Niklas Söderlund wrote: > The parsing and registering CSI-2 subdevices with the v4l2 async > framework is a collaborative effort shared between the VIN instances > which are part of the group. When the last VIN in the group is probed it > asks all other VINs to parse its share

Re: [PATCH v12 29/33] rcar-vin: add link notify for Gen3

On 07/03/18 23:05, Niklas Söderlund wrote: > Add the ability to process media device link change requests. Link > enabling is a bit complicated on Gen3, whether or not it's possible to > enable a link depends on what other links already are enabled. On Gen3 > the 8 VINs are split into two

Re: [PATCH v12 16/33] rcar-vin: simplify how formats are set and reset

On 07/03/18 23:04, Niklas Söderlund wrote: > With the recent cleanup of the format code to prepare for Gen3 it's > possible to simplify the Gen2 format code path as well. Clean up the > process by defining two functions to handle the set format and reset of > format when the standard is changed. >

  1   2   >