cron job: media_tree daily build: ERRORS

2018-03-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 27 05:00:12 CEST 2018 media-tree git hash:6ccd228e0cfce2a4f44558422d25c60fcb1a6710 media_build

RE: [PATCH 2/5] drm/ttm: keep a reference to transfer pipelined BOs

2018-03-26 Thread He, Roger
Reviewed-by: Roger He -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, March 16, 2018 9:21 PM To: linaro-mm-...@lists.linaro.org; linux-media@vger.kernel.org; dri-de...@lists.freedesktop.org;

Re: [PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

2018-03-26 Thread Ji-Hun Kim
On Wed, Mar 21, 2018 at 01:39:09PM +0900, Ji-Hun Kim wrote: > There is no failure checking on the param value which will be allocated > memory by kmalloc. Add a null pointer checking statement. Then goto error: > and return -ENOMEM error code when kmalloc is failed. > > Signed-off-by: Ji-Hun Kim

Re: [PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

2018-03-26 Thread Dan Carpenter
On Tue, Mar 27, 2018 at 02:00:45PM +0900, Ji-Hun Kim wrote: > > Are there any opinions? I'd like to know how this patch is going. > Looks good. Thanks! Greg just hasn't gotten to it yet. regards, dan carpenter

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-26 Thread Yeh, Andy
Got it. We shall reverse the order in the later submission on list. Regards, Andy -Original Message- From: sakari.ai...@linux.intel.com [mailto:sakari.ai...@linux.intel.com] Sent: Thursday, March 22, 2018 1:07 AM To: Yeh, Andy Cc: jacopo mondi ;

RE: [PATCH 3/5] drm/ttm: remove the backing store if no placement is given

2018-03-26 Thread He, Roger
Acked-by: Roger He -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Sunday, March 25, 2018 6:58 PM To: linaro-mm-...@lists.linaro.org; linux-media@vger.kernel.org; dri-de...@lists.freedesktop.org;

[PATCH] media: cx231xx: Add support for AverMedia DVD EZMaker 7

2018-03-26 Thread Kai-Heng Feng
User reports AverMedia DVD EZMaker 7 can be driven by VIDEO_GRABBER. Add the device to the id_table to make it work. BugLink: https://bugs.launchpad.net/bugs/1620762 Signed-off-by: Kai-Heng Feng --- drivers/media/usb/cx231xx/cx231xx-cards.c | 3 +++ 1 file changed,

Re: [RFC v2 00/10] Preparing the request API

2018-03-26 Thread Hans Verkuil
On 03/26/2018 09:58 AM, Sakari Ailus wrote: > Hi Hans, > > On Sun, Mar 25, 2018 at 06:17:30PM +0200, Hans Verkuil wrote: >> On 03/25/2018 05:12 PM, Hans Verkuil wrote: >>> Hi all, >>> >>> On 03/23/2018 10:17 PM, Sakari Ailus wrote: Hi folks, This preliminary RFC patchset prepares

[GIT PULL FOR v4.17] Final set of fixes for 4.17

2018-03-26 Thread Hans Verkuil
Various code and documentation fixes. Regards, Hans The following changes since commit 6ccd228e0cfce2a4f44558422d25c60fcb1a6710: media: fimc-capture: get rid of two warnings (2018-03-23 08:56:36 -0400) are available in the Git repository at:

Re: [PATCH 08/30] media: v4l2-ioctl: fix some "too small" warnings

2018-03-26 Thread Mauro Carvalho Chehab
Em Fri, 23 Mar 2018 23:53:56 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Fri, Mar 23, 2018 at 07:56:54AM -0400, Mauro Carvalho Chehab wrote: > > While the code there is right, it produces three false positives: > > drivers/media/v4l2-core/v4l2-ioctl.c:2868

Re: [RFC v2 06/10] vb2: Add support for requests

2018-03-26 Thread Sakari Ailus
On Mon, Mar 26, 2018 at 03:02:53PM +0900, Tomasz Figa wrote: > Hi Sakari, > > I would have appreciated being CCed on this series, but anyway, thanks > for sending it. Please see my comments inline. > > On Sat, Mar 24, 2018 at 6:17 AM, Sakari Ailus > wrote: > >

Re: [RFC v2 06/10] vb2: Add support for requests

2018-03-26 Thread Tomasz Figa
Hi Sakari, I would have appreciated being CCed on this series, but anyway, thanks for sending it. Please see my comments inline. On Sat, Mar 24, 2018 at 6:17 AM, Sakari Ailus wrote: > Associate a buffer to a request when it is queued and disassociate when it > is

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-26 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 10:37:55AM +0100, Christian König wrote: > Am 22.03.2018 um 08:14 schrieb Daniel Vetter: > > On Wed, Mar 21, 2018 at 10:34:05AM +0100, Christian König wrote: > > > Am 21.03.2018 um 09:18 schrieb Daniel Vetter: > > > > [SNIP] > > > For correct operation you always need to

Re: [RFC v2 00/10] Preparing the request API

2018-03-26 Thread Sakari Ailus
On Mon, Mar 26, 2018 at 10:31:50AM +0200, Hans Verkuil wrote: > On 03/26/2018 09:58 AM, Sakari Ailus wrote: > > Hi Hans, > > > > On Sun, Mar 25, 2018 at 06:17:30PM +0200, Hans Verkuil wrote: > >> On 03/25/2018 05:12 PM, Hans Verkuil wrote: > >>> Hi all, > >>> > >>> On 03/23/2018 10:17 PM, Sakari

Re: [RFC v2 00/10] Preparing the request API

2018-03-26 Thread Sakari Ailus
Hi Hans, On Sun, Mar 25, 2018 at 06:17:30PM +0200, Hans Verkuil wrote: > On 03/25/2018 05:12 PM, Hans Verkuil wrote: > > Hi all, > > > > On 03/23/2018 10:17 PM, Sakari Ailus wrote: > >> Hi folks, > >> > >> This preliminary RFC patchset prepares for the request API. What's new > >> here is

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-26 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 10:58:55AM +0100, Christian König wrote: > Am 22.03.2018 um 08:18 schrieb Daniel Vetter: > > On Wed, Mar 21, 2018 at 12:54:20PM +0100, Christian König wrote: > > > Am 21.03.2018 um 09:28 schrieb Daniel Vetter: > > > > On Tue, Mar 20, 2018 at 06:47:57PM +0100, Christian

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-26 Thread Simon Horman
On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: > Hi Simon, > > On 23/03/18 08:51, Simon Horman wrote: > > On Thu, Mar 22, 2018 at 09:30:40PM +, Kieran Bingham wrote: > >> The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C > >> bus, however in low power mode

Re: [PATCH 08/30] media: v4l2-ioctl: fix some "too small" warnings

2018-03-26 Thread Sakari Ailus
Hi Mauro, On Mon, Mar 26, 2018 at 07:08:16AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 23 Mar 2018 23:53:56 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Fri, Mar 23, 2018 at 07:56:54AM -0400, Mauro Carvalho Chehab wrote: > > > While the code there

RE: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-26 Thread Mario.Limonciello
> -Original Message- > From: Paul Menzel [mailto:pmenzel+linux-me...@molgen.mpg.de] > Sent: Wednesday, March 21, 2018 7:35 AM > To: Laurent Pinchart > Cc: linux-media@vger.kernel.org; linux-ker...@vger.kernel.org; it+linux- > me...@molgen.mpg.de;

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Daniel Vetter
On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: > Move the parameters into a structure to make it simpler to extend it in > follow up patches. > > This also adds the importer private as parameter so that we can directly > work with a completely filled in attachment structure. >

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-26 Thread Kieran Bingham
Hi Simon, On 26/03/18 09:31, Simon Horman wrote: > On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: >> Hi Simon, >> >> On 23/03/18 08:51, Simon Horman wrote: >>> On Thu, Mar 22, 2018 at 09:30:40PM +, Kieran Bingham wrote: The r8a7792 Wheat board has two ADV7513 devices

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-26 Thread Mauro Carvalho Chehab
Hi Nasser, Em Mon, 26 Mar 2018 03:26:33 +0430 Nasser Afshin escreveu: > According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down > resistor if it's been disabled. On hardware that does not have such > resistor, we should use the default output enable

[PATCH v7 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

2018-03-26 Thread Maxime Ripard
Hi, Here is an attempt at supporting the MIPI-CSI2 TX block from Cadence. This IP block is able to receive 4 video streams and stream them over a MIPI-CSI2 link using up to 4 lanes. Those streams are basically the interfaces to controllers generating some video signals, like a camera or a

Re: [RFC v2 01/10] media: Support variable size IOCTL arguments

2018-03-26 Thread Sakari Ailus
Hi Mauro, On Mon, Mar 26, 2018 at 07:47:42AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 23 Mar 2018 23:17:35 +0200 > Sakari Ailus escreveu: > > > Maintain a list of supported IOCTL argument sizes and allow only those in > > the list. > > > > As an additional

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Christian König
Am 26.03.2018 um 10:36 schrieb Daniel Vetter: On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: [SNIP] - attach->dev = dev; + attach->dev = info->dev; attach->dmabuf = dmabuf; + attach->priv = info->priv; The ->priv field is for the exporter, not the

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Christian König
Am 26.03.2018 um 10:36 schrieb Daniel Vetter: On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: [SNIP] - attach->dev = dev; + attach->dev = info->dev; attach->dmabuf = dmabuf; + attach->priv = info->priv; The ->priv field is for the exporter, not the

Re: [RFC v2 01/10] media: Support variable size IOCTL arguments

2018-03-26 Thread Mauro Carvalho Chehab
Em Fri, 23 Mar 2018 23:17:35 +0200 Sakari Ailus escreveu: > Maintain a list of supported IOCTL argument sizes and allow only those in > the list. > > As an additional bonus, IOCTL handlers will be able to check whether the > caller actually set (using the argument

Re: [PATCH] media: vsp1: Fix BRx conditional path in WPF

2018-03-26 Thread Kieran Bingham
Sorry, This should have been from my +renesas to support Renesas' statistics and filtering of course. On 26/03/18 14:29, Kieran Bingham wrote: > When a BRx is provided by a pipeline, the WPF must determine the master > layer. Currently the condition to check this identifies pipe->bru || >

[RFC v2.1 1/1] media: Support variable size IOCTL arguments

2018-03-26 Thread Sakari Ailus
Maintain a list of supported IOCTL argument sizes and allow only those in the list. As an additional bonus, IOCTL handlers will be able to check whether the caller actually set (using the argument size) the field vs. assigning it to zero. Separate macro can be provided for that. This will be

Re: [RFC v2.1 1/1] media: Support variable size IOCTL arguments

2018-03-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Mar 2018 16:23:24 +0300 Sakari Ailus escreveu: > Maintain a list of supported IOCTL argument sizes and allow only those in > the list. > > As an additional bonus, IOCTL handlers will be able to check whether the > caller actually set (using the argument

[PATCH v3 5/5] dvb-usb-v2/gl861: ensure USB message buffers DMA'able

2018-03-26 Thread tskd08
From: Akihiro Tsukada i2c message buf might be on stack. Signed-off-by: Akihiro Tsukada --- drivers/media/usb/dvb-usb-v2/gl861.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/gl861.c

[PATCH v3 3/5] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio

2018-03-26 Thread tskd08
From: Akihiro Tsukada Friio device contains "gl861" bridge and "tc90522" demod, for which the separate drivers are already in the kernel. But friio driver was monolithic and did not use them, practically copying those features. This patch decomposes friio driver into sub

[PATCH v3 4/5] dvb-usb-v2/gl861: use usleep_range() for short delay

2018-03-26 Thread tskd08
From: Akihiro Tsukada As the kernel doc "timers-howto.txt" reads, short delay with msleep() can take much longer. In a case of raspbery-pi platform where CONFIG_HZ_100 was set, it actually affected the init of Friio devices since it issues lots of i2c transactions with short

[PATCH v3 2/5] dvb-frontends/dvb-pll: add tua6034 ISDB-T tuner used in Friio

2018-03-26 Thread tskd08
From: Akihiro Tsukada This driver already contains tua6034-based device settings, but they are not for ISDB-T and have different parameters. Signed-off-by: Akihiro Tsukada --- Changes since v2: (patch #27927 dvb: tua6034: add a new driver for Infineon

[PATCH v3 1/5] dvb-frontends/dvb-pll: add i2c driver support

2018-03-26 Thread tskd08
From: Akihiro Tsukada registers the module as an i2c driver, but keeps dvb_pll_attach() untouched for compatibility. Signed-off-by: Akihiro Tsukada --- drivers/media/dvb-frontends/dvb-pll.c | 49 +++

[PATCH v3 0/5] dvb-usb-friio: decompose friio and merge with gl861

2018-03-26 Thread tskd08
From: Akihiro Tsukada This series decomposes dvb-usb-friio into sub drivers and merge the bridge driver with dvb-usb-gl861. As to the demod & tuner drivers, existing drivers are re-used. Changes since v2 - used the new i2c binding helpers instead of my own one - extends

[PATCH] media: vsp1: Fix BRx conditional path in WPF

2018-03-26 Thread Kieran Bingham
When a BRx is provided by a pipeline, the WPF must determine the master layer. Currently the condition to check this identifies pipe->bru || pipe->num_inputs > 1. The code then moves on to dereference pipe->bru, thus the check fails static analysers on the possibility that pipe->num_inputs could

[PATCH v7 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-03-26 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used as a bridge between pixel interfaces and a CSI-2 bus. It supports operating with an internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. While the virtual

[PATCH v7 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

2018-03-26 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 video streams and can output on up to 4 CSI-2 lanes, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

Re: [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping

2018-03-26 Thread Suman Anna
Hi Mauro, On 03/21/2018 05:26 AM, Laurent Pinchart wrote: > Hi Suman, > > Thank you for the patch. > > On Wednesday, 14 March 2018 17:41:36 EET Suman Anna wrote: >> The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware >> ARM DMA backend. The current code creates a

Re: [PATCH] media: vsp1: Fix BRx conditional path in WPF

2018-03-26 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Monday, 26 March 2018 16:29:17 EEST Kieran Bingham wrote: > When a BRx is provided by a pipeline, the WPF must determine the master > layer. Currently the condition to check this identifies pipe->bru || > pipe->num_inputs > 1. > > The code then moves on to

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Daniel Vetter
On Mon, Mar 26, 2018 at 12:47:01PM +0200, Christian König wrote: > Am 26.03.2018 um 10:36 schrieb Daniel Vetter: > > On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: > [SNIP] > > > - attach->dev = dev; > > > + attach->dev = info->dev; > > > attach->dmabuf = dmabuf; > > >

Re: [RFC v2 00/10] Preparing the request API

2018-03-26 Thread Hans Verkuil
On 03/25/2018 06:17 PM, Hans Verkuil wrote: >> So this weekend I worked on a merger of this work and the RFCv4 Request API >> patch series, taking what I think are the best bits of both. >> >> It is available here: >> >> https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=reqv6 > > I

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-26 Thread Jerome Glisse
On Mon, Mar 26, 2018 at 10:01:21AM +0200, Daniel Vetter wrote: > On Thu, Mar 22, 2018 at 10:58:55AM +0100, Christian König wrote: > > Am 22.03.2018 um 08:18 schrieb Daniel Vetter: > > > On Wed, Mar 21, 2018 at 12:54:20PM +0100, Christian König wrote: > > > > Am 21.03.2018 um 09:28 schrieb Daniel

Re: [PATCH 08/30] media: v4l2-ioctl: fix some "too small" warnings

2018-03-26 Thread Laurent Pinchart
Hi Mauro, On Monday, 26 March 2018 13:08:16 EEST Mauro Carvalho Chehab wrote: > Em Fri, 23 Mar 2018 23:53:56 +0200 Sakari Ailus escreveu: > > On Fri, Mar 23, 2018 at 07:56:54AM -0400, Mauro Carvalho Chehab wrote: > >> While the code there is right, it produces three false positives: > >>

Re: [RFC v2.1 1/1] media: Support variable size IOCTL arguments

2018-03-26 Thread Sakari Ailus
Hi Mauro, On Mon, Mar 26, 2018 at 02:28:34PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 26 Mar 2018 16:23:24 +0300 > Sakari Ailus escreveu: > > > Maintain a list of supported IOCTL argument sizes and allow only those in > > the list. > > > > As an additional

Re: [PATCH 08/30] media: v4l2-ioctl: fix some "too small" warnings

2018-03-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Mar 2018 21:47:33 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday, 26 March 2018 13:08:16 EEST Mauro Carvalho Chehab wrote: > > Em Fri, 23 Mar 2018 23:53:56 +0200 Sakari Ailus escreveu: > > > On Fri, Mar 23, 2018 at 07:56:54AM -0400,

Re: [RFC v2.1 1/1] media: Support variable size IOCTL arguments

2018-03-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Mar 2018 23:00:17 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Mar 26, 2018 at 02:28:34PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 26 Mar 2018 16:23:24 +0300 > > Sakari Ailus escreveu: > > > > > Maintain a

[PATCH 15/18] media: staging: atomisp: get rid of some static warnings

2018-03-26 Thread Mauro Carvalho Chehab
Get rid of those warnings: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/tdf/tdf_1.0/ia_css_tdf.host.c:18:15: warning: symbol 'g_pyramid' was not declared. Should it be static? drivers/staging/media/atomisp/pci/atomisp2/mmu/sh_mmu_mrfld.c:66:23: warning: symbol

[PATCH 16/18] media: staging: atomisp: stop mixing enum types

2018-03-26 Thread Mauro Carvalho Chehab
This driver abuses on enum types: drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c:1027:37: warning: mixing different enum types drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c:1027:37: int enum ia_css_csi2_port versus

[PATCH 12/18] media: staging: atomisp: avoid a warning if 32 bits build

2018-03-26 Thread Mauro Carvalho Chehab
Checking if a size_t value is bigger than ULONG_INT only makes sense if building on 64 bits, as warned by: drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:697 gmin_get_config_var() warn: impossible condition '(*out_len > (~0)) => (0-u32max > u32max)'

[PATCH 13/18] media: staging: atomisp: remove an useless check

2018-03-26 Thread Mauro Carvalho Chehab
There's a check at ia_css_vf_configure() to verify if binary is not null. However, this is called too late: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c:133 ia_css_vf_configure() warn: variable dereferenced before check 'binary' (see line

[PATCH 14/18] media: staging: atomisp: use %p to print pointers

2018-03-26 Thread Mauro Carvalho Chehab
Instead of a converting pointers to unsigned long, just print them as-is, using %p. Fixes this warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c:3012 ia_css_debug_pipe_graph_dump_sp_raw_copy() warn: argument 4 to %08lx specifier is cast from

[PATCH 09/18] media: staging: atomisp: get rid of an unused function

2018-03-26 Thread Mauro Carvalho Chehab
The function __need_realloc_mipi_buffer() is not used anywhere. Signed-off-by: Mauro Carvalho Chehab --- .../atomisp/pci/atomisp2/atomisp_compat_css20.c | 21 - 1 file changed, 21 deletions(-) diff --git

[PATCH 07/18] media: staging: atomisp: fix endianess issues

2018-03-26 Thread Mauro Carvalho Chehab
There are lots of be-related warnings there, as it doesn't properly mark what data uses bigendian. Warnings fixed: drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c:134:15: warning: incorrect type in assignment (different base types)

[PATCH 18/18] media: staging: atomisp: stop duplicating input format types

2018-03-26 Thread Mauro Carvalho Chehab
The same formats are defined twice with different names, as warned: drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c:5092:58: warning: mixing different enum types drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c:5092:58: int enum atomisp_input_format versus

[PATCH 17/18] media: staging: atomisp: get rid of an unused var

2018-03-26 Thread Mauro Carvalho Chehab
As warned: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c:8085 create_host_regular_capture_pipeline() error: uninitialized symbol 'frm'. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 1 - 1

[PATCH 02/18] media: staging: atomisp: do some coding style improvements

2018-03-26 Thread Mauro Carvalho Chehab
Use make coccicheck in patch mode to do some coding style improvements. Adjust the results manually. Signed-off-by: Mauro Carvalho Chehab --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c | 14 +- .../media/atomisp/pci/atomisp2/atomisp_fops.c | 14

[PATCH 11/18] media: staging: atomisp: don't access a NULL var

2018-03-26 Thread Mauro Carvalho Chehab
Get rid of those warnings: drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:446 gmin_v1p2_ctrl() error: we previously assumed 'gs' could be null (see line 444) drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:480 gmin_v1p8_ctrl()

[PATCH 01/18] media: r820t: don't crash if attach fails

2018-03-26 Thread Mauro Carvalho Chehab
As pointed by smatch: drivers/media/tuners/r820t.c:2374 r820t_attach() error: potential null dereference 'priv'. (kzalloc returns null) The current function with prints error assumes that the attach succeeds. So, don't use it in case of failures. Signed-off-by: Mauro Carvalho Chehab

[PATCH 10/18] media: staging: atomisp: Get rid of *default.host.[ch]

2018-03-26 Thread Mauro Carvalho Chehab
There are a number of files at atomisp that aren't used anywhere, called as "*default.host.[ch]": css2400/isp/kernels/dpc2/ia_css_dpc2_default.host.[ch] css2400/isp/kernels/bnlm/ia_css_bnlm_default.host.[ch] css2400/isp/kernels/tdf/tdf_1.0/ia_css_tdf_default.host.[ch]

[PATCH 06/18] media: staging: atomisp: add a missing include

2018-03-26 Thread Mauro Carvalho Chehab
atomisp_drvfs.c is not including its own header, causing those warnings: drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c:185:5: warning: symbol 'atomisp_drvfs_init' was not declared. Should it be static? drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c:201:6:

[PATCH 03/18] media: staging: atomisp: ia_css_output.host: don't use var before check

2018-03-26 Thread Mauro Carvalho Chehab
Fix this warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/output/output_1.0/ia_css_output.host.c:64 ia_css_output_config() warn: variable dereferenced before check 'from->info' (see line 63) Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 08/18] media: staging: atomisp: remove unused set_pd_base()

2018-03-26 Thread Mauro Carvalho Chehab
There's an implementation for set_pd_base at sh_mmu logic with is said to be mandatory. However, the implementation ends by calling a routine that does nothing. So get rid of this entire nonsense. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v13 03/33] rcar-vin: add Gen3 devicetree bindings documentation

2018-03-26 Thread Niklas Söderlund
Document the devicetree bindings for the CSI-2 inputs available on Gen3. There is a need to add a custom property 'renesas,id' and to define which CSI-2 input is described in which endpoint under the port@1 node. This information is needed since there are a set of predefined routes between each

[PATCH v13 13/33] rcar-vin: update bytesperline and sizeimage calculation

2018-03-26 Thread Niklas Söderlund
Remove over complicated logic to calculate the value for bytesperline and sizeimage that was carried over from the soc_camera port. There is no need to find the max value of bytesperline and sizeimage from user-space as they are set to 0 before the max_t() operation. Signed-off-by: Niklas

[PATCH v13 22/33] rcar-vin: use different v4l2 operations in media controller mode

2018-03-26 Thread Niklas Söderlund
When the driver runs in media controller mode it should not directly control the subdevice instead userspace will be responsible for configuring the pipeline. To be able to run in this mode a different set of v4l2 operations needs to be used. Add a new set of v4l2 operations to support operation

[PATCH v13 16/33] rcar-vin: simplify how formats are set and reset

2018-03-26 Thread Niklas Söderlund
With the recent cleanup of the format code to prepare for Gen3 it's possible to simplify the Gen2 format code path as well. Clean up the process by defining two functions to handle the set format and reset of format when the standard is changed. While at it replace the driver local struct

[PATCH v13 29/33] rcar-vin: add link notify for Gen3

2018-03-26 Thread Niklas Söderlund
Add the ability to process media device link change requests. Link enabling is a bit complicated on Gen3, whether or not it's possible to enable a link depends on what other links already are enabled. On Gen3 the 8 VINs are split into two subgroup's (VIN0-3 and VIN4-7) and from a routing

[PATCH v13 18/33] rcar-vin: move media bus configuration to struct rvin_dev

2018-03-26 Thread Niklas Söderlund
Bus configuration will once the driver is extended to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_dev to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund

[PATCH v13 01/33] dt-bindings: media: rcar_vin: Reverse SoC part number list

2018-03-26 Thread Niklas Söderlund
From: Fabrizio Castro Change the sorting of the part numbers from descending to ascending to match with other documentation. Signed-off-by: Fabrizio Castro Reviewed-by: Biju Das Reviewed-by: Simon Horman

[PATCH v13 26/33] rcar-vin: change name of video device

2018-03-26 Thread Niklas Söderlund
The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart

[PATCH v13 30/33] rcar-vin: extend {start,stop}_streaming to work with media controller

2018-03-26 Thread Niklas Söderlund
The procedure to start or stop streaming using the non-MC single subdevice and the MC graph and multiple subdevices are quite different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v13 20/33] rcar-vin: add function to manipulate Gen3 chsel value

2018-03-26 Thread Niklas Söderlund
On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One feature of this register is that it's only present in the VIN0 and VIN4 instances. The register in VIN0 controls the routing for VIN0-3 and the register in VIN4 controls routing for VIN4-7. To be able to control routing from

[PATCH v13 10/33] rcar-vin: all Gen2 boards can scale simplify logic

2018-03-26 Thread Niklas Söderlund
The logic to preserve the requested format width and height are too complex and come from a premature optimization for Gen3. All Gen2 SoC can scale and the Gen3 implementation will not use these functions at all so simply preserve the width and height when interacting with the subdevice much like

[PATCH v13 25/33] rcar-vin: add group allocator functions

2018-03-26 Thread Niklas Söderlund
In media controller mode all VIN instances needs to be part of the same media graph. There is also a need for each VIN instance to know about and in some cases be able to communicate with other VIN instances. Add an allocator framework where the first VIN instance to be probed creates a shared

[PATCH v13 19/33] rcar-vin: enable Gen3 hardware configuration

2018-03-26 Thread Niklas Söderlund
Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund Reviewed-by: Hans

[PATCH v13 28/33] rcar-vin: parse Gen3 OF and setup media graph

2018-03-26 Thread Niklas Söderlund
The parsing and registering CSI-2 subdevices with the v4l2 async framework is a collaborative effort shared between the VIN instances which are part of the group. When the last VIN in the group is probed it asks all other VINs to parse its share of OF and record the async subdevices it finds in

[PATCH v13 24/33] rcar-vin: prepare for media controller mode initialization

2018-03-26 Thread Niklas Söderlund
Prepare for media controller by calling a different initialization then when running in device centric mode. Add trivial configuration of the mbus and creation of the media pad for the video device entity. While we are at it clearly mark the digital device centric notifier functions with a

[PATCH v13 31/33] rcar-vin: enable support for r8a7795

2018-03-26 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil ---

[PATCH v13 15/33] rcar-vin: break out format alignment and checking

2018-03-26 Thread Niklas Söderlund
Part of the format alignment and checking can be shared with the Gen3 format handling. Break that part out to a separate function. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil ---

[PATCH v13 08/33] rcar-vin: move max width and height information to chip information

2018-03-26 Thread Niklas Söderlund
On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct rvin_info to prepare for Gen3 support. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham Reviewed-by:

[PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2018-03-26 Thread Niklas Söderlund
From: Fabrizio Castro Add compatible strings for r8a7743 and r8a7745. No driver change is needed as "renesas,rcar-gen2-vin" will activate the right code. However, it is good practice to document compatible strings for the specific SoC as this allows SoC specific

[PATCH v13 33/33] rcar-vin: enable support for r8a77970

2018-03-26 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a77970. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil --- drivers/media/platform/rcar-vin/rcar-core.c | 23

[PATCH v13 12/33] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-03-26 Thread Niklas Söderlund
There was never proper support in the VIN driver to deliver ALTERNATING field format to user-space, remove this field option. The problem is that ALTERNATING field order requires the sequence numbers of buffers returned to userspace to reflect if fields were dropped or not, something which is not

[PATCH v13 17/33] rcar-vin: cache video standard

2018-03-26 Thread Niklas Söderlund
At stream on time the driver should not query the subdevice for which standard are used. Instead it should be cached when userspace sets the standard and used at stream on time. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil

[PATCH v13 32/33] rcar-vin: enable support for r8a7796

2018-03-26 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil --- drivers/media/platform/rcar-vin/rcar-core.c | 44

[PATCH v13 21/33] rcar-vin: add flag to switch to media controller mode

2018-03-26 Thread Niklas Söderlund
On Gen3 a media controller API needs to be used to allow userspace to configure the subdevices in the pipeline instead of directly controlling a single source subdevice, which is and will continue to be the mode of operation on Gen2. Prepare for these two modes of operation by adding a flag to

[PATCH v13 27/33] rcar-vin: add chsel information to rvin_info

2018-03-26 Thread Niklas Söderlund
Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil

[PATCH v13 23/33] rcar-vin: force default colorspace for media centric mode

2018-03-26 Thread Niklas Söderlund
The V4L2 specification clearly documents the colorspace fields as being set by drivers for capture devices. Using the values supplied by userspace thus wouldn't comply with the API. Until the API is updated to allow for userspace to set these Hans wants the fields to be set by the driver to fixed

[PATCH v3] i2c: adv748x: afe: fix sparse warning

2018-03-26 Thread Niklas Söderlund
This fixes the following sparse warning: drivers/media/i2c/adv748x/adv748x-afe.c:294:34:expected unsigned int [usertype] *signal drivers/media/i2c/adv748x/adv748x-afe.c:294:34:got int * drivers/media/i2c/adv748x/adv748x-afe.c:294:34: warning: incorrect type in argument 2 (different

Re: RESEND[PATCH v6 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-03-26 Thread Rob Herring
On Sat, Mar 17, 2018 at 01:05:25AM +0800, Andy Yeh wrote: > From: Alan Chiang > > Dongwoon DW9807 is a voice coil lens driver. > > Signed-off-by: Andy Yeh > --- > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 + > 1

Re: [PATCHv2 1/3] dt-bindings: display: dw_hdmi.txt: add cec-disable property

2018-03-26 Thread Rob Herring
On Fri, Mar 23, 2018 at 01:59:13PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Some boards have both a DesignWare and their own CEC controller. > The CEC pin is only hooked up to their own CEC controller and not > to the DW controller. > > Add the cec-disable

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-26 Thread Nasser
On Mon, Mar 26, 2018 at 06:43:53AM -0300, Mauro Carvalho Chehab wrote: > Hi Nasser, > > Em Mon, 26 Mar 2018 03:26:33 +0430 > Nasser Afshin escreveu: > > > According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down > > resistor if it's been disabled. On

[PATCH 04/18] media: staging atomisp: declare static vars as such

2018-03-26 Thread Mauro Carvalho Chehab
Fix a bunch of warnings: drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c:93:23: warning: symbol 'css_queues' was not declared. Should it be static? drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c:27:32: warning: symbol

[PATCH 05/18] media: staging: atomisp: get rid of stupid statements

2018-03-26 Thread Mauro Carvalho Chehab
It makes no sense to have a do nothing statement like: (void)stage; Fix those warnings: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:3808 sh_css_param_update_isp_params() error: uninitialized symbol 'stage'.

[PATCH v13 04/33] rcar-vin: rename poorly named initialize and cleanup functions

2018-03-26 Thread Niklas Söderlund
The functions to register and unregister the hardware and video device where poorly named from the start. Rename them to better describe their intended function. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham

[PATCH v13 00/33] rcar-vin: Add Gen3 with media controller

2018-03-26 Thread Niklas Söderlund
Hi, This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, r8a7796 and r8a77970. It is based on the media-tree and depends on Fabrizio Castro patches as they touches the order of the compatible strings in the documentation to reduce merge conflicts. The dependencies are

[PATCH v13 07/33] rcar-vin: move model information to own struct

2018-03-26 Thread Niklas Söderlund
When Gen3 support is added to the driver more than model ID will be different for the different SoCs. To avoid a lot of if statements in the code create a struct rvin_info to store this information. While we are at it rename the poorly chosen enum which contains the different model IDs from

[PATCH v13 06/33] rcar-vin: move subdevice handling to async callbacks

2018-03-26 Thread Niklas Söderlund
In preparation for Gen3 support move the subdevice initialization and clean up from rvin_v4l2_{register,unregister}() directly to the async callbacks. This simplifies the addition of Gen3 support as the rvin_v4l2_register() can be shared for both Gen2 and Gen3 while direct subdevice control are

  1   2   >